diff --git a/core/commands/refs.go b/core/commands/refs.go index 4a7285cc95c..3a7d51e7b5f 100644 --- a/core/commands/refs.go +++ b/core/commands/refs.go @@ -134,7 +134,7 @@ var RefsLocalCmd = &cmds.Command{ Helptext: cmds.HelpText{ Tagline: "List all local references.", ShortDescription: ` -Displays the hashes of all local objects. +Displays the hashes of all local objects. NOTE: This treats all local objects as "raw blocks" and returns CIDv1-Raw CIDs. `, }, diff --git a/core/node/storage.go b/core/node/storage.go index f1d9495fe53..a6c8a46ef1c 100644 --- a/core/node/storage.go +++ b/core/node/storage.go @@ -14,7 +14,6 @@ import ( "github.com/ipfs/go-filestore" "github.com/ipfs/go-ipfs/core/node/helpers" "github.com/ipfs/go-ipfs/repo" - "github.com/ipfs/go-ipfs/thirdparty/cidv0v1" "github.com/ipfs/go-ipfs/thirdparty/verifbs" ) @@ -61,7 +60,6 @@ func BaseBlockstoreCtor(cacheOpts blockstore.CacheOpts, nilRepo bool, hashOnRead } bs = blockstore.NewIdStore(bs) - bs = cidv0v1.NewBlockstore(bs) if hashOnRead { // TODO: review: this is how it was done originally, is there a reason we can't just pass this directly? bs.HashOnRead(true) diff --git a/gc/gc.go b/gc/gc.go index 43669090022..b205dc57725 100644 --- a/gc/gc.go +++ b/gc/gc.go @@ -28,6 +28,16 @@ type Result struct { Error error } +// converts a set of CIDs with different codecs to a set of CIDs with the raw codec. +func toRawCids(set *cid.Set) *cid.Set { + newSet := cid.NewSet() + set.ForEach(func(c cid.Cid) error { + newSet.Add(cid.NewCidV1(cid.Raw, c.Hash())) + return nil + }) + return newSet +} + // GC performs a mark and sweep garbage collection of the blocks in the blockstore // first, it creates a 'marked' set and adds to it the following: // - all recursively pinned blocks, plus all of their descendants (recursively) @@ -60,6 +70,15 @@ func GC(ctx context.Context, bs bstore.GCBlockstore, dstor dstore.Datastore, pn } return } + + // The blockstore reports raw blocks. We need to remove the codecs from the CIDs. + gcs = toRawCids(gcs) + emark.Append(logging.LoggableMap{ + "blackSetSize": fmt.Sprintf("%d", gcs.Len()), + }) + emark.Done() + esweep := log.EventBegin(ctx, "GC.sweep") + keychan, err := bs.AllKeysChan(ctx) if err != nil { select { @@ -79,6 +98,8 @@ func GC(ctx context.Context, bs bstore.GCBlockstore, dstor dstore.Datastore, pn if !ok { break loop } + // NOTE: assumes that all CIDs returned by the keychan are _raw_ CIDv1 CIDs. + // This means we keep the block as long as we want it somewhere (CIDv1, CIDv0, Raw, other...). if !gcs.Has(k) { err := bs.DeleteBlock(k) removed++ @@ -154,7 +175,9 @@ func Descendants(ctx context.Context, getLinks dag.GetLinks, set *cid.Set, roots for _, c := range roots { // Walk recursively walks the dag and adds the keys to the given set - err := dag.Walk(ctx, verifyGetLinks, c, set.Visit, dag.Concurrent()) + err := dag.Walk(ctx, verifyGetLinks, c, func(k cid.Cid) bool { + return set.Visit(toCidV1(k)) + }, dag.Concurrent()) if err != nil { err = verboseCidError(err) @@ -165,6 +188,14 @@ func Descendants(ctx context.Context, getLinks dag.GetLinks, set *cid.Set, roots return nil } +// toCidV1 converts any CIDv0s to CIDv1s. +func toCidV1(c cid.Cid) cid.Cid { + if c.Version() == 0 { + return cid.NewCidV1(c.Type(), c.Hash()) + } + return c +} + // ColoredSet computes the set of nodes in the graph that are pinned by the // pins in the given pinner. func ColoredSet(ctx context.Context, pn pin.Pinner, ng ipld.NodeGetter, bestEffortRoots []cid.Cid, output chan<- Result) (*cid.Set, error) { @@ -225,7 +256,7 @@ func ColoredSet(ctx context.Context, pn pin.Pinner, ng ipld.NodeGetter, bestEffo return nil, err } for _, k := range dkeys { - gcs.Add(k) + gcs.Add(toCidV1(k)) } ikeys, err := pn.InternalPins(ctx) diff --git a/go.mod b/go.mod index 091c7ac6781..fc0c3cb3f50 100644 --- a/go.mod +++ b/go.mod @@ -31,7 +31,7 @@ require ( github.com/ipfs/go-ipfs-chunker v0.0.3 github.com/ipfs/go-ipfs-cmds v0.1.1 github.com/ipfs/go-ipfs-config v0.2.0 - github.com/ipfs/go-ipfs-ds-help v0.0.1 + github.com/ipfs/go-ipfs-ds-help v0.0.2-0.20200107180048-11890cc86e62 github.com/ipfs/go-ipfs-exchange-interface v0.0.1 github.com/ipfs/go-ipfs-exchange-offline v0.0.1 github.com/ipfs/go-ipfs-files v0.0.6 diff --git a/go.sum b/go.sum index 92c5d7b39de..fae63a18663 100644 --- a/go.sum +++ b/go.sum @@ -231,6 +231,8 @@ github.com/ipfs/go-ipfs-delay v0.0.1 h1:r/UXYyRcddO6thwOnhiznIAiSvxMECGgtv35Xs1I github.com/ipfs/go-ipfs-delay v0.0.1/go.mod h1:8SP1YXK1M1kXuc4KJZINY3TQQ03J2rwBG9QfXmbRPrw= github.com/ipfs/go-ipfs-ds-help v0.0.1 h1:QBg+Ts2zgeemK/dB0saiF/ykzRGgfoFMT90Rzo0OnVU= github.com/ipfs/go-ipfs-ds-help v0.0.1/go.mod h1:gtP9xRaZXqIQRh1HRpp595KbBEdgqWFxefeVKOV8sxo= +github.com/ipfs/go-ipfs-ds-help v0.0.2-0.20200107180048-11890cc86e62 h1:ib57ZzQCRZ/scmBO32DqWThjwpTqBW/fGqurYDE/rFA= +github.com/ipfs/go-ipfs-ds-help v0.0.2-0.20200107180048-11890cc86e62/go.mod h1:zjN0aB3d6VyzJTSvcylSYxo+LSR/ELEfNnQM8p/vwc8= github.com/ipfs/go-ipfs-exchange-interface v0.0.1 h1:LJXIo9W7CAmugqI+uofioIpRb6rY30GUu7G6LUfpMvM= github.com/ipfs/go-ipfs-exchange-interface v0.0.1/go.mod h1:c8MwfHjtQjPoDyiy9cFquVtVHkO9b9Ob3FG91qJnWCM= github.com/ipfs/go-ipfs-exchange-offline v0.0.1 h1:P56jYKZF7lDDOLx5SotVh5KFxoY6C81I1NSHW1FxGew= diff --git a/thirdparty/cidv0v1/blockstore.go b/thirdparty/cidv0v1/blockstore.go deleted file mode 100644 index 2f098dff9fe..00000000000 --- a/thirdparty/cidv0v1/blockstore.go +++ /dev/null @@ -1,87 +0,0 @@ -package cidv0v1 - -import ( - blocks "github.com/ipfs/go-block-format" - cid "github.com/ipfs/go-cid" - bs "github.com/ipfs/go-ipfs-blockstore" - mh "github.com/multiformats/go-multihash" -) - -type blockstore struct { - bs.Blockstore -} - -func NewBlockstore(b bs.Blockstore) bs.Blockstore { - return &blockstore{b} -} - -func (b *blockstore) Has(c cid.Cid) (bool, error) { - have, err := b.Blockstore.Has(c) - if have || err != nil { - return have, err - } - c1 := tryOtherCidVersion(c) - if !c1.Defined() { - return false, nil - } - return b.Blockstore.Has(c1) -} - -func (b *blockstore) Get(c cid.Cid) (blocks.Block, error) { - block, err := b.Blockstore.Get(c) - if err == nil { - return block, nil - } - if err != bs.ErrNotFound { - return nil, err - } - c1 := tryOtherCidVersion(c) - if !c1.Defined() { - return nil, bs.ErrNotFound - } - block, err = b.Blockstore.Get(c1) - if err != nil { - return nil, err - } - // modify block so it has the original CID - block, err = blocks.NewBlockWithCid(block.RawData(), c) - if err != nil { - return nil, err - } - // insert the block with the original CID to avoid problems - // with pinning - err = b.Blockstore.Put(block) - if err != nil { - return nil, err - } - return block, nil -} - -func (b *blockstore) GetSize(c cid.Cid) (int, error) { - size, err := b.Blockstore.GetSize(c) - if err == nil { - return size, nil - } - if err != bs.ErrNotFound { - return -1, err - } - c1 := tryOtherCidVersion(c) - if !c1.Defined() { - return -1, bs.ErrNotFound - } - return b.Blockstore.GetSize(c1) -} - -func tryOtherCidVersion(c cid.Cid) cid.Cid { - prefix := c.Prefix() - if prefix.Codec != cid.DagProtobuf || prefix.MhType != mh.SHA2_256 || prefix.MhLength != 32 { - return cid.Undef - } - var c1 cid.Cid - if prefix.Version == 0 { - c1 = cid.NewCidV1(cid.DagProtobuf, c.Hash()) - } else { - c1 = cid.NewCidV0(c.Hash()) - } - return c1 -}