Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Rename --local to --offline #1778

Closed
1 of 2 tasks
Stebalien opened this issue Dec 13, 2018 · 3 comments
Closed
1 of 2 tasks

Rename --local to --offline #1778

Stebalien opened this issue Dec 13, 2018 · 3 comments
Assignees
Labels
exp/wizard Extensive knowledge (implications, ramifications) required kind/wontfix-migration-available P2 Medium: Good to have, but can wait until someone steps up status/in-progress In progress

Comments

@Stebalien
Copy link
Member

Stebalien commented Dec 13, 2018

Related to: ipfs/kubo#4182
Go-ipfs proposal: ipfs/kubo#5825 (comment)

The local flag was supposed to mean "do this on the client, not the daemon" (I think?). However, that hasn't been true for a while. Now it just means "don't use the network for this operation".

Proposal:

  1. Rename --local to --offline (replacing the daemon --offline flag with the global --offline flag (chore: rename local option to offline #1850).
  2. Make it apply everywhere.
@alanshaw
Copy link
Member

I'm fine with this. I think there's only a few places in the code where the local flag is observed - it needs to be reviewed and a rename is a good chance to do that.

Just one weird question, can it be used with the HTTP API? In this context "offline" and "don't go to the network" doesn't fit right as we're clearly already talking over the network!...and "local" makes more sense...

cc @magik6k

@alanshaw alanshaw added exp/wizard Extensive knowledge (implications, ramifications) required status/ready Ready to be worked P2 Medium: Good to have, but can wait until someone steps up labels Dec 13, 2018
@magik6k
Copy link
Member

magik6k commented Dec 13, 2018

We have to expose API somehow, and it just happens to be over the network too. This option only affects the 'libp2p network' part of ipfs, so yeah, it can be used with HTTP API.

@ghost ghost assigned vasco-santos Jan 29, 2019
@ghost ghost added status/in-progress In progress and removed status/ready Ready to be worked labels Jan 29, 2019
hugomrdias pushed a commit to ipfs/js-ipfsd-ctl that referenced this issue Jan 30, 2019
In the context of ipfs/js-ipfs#1778 and ipfs/js-ipfs#1850 , this is now needed for the tests.

BREAKING CHANGE: `--local` option has been renamed to `--offline`
@SgtPooki SgtPooki moved this to 🥞 Todo in js-ipfs deprecation May 17, 2023
@whizzzkid whizzzkid moved this from 🥞 Todo to 🛑 Blocked in js-ipfs deprecation May 24, 2023
@whizzzkid
Copy link

js-ipfs is being deprecated in favor of Helia. You can #4336 and read the migration guide.

Please feel to reopen with any comments before 2023-06-05. We will do a final pass on reopened issues afterward (see #4336).

@github-project-automation github-project-automation bot moved this from 🛑 Blocked to ✅ Done in js-ipfs deprecation May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/wizard Extensive knowledge (implications, ramifications) required kind/wontfix-migration-available P2 Medium: Good to have, but can wait until someone steps up status/in-progress In progress
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants