Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Wantlist handling like go did #26

Closed
dignifiedquire opened this issue Sep 6, 2016 · 2 comments · Fixed by #214
Closed

Improve Wantlist handling like go did #26

dignifiedquire opened this issue Sep 6, 2016 · 2 comments · Fixed by #214
Labels
exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@dignifiedquire
Copy link
Member

Ref ipfs/kubo#3182
@daviddias daviddias self-assigned this Oct 31, 2016
@daviddias daviddias added status/in-progress In progress and removed js-ipfs-ready labels Oct 31, 2016
@daviddias daviddias added status/ready Ready to be worked and removed status/in-progress In progress labels Dec 5, 2016
@daviddias daviddias removed their assignment Dec 7, 2016
@daviddias daviddias added status/deferred Conscious decision to pause or backlog exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue labels Dec 7, 2016
@daviddias
Copy link
Member

This requires https://github.com/ipfs/interface-ipfs-core/issues/58

@daviddias daviddias removed the status/ready Ready to be worked label Jan 29, 2017
@daviddias daviddias added status/ready Ready to be worked P1 High: Likely tackled by core team if no one steps up and removed status/deferred Conscious decision to pause or backlog labels Oct 17, 2017
@achingbrain achingbrain linked a pull request May 26, 2020 that will close this issue
fix: race condition when requesting the same block twice #214
Merged
@achingbrain
Copy link
Member

Interface tests for this have been added to ipfs/js-ipfs#3041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: race condition when requesting the same block twice ipfs/js-ipfs-bitswap
3 participants
@achingbrain @dignifiedquire @daviddias