bug: closeMenu directive affect the next view even when the view dosen't need to change

[sharvit]

Type: bug

Platform: all

Hi :)

The first very problematic use-case is when the SideMenu contain a link to the current view.
At this use-case the SideMenu will close and the view will not change.
BUT!!
After i click on a link inside my current view, it make the next view as a RootView and i don't have a back button.

This bug will happen for all elements that contain MenuClose and not change the next view.

<ion-side-menu side="left">
  <ion-content>
    <ion-list>
      <!-- Close the menu but the next view (whatever it will be) going to be to RootView -->
      <ion-item menu-close>
        Close The Menu
      </ion-item>
      <!-- Close the menu but the next view (whatever it will be) going to be to RootView -->
      <ion-item  menu-close href="#/current-view">
        Link to my current view
      </ion-item>
      <!-- The only use-case it will work well -->
      <ion-item menu-close href="#/another-view">
        Work Well
      </ion-item>
    </ion-list>
  </ion-content>
</ion-side-menu>

The problem is here:
https://github.com/driftyco/ionic/blob/master/js/angular/directive/menuClose.js#L1

Need to check that the view are actually going to change before setting the next view as the root view.

Thank you for this amazing platform 👍

[stan-kondrat]

same #4038

[mhartington]

Closing as a duplicate of #4132