Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ionSpinner customization in refresher and infinite scroll #3203

Closed
danjohnso opened this issue Feb 28, 2015 · 3 comments
Closed

feat: ionSpinner customization in refresher and infinite scroll #3203

danjohnso opened this issue Feb 28, 2015 · 3 comments

Comments

@danjohnso
Copy link

Type: feat

Platform: all

It would be nice to be able to add the color class to the spinner from the refresher and infinite scroll directives. Looks like right now we can only change what the icon type is. Natural follow up to #3077

@danjohnso danjohnso changed the title ionSpinner customization in refresher and infinite scroll feat: ionSpinner customization in refresher and infinite scroll Feb 28, 2015
@felquis
Copy link

felquis commented Mar 17, 2015

+1 👍

I think something like this would be nice!

<ion-infinite-scroll
  on-infinite="loadMore()"
  distance="10%"
  spinner-class="spinner-light or-something-else">
</ion-infinite-scroll>

I also noticed that when using infinite-scroll with ng-repeat, the spinner appears where I put the ion-infinite-scroll directive, so may be useful to use the content of this directive to show a completely different loading, to let developers use whatever they want to, like:

<ion-infinite-scroll
  on-infinite="loadMore()"
  distance="10%"
  use-content="true">

  <p>
    <ion-spinner class="spinner-light"></ion-spinner>
  </p>

  Loading
</ion-infinite-scroll>

@felquis
Copy link

felquis commented Mar 17, 2015

I bit related to #3343

@mhartington
Copy link
Contributor

Closing this as a feature request and moving to our trello board
https://trello.com/c/pedEiFm5/93-allow-classes-for-ion-refresher-and-ion-infinite-scroll

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants