Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding href to ion-button adds extra width #14760

Closed
corysmc opened this issue Jul 12, 2018 · 2 comments
Closed

Adding href to ion-button adds extra width #14760

corysmc opened this issue Jul 12, 2018 · 2 comments
Assignees
Labels

Comments

@corysmc
Copy link
Contributor

corysmc commented Jul 12, 2018

Bug Report

Ionic Info

Describe the Bug
Adding href to an ion-button with expand="block" adds extra width to ion-button

Steps to Reproduce
Steps to reproduce the behavior:

  1. create <ion-button expand="block" href="#">Button</ion-button> inside a max width wrapper.
  2. Observe the button overflows past the wrapper

Related Code
https://codepen.io/corysmc/pen/NBqzJe

Expected Behavior
Should be the same size button with or without the href.

@ionitron-bot ionitron-bot bot added the triage label Jul 12, 2018
@brandyscarney
Copy link
Member

Thanks for the issue! We need to add the following to .button-native:

box-sizing: border-box;

@brandyscarney brandyscarney self-assigned this Jul 12, 2018
@ionitron-bot
Copy link

ionitron-bot bot commented Sep 1, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants