Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: Some bugs on ion-card #14723

Closed
mburger81 opened this issue Jul 6, 2018 · 2 comments
Closed

v4: Some bugs on ion-card #14723

mburger81 opened this issue Jul 6, 2018 · 2 comments
Labels

Comments

@mburger81
Copy link
Contributor

Describe the Bug
We try to use your ion-card and sub components using alpha.7 with latest beta documentation.
We also created a demo repo https://github.com/mburger81/ionic4-tests where you can navigate to Cards menu to see bugs and simulate them.

This is what we have figured out, or we think we have figured out :)

  1. You can use ion-card-subtitle before ion-card-title, but this should be a wrong usage and probably you can avoid this by using slots, right? In this case it would be independent from the order you list it in code, we found this bug on your first card example in docs https://beta.ionicframework.com/docs/api/card
  2. The ion-card-header on MD should be 20px instead of 24px, right?
  3. setting color attribute to ion-card-header does not have any effect, perhaps color attribute is already documented on docs but not implemented on alpha.7?

image

  1. We are not sure how to use ACTIONS in ion-card-header, perhaps we are missing something or there is a bug, but having a look to your documentation we found this out
    • we should use ion-item in ion-header if we wan' to use buttons, wrapping ion-card-title and ion-card-subtitle in ion-label
    • if we use ion-item in ion-card-header the padding is completely different from first example, which should be the right padding

image

@Ritzlgrmft
Copy link
Contributor

Ritzlgrmft commented Sep 14, 2018

I have the same problem with <ion-card-header color="...">, using 4.0.0-beta.7.
However, it was helping to set the color attribute for the card itself: <ion-card color="...">. This changed the color of the header...

brandyscarney added a commit that referenced this issue Oct 9, 2018
@ionitron-bot
Copy link

ionitron-bot bot commented Jan 2, 2019

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jan 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants