Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(analytics): add screen_class to navigation screen tracking examples #4174

Merged
merged 2 commits into from
Aug 29, 2020
Merged

docs(analytics): add screen_class to navigation screen tracking examples #4174

merged 2 commits into from
Aug 29, 2020

Conversation

MoKhajavi75
Copy link
Contributor

Description

Related issues

#4145

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel vercel bot temporarily deployed to Preview August 29, 2020 20:51 Inactive
@vercel
Copy link

vercel bot commented Aug 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/46y286n4y
✅ Preview: https://react-native-firebase-git-fork-mohamadkh75-patch-1.invertase.vercel.app

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@mikehardy mikehardy changed the title Update screen-tracking.md docs(analytics): add screen_class to navigation screen tracking examples Aug 29, 2020
@mikehardy
Copy link
Collaborator

happened to be scanning the queue in between tasks and saw it right as it came in ;-)
Thanks for this!

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Aug 29, 2020
@mikehardy mikehardy merged commit 01fed16 into invertase:master Aug 29, 2020
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Aug 29, 2020
@MoKhajavi75 MoKhajavi75 deleted the patch-1 branch August 29, 2020 21:11
@MoKhajavi75
Copy link
Contributor Author

Thanks @mikehardy
I really appreciate your efforts ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants