Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(messaging,ios): crash receiving notification with image #3701

Merged
merged 1 commit into from
May 28, 2020
Merged

fix(messaging,ios): crash receiving notification with image #3701

merged 1 commit into from
May 28, 2020

Conversation

zoontek
Copy link
Contributor

@zoontek zoontek commented May 28, 2020

Hi,

Currently receiving notifications with images will crash the app on iOS (Fixes #3447, #3616).
This is only the patch proposed by @actuosus, thanks to him 🙌 #3447 (comment)

Release Summary

  • Fix crash when receiving notification with an image on iOS.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

  • Simulate a notification on the Firebase console using your device FCM token
  • Don't forget to upload a logo
  • Profit! 😄

🔥

@mikehardy
Copy link
Collaborator

@zoontek for the win :-), @Salakar / @Ehesp this has been discussed before, seems like it's the right patch for an easy merge/release win?

@mikehardy mikehardy added Workflow: Needs Review Pending feedback or review from a maintainer. impact: crash Behaviour causing app to crash. platform: ios plugin: messaging FCM only - ( messaging() ) - do not use for Notifications Version: >= 6 labels May 28, 2020
@Salakar Salakar changed the title fix(messaging,ios): fixed crash when receiving notification with images on iOS fix(messaging,ios): crash receiving notification with image May 28, 2020
@Salakar Salakar merged commit f889646 into invertase:master May 28, 2020
@Salakar
Copy link
Contributor

Salakar commented May 28, 2020

Shipped! 3549999

Thanks :)

@zoontek zoontek deleted the ios-notif-image branch May 29, 2020 07:54
stefkampen pushed a commit to stefkampen/react-native-firebase that referenced this pull request Jun 6, 2020
@zoontek @stefkampen
fix(messaging,ios): crash receiving notification with image (invertas…
517787f 
…e#3701)

Currently receiving notifications with images will crash the app on iOS (Fixes invertase#3447, invertase#3616).

Patch proposed by @actuosus, thanks to him 🙌 invertase#3447 (comment)

[publish]
@mikehardy mikehardy removed the Workflow: Needs Review Pending feedback or review from a maintainer. label Dec 2, 2020
hmhm2292 pushed a commit to hmhm2292/react-native-firebase that referenced this pull request Jul 13, 2021
@zoontek
fix(messaging,ios): crash receiving notification with image (invertas…
e9386dd 
…e#3701)

Currently receiving notifications with images will crash the app on iOS (Fixes invertase#3447, invertase#3616).

Patch proposed by @actuosus, thanks to him 🙌 invertase#3447 (comment)

[publish]
@vipu-sa

This comment has been minimized.

Sign in to view
@mikehardy

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

Assignees
No one assigned
Labels
impact: crash Behaviour causing app to crash. platform: ios plugin: messaging FCM only - ( messaging() ) - do not use for Notifications
Projects
None yet
Milestone
No milestone
4 participants
@zoontek @mikehardy @Salakar @vipu-sa