Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The boundary prop type check seems wrong #47

Open
Michael-Tajmajer-Bentley opened this issue Aug 28, 2021 · 0 comments
Open

The boundary prop type check seems wrong #47

Michael-Tajmajer-Bentley opened this issue Aug 28, 2021 · 0 comments

Comments

@Michael-Tajmajer-Bentley

The code is using:

location: _propTypes2.default.oneOfType([_propTypes2.default.arrayOf(_propTypes2.default.number), _propTypes2.default.arrayOf(_propTypes2.default.string)]),

However, the boundary can be an array of two item types - a string ('location name') or a Location.
see: Microsoft.Maps.SpatialDataService.GeoDataAPIManager.getBoundary

Location is simple class that has:
latitude | number | The latitude of the location.
longitude | number | The longitude of the location.

When passing in an array that contains a Location object, the propcheck fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant