Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.23.0-preview0 #1073

Closed
fintelia opened this issue Nov 3, 2019 · 8 comments · Fixed by #1133
Closed

Release 0.23.0-preview0 #1073

fintelia opened this issue Nov 3, 2019 · 8 comments · Fixed by #1133

Comments

@fintelia
Copy link
Contributor

fintelia commented Nov 3, 2019

The next branch has accumulated a bunch of changes that improve various aspects of the library, but require a major version bump. We should release a preview version of the crate soon so that we can test them.

Are there any remaining patches we should wait on before a first preview release?

@HeroicKatora
Copy link
Member

HeroicKatora commented Nov 3, 2019

Of those outstanding PRs that should go into next:

Other changes seem less consquential.

  • Error clean up #928 is an ambitious work but needs time to find the correct set of variants anyways. It's not highly critical.
  • Flif decoding support implemented #930, DXT: Fix alpha handling #1060 show that we might want to dedicate some thought into making the ImageFormat enum non-exhaustive, potentially other types as well. However, that's not decided and delaying it until a finalized 0.23 seems just fine.
  • Fix potential overflow in GIF decoding #1036 likewise will not likely affect too many users
  • No tracking issue but we would want to update some dependencies. That would mean ensuring that there aren't any issues blocking us from doing so. However, that's no breaking concern for the preview release.

CI indicates the branch is theoretically ready

@CryZe
Copy link
Contributor

CryZe commented Nov 25, 2019

image seems to use tiff 0.3.1 at the moment. It seems tiff 0.4.0 just got released. Will that also go into 0.23.0 of image? The reason why I'm asking is that tiff 0.3.1 seems to be the only crate pulling syn <1.0 into my dependency tree, which slows down compile times significantly.

@nox
Copy link
Contributor

nox commented Nov 27, 2019

Any ETA for 0.23?

@Shnatsel
Copy link
Contributor

I'd like to point out that while #1036 is not that critical in and of itself, it blocks further fuzzing. So it may be preventing discovery of other failure conditions on crafted inputs - panics, memory exhaustion, infinite loops, etc.

@nox
Copy link
Contributor

nox commented Jan 6, 2020

Seems like the biggest blocker is now #928.

@Manishearth
Copy link
Contributor

Could we perhaps have a patch release on 0.22 that uses the newer tiff (so that others can use the new num_derive and thus syn)? Duplicated syn dependencies really slow down build times

@nox
Copy link
Contributor

nox commented Jan 8, 2020

tiff is exposed from the public API which is why we are waiting on 0.23, AFAIK.

@Manishearth
Copy link
Contributor

Ah, makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants