Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tonic-web incompatible with tonic 0.4.3 because of changes in BodyBox #674

Closed
CptCrispyCrunchy opened this issue Jun 2, 2021 · 3 comments

Comments

@CptCrispyCrunchy
Copy link

Bug Report

Version

0.4.3

Platform

Linux ******** 5.8.0-53-generic #60-Ubuntu SMP Thu May 6 07:46:32 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Crates

tonic-web

Description

Some functions from body.rs were moved/deprecated, including BodyBox::empty() which is used by tonic-web service module and here.

To fix this problem, it can be replaced with the empty_body method found in codegen

@davidpdrsn
Copy link
Member

davidpdrsn commented Jun 2, 2021

This will be fixed by #670. I'm gonna merge that now.

Then you can depend on tonic through a git dependency since we've made breaking changes on master.

@CptCrispyCrunchy
Copy link
Author

Oh great, thank you! :)
I guess this issue can be closed then?

@davidpdrsn
Copy link
Member

Yes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants