Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: replace hardcoded variables with import from global vars #7

Open
heyJonBray opened this issue Jul 29, 2024 · 1 comment
Open
Assignees
Labels
DRAFT For draft PRs that are awaiting additional commits before merging type: chore General chores, refactors, and other todo items. type: enhancement Updating an existing feature

Comments

@heyJonBray
Copy link
Owner

Task to be completed

store hardcoded address variables in a global OnchainData.sol file and pull from them as needed

Scope of work

script files rely on hardcoded onchain data and is chain dependent. instead of managing hardcoded vars in each file, which often overlap, create a global contract, for example /utils/OnchainData.sol that can be imported where these variables are needed

Additional context

example of what I'd like to avoid when possible:
image

@heyJonBray heyJonBray added type: enhancement Updating an existing feature DRAFT For draft PRs that are awaiting additional commits before merging type: chore General chores, refactors, and other todo items. labels Jul 29, 2024
@heyJonBray heyJonBray self-assigned this Jul 29, 2024
@heyJonBray
Copy link
Owner Author

WIP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DRAFT For draft PRs that are awaiting additional commits before merging type: chore General chores, refactors, and other todo items. type: enhancement Updating an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant