Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helidon should avoid calling Application subclass methods directly #3338

Closed
spericas opened this issue Aug 30, 2021 · 1 comment
Closed

Helidon should avoid calling Application subclass methods directly #3338

spericas opened this issue Aug 30, 2021 · 1 comment
Assignees
@spericas
Labels
jax-rs JAX-RS and Jersey related issues
Milestone
2.4.0

Comments

@spericas
Copy link
Member

This is to avoid repeated calls to getSingletons in particular. The implementation of this method often creates fresh instances, and this can be a problem if called multiple times. There's at least one place where we do this.
@spericas spericas added the jax-rs JAX-RS and Jersey related issues label Aug 30, 2021
@spericas spericas added this to the 2.4.0 milestone Aug 30, 2021
@spericas spericas self-assigned this Aug 30, 2021
@spericas
Copy link
Member Author

spericas commented Sep 1, 2021

PR #3340

@spericas spericas closed this as completed Sep 1, 2021
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spericas spericas

Labels
jax-rs JAX-RS and Jersey related issues
Projects
Backlog
Archived in project
Milestone
2.4.0
Development

No branches or pull requests
1 participant
@spericas