Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showTypeForSelection working? #1973

Closed
jamesdbrock opened this issue Jun 24, 2021 · 2 comments
Closed

showTypeForSelection working? #1973

jamesdbrock opened this issue Jun 24, 2021 · 2 comments
Labels
type: enhancement New feature or request

Comments

@jamesdbrock
Copy link

This “show type of selected expression on hover” feature haskell/vscode-haskell#40 is great. Is this currently working?

I can’t find any mention of this feature in the README.md.

I tried this in my settings.json and nothing happens.

  "languageServerHaskell.showTypeForSelection.onHover": "true",
  "languageServerHaskell.showTypeForSelection.command.location": "dropdown",

I don't see any mention of this in the logs, for example ~/.config/Code/logs/20210624T170820/exthost1/output_logging_20210624T170826/5-Haskell\ \(IHaskell2\).log

VSCode v1.57.1
haskell.haskell extension v1.4.0

@jneira
Copy link
Member

jneira commented Jun 24, 2021

Wow, thanks for linking the pr, i was not aware that worked at some point.
I am afraid at that moment the unique lsp server of the extension was haskell-ide-engine which supported the feature added in that pr.
Now the unique lsp server is haskell-language-server and it does not support it. 😞
We have a feature request in hls about and knowing it worked in hie maybe could help us to reimplement it again (although it used ghcmod, which is complicated to integrate again)

@jneira jneira transferred this issue from haskell/vscode-haskell Jun 24, 2021
@jneira jneira added the type: enhancement New feature or request label Jun 24, 2021
@jneira
Copy link
Member

jneira commented Jun 24, 2021

If you dont mind i am gonna close it as duplicate of the mentioned issue: #709, you could track the progress an eventual implementation there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants