Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting quic_override in google_compute_target_https_proxy once stops being optional #4574

Closed
gilberthdez opened this issue Sep 29, 2019 · 3 comments
Labels

Comments

@gilberthdez
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
  • If an issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to "hashibot", a community member has claimed the issue already.

Terraform Version

Terraform v0.12.9

  • provider.google v2.15.0
  • provider.google-beta v2.15.0

Affected Resource(s)

  • google_compute_target_https_proxy

Terraform Configuration Files

resource "google_compute_target_https_proxy" "test" {
  name             = "tf-test-proxy"
  url_map          = "${google_compute_url_map.test.self_link}"
  ssl_certificates = "${concat([var.test_certificate_link])}"
  #quic_override    = "ENABLE"
}

Debug Output

Panic Output

Error: Error updating TargetHttpsProxy "tf-test-proxy": googleapi: Error 400: Required field 'quicOverride' not specified, required

Expected Behavior

Based on the documentation, the argument is 'optional'. Meaning that setting it once and removing it later shouldn't yield an Error and should set it as default "NONE" as expressed in the documentation.

Actual Behavior

Steps to Reproduce

  1. Create a google_compute_target_https_proxy resource setting the quic_override.

  2. Update the resource description and comment out quic_override.

  3. terraform apply

Important Factoids

References

  • #0000
@ghost ghost added the bug label Sep 29, 2019
@nat-henderson
Copy link
Contributor

Well, that's certainly what it says in the public REST documentation...

image

This is a bug in GCP, then. We'll work around it by explicitly setting the field default to NONE.

@nat-henderson
Copy link
Contributor

That'll be GoogleCloudPlatform/magic-modules#2404.

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
@github-actions github-actions bot added forward/review In review; remove label to forward service/compute-l7-load-balancer labels Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants