Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SourceRepository for CloudFunctions #2685

Closed
pratikmallya opened this issue Dec 15, 2018 · 2 comments
Closed

Support SourceRepository for CloudFunctions #2685

pratikmallya opened this issue Dec 15, 2018 · 2 comments
Labels

Comments

@pratikmallya
Copy link

pratikmallya commented Dec 15, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Currently, the only way to specify the source of a respository seems to be to use a GCS bucket. Cloud Functions do support Google Source Repositories as a source for code and that parameter would be nice to have

New or Affected Resource(s)

  • google_cloudfunctions_function

Potential Terraform Configuration

resource "google_sourcerepo_repository" "cf_trigger" {
  name = "trigger"
}

resource "google_cloudfunctions_function" "cf_trigger" {
...
sourceRepo = "${google_sourcerepo_repository.cf_trigger.url}"
}

References

@ghost ghost added the enhancement label Dec 15, 2018
@rileykarson
Copy link
Collaborator

rileykarson commented Dec 17, 2018

Support was added in #2650, this feature will be in 2.0.0.

@ghost
Copy link

ghost commented Jan 17, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 17, 2019
@github-actions github-actions bot added service/cloudfunctions forward/review In review; remove label to forward labels Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants