diff --git a/.changelog/37353.txt b/.changelog/37353.txt new file mode 100644 index 000000000000..6313582895f1 --- /dev/null +++ b/.changelog/37353.txt @@ -0,0 +1,11 @@ +```release-note:bug +resource/aws_fsx_ontap_storage_virtual_machine: Correctly set `tags` and `tags_all` on resource Read +``` + +```release-note:bug +data-source/aws_fsx_ontap_storage_virtual_machine: Correctly set `tags` on Read +``` + +```release-note:bug +resource/aws_fsx_openzfs_file_system: Correctly set `tags` and `tags_all` on resource Read +``` \ No newline at end of file diff --git a/internal/service/fsx/ontap_storage_virtual_machine.go b/internal/service/fsx/ontap_storage_virtual_machine.go index 9f708f72b9bf..e22ac9e539b2 100644 --- a/internal/service/fsx/ontap_storage_virtual_machine.go +++ b/internal/service/fsx/ontap_storage_virtual_machine.go @@ -306,7 +306,8 @@ func resourceONTAPStorageVirtualMachineRead(ctx context.Context, d *schema.Resou d.Set("svm_admin_password", d.Get("svm_admin_password").(string)) d.Set("uuid", storageVirtualMachine.UUID) - setTagsOut(ctx, storageVirtualMachine.Tags) + // SVM tags aren't set in the Describe response. + // setTagsOut(ctx, storageVirtualMachine.Tags) return diags } diff --git a/internal/service/fsx/ontap_storage_virtual_machine_data_source.go b/internal/service/fsx/ontap_storage_virtual_machine_data_source.go index 4af66e0fdb11..caf5fd25a790 100644 --- a/internal/service/fsx/ontap_storage_virtual_machine_data_source.go +++ b/internal/service/fsx/ontap_storage_virtual_machine_data_source.go @@ -196,6 +196,8 @@ func dataSourceONTAPStorageVirtualMachine() *schema.Resource { func dataSourceONTAPStorageVirtualMachineRead(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics { var diags diag.Diagnostics conn := meta.(*conns.AWSClient).FSxConn(ctx) + defaultTagsConfig := meta.(*conns.AWSClient).DefaultTagsConfig + ignoreTagsConfig := meta.(*conns.AWSClient).IgnoreTagsConfig input := &fsx.DescribeStorageVirtualMachinesInput{} @@ -235,7 +237,15 @@ func dataSourceONTAPStorageVirtualMachineRead(ctx context.Context, d *schema.Res d.Set("subtype", svm.Subtype) d.Set("uuid", svm.UUID) - setTagsOut(ctx, svm.Tags) + // SVM tags aren't set in the Describe response. + // setTagsOut(ctx, svm.Tags) + + tags := KeyValueTags(ctx, svm.Tags).IgnoreAWS().IgnoreConfig(ignoreTagsConfig) + + //lintignore:AWSR002 + if err := d.Set(names.AttrTags, tags.RemoveDefaultConfig(defaultTagsConfig).Map()); err != nil { + return sdkdiag.AppendErrorf(diags, "setting tags: %s", err) + } return diags } diff --git a/internal/service/fsx/ontap_storage_virtual_machine_data_source_test.go b/internal/service/fsx/ontap_storage_virtual_machine_data_source_test.go index 71a4d84096fb..f7be92bcd255 100644 --- a/internal/service/fsx/ontap_storage_virtual_machine_data_source_test.go +++ b/internal/service/fsx/ontap_storage_virtual_machine_data_source_test.go @@ -38,6 +38,7 @@ func TestAccFSxONTAPStorageVirtualMachineDataSource_Id(t *testing.T) { resource.TestCheckResourceAttrPair(dataSourceName, names.AttrID, resourceName, names.AttrID), resource.TestCheckResourceAttrPair(dataSourceName, names.AttrName, resourceName, names.AttrName), resource.TestCheckResourceAttrPair(dataSourceName, "subtype", resourceName, "subtype"), + resource.TestCheckResourceAttrPair(dataSourceName, "tags.%", resourceName, "tags.%"), resource.TestCheckResourceAttrPair(dataSourceName, "uuid", resourceName, "uuid"), ), }, @@ -71,6 +72,7 @@ func TestAccFSxONTAPStorageVirtualMachineDataSource_Filter(t *testing.T) { resource.TestCheckResourceAttrPair(dataSourceName, names.AttrID, resourceName, names.AttrID), resource.TestCheckResourceAttrPair(dataSourceName, names.AttrName, resourceName, names.AttrName), resource.TestCheckResourceAttrPair(dataSourceName, "subtype", resourceName, "subtype"), + resource.TestCheckResourceAttrPair(dataSourceName, "tags.%", resourceName, "tags.%"), resource.TestCheckResourceAttrPair(dataSourceName, "uuid", resourceName, "uuid"), ), }, diff --git a/internal/service/fsx/openzfs_file_system.go b/internal/service/fsx/openzfs_file_system.go index 8e1426b9cbbf..64ef2d9b44a8 100644 --- a/internal/service/fsx/openzfs_file_system.go +++ b/internal/service/fsx/openzfs_file_system.go @@ -514,7 +514,8 @@ func resourceOpenZFSFileSystemRead(ctx context.Context, d *schema.ResourceData, d.Set(names.AttrVPCID, filesystem.VpcId) d.Set("weekly_maintenance_start_time", openZFSConfig.WeeklyMaintenanceStartTime) - setTagsOut(ctx, filesystem.Tags) + // FS tags aren't set in the Describe response. + // setTagsOut(ctx, filesystem.Tags) rootVolume, err := findOpenZFSVolumeByID(ctx, conn, rootVolumeID)