From 03d978b12e38bac0ff51271dc6e748b7d0c2f1c8 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Thu, 22 Aug 2024 14:48:09 -0400 Subject: [PATCH 001/281] go: Upgrade to go1.23.0 --- .ci/providerlint/go.mod | 2 +- .ci/tools/go.mod | 2 +- .go-version | 2 +- go.mod | 2 +- skaff/go.mod | 2 +- tools/awssdkpatch/go.mod | 2 +- tools/literally/go.mod | 2 +- tools/tfsdk2fw/go.mod | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.ci/providerlint/go.mod b/.ci/providerlint/go.mod index 8e7ed23d021d..2ae777180067 100644 --- a/.ci/providerlint/go.mod +++ b/.ci/providerlint/go.mod @@ -1,6 +1,6 @@ module github.com/hashicorp/terraform-provider-aws/ci/providerlint -go 1.22.6 +go 1.23.0 require ( github.com/aws/aws-sdk-go v1.55.5 diff --git a/.ci/tools/go.mod b/.ci/tools/go.mod index 851b52727a0c..be1c6378bb36 100644 --- a/.ci/tools/go.mod +++ b/.ci/tools/go.mod @@ -1,6 +1,6 @@ module github.com/hashicorp/terraform-provider-aws/tools -go 1.22.6 +go 1.23.0 require ( github.com/YakDriver/tfproviderdocs v0.13.0 diff --git a/.go-version b/.go-version index 013173af5e9b..a6c2798a482e 100644 --- a/.go-version +++ b/.go-version @@ -1 +1 @@ -1.22.6 +1.23.0 diff --git a/go.mod b/go.mod index 94cb82b2fe70..ca229cd0fbdb 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/hashicorp/terraform-provider-aws -go 1.22.6 +go 1.23.0 require ( github.com/ProtonMail/go-crypto v1.1.0-alpha.5-proton diff --git a/skaff/go.mod b/skaff/go.mod index fe853bdee7f8..b02e6a469e42 100644 --- a/skaff/go.mod +++ b/skaff/go.mod @@ -1,6 +1,6 @@ module github.com/hashicorp/terraform-provider-aws/skaff -go 1.22.6 +go 1.23.0 require ( github.com/YakDriver/regexache v0.24.0 diff --git a/tools/awssdkpatch/go.mod b/tools/awssdkpatch/go.mod index 45b9506f9a39..0890f464457d 100644 --- a/tools/awssdkpatch/go.mod +++ b/tools/awssdkpatch/go.mod @@ -1,6 +1,6 @@ module github.com/hashicorp/terraform-provider-aws/tools/awssdkpatch -go 1.22.6 +go 1.23.0 require ( github.com/hashicorp/terraform-provider-aws v1.60.1-0.20220322001452-8f7a597d0c24 diff --git a/tools/literally/go.mod b/tools/literally/go.mod index a12efe33aab2..483534063445 100644 --- a/tools/literally/go.mod +++ b/tools/literally/go.mod @@ -1,3 +1,3 @@ module github.com/hashicorp/terraform-provider-aws/tools/literally -go 1.22.6 +go 1.23.0 diff --git a/tools/tfsdk2fw/go.mod b/tools/tfsdk2fw/go.mod index 4a27e1947bfe..ba6de5833b79 100644 --- a/tools/tfsdk2fw/go.mod +++ b/tools/tfsdk2fw/go.mod @@ -1,6 +1,6 @@ module github.com/hashicorp/terraform-provider-aws/tools/tfsdk2fw -go 1.22.6 +go 1.23.0 require ( github.com/hashicorp/terraform-plugin-sdk/v2 v2.34.0 From 13d3dd8f12032e3c5205ae05885aa180d640c61f Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:36 -0400 Subject: [PATCH 002/281] .ci: linter changes --- .ci/.golangci2.yml | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/.ci/.golangci2.yml b/.ci/.golangci2.yml index 14181c9f4223..775d2f184261 100644 --- a/.ci/.golangci2.yml +++ b/.ci/.golangci2.yml @@ -124,12 +124,12 @@ linters: - asciicheck - containedctx - contextcheck + - copyloopvar - dogsled - durationcheck - errcheck - errname - errorlint - - exportloopref - goconst - gocritic - gofmt @@ -160,10 +160,17 @@ linters: # - thelper linters-settings: + copyloopvar: + check-alias: true dogsled: max-blank-identifiers: 3 errcheck: - ignore: github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:ForceNew|Set,fmt:.*,io:Close + ignore: github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:ForceNew|Set,io:Close + # "ignore" is deprecated but "exclude-functions" doesn't seem to work or the syntax is non-obvious. + # https://github.com/kisielk/errcheck#excluding-functions + #exclude-functions: + # - (github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.ResourceData).Set + # - io:Close errorlint: errorf: false goconst: @@ -173,10 +180,10 @@ linters-settings: enabled-tags: - diagnostic disabled-tags: - - style - - performance - experimental - opinionated + - performance + - style mnd: checks: - argument @@ -221,7 +228,7 @@ linters-settings: - tparallel - unparam predeclared: - ignore: cap,close,copy,delete,len,new + ignore: cap,close,copy,delete,len,new,min,max revive: # Recommended configuration. # See https://github.com/mgechev/revive#recommended-configuration. From 6a717b5d57f8d684bf13350eb38d85acc04f66db Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:36 -0400 Subject: [PATCH 003/281] docs: linter changes --- docs/unit-tests.md | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/unit-tests.md b/docs/unit-tests.md index e1103ae20538..617c2533e3ba 100644 --- a/docs/unit-tests.md +++ b/docs/unit-tests.md @@ -63,7 +63,6 @@ func TestExampleUnitTest(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() got, err := tfrds.FunctionFromResource(testCase.Input) From 63591e75d758320c49ce640d75f0844ee03b3f5f Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:37 -0400 Subject: [PATCH 004/281] acctest: linter changes --- internal/acctest/acctest.go | 4 ---- internal/acctest/jsoncmp/compare_test.go | 1 - internal/acctest/partition_test.go | 4 ---- 3 files changed, 9 deletions(-) diff --git a/internal/acctest/acctest.go b/internal/acctest/acctest.go index 265d24e032f4..69ad61eddc53 100644 --- a/internal/acctest/acctest.go +++ b/internal/acctest/acctest.go @@ -2718,7 +2718,6 @@ func RunSerialTests1Level(t *testing.T, testCases map[string]func(*testing.T), d t.Helper() for name, tc := range testCases { - tc := tc t.Run(name, func(t *testing.T) { tc(t) time.Sleep(d) @@ -2731,7 +2730,6 @@ func RunSerialTests2Levels(t *testing.T, testCases map[string]map[string]func(*t t.Helper() for group, m := range testCases { - m := m t.Run(group, func(t *testing.T) { RunSerialTests1Level(t, m, d) }) @@ -2743,9 +2741,7 @@ func RunLimitedConcurrencyTests2Levels(t *testing.T, semaphore tfsync.Semaphore, t.Helper() for group, m := range testCases { - m := m for name, tc := range m { - tc := tc t.Run(fmt.Sprintf("%s_%s", group, name), func(t *testing.T) { t.Cleanup(func() { if os.Getenv(resource.EnvTfAcc) != "" { diff --git a/internal/acctest/jsoncmp/compare_test.go b/internal/acctest/jsoncmp/compare_test.go index 5607f8b447c5..22f9b1f89ee3 100644 --- a/internal/acctest/jsoncmp/compare_test.go +++ b/internal/acctest/jsoncmp/compare_test.go @@ -31,7 +31,6 @@ func TestDiff(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.testName, func(t *testing.T) { t.Parallel() diff --git a/internal/acctest/partition_test.go b/internal/acctest/partition_test.go index 0990a739dab6..aeaf71f4f0bb 100644 --- a/internal/acctest/partition_test.go +++ b/internal/acctest/partition_test.go @@ -48,7 +48,6 @@ func TestIsIsolatedPartition(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.input, func(t *testing.T) { t.Parallel() @@ -93,7 +92,6 @@ func TestIsIsolatedRegion(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.input, func(t *testing.T) { t.Parallel() @@ -142,7 +140,6 @@ func TestIsStandardPartition(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.input, func(t *testing.T) { t.Parallel() @@ -187,7 +184,6 @@ func TestIsStandardRegion(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.input, func(t *testing.T) { t.Parallel() From 073a58b59fc9682520bc698ddf11ee7b3a6dfdf9 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:37 -0400 Subject: [PATCH 005/281] conns: linter changes --- internal/conns/apiretry_test.go | 1 - internal/conns/awsclient_test.go | 4 ---- internal/conns/config.go | 2 +- internal/conns/config_test.go | 1 - 4 files changed, 1 insertion(+), 7 deletions(-) diff --git a/internal/conns/apiretry_test.go b/internal/conns/apiretry_test.go index 8b4d50e874cd..13bb30b60909 100644 --- a/internal/conns/apiretry_test.go +++ b/internal/conns/apiretry_test.go @@ -83,7 +83,6 @@ func TestAddIsErrorRetryables(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() diff --git a/internal/conns/awsclient_test.go b/internal/conns/awsclient_test.go index e69694f98974..5676cd90d937 100644 --- a/internal/conns/awsclient_test.go +++ b/internal/conns/awsclient_test.go @@ -37,7 +37,6 @@ func TestAWSClientPartitionHostname(t *testing.T) { // nosemgrep:ci.aws-in-func- } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Name, func(t *testing.T) { t.Parallel() @@ -81,7 +80,6 @@ func TestAWSClientRegionalHostname(t *testing.T) { // nosemgrep:ci.aws-in-func-n } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Name, func(t *testing.T) { t.Parallel() @@ -125,7 +123,6 @@ func TestAWSClientEC2PrivateDNSNameForIP(t *testing.T) { // nosemgrep:ci.aws-in- } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Name, func(t *testing.T) { t.Parallel() @@ -169,7 +166,6 @@ func TestAWSClientEC2PublicDNSNameForIP(t *testing.T) { // nosemgrep:ci.aws-in-f } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Name, func(t *testing.T) { t.Parallel() diff --git a/internal/conns/config.go b/internal/conns/config.go index fbba342b8e05..ba533e77e9f7 100644 --- a/internal/conns/config.go +++ b/internal/conns/config.go @@ -201,7 +201,7 @@ func (c *Config) ConfigureProvider(ctx context.Context, client *AWSClient) (*AWS err := awsbaseConfig.VerifyAccountIDAllowed(accountID) if err != nil { - return nil, sdkdiag.AppendErrorf(diags, err.Error()) + return nil, sdkdiag.AppendErrorf(diags, "%s", err.Error()) } dnsSuffix := "amazonaws.com" diff --git a/internal/conns/config_test.go b/internal/conns/config_test.go index 50164fa8f4db..f7684e658ac3 100644 --- a/internal/conns/config_test.go +++ b/internal/conns/config_test.go @@ -439,7 +439,6 @@ func TestProxyConfig(t *testing.T) { } for name, tc := range cases { - tc := tc t.Run(name, func(t *testing.T) { ctx := context.Background() From cb54b185f222f13c1e301a4a07e674954e69a353 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:37 -0400 Subject: [PATCH 006/281] create: linter changes --- internal/create/errors.go | 4 ++-- internal/create/naming_test.go | 6 ------ 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/internal/create/errors.go b/internal/create/errors.go index d739ba9154c7..fe43256d4ff0 100644 --- a/internal/create/errors.go +++ b/internal/create/errors.go @@ -90,7 +90,7 @@ func diagError(service, action, resource, id string, gotError error) diag.Diagno func AppendDiagErrorMessage(diags diag.Diagnostics, service, action, resource, id, message string) diag.Diagnostics { return append(diags, - diagError(service, action, resource, id, fmt.Errorf(message)), + diagError(service, action, resource, id, errors.New(message)), ) } @@ -104,7 +104,7 @@ func AppendDiagWarningMessage(diags diag.Diagnostics, service, action, resource, return append(diags, diag.Diagnostic{ Severity: diag.Warning, - Summary: ProblemStandardMessage(service, action, resource, id, fmt.Errorf(message)), + Summary: ProblemStandardMessage(service, action, resource, id, errors.New(message)), }, ) } diff --git a/internal/create/naming_test.go b/internal/create/naming_test.go index d671b5020cf8..497b6901d552 100644 --- a/internal/create/naming_test.go +++ b/internal/create/naming_test.go @@ -52,7 +52,6 @@ func TestName(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.testName, func(t *testing.T) { t.Parallel() @@ -122,7 +121,6 @@ func TestNameWithSuffix(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.testName, func(t *testing.T) { t.Parallel() @@ -167,7 +165,6 @@ func TestNameWithDefaultPrefix(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.testName, func(t *testing.T) { t.Parallel() @@ -221,7 +218,6 @@ func TestHasResourceUniqueIDPlusAdditionalSuffix(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() @@ -281,7 +277,6 @@ func TestNamePrefixFromName(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() @@ -383,7 +378,6 @@ func TestNamePrefixFromNameWithSuffix(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() From 904aba5e121f56f54344fc93fec65562d921a6b8 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:37 -0400 Subject: [PATCH 007/281] fwdiag: linter changes --- internal/errs/fwdiag/diags_test.go | 1 - 1 file changed, 1 deletion(-) diff --git a/internal/errs/fwdiag/diags_test.go b/internal/errs/fwdiag/diags_test.go index cf823b704df7..7be4bcc5c0b1 100644 --- a/internal/errs/fwdiag/diags_test.go +++ b/internal/errs/fwdiag/diags_test.go @@ -56,7 +56,6 @@ func TestDiagnosticsError(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.testName, func(t *testing.T) { t.Parallel() From 2c2e9bca4e6d43fcec023cd6c9debe2f414cada7 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:37 -0400 Subject: [PATCH 008/281] sdkdiag: linter changes --- internal/errs/sdkdiag/diags_test.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/internal/errs/sdkdiag/diags_test.go b/internal/errs/sdkdiag/diags_test.go index 6c60474ca131..7a00e949f3bd 100644 --- a/internal/errs/sdkdiag/diags_test.go +++ b/internal/errs/sdkdiag/diags_test.go @@ -56,7 +56,6 @@ func TestErrors(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.testName, func(t *testing.T) { t.Parallel() @@ -115,7 +114,6 @@ func TestWarnings(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.testName, func(t *testing.T) { t.Parallel() @@ -174,7 +172,6 @@ func TestDiagnosticsError(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.testName, func(t *testing.T) { t.Parallel() From 915ecf537a7a5c56380fd11aaf7ab6603e8d2c75 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:37 -0400 Subject: [PATCH 009/281] flex: linter changes --- internal/framework/flex/auto_expand_test.go | 5 ----- internal/framework/flex/auto_flatten_test.go | 10 ---------- internal/framework/flex/bool_test.go | 4 ---- internal/framework/flex/float_test.go | 4 ---- internal/framework/flex/int_test.go | 7 ------- internal/framework/flex/list_test.go | 14 -------------- internal/framework/flex/map_test.go | 5 ----- internal/framework/flex/set_test.go | 14 -------------- internal/framework/flex/string_test.go | 8 -------- internal/framework/flex/time_test.go | 2 -- 10 files changed, 73 deletions(-) diff --git a/internal/framework/flex/auto_expand_test.go b/internal/framework/flex/auto_expand_test.go index 64b5efcd6c44..150e197269b9 100644 --- a/internal/framework/flex/auto_expand_test.go +++ b/internal/framework/flex/auto_expand_test.go @@ -1061,7 +1061,6 @@ func TestExpandFloat64(t *testing.T) { } for testName, cases := range testCases { - cases := cases t.Run(testName, func(t *testing.T) { t.Parallel() @@ -1217,7 +1216,6 @@ func TestExpandFloat32(t *testing.T) { } for testName, cases := range testCases { - cases := cases t.Run(testName, func(t *testing.T) { t.Parallel() @@ -1369,7 +1367,6 @@ func TestExpandInt64(t *testing.T) { } for testName, cases := range testCases { - cases := cases t.Run(testName, func(t *testing.T) { t.Parallel() @@ -1521,7 +1518,6 @@ func TestExpandInt32(t *testing.T) { } for testName, cases := range testCases { - cases := cases t.Run(testName, func(t *testing.T) { t.Parallel() @@ -4282,7 +4278,6 @@ func runAutoExpandTestCases(t *testing.T, testCases autoFlexTestCases) { t.Helper() for testName, testCase := range testCases { - testCase := testCase t.Run(testName, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/flex/auto_flatten_test.go b/internal/framework/flex/auto_flatten_test.go index 31249d0404e9..98467a6618f2 100644 --- a/internal/framework/flex/auto_flatten_test.go +++ b/internal/framework/flex/auto_flatten_test.go @@ -1372,7 +1372,6 @@ func TestFlattenFloat64(t *testing.T) { } for testName, cases := range testCases { - cases := cases t.Run(testName, func(t *testing.T) { t.Parallel() @@ -1555,7 +1554,6 @@ func TestFlattenFloat32(t *testing.T) { } for testName, cases := range testCases { - cases := cases t.Run(testName, func(t *testing.T) { t.Parallel() @@ -1733,7 +1731,6 @@ func TestFlattenInt64(t *testing.T) { } for testName, cases := range testCases { - cases := cases t.Run(testName, func(t *testing.T) { t.Parallel() @@ -1916,7 +1913,6 @@ func TestFlattenInt32(t *testing.T) { } for testName, cases := range testCases { - cases := cases t.Run(testName, func(t *testing.T) { t.Parallel() @@ -1966,8 +1962,6 @@ func TestFlattenTopLevelStringPtr(t *testing.T) { } for testName, testCase := range testCases { - testCase := testCase - t.Run(testName, func(t *testing.T) { t.Parallel() @@ -2044,8 +2038,6 @@ func TestFlattenTopLevelInt64Ptr(t *testing.T) { } for testName, testCase := range testCases { - testCase := testCase - t.Run(testName, func(t *testing.T) { t.Parallel() @@ -3781,7 +3773,6 @@ func runAutoFlattenTestCases(t *testing.T, testCases autoFlexTestCases) { t.Helper() for testName, testCase := range testCases { - testCase := testCase t.Run(testName, func(t *testing.T) { t.Parallel() @@ -3849,7 +3840,6 @@ func TestFlattenPrePopulate(t *testing.T) { } for name, testCase := range testCases { - testCase := testCase t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/flex/bool_test.go b/internal/framework/flex/bool_test.go index a2dd5a2d1c06..b889bbd5f26e 100644 --- a/internal/framework/flex/bool_test.go +++ b/internal/framework/flex/bool_test.go @@ -36,7 +36,6 @@ func TestBoolFromFramework(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -72,7 +71,6 @@ func TestBoolValueFromFramework(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -104,7 +102,6 @@ func TestBoolToFramework(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -136,7 +133,6 @@ func TestBoolToFrameworkLegacy(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/flex/float_test.go b/internal/framework/flex/float_test.go index 167f33dd0e4c..4d98dd1a6f35 100644 --- a/internal/framework/flex/float_test.go +++ b/internal/framework/flex/float_test.go @@ -36,7 +36,6 @@ func TestFloat64ToFramework(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -72,7 +71,6 @@ func TestFloat64ToFrameworkLegacy(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -108,7 +106,6 @@ func TestFloat32ToFramework(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -144,7 +141,6 @@ func TestFloat32ToFrameworkLegacy(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/flex/int_test.go b/internal/framework/flex/int_test.go index 6d19a021d9a6..389fff063a69 100644 --- a/internal/framework/flex/int_test.go +++ b/internal/framework/flex/int_test.go @@ -40,7 +40,6 @@ func TestInt64FromFramework(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -76,7 +75,6 @@ func TestInt64ToFramework(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -112,7 +110,6 @@ func TestInt64ToFrameworkLegacy(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -148,7 +145,6 @@ func TestInt32ToFramework(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -184,7 +180,6 @@ func TestInt32ToFrameworkLegacy(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -224,7 +219,6 @@ func TestInt32FromFramework(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -264,7 +258,6 @@ func TestInt32FromFrameworkLegacy(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/flex/list_test.go b/internal/framework/flex/list_test.go index 5239e07269fb..f52e0cd470b6 100644 --- a/internal/framework/flex/list_test.go +++ b/internal/framework/flex/list_test.go @@ -50,7 +50,6 @@ func TestExpandFrameworkInt32List(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -99,7 +98,6 @@ func TestExpandFrameworkInt32ValueList(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -148,7 +146,6 @@ func TestExpandFrameworkInt64List(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -197,7 +194,6 @@ func TestExpandFrameworkInt64ValueList(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -246,7 +242,6 @@ func TestExpandFrameworkStringList(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -295,7 +290,6 @@ func TestExpandFrameworkStringValueList(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -334,7 +328,6 @@ func TestFlattenFrameworkInt32List(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -373,7 +366,6 @@ func TestFlattenFrameworkInt32ValueList(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -412,7 +404,6 @@ func TestFlattenFrameworkInt64List(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -451,7 +442,6 @@ func TestFlattenFrameworkInt64ValueList(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -490,7 +480,6 @@ func TestFlattenFrameworkStringList(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -529,7 +518,6 @@ func TestFlattenFrameworkStringListLegacy(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -571,7 +559,6 @@ func TestFlattenFrameworkStringValueList(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -613,7 +600,6 @@ func TestFlattenFrameworkStringValueListLegacy(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/flex/map_test.go b/internal/framework/flex/map_test.go index bd5c9fc3461b..b320c1d8704a 100644 --- a/internal/framework/flex/map_test.go +++ b/internal/framework/flex/map_test.go @@ -63,7 +63,6 @@ func TestExpandFrameworkStringMap(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -115,7 +114,6 @@ func TestExpandFrameworkStringValueMap(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -157,7 +155,6 @@ func TestFlattenFrameworkStringMap(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -199,7 +196,6 @@ func TestFlattenFrameworkStringValueMap(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -241,7 +237,6 @@ func TestFlattenFrameworkStringValueMapLegacy(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/flex/set_test.go b/internal/framework/flex/set_test.go index 453ffc9060f6..29223622236c 100644 --- a/internal/framework/flex/set_test.go +++ b/internal/framework/flex/set_test.go @@ -51,7 +51,6 @@ func TestExpandFrameworkInt32Set(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -100,7 +99,6 @@ func TestExpandFrameworkInt32ValueSet(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -149,7 +147,6 @@ func TestExpandFrameworkInt64Set(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -198,7 +195,6 @@ func TestExpandFrameworkInt64ValueSet(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -247,7 +243,6 @@ func TestExpandFrameworkStringSet(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -296,7 +291,6 @@ func TestExpandFrameworkStringValueSet(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -349,7 +343,6 @@ func TestExpandFrameworkStringyValueSet(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -388,7 +381,6 @@ func TestFlattenFrameworkInt32Set(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -427,7 +419,6 @@ func TestFlattenFrameworkInt32ValueSet(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -466,7 +457,6 @@ func TestFlattenFrameworkInt64Set(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -505,7 +495,6 @@ func TestFlattenFrameworkInt64ValueSet(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -544,7 +533,6 @@ func TestFlattenFrameworkStringSet(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -586,7 +574,6 @@ func TestFlattenFrameworkStringValueSet(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -628,7 +615,6 @@ func TestFlattenFrameworkStringValueSetLegacy(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/flex/string_test.go b/internal/framework/flex/string_test.go index 2176437cf86e..8a78f13e6b08 100644 --- a/internal/framework/flex/string_test.go +++ b/internal/framework/flex/string_test.go @@ -41,7 +41,6 @@ func TestStringFromFramework(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -77,7 +76,6 @@ func TestStringToFramework(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -113,7 +111,6 @@ func TestStringToFrameworkLegacy(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -151,7 +148,6 @@ func TestStringValueToFramework(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -186,7 +182,6 @@ func TestStringValueToFrameworkLegacy(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -222,7 +217,6 @@ func TestARNStringFromFramework(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -254,7 +248,6 @@ func TestStringToFrameworkARN(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -294,7 +287,6 @@ func TestEmptyStringAsNull(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/flex/time_test.go b/internal/framework/flex/time_test.go index a2722483642d..fa60f4f1d218 100644 --- a/internal/framework/flex/time_test.go +++ b/internal/framework/flex/time_test.go @@ -38,7 +38,6 @@ func TestTimeFromFramework(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -71,7 +70,6 @@ func TestTimeToFramework(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() From f3f5c5c583f95e1c73382becd96db236295ec7f0 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:37 -0400 Subject: [PATCH 010/281] types: linter changes --- internal/framework/types/arn_test.go | 3 --- internal/framework/types/cidr_block_test.go | 3 --- internal/framework/types/duration_test.go | 3 --- internal/framework/types/iam_policy_test.go | 2 -- internal/framework/types/list_nested_objectof_test.go | 3 --- internal/framework/types/listof_test.go | 1 - internal/framework/types/multiset_test.go | 1 - internal/framework/types/objectof_test.go | 3 --- internal/framework/types/once_a_week_window_test.go | 2 -- internal/framework/types/regexp_test.go | 3 --- internal/framework/types/set_nested_objectof_test.go | 3 --- internal/framework/types/setof_test.go | 1 - internal/framework/types/smithy_json_test.go | 3 --- internal/framework/types/string_enum_test.go | 2 -- 14 files changed, 33 deletions(-) diff --git a/internal/framework/types/arn_test.go b/internal/framework/types/arn_test.go index 148981e46f40..08283aa29996 100644 --- a/internal/framework/types/arn_test.go +++ b/internal/framework/types/arn_test.go @@ -41,7 +41,6 @@ func TestARNTypeValueFromTerraform(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -83,7 +82,6 @@ func TestARNValidateAttribute(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -122,7 +120,6 @@ func TestARNToStringValue(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/types/cidr_block_test.go b/internal/framework/types/cidr_block_test.go index a0b44610f7db..508152763a3b 100644 --- a/internal/framework/types/cidr_block_test.go +++ b/internal/framework/types/cidr_block_test.go @@ -41,7 +41,6 @@ func TestCIDRBlockTypeValueFromTerraform(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -90,7 +89,6 @@ func TestCIDRBlockValidateAttrbute(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -129,7 +127,6 @@ func TestCIDRBlockToStringValue(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/types/duration_test.go b/internal/framework/types/duration_test.go index 7fa3d636f254..9beef1ad640c 100644 --- a/internal/framework/types/duration_test.go +++ b/internal/framework/types/duration_test.go @@ -41,7 +41,6 @@ func TestDurationTypeValueFromTerraform(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -83,7 +82,6 @@ func TestDurationValidateAttribute(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -122,7 +120,6 @@ func TestDurationToStringValue(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/types/iam_policy_test.go b/internal/framework/types/iam_policy_test.go index 66c38a1ffc36..214ce0ef3389 100644 --- a/internal/framework/types/iam_policy_test.go +++ b/internal/framework/types/iam_policy_test.go @@ -35,7 +35,6 @@ func TestIAMPolicyValidateAttribute(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -148,7 +147,6 @@ func TestIAMPolicyStringSemanticEquals(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/types/list_nested_objectof_test.go b/internal/framework/types/list_nested_objectof_test.go index ef9ea4cbd35c..9c024f896cfe 100644 --- a/internal/framework/types/list_nested_objectof_test.go +++ b/internal/framework/types/list_nested_objectof_test.go @@ -35,7 +35,6 @@ func TestListNestedObjectTypeOfEqual(t *testing.T) { } for name, testCase := range testCases { - name, testCase := name, testCase t.Run(name, func(t *testing.T) { t.Parallel() @@ -100,7 +99,6 @@ func TestListNestedObjectTypeOfValueFromTerraform(t *testing.T) { } for name, testCase := range testCases { - name, testCase := name, testCase t.Run(name, func(t *testing.T) { t.Parallel() @@ -162,7 +160,6 @@ func TestListNestedObjectValueOfEqual(t *testing.T) { } for name, testCase := range testCases { - name, testCase := name, testCase t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/types/listof_test.go b/internal/framework/types/listof_test.go index fe6856be7dda..0a352c7a9ad1 100644 --- a/internal/framework/types/listof_test.go +++ b/internal/framework/types/listof_test.go @@ -39,7 +39,6 @@ func TestListOfStringFromTerraform(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/types/multiset_test.go b/internal/framework/types/multiset_test.go index 24b2c2ad2472..f3ca45c24a52 100644 --- a/internal/framework/types/multiset_test.go +++ b/internal/framework/types/multiset_test.go @@ -124,7 +124,6 @@ func TestMultisetListSemanticEquals(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/types/objectof_test.go b/internal/framework/types/objectof_test.go index a816117463bf..4bd24671c733 100644 --- a/internal/framework/types/objectof_test.go +++ b/internal/framework/types/objectof_test.go @@ -43,7 +43,6 @@ func TestObjectTypeOfEqual(t *testing.T) { } for name, testCase := range testCases { - name, testCase := name, testCase t.Run(name, func(t *testing.T) { t.Parallel() @@ -105,7 +104,6 @@ func TestObjectTypeOfValueFromTerraform(t *testing.T) { } for name, testCase := range testCases { - name, testCase := name, testCase t.Run(name, func(t *testing.T) { t.Parallel() @@ -167,7 +165,6 @@ func TestObjectValueOfEqual(t *testing.T) { } for name, testCase := range testCases { - name, testCase := name, testCase t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/types/once_a_week_window_test.go b/internal/framework/types/once_a_week_window_test.go index 4ca270fd55ac..fed8fa731d51 100644 --- a/internal/framework/types/once_a_week_window_test.go +++ b/internal/framework/types/once_a_week_window_test.go @@ -38,7 +38,6 @@ func TestOnceAWeekWindowValidateAttribute(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -91,7 +90,6 @@ func TestOnceAWeekWindowStringSemanticEquals(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/types/regexp_test.go b/internal/framework/types/regexp_test.go index 51e62b25960e..ede5273649a2 100644 --- a/internal/framework/types/regexp_test.go +++ b/internal/framework/types/regexp_test.go @@ -39,7 +39,6 @@ func TestRegexpTypeValueFromTerraform(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -81,7 +80,6 @@ func TestRegexpValidateAttribute(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -120,7 +118,6 @@ func TestRegexpToStringValue(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/types/set_nested_objectof_test.go b/internal/framework/types/set_nested_objectof_test.go index b6f6b9d40a70..6e16e791a497 100644 --- a/internal/framework/types/set_nested_objectof_test.go +++ b/internal/framework/types/set_nested_objectof_test.go @@ -35,7 +35,6 @@ func TestSetNestedObjectTypeOfEqual(t *testing.T) { } for name, testCase := range testCases { - name, testCase := name, testCase t.Run(name, func(t *testing.T) { t.Parallel() @@ -100,7 +99,6 @@ func TestSetNestedObjectTypeOfValueFromTerraform(t *testing.T) { } for name, testCase := range testCases { - name, testCase := name, testCase t.Run(name, func(t *testing.T) { t.Parallel() @@ -162,7 +160,6 @@ func TestSetNestedObjectValueOfEqual(t *testing.T) { } for name, testCase := range testCases { - name, testCase := name, testCase t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/types/setof_test.go b/internal/framework/types/setof_test.go index 017a587170f5..01ce677c4bce 100644 --- a/internal/framework/types/setof_test.go +++ b/internal/framework/types/setof_test.go @@ -39,7 +39,6 @@ func TestSetOfStringFromTerraform(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/types/smithy_json_test.go b/internal/framework/types/smithy_json_test.go index 17b5058c864f..41008e8a2a3c 100644 --- a/internal/framework/types/smithy_json_test.go +++ b/internal/framework/types/smithy_json_test.go @@ -42,7 +42,6 @@ func TestSmithyJSONTypeValueFromTerraform(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -83,7 +82,6 @@ func TestSmithyJSONValidateAttribute(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -155,7 +153,6 @@ func TestSmithyJSONValueInterface(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/types/string_enum_test.go b/internal/framework/types/string_enum_test.go index 88dd2fcba020..fa263924d46f 100644 --- a/internal/framework/types/string_enum_test.go +++ b/internal/framework/types/string_enum_test.go @@ -37,7 +37,6 @@ func TestStringEnumTypeValueFromTerraform(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -81,7 +80,6 @@ func TestStringEnumValidateAttribute(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() From 779d3f83dd8940c71b3240f6241ca29411e61137 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:37 -0400 Subject: [PATCH 011/281] validators: linter changes --- internal/framework/validators/aws_account_id_test.go | 1 - internal/framework/validators/cidr_test.go | 2 -- internal/framework/validators/ip_test.go | 2 -- internal/framework/validators/json_test.go | 1 - internal/framework/validators/s3_uri_test.go | 1 - 5 files changed, 7 deletions(-) diff --git a/internal/framework/validators/aws_account_id_test.go b/internal/framework/validators/aws_account_id_test.go index d4f344ef1b63..72674209ed8b 100644 --- a/internal/framework/validators/aws_account_id_test.go +++ b/internal/framework/validators/aws_account_id_test.go @@ -65,7 +65,6 @@ func TestAWSAccountIDValidator(t *testing.T) { // nosemgrep:ci.aws-in-func-name } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/validators/cidr_test.go b/internal/framework/validators/cidr_test.go index c04c5c34f5d5..68611f6107fc 100644 --- a/internal/framework/validators/cidr_test.go +++ b/internal/framework/validators/cidr_test.go @@ -65,7 +65,6 @@ func TestIPv4CIDRNetworkAddressValidator(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -136,7 +135,6 @@ func TestIPv6CIDRNetworkAddressValidator(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/validators/ip_test.go b/internal/framework/validators/ip_test.go index a724ef7be233..e0441df27243 100644 --- a/internal/framework/validators/ip_test.go +++ b/internal/framework/validators/ip_test.go @@ -65,7 +65,6 @@ func TestIPv4AddressValidator(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -136,7 +135,6 @@ func TestIPv6AddressValidator(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/validators/json_test.go b/internal/framework/validators/json_test.go index 494e5f1de9c5..176778f5da2e 100644 --- a/internal/framework/validators/json_test.go +++ b/internal/framework/validators/json_test.go @@ -45,7 +45,6 @@ func TestJSONValidator(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/framework/validators/s3_uri_test.go b/internal/framework/validators/s3_uri_test.go index b8b9212224ba..b78a5c47b474 100644 --- a/internal/framework/validators/s3_uri_test.go +++ b/internal/framework/validators/s3_uri_test.go @@ -55,7 +55,6 @@ func TestS3URIValidator(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() From 6c06b68a13406156bb58f9b8cc9fc2260e4bd4b4 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:37 -0400 Subject: [PATCH 012/281] serviceendpointtests: linter changes --- internal/generate/serviceendpointtests/file.gtpl | 6 ------ 1 file changed, 6 deletions(-) diff --git a/internal/generate/serviceendpointtests/file.gtpl b/internal/generate/serviceendpointtests/file.gtpl index ac57f2580a99..388979a3da41 100644 --- a/internal/generate/serviceendpointtests/file.gtpl +++ b/internal/generate/serviceendpointtests/file.gtpl @@ -488,8 +488,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S {{ if and (ne .GoV1Package "") (ne .GoV2Package "") }} t.Run("v1", func(t *testing.T) { for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callServiceV1) }) @@ -498,8 +496,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S t.Run("v2", func(t *testing.T) { for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callServiceV2) }) @@ -507,8 +503,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S }) {{ else }} for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 4002cc831df2b763baf169bd68e9fed9a2b0fad0 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:37 -0400 Subject: [PATCH 013/281] json: linter changes --- internal/json/decode_test.go | 1 - internal/json/encode_test.go | 1 - internal/json/equal_test.go | 1 - internal/json/remove_test.go | 2 -- "internal/json/ujson/\302\265json_test.go" | 2 -- 5 files changed, 7 deletions(-) diff --git a/internal/json/decode_test.go b/internal/json/decode_test.go index 6e03986dbd1a..9c36f6980a86 100644 --- a/internal/json/decode_test.go +++ b/internal/json/decode_test.go @@ -59,7 +59,6 @@ func TestDecodeFromString(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.testName, func(t *testing.T) { t.Parallel() diff --git a/internal/json/encode_test.go b/internal/json/encode_test.go index 118a86d65613..dd686561029b 100644 --- a/internal/json/encode_test.go +++ b/internal/json/encode_test.go @@ -51,7 +51,6 @@ func TestEncodeToString(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.testName, func(t *testing.T) { t.Parallel() diff --git a/internal/json/equal_test.go b/internal/json/equal_test.go index 951084749876..1e80913d7138 100644 --- a/internal/json/equal_test.go +++ b/internal/json/equal_test.go @@ -61,7 +61,6 @@ func TestEqualStrings(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.testName, func(t *testing.T) { t.Parallel() diff --git a/internal/json/remove_test.go b/internal/json/remove_test.go index 6ce2788d029d..33d313d5d6a8 100644 --- a/internal/json/remove_test.go +++ b/internal/json/remove_test.go @@ -35,7 +35,6 @@ func TestRemoveFields(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.testName, func(t *testing.T) { t.Parallel() @@ -117,7 +116,6 @@ func TestRemoveEmptyFields(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.testName, func(t *testing.T) { t.Parallel() diff --git "a/internal/json/ujson/\302\265json_test.go" "b/internal/json/ujson/\302\265json_test.go" index 8f84077c0d50..f189ea86f21d 100644 --- "a/internal/json/ujson/\302\265json_test.go" +++ "b/internal/json/ujson/\302\265json_test.go" @@ -316,7 +316,6 @@ func TestWalk(t *testing.T) { } for _, tt := range tests { - tt := tt t.Run("Walk/"+tt.input, func(t *testing.T) { t.Parallel() @@ -335,7 +334,6 @@ func TestWalk(t *testing.T) { } for _, tt := range tests { - tt := tt t.Run("Reconstruct/"+tt.input, func(t *testing.T) { t.Parallel() From 6a2bb38ffa877b06a3c6cd96d11ea92f09e42e07 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:37 -0400 Subject: [PATCH 014/281] maps: linter changes --- internal/maps/maps_test.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/internal/maps/maps_test.go b/internal/maps/maps_test.go index 044ce5000181..1ce3a696b763 100644 --- a/internal/maps/maps_test.go +++ b/internal/maps/maps_test.go @@ -36,7 +36,6 @@ func TestApplyToAllKeys(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -80,7 +79,6 @@ func TestApplyToAllValues(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -115,7 +113,6 @@ func TestKeys(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -150,7 +147,6 @@ func TestValues(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() From b00692d25f2c085b41a4b7829a505b6afef5afc9 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:38 -0400 Subject: [PATCH 015/281] namevaluesfilters: linter changes --- internal/namevaluesfilters/name_values_filters_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/namevaluesfilters/name_values_filters_test.go b/internal/namevaluesfilters/name_values_filters_test.go index e4de0f0bf2eb..a3d6b438ed3a 100644 --- a/internal/namevaluesfilters/name_values_filters_test.go +++ b/internal/namevaluesfilters/name_values_filters_test.go @@ -47,7 +47,6 @@ func TestNameValuesFiltersMap(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -146,7 +145,6 @@ func TestNameValuesFiltersAdd(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() From d4d23dec8bdf41ed3185f1656ad362ad0a618feb Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:38 -0400 Subject: [PATCH 016/281] provider: linter changes --- internal/provider/fwprovider/provider.go | 2 -- internal/provider/provider.go | 2 -- internal/provider/provider_config_test.go | 2 -- 3 files changed, 6 deletions(-) diff --git a/internal/provider/fwprovider/provider.go b/internal/provider/fwprovider/provider.go index 5435b5031738..702305fc5642 100644 --- a/internal/provider/fwprovider/provider.go +++ b/internal/provider/fwprovider/provider.go @@ -319,7 +319,6 @@ func (p *fwprovider) DataSources(ctx context.Context) []func() datasource.DataSo servicePackageName := sp.ServicePackageName() for _, v := range sp.FrameworkDataSources(ctx) { - v := v inner, err := v.Factory(ctx) if err != nil { @@ -394,7 +393,6 @@ func (p *fwprovider) Resources(ctx context.Context) []func() resource.Resource { servicePackageName := sp.ServicePackageName() for _, v := range sp.FrameworkResources(ctx) { - v := v inner, err := v.Factory(ctx) if err != nil { diff --git a/internal/provider/provider.go b/internal/provider/provider.go index cc2fcc4ed23c..7f0b2027f77b 100644 --- a/internal/provider/provider.go +++ b/internal/provider/provider.go @@ -273,7 +273,6 @@ func New(ctx context.Context) (*schema.Provider, error) { servicePackageMap[servicePackageName] = sp for _, v := range sp.SDKDataSources(ctx) { - v := v typeName := v.TypeName if _, ok := provider.DataSourcesMap[typeName]; ok { @@ -338,7 +337,6 @@ func New(ctx context.Context) (*schema.Provider, error) { } for _, v := range sp.SDKResources(ctx) { - v := v typeName := v.TypeName if _, ok := provider.ResourcesMap[typeName]; ok { diff --git a/internal/provider/provider_config_test.go b/internal/provider/provider_config_test.go index 2b9aafcf4734..be2403029218 100644 --- a/internal/provider/provider_config_test.go +++ b/internal/provider/provider_config_test.go @@ -132,8 +132,6 @@ sso_start_url = https://d-123456789a.awsapps.com/start# } for name, tc := range testcases { //nolint:paralleltest - tc := tc - t.Run(name, func(t *testing.T) { ctx := context.TODO() From 27d4f0c1e82722ae7f07b7be0ed444963c6e6bc9 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:38 -0400 Subject: [PATCH 017/281] types: linter changes --- internal/sdkv2/types/testing_test.go | 1 - 1 file changed, 1 deletion(-) diff --git a/internal/sdkv2/types/testing_test.go b/internal/sdkv2/types/testing_test.go index 29dab4666252..f6790d4c7ad5 100644 --- a/internal/sdkv2/types/testing_test.go +++ b/internal/sdkv2/types/testing_test.go @@ -23,7 +23,6 @@ func runTestCases(t *testing.T, cases map[string]testCase) { t.Helper() for name, tc := range cases { - tc := tc t.Run(name, func(t *testing.T) { t.Parallel() From 21ec26a41cda27994915c48d392c47f5872df4fc Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:38 -0400 Subject: [PATCH 018/281] accessanalyzer: linter changes --- internal/service/accessanalyzer/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/accessanalyzer/service_endpoints_gen_test.go b/internal/service/accessanalyzer/service_endpoints_gen_test.go index 8a28013d6438..23816ec8b962 100644 --- a/internal/service/accessanalyzer/service_endpoints_gen_test.go +++ b/internal/service/accessanalyzer/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 3ade291af2774d11b0d953a6b409f723fdc46065 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:38 -0400 Subject: [PATCH 019/281] account: linter changes --- internal/service/account/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/account/service_endpoints_gen_test.go b/internal/service/account/service_endpoints_gen_test.go index ff2d5701f60b..4a5ab66d531f 100644 --- a/internal/service/account/service_endpoints_gen_test.go +++ b/internal/service/account/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 8fb24ab746bc3e25842cfc7f06770c4dd3922542 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:38 -0400 Subject: [PATCH 020/281] acm: linter changes --- internal/service/acm/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/acm/service_endpoints_gen_test.go b/internal/service/acm/service_endpoints_gen_test.go index ec8b64d61071..f269155c1a37 100644 --- a/internal/service/acm/service_endpoints_gen_test.go +++ b/internal/service/acm/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From a061f4936606f8068fe17d0854cdbef3153c19fc Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:38 -0400 Subject: [PATCH 021/281] acmpca: linter changes --- internal/service/acmpca/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/acmpca/service_endpoints_gen_test.go b/internal/service/acmpca/service_endpoints_gen_test.go index e544ebd74eb5..c954f203d457 100644 --- a/internal/service/acmpca/service_endpoints_gen_test.go +++ b/internal/service/acmpca/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 53587eb655caf32d0fab30aec760ebc255713385 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:38 -0400 Subject: [PATCH 022/281] amp: linter changes --- internal/service/amp/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/amp/service_endpoints_gen_test.go b/internal/service/amp/service_endpoints_gen_test.go index 0301d8d856cb..9e287f49e730 100644 --- a/internal/service/amp/service_endpoints_gen_test.go +++ b/internal/service/amp/service_endpoints_gen_test.go @@ -348,8 +348,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 8ce17183bfd539db0a54812855c038d858d5b30a Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:38 -0400 Subject: [PATCH 023/281] amplify: linter changes --- internal/service/amplify/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/amplify/service_endpoints_gen_test.go b/internal/service/amplify/service_endpoints_gen_test.go index 2ca6f8c9f155..d18c6d68363e 100644 --- a/internal/service/amplify/service_endpoints_gen_test.go +++ b/internal/service/amplify/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From d3a0553d7e90d308a4728ab319d333827752fe7a Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:38 -0400 Subject: [PATCH 024/281] apigateway: linter changes --- internal/service/apigateway/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/apigateway/service_endpoints_gen_test.go b/internal/service/apigateway/service_endpoints_gen_test.go index b0dcb43c2add..81aea62d05a0 100644 --- a/internal/service/apigateway/service_endpoints_gen_test.go +++ b/internal/service/apigateway/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From dddcb0bc4f98c6e3145f6491ed1b46608a86c7ae Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:38 -0400 Subject: [PATCH 025/281] apigatewayv2: linter changes --- internal/service/apigatewayv2/api_mapping_test.go | 1 - internal/service/apigatewayv2/service_endpoints_gen_test.go | 2 -- 2 files changed, 3 deletions(-) diff --git a/internal/service/apigatewayv2/api_mapping_test.go b/internal/service/apigatewayv2/api_mapping_test.go index a473bf7ee6b8..fbfdcf6c58af 100644 --- a/internal/service/apigatewayv2/api_mapping_test.go +++ b/internal/service/apigatewayv2/api_mapping_test.go @@ -45,7 +45,6 @@ func TestAccAPIGatewayV2APIMapping_serial(t *testing.T) { "ApiMappingKey": testAccAPIMapping_key, } for name, tc := range testCases { //nolint:paralleltest - tc := tc t.Run(name, func(t *testing.T) { tc(t, rName, &certificateARN) }) diff --git a/internal/service/apigatewayv2/service_endpoints_gen_test.go b/internal/service/apigatewayv2/service_endpoints_gen_test.go index 1b29d667399e..4367e1b7898d 100644 --- a/internal/service/apigatewayv2/service_endpoints_gen_test.go +++ b/internal/service/apigatewayv2/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From f0a13a419911702f5988b9f90578bd4bf71284ce Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:38 -0400 Subject: [PATCH 026/281] appautoscaling: linter changes --- internal/service/appautoscaling/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/appautoscaling/service_endpoints_gen_test.go b/internal/service/appautoscaling/service_endpoints_gen_test.go index 989b8233bb14..414364f4412f 100644 --- a/internal/service/appautoscaling/service_endpoints_gen_test.go +++ b/internal/service/appautoscaling/service_endpoints_gen_test.go @@ -290,8 +290,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 365e0b72c6bbb22219ab83181748e34f5a95c0d6 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:38 -0400 Subject: [PATCH 027/281] appconfig: linter changes --- internal/service/appconfig/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/appconfig/service_endpoints_gen_test.go b/internal/service/appconfig/service_endpoints_gen_test.go index b0b61c369383..0a8c8d9b9039 100644 --- a/internal/service/appconfig/service_endpoints_gen_test.go +++ b/internal/service/appconfig/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 52ae403dfae7e2ea513ea1689eb7e1b2bd1da075 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:39 -0400 Subject: [PATCH 028/281] appfabric: linter changes --- internal/service/appfabric/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/appfabric/service_endpoints_gen_test.go b/internal/service/appfabric/service_endpoints_gen_test.go index e58b3ca4fd2c..5fe9886d30fa 100644 --- a/internal/service/appfabric/service_endpoints_gen_test.go +++ b/internal/service/appfabric/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 8c5bd05575ee7c1825a721869c3ce96c65b43efc Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:39 -0400 Subject: [PATCH 029/281] appflow: linter changes --- internal/service/appflow/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/appflow/service_endpoints_gen_test.go b/internal/service/appflow/service_endpoints_gen_test.go index 66f3767e7c3d..90e80ddec193 100644 --- a/internal/service/appflow/service_endpoints_gen_test.go +++ b/internal/service/appflow/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From d5e2076b22ca124eb07903a22e2a884c19fadaa4 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:39 -0400 Subject: [PATCH 030/281] appintegrations: linter changes --- internal/service/appintegrations/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/appintegrations/service_endpoints_gen_test.go b/internal/service/appintegrations/service_endpoints_gen_test.go index 8d773dd904c5..cedf10575266 100644 --- a/internal/service/appintegrations/service_endpoints_gen_test.go +++ b/internal/service/appintegrations/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From cd850aac4b6a3707cb272eb7906cf7cca1227fee Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:39 -0400 Subject: [PATCH 031/281] applicationinsights: linter changes --- .../service/applicationinsights/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/applicationinsights/service_endpoints_gen_test.go b/internal/service/applicationinsights/service_endpoints_gen_test.go index 87f7c34ab147..42fccf661cd1 100644 --- a/internal/service/applicationinsights/service_endpoints_gen_test.go +++ b/internal/service/applicationinsights/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From c716a874d3815a0a6077c46710b843d56002b369 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:39 -0400 Subject: [PATCH 032/281] applicationsignals: linter changes --- .../service/applicationsignals/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/applicationsignals/service_endpoints_gen_test.go b/internal/service/applicationsignals/service_endpoints_gen_test.go index 2b41cb46dbc5..6e5b5c6e3900 100644 --- a/internal/service/applicationsignals/service_endpoints_gen_test.go +++ b/internal/service/applicationsignals/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 30176f0886a6a88d833ebf9cc715cea820842764 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:39 -0400 Subject: [PATCH 033/281] appmesh: linter changes --- internal/service/appmesh/flex.go | 4 ++-- internal/service/appmesh/service_endpoints_gen_test.go | 2 -- internal/service/appmesh/virtual_gateway.go | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/internal/service/appmesh/flex.go b/internal/service/appmesh/flex.go index 1fd84e65fb1a..a8f9229a1a5b 100644 --- a/internal/service/appmesh/flex.go +++ b/internal/service/appmesh/flex.go @@ -1706,7 +1706,7 @@ func flattenVirtualNodeSpec(spec *awstypes.VirtualNodeSpec) []interface{} { mSpec["backend_defaults"] = []interface{}{mBackendDefaults} } - if spec.Listeners != nil && len(spec.Listeners) > 0 { + if len(spec.Listeners) > 0 { var mListeners []interface{} // Per schema definition, set at most 1 Listener for _, listener := range spec.Listeners { @@ -1955,7 +1955,7 @@ func flattenVirtualRouterSpec(spec *awstypes.VirtualRouterSpec) []interface{} { return []interface{}{} } mSpec := make(map[string]interface{}) - if spec.Listeners != nil && len(spec.Listeners) > 0 { + if len(spec.Listeners) > 0 { var mListeners []interface{} for _, listener := range spec.Listeners { mListener := map[string]interface{}{} diff --git a/internal/service/appmesh/service_endpoints_gen_test.go b/internal/service/appmesh/service_endpoints_gen_test.go index 30a48e3684ec..128bf6f8fc34 100644 --- a/internal/service/appmesh/service_endpoints_gen_test.go +++ b/internal/service/appmesh/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/appmesh/virtual_gateway.go b/internal/service/appmesh/virtual_gateway.go index 6b86ad5caca8..6832931aedc1 100644 --- a/internal/service/appmesh/virtual_gateway.go +++ b/internal/service/appmesh/virtual_gateway.go @@ -1296,7 +1296,7 @@ func flattenVirtualGatewaySpec(spec *awstypes.VirtualGatewaySpec) []interface{} mSpec["backend_defaults"] = []interface{}{mBackendDefaults} } - if spec.Listeners != nil && len(spec.Listeners) > 0 { + if len(spec.Listeners) > 0 { var mListeners []interface{} for _, listener := range spec.Listeners { mListener := map[string]interface{}{} From a538ee24d259253495217c770e90320fc225d23f Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:39 -0400 Subject: [PATCH 034/281] apprunner: linter changes --- .../service/apprunner/auto_scaling_configuration_version.go | 1 - internal/service/apprunner/custom_domain_association.go | 1 - internal/service/apprunner/service_endpoints_gen_test.go | 2 -- 3 files changed, 4 deletions(-) diff --git a/internal/service/apprunner/auto_scaling_configuration_version.go b/internal/service/apprunner/auto_scaling_configuration_version.go index 197592a13204..ae761e430e4f 100644 --- a/internal/service/apprunner/auto_scaling_configuration_version.go +++ b/internal/service/apprunner/auto_scaling_configuration_version.go @@ -250,7 +250,6 @@ func findAutoScalingConfigurationSummaries(ctx context.Context, conn *apprunner. } for _, v := range page.AutoScalingConfigurationSummaryList { - v := v if v := &v; filter(v) { output = append(output, v) } diff --git a/internal/service/apprunner/custom_domain_association.go b/internal/service/apprunner/custom_domain_association.go index 328ad57aa416..009eb9be10d7 100644 --- a/internal/service/apprunner/custom_domain_association.go +++ b/internal/service/apprunner/custom_domain_association.go @@ -230,7 +230,6 @@ func findCustomDomains(ctx context.Context, conn *apprunner.Client, input *appru err := forEachCustomDomainPage(ctx, conn, input, func(page *apprunner.DescribeCustomDomainsOutput) { for _, v := range page.CustomDomains { - v := v if v := &v; filter(v) { output = append(output, v) } diff --git a/internal/service/apprunner/service_endpoints_gen_test.go b/internal/service/apprunner/service_endpoints_gen_test.go index 28192b44c001..70efb684a2db 100644 --- a/internal/service/apprunner/service_endpoints_gen_test.go +++ b/internal/service/apprunner/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 52915d71810f0fd05822e4bdf82f21e7af8591b2 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:39 -0400 Subject: [PATCH 035/281] appstream: linter changes --- internal/service/appstream/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/appstream/service_endpoints_gen_test.go b/internal/service/appstream/service_endpoints_gen_test.go index 2d22f4739afc..fb1ffc89e95a 100644 --- a/internal/service/appstream/service_endpoints_gen_test.go +++ b/internal/service/appstream/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 1041082aa928a68f3b3cf93588b58f8374cf0a3d Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:39 -0400 Subject: [PATCH 036/281] appsync: linter changes --- internal/service/appsync/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/appsync/service_endpoints_gen_test.go b/internal/service/appsync/service_endpoints_gen_test.go index 8924b03c34a4..88c7ee064aa1 100644 --- a/internal/service/appsync/service_endpoints_gen_test.go +++ b/internal/service/appsync/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 8f7304423efb044e2a6a9314f6eee978e7dfda5c Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:39 -0400 Subject: [PATCH 037/281] athena: linter changes --- internal/service/athena/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/athena/service_endpoints_gen_test.go b/internal/service/athena/service_endpoints_gen_test.go index 7777c256879e..c0ddd30a89d5 100644 --- a/internal/service/athena/service_endpoints_gen_test.go +++ b/internal/service/athena/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From ace7ac972bd0f0efb0648bafe9702ef61e7680d0 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:39 -0400 Subject: [PATCH 038/281] auditmanager: linter changes --- internal/service/auditmanager/framework_share_test.go | 1 - internal/service/auditmanager/service_endpoints_gen_test.go | 2 -- 2 files changed, 3 deletions(-) diff --git a/internal/service/auditmanager/framework_share_test.go b/internal/service/auditmanager/framework_share_test.go index 30c4adfefd37..48f81d3dfb79 100644 --- a/internal/service/auditmanager/framework_share_test.go +++ b/internal/service/auditmanager/framework_share_test.go @@ -40,7 +40,6 @@ func TestCanBeRevoked(t *testing.T) { {"shared", types.ShareRequestStatusShared, true}, } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() diff --git a/internal/service/auditmanager/service_endpoints_gen_test.go b/internal/service/auditmanager/service_endpoints_gen_test.go index 18afec6a5387..af7cf9a11461 100644 --- a/internal/service/auditmanager/service_endpoints_gen_test.go +++ b/internal/service/auditmanager/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From f8ea1e228b5da0b2c79c597e5cfe30c9783de0c2 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:39 -0400 Subject: [PATCH 039/281] autoscaling: linter changes --- internal/service/autoscaling/group.go | 6 ++---- internal/service/autoscaling/group_migrate_test.go | 1 - internal/service/autoscaling/policy.go | 2 +- internal/service/autoscaling/service_endpoints_gen_test.go | 2 -- 4 files changed, 3 insertions(+), 8 deletions(-) diff --git a/internal/service/autoscaling/group.go b/internal/service/autoscaling/group.go index bc5712684f67..936a41648086 100644 --- a/internal/service/autoscaling/group.go +++ b/internal/service/autoscaling/group.go @@ -1968,8 +1968,7 @@ func drainWarmPool(ctx context.Context, conn *autoscaling.Client, name string, t func findELBInstanceStates(ctx context.Context, conn *elasticloadbalancing.Client, g *awstypes.AutoScalingGroup) (map[string]map[string]string, error) { instanceStates := make(map[string]map[string]string) - for _, v := range g.LoadBalancerNames { - lbName := v + for _, lbName := range g.LoadBalancerNames { input := &elasticloadbalancing.DescribeInstanceHealthInput{ LoadBalancerName: aws.String(lbName), } @@ -2002,8 +2001,7 @@ func findELBInstanceStates(ctx context.Context, conn *elasticloadbalancing.Clien func findELBV2InstanceStates(ctx context.Context, conn *elasticloadbalancingv2.Client, g *awstypes.AutoScalingGroup) (map[string]map[string]string, error) { instanceStates := make(map[string]map[string]string) - for _, v := range g.TargetGroupARNs { - targetGroupARN := v + for _, targetGroupARN := range g.TargetGroupARNs { input := &elasticloadbalancingv2.DescribeTargetHealthInput{ TargetGroupArn: aws.String(targetGroupARN), } diff --git a/internal/service/autoscaling/group_migrate_test.go b/internal/service/autoscaling/group_migrate_test.go index 0d3ef2a84ba1..7c8101b42ad7 100644 --- a/internal/service/autoscaling/group_migrate_test.go +++ b/internal/service/autoscaling/group_migrate_test.go @@ -59,7 +59,6 @@ func TestGroupStateUpgradeV0(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.testName, func(t *testing.T) { t.Parallel() diff --git a/internal/service/autoscaling/policy.go b/internal/service/autoscaling/policy.go index 1ced8e93c238..fccce5278f5c 100644 --- a/internal/service/autoscaling/policy.go +++ b/internal/service/autoscaling/policy.go @@ -1137,7 +1137,7 @@ func flattenPredictiveScalingConfig(predictiveScalingConfig *awstypes.Predictive if predictiveScalingConfig == nil { return nil } - if predictiveScalingConfig.MetricSpecifications != nil && len(predictiveScalingConfig.MetricSpecifications) > 0 { + if len(predictiveScalingConfig.MetricSpecifications) > 0 { predictiveScalingConfigFlat["metric_specification"] = flattenPredictiveScalingMetricSpecifications(predictiveScalingConfig.MetricSpecifications) } predictiveScalingConfigFlat[names.AttrMode] = string(predictiveScalingConfig.Mode) diff --git a/internal/service/autoscaling/service_endpoints_gen_test.go b/internal/service/autoscaling/service_endpoints_gen_test.go index 790a7bc829b3..6091ee446e4f 100644 --- a/internal/service/autoscaling/service_endpoints_gen_test.go +++ b/internal/service/autoscaling/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 34a7f4c54cfad4fea5c081ed6cb1704364277cb8 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:39 -0400 Subject: [PATCH 040/281] autoscalingplans: linter changes --- internal/service/autoscalingplans/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/autoscalingplans/service_endpoints_gen_test.go b/internal/service/autoscalingplans/service_endpoints_gen_test.go index 31e88ea87c1d..d2270b7ff350 100644 --- a/internal/service/autoscalingplans/service_endpoints_gen_test.go +++ b/internal/service/autoscalingplans/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From a4bb7b65f79484e01b134cb06e5918aca096fe41 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:39 -0400 Subject: [PATCH 041/281] backup: linter changes --- internal/service/backup/report_plan.go | 10 +++++----- internal/service/backup/service_endpoints_gen_test.go | 2 -- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/internal/service/backup/report_plan.go b/internal/service/backup/report_plan.go index 8dca727d1519..3a25670d2e88 100644 --- a/internal/service/backup/report_plan.go +++ b/internal/service/backup/report_plan.go @@ -333,7 +333,7 @@ func flattenReportDeliveryChannel(reportDeliveryChannel *awstypes.ReportDelivery names.AttrS3BucketName: aws.ToString(reportDeliveryChannel.S3BucketName), } - if reportDeliveryChannel.Formats != nil && len(reportDeliveryChannel.Formats) > 0 { + if len(reportDeliveryChannel.Formats) > 0 { values["formats"] = flex.FlattenStringValueSet(reportDeliveryChannel.Formats) } @@ -353,21 +353,21 @@ func flattenReportSetting(reportSetting *awstypes.ReportSetting) []interface{} { "report_template": aws.ToString(reportSetting.ReportTemplate), } - if reportSetting.Accounts != nil && len(reportSetting.Accounts) > 0 { + if len(reportSetting.Accounts) > 0 { values["accounts"] = flex.FlattenStringValueSet(reportSetting.Accounts) } - if reportSetting.FrameworkArns != nil && len(reportSetting.FrameworkArns) > 0 { + if len(reportSetting.FrameworkArns) > 0 { values["framework_arns"] = flex.FlattenStringValueSet(reportSetting.FrameworkArns) } values["number_of_frameworks"] = reportSetting.NumberOfFrameworks - if reportSetting.OrganizationUnits != nil && len(reportSetting.OrganizationUnits) > 0 { + if len(reportSetting.OrganizationUnits) > 0 { values["organization_units"] = flex.FlattenStringValueSet(reportSetting.OrganizationUnits) } - if reportSetting.Regions != nil && len(reportSetting.Regions) > 0 { + if len(reportSetting.Regions) > 0 { values["regions"] = flex.FlattenStringValueSet(reportSetting.Regions) } diff --git a/internal/service/backup/service_endpoints_gen_test.go b/internal/service/backup/service_endpoints_gen_test.go index 28c210b2512a..d08cbd1a10f8 100644 --- a/internal/service/backup/service_endpoints_gen_test.go +++ b/internal/service/backup/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From aa52252d3c57ff4a17c11352ecefa89c72cd0b88 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:40 -0400 Subject: [PATCH 042/281] batch: linter changes --- internal/service/batch/container_properties_test.go | 1 - internal/service/batch/ecs_properties_test.go | 1 - internal/service/batch/node_properties_test.go | 1 - internal/service/batch/service_endpoints_gen_test.go | 2 -- 4 files changed, 5 deletions(-) diff --git a/internal/service/batch/container_properties_test.go b/internal/service/batch/container_properties_test.go index 7a68ba0aa738..f279cd79d242 100644 --- a/internal/service/batch/container_properties_test.go +++ b/internal/service/batch/container_properties_test.go @@ -454,7 +454,6 @@ func TestEquivalentContainerPropertiesJSON(t *testing.T) { } for name, testCase := range testCases { - testCase := testCase t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/service/batch/ecs_properties_test.go b/internal/service/batch/ecs_properties_test.go index 9e8387ba9b44..22cf730262ec 100644 --- a/internal/service/batch/ecs_properties_test.go +++ b/internal/service/batch/ecs_properties_test.go @@ -294,7 +294,6 @@ func TestEquivalentECSPropertiesJSON(t *testing.T) { } for name, testCase := range testCases { - testCase := testCase t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/service/batch/node_properties_test.go b/internal/service/batch/node_properties_test.go index 7e09f08080b2..67a6c3eb35cd 100644 --- a/internal/service/batch/node_properties_test.go +++ b/internal/service/batch/node_properties_test.go @@ -137,7 +137,6 @@ func TestEquivalentNodePropertiesJSON(t *testing.T) { } for name, testCase := range testCases { - testCase := testCase t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/service/batch/service_endpoints_gen_test.go b/internal/service/batch/service_endpoints_gen_test.go index 39444cdb4dc6..d66e4c1e4e59 100644 --- a/internal/service/batch/service_endpoints_gen_test.go +++ b/internal/service/batch/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 176713674bef300516c357b97f58875aa132e972 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:40 -0400 Subject: [PATCH 043/281] bcmdataexports: linter changes --- internal/service/bcmdataexports/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/bcmdataexports/service_endpoints_gen_test.go b/internal/service/bcmdataexports/service_endpoints_gen_test.go index 261364a9a92d..ef7611571b1f 100644 --- a/internal/service/bcmdataexports/service_endpoints_gen_test.go +++ b/internal/service/bcmdataexports/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 974fe04313a2c3b7f2e19ca4e907a671be5ce3ad Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:40 -0400 Subject: [PATCH 044/281] bedrock: linter changes --- internal/service/bedrock/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/bedrock/service_endpoints_gen_test.go b/internal/service/bedrock/service_endpoints_gen_test.go index a41897029ca5..66fd7d4523e0 100644 --- a/internal/service/bedrock/service_endpoints_gen_test.go +++ b/internal/service/bedrock/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From f8740d2fdfd4a4c10045d5d661f311b4d754bee2 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:40 -0400 Subject: [PATCH 045/281] bedrockagent: linter changes --- internal/service/bedrockagent/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/bedrockagent/service_endpoints_gen_test.go b/internal/service/bedrockagent/service_endpoints_gen_test.go index 32305838fc30..7676a459e6d8 100644 --- a/internal/service/bedrockagent/service_endpoints_gen_test.go +++ b/internal/service/bedrockagent/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From c4b1b0bc31756a3826e5753eda63207761406051 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:40 -0400 Subject: [PATCH 046/281] budgets: linter changes --- internal/service/budgets/budget_action.go | 8 ++++---- internal/service/budgets/service_endpoints_gen_test.go | 2 -- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/internal/service/budgets/budget_action.go b/internal/service/budgets/budget_action.go index f694d658c202..85fe458bd261 100644 --- a/internal/service/budgets/budget_action.go +++ b/internal/service/budgets/budget_action.go @@ -628,15 +628,15 @@ func flattenBudgetActionIAMActionDefinition(lt *awstypes.IamActionDefinition) [] "policy_arn": aws.ToString(lt.PolicyArn), } - if lt.Users != nil && len(lt.Users) > 0 { + if len(lt.Users) > 0 { attrs["users"] = flex.FlattenStringValueSet(lt.Users) } - if lt.Roles != nil && len(lt.Roles) > 0 { + if len(lt.Roles) > 0 { attrs["roles"] = flex.FlattenStringValueSet(lt.Roles) } - if lt.Groups != nil && len(lt.Groups) > 0 { + if len(lt.Groups) > 0 { attrs["groups"] = flex.FlattenStringValueSet(lt.Groups) } @@ -652,7 +652,7 @@ func flattenBudgetActionScpActionDefinition(lt *awstypes.ScpActionDefinition) [] "policy_id": aws.ToString(lt.PolicyId), } - if lt.TargetIds != nil && len(lt.TargetIds) > 0 { + if len(lt.TargetIds) > 0 { attrs["target_ids"] = flex.FlattenStringValueSet(lt.TargetIds) } diff --git a/internal/service/budgets/service_endpoints_gen_test.go b/internal/service/budgets/service_endpoints_gen_test.go index 14463e7cfbfc..77c2ed2bd317 100644 --- a/internal/service/budgets/service_endpoints_gen_test.go +++ b/internal/service/budgets/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From ef1e46d06dd9122386b4f911a569c134aaf0b1cf Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:40 -0400 Subject: [PATCH 047/281] ce: linter changes --- internal/service/ce/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/ce/service_endpoints_gen_test.go b/internal/service/ce/service_endpoints_gen_test.go index d9d1460d882e..140caf4fcbfe 100644 --- a/internal/service/ce/service_endpoints_gen_test.go +++ b/internal/service/ce/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 9ef67118880f3457f9589f48cf043d651c1eee24 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:40 -0400 Subject: [PATCH 048/281] chatbot: linter changes --- internal/service/chatbot/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/chatbot/service_endpoints_gen_test.go b/internal/service/chatbot/service_endpoints_gen_test.go index e022c7a05397..e19d23d94185 100644 --- a/internal/service/chatbot/service_endpoints_gen_test.go +++ b/internal/service/chatbot/service_endpoints_gen_test.go @@ -237,8 +237,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 65d6631567ca34a90820218e8628d0991bdd9e2a Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:40 -0400 Subject: [PATCH 049/281] chime: linter changes --- internal/service/chime/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/chime/service_endpoints_gen_test.go b/internal/service/chime/service_endpoints_gen_test.go index 1ed11cd92e56..21abf3c48159 100644 --- a/internal/service/chime/service_endpoints_gen_test.go +++ b/internal/service/chime/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From ff5f8609624d50d5748594e4b141ec124c742494 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:40 -0400 Subject: [PATCH 050/281] chimesdkmediapipelines: linter changes --- .../chimesdkmediapipelines/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/chimesdkmediapipelines/service_endpoints_gen_test.go b/internal/service/chimesdkmediapipelines/service_endpoints_gen_test.go index 88707528d6d7..745c7f802304 100644 --- a/internal/service/chimesdkmediapipelines/service_endpoints_gen_test.go +++ b/internal/service/chimesdkmediapipelines/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From d4e04a0d807037f37a399ddff4dbf9fd7bf6cea8 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:40 -0400 Subject: [PATCH 051/281] chimesdkvoice: linter changes --- internal/service/chimesdkvoice/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/chimesdkvoice/service_endpoints_gen_test.go b/internal/service/chimesdkvoice/service_endpoints_gen_test.go index 1238fde0ae1e..07440d8077b3 100644 --- a/internal/service/chimesdkvoice/service_endpoints_gen_test.go +++ b/internal/service/chimesdkvoice/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From d7713b0b9da1c2b80ad01d07588cdce0f2c40c1f Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:40 -0400 Subject: [PATCH 052/281] cleanrooms: linter changes --- internal/service/cleanrooms/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/cleanrooms/service_endpoints_gen_test.go b/internal/service/cleanrooms/service_endpoints_gen_test.go index d199fa3ea51f..5dcdbafcc6bc 100644 --- a/internal/service/cleanrooms/service_endpoints_gen_test.go +++ b/internal/service/cleanrooms/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From d093a02981b9d3eee8ad5f8f0132a9fcccd872a0 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:40 -0400 Subject: [PATCH 053/281] cloud9: linter changes --- internal/service/cloud9/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/cloud9/service_endpoints_gen_test.go b/internal/service/cloud9/service_endpoints_gen_test.go index 915a7877f15e..5e688cdd9063 100644 --- a/internal/service/cloud9/service_endpoints_gen_test.go +++ b/internal/service/cloud9/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 95e891a3e5404b98876987062a5c0bbe689f30e3 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:40 -0400 Subject: [PATCH 054/281] cloudcontrol: linter changes --- internal/service/cloudcontrol/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/cloudcontrol/service_endpoints_gen_test.go b/internal/service/cloudcontrol/service_endpoints_gen_test.go index da0057352b90..8f997d3ffd84 100644 --- a/internal/service/cloudcontrol/service_endpoints_gen_test.go +++ b/internal/service/cloudcontrol/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 7854ab2eee059436b101a528365e5ca06aabd027 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:40 -0400 Subject: [PATCH 055/281] cloudformation: linter changes --- internal/service/cloudformation/arn_test.go | 1 - internal/service/cloudformation/service_endpoints_gen_test.go | 2 -- 2 files changed, 3 deletions(-) diff --git a/internal/service/cloudformation/arn_test.go b/internal/service/cloudformation/arn_test.go index baa3b1435159..12752df6abfc 100644 --- a/internal/service/cloudformation/arn_test.go +++ b/internal/service/cloudformation/arn_test.go @@ -55,7 +55,6 @@ func TestTypeVersionARNToTypeARNAndVersionID(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() diff --git a/internal/service/cloudformation/service_endpoints_gen_test.go b/internal/service/cloudformation/service_endpoints_gen_test.go index 20198e3936fc..62b2e30a0982 100644 --- a/internal/service/cloudformation/service_endpoints_gen_test.go +++ b/internal/service/cloudformation/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 422f94413ef3de91009910aded452c0e204a5bf8 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:41 -0400 Subject: [PATCH 056/281] cloudfront: linter changes --- internal/service/cloudfront/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/cloudfront/service_endpoints_gen_test.go b/internal/service/cloudfront/service_endpoints_gen_test.go index 3f001e4e08a9..4486514f4ef0 100644 --- a/internal/service/cloudfront/service_endpoints_gen_test.go +++ b/internal/service/cloudfront/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From eb73c88355360a96cfea41dff0187bea2af92d17 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:41 -0400 Subject: [PATCH 057/281] cloudhsmv2: linter changes --- internal/service/cloudhsmv2/hsm.go | 2 -- internal/service/cloudhsmv2/service_endpoints_gen_test.go | 2 -- 2 files changed, 4 deletions(-) diff --git a/internal/service/cloudhsmv2/hsm.go b/internal/service/cloudhsmv2/hsm.go index b334ed499723..ef0a9878be90 100644 --- a/internal/service/cloudhsmv2/hsm.go +++ b/internal/service/cloudhsmv2/hsm.go @@ -194,8 +194,6 @@ func findHSMByTwoPartKey(ctx context.Context, conn *cloudhsmv2.Client, hsmID, en for _, v := range output { for _, v := range v.Hsms { - v := v - // CloudHSMv2 HSM instances can be recreated, but the ENI ID will // remain consistent. Without this ENI matching, HSM instances // instances can become orphaned. diff --git a/internal/service/cloudhsmv2/service_endpoints_gen_test.go b/internal/service/cloudhsmv2/service_endpoints_gen_test.go index 46b19669c04c..315c60e64e00 100644 --- a/internal/service/cloudhsmv2/service_endpoints_gen_test.go +++ b/internal/service/cloudhsmv2/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From d7ebc7f9dd226fdd36569cf6a704a6d26320f252 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:41 -0400 Subject: [PATCH 058/281] cloudsearch: linter changes --- internal/service/cloudsearch/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/cloudsearch/service_endpoints_gen_test.go b/internal/service/cloudsearch/service_endpoints_gen_test.go index 0ca66dc3b205..a3d9a745528d 100644 --- a/internal/service/cloudsearch/service_endpoints_gen_test.go +++ b/internal/service/cloudsearch/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From fbf866194ddeea0cae302ad329a0355e4fffa431 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:41 -0400 Subject: [PATCH 059/281] cloudtrail: linter changes --- internal/service/cloudtrail/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/cloudtrail/service_endpoints_gen_test.go b/internal/service/cloudtrail/service_endpoints_gen_test.go index a6c8e24747cf..e1e26b4495c8 100644 --- a/internal/service/cloudtrail/service_endpoints_gen_test.go +++ b/internal/service/cloudtrail/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 4d2bf5727d6cc62d4350d2e16bcfa8b8093f3d19 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:41 -0400 Subject: [PATCH 060/281] cloudwatch: linter changes --- internal/service/cloudwatch/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/cloudwatch/service_endpoints_gen_test.go b/internal/service/cloudwatch/service_endpoints_gen_test.go index 4a83208444db..7beedb480929 100644 --- a/internal/service/cloudwatch/service_endpoints_gen_test.go +++ b/internal/service/cloudwatch/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From c766da2ccc68c4f1329c0aeb11dbeb4f810d626d Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:41 -0400 Subject: [PATCH 061/281] codeartifact: linter changes --- internal/service/codeartifact/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/codeartifact/service_endpoints_gen_test.go b/internal/service/codeartifact/service_endpoints_gen_test.go index 52f947f89275..142603694416 100644 --- a/internal/service/codeartifact/service_endpoints_gen_test.go +++ b/internal/service/codeartifact/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From b31b6970c8cd0281ff950cca16a7ef43393eb70c Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:41 -0400 Subject: [PATCH 062/281] codebuild: linter changes --- internal/service/codebuild/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/codebuild/service_endpoints_gen_test.go b/internal/service/codebuild/service_endpoints_gen_test.go index c11ccb1dd83c..4870e21550bd 100644 --- a/internal/service/codebuild/service_endpoints_gen_test.go +++ b/internal/service/codebuild/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From cc32df4f0a8f73b73b00ea8a363f6a6760fb629c Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:41 -0400 Subject: [PATCH 063/281] codecommit: linter changes --- internal/service/codecommit/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/codecommit/service_endpoints_gen_test.go b/internal/service/codecommit/service_endpoints_gen_test.go index 6acd86e61987..beace358730c 100644 --- a/internal/service/codecommit/service_endpoints_gen_test.go +++ b/internal/service/codecommit/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From c44a6941a0870204cb5aad580c790d6af2bf0a13 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:41 -0400 Subject: [PATCH 064/281] codeguruprofiler: linter changes --- internal/service/codeguruprofiler/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/codeguruprofiler/service_endpoints_gen_test.go b/internal/service/codeguruprofiler/service_endpoints_gen_test.go index 8426219547f5..921b1c71b181 100644 --- a/internal/service/codeguruprofiler/service_endpoints_gen_test.go +++ b/internal/service/codeguruprofiler/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From abf518f0b5fb0c416630104df684ef7fa88af8be Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:41 -0400 Subject: [PATCH 065/281] codegurureviewer: linter changes --- internal/service/codegurureviewer/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/codegurureviewer/service_endpoints_gen_test.go b/internal/service/codegurureviewer/service_endpoints_gen_test.go index 1f573bf3d549..2b558f1bfc06 100644 --- a/internal/service/codegurureviewer/service_endpoints_gen_test.go +++ b/internal/service/codegurureviewer/service_endpoints_gen_test.go @@ -236,8 +236,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 02e3096e6bd466fc1ba74cd1ee89f4e770f5346a Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:41 -0400 Subject: [PATCH 066/281] codepipeline: linter changes --- internal/service/codepipeline/codepipeline.go | 1 - internal/service/codepipeline/custom_action_type.go | 1 - internal/service/codepipeline/service_endpoints_gen_test.go | 2 -- internal/service/codepipeline/webhook.go | 1 - 4 files changed, 5 deletions(-) diff --git a/internal/service/codepipeline/codepipeline.go b/internal/service/codepipeline/codepipeline.go index 09b7c639f9d6..d2427dbd50b9 100644 --- a/internal/service/codepipeline/codepipeline.go +++ b/internal/service/codepipeline/codepipeline.go @@ -666,7 +666,6 @@ func expandPipelineDeclaration(d *schema.ResourceData) (*types.PipelineDeclarati if region != "" { return nil, errors.New("region cannot be set for a single-region CodePipeline Pipeline") } - v := v apiObject.ArtifactStore = &v } diff --git a/internal/service/codepipeline/custom_action_type.go b/internal/service/codepipeline/custom_action_type.go index 992d709eda36..d0527a8e7d02 100644 --- a/internal/service/codepipeline/custom_action_type.go +++ b/internal/service/codepipeline/custom_action_type.go @@ -374,7 +374,6 @@ func findActionTypes(ctx context.Context, conn *codepipeline.Client, input *code } for _, v := range page.ActionTypes { - v := v if v := &v; filter(v) { output = append(output, v) } diff --git a/internal/service/codepipeline/service_endpoints_gen_test.go b/internal/service/codepipeline/service_endpoints_gen_test.go index ac6e0bfbbffb..677a277b3c89 100644 --- a/internal/service/codepipeline/service_endpoints_gen_test.go +++ b/internal/service/codepipeline/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/codepipeline/webhook.go b/internal/service/codepipeline/webhook.go index 446655462d2f..db3ab34a0f49 100644 --- a/internal/service/codepipeline/webhook.go +++ b/internal/service/codepipeline/webhook.go @@ -275,7 +275,6 @@ func findWebhooks(ctx context.Context, conn *codepipeline.Client, input *codepip } for _, v := range page.Webhooks { - v := v if v := &v; filter(v) { output = append(output, v) } From 070287c95c025e0919b5ab4b27b0dcd5bfaf0c0e Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:41 -0400 Subject: [PATCH 067/281] codestarconnections: linter changes --- internal/service/codestarconnections/connection_data_source.go | 2 -- .../service/codestarconnections/service_endpoints_gen_test.go | 2 -- 2 files changed, 4 deletions(-) diff --git a/internal/service/codestarconnections/connection_data_source.go b/internal/service/codestarconnections/connection_data_source.go index 90f99854d183..4c171af4b336 100644 --- a/internal/service/codestarconnections/connection_data_source.go +++ b/internal/service/codestarconnections/connection_data_source.go @@ -83,8 +83,6 @@ func dataSourceConnectionRead(ctx context.Context, d *schema.ResourceData, meta } for _, v := range page.Connections { - v := v - if aws.ToString(v.ConnectionName) == name { connection = &v break diff --git a/internal/service/codestarconnections/service_endpoints_gen_test.go b/internal/service/codestarconnections/service_endpoints_gen_test.go index 7e984327f264..68559d53137a 100644 --- a/internal/service/codestarconnections/service_endpoints_gen_test.go +++ b/internal/service/codestarconnections/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 46dd3316d94ab2adf7a356dc1e1fa8869ee5f78f Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:41 -0400 Subject: [PATCH 068/281] codestarnotifications: linter changes --- .../service/codestarnotifications/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/codestarnotifications/service_endpoints_gen_test.go b/internal/service/codestarnotifications/service_endpoints_gen_test.go index 4116ac5670bb..bf6543d1f34e 100644 --- a/internal/service/codestarnotifications/service_endpoints_gen_test.go +++ b/internal/service/codestarnotifications/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 4fc51c1864659fd45fb8af3f01dc022a623b16f3 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:41 -0400 Subject: [PATCH 069/281] cognitoidentity: linter changes --- internal/service/cognitoidentity/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/cognitoidentity/service_endpoints_gen_test.go b/internal/service/cognitoidentity/service_endpoints_gen_test.go index 3134656aec0e..d591f7f93c4f 100644 --- a/internal/service/cognitoidentity/service_endpoints_gen_test.go +++ b/internal/service/cognitoidentity/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 3621e9e4992c8c946e8f72d718cd6fddc37cebc8 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:42 -0400 Subject: [PATCH 070/281] cognitoidp: linter changes --- internal/service/cognitoidp/flex_test.go | 2 -- internal/service/cognitoidp/service_endpoints_gen_test.go | 2 -- 2 files changed, 4 deletions(-) diff --git a/internal/service/cognitoidp/flex_test.go b/internal/service/cognitoidp/flex_test.go index 084892e7e92f..db6a6cdc4029 100644 --- a/internal/service/cognitoidp/flex_test.go +++ b/internal/service/cognitoidp/flex_test.go @@ -152,7 +152,6 @@ func TestUserPoolSchemaAttributeMatchesStandardAttribute(t *testing.T) { } for _, tc := range cases { - tc := tc t.Run(tc.Name, func(t *testing.T) { t.Parallel() output := userPoolSchemaAttributeMatchesStandardAttribute(tc.Input) @@ -255,7 +254,6 @@ func TestSkipFlatteningStringAttributeContraints(t *testing.T) { } for _, tc := range cases { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() got := skipFlatteningStringAttributeContraints(tc.configured, tc.input) diff --git a/internal/service/cognitoidp/service_endpoints_gen_test.go b/internal/service/cognitoidp/service_endpoints_gen_test.go index 0852e65f2a6d..ececd9786a9d 100644 --- a/internal/service/cognitoidp/service_endpoints_gen_test.go +++ b/internal/service/cognitoidp/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 300f680b1b395d455980ebbdf2c1365f6f067415 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:42 -0400 Subject: [PATCH 071/281] comprehend: linter changes --- internal/service/comprehend/document_classifier.go | 2 -- internal/service/comprehend/entity_recognizer.go | 2 -- internal/service/comprehend/service_endpoints_gen_test.go | 2 -- 3 files changed, 6 deletions(-) diff --git a/internal/service/comprehend/document_classifier.go b/internal/service/comprehend/document_classifier.go index b6e28090b97e..c3b8c7f4ad44 100644 --- a/internal/service/comprehend/document_classifier.go +++ b/internal/service/comprehend/document_classifier.go @@ -404,7 +404,6 @@ func resourceDocumentClassifierDelete(ctx context.Context, d *schema.ResourceDat var g multierror.Group for _, v := range versions { - v := v g.Go(func() error { _, err = conn.DeleteDocumentClassifier(ctx, &comprehend.DeleteDocumentClassifierInput{ DocumentClassifierArn: v.DocumentClassifierArn, @@ -431,7 +430,6 @@ func resourceDocumentClassifierDelete(ctx context.Context, d *schema.ResourceDat } for _, v := range networkInterfaces { - v := v g.Go(func() error { networkInterfaceID := aws.ToString(v.NetworkInterfaceId) diff --git a/internal/service/comprehend/entity_recognizer.go b/internal/service/comprehend/entity_recognizer.go index e22146d6e676..1081c12242cb 100644 --- a/internal/service/comprehend/entity_recognizer.go +++ b/internal/service/comprehend/entity_recognizer.go @@ -434,7 +434,6 @@ func resourceEntityRecognizerDelete(ctx context.Context, d *schema.ResourceData, var g multierror.Group for _, v := range versions { - v := v g.Go(func() error { _, err = conn.DeleteEntityRecognizer(ctx, &comprehend.DeleteEntityRecognizerInput{ EntityRecognizerArn: v.EntityRecognizerArn, @@ -461,7 +460,6 @@ func resourceEntityRecognizerDelete(ctx context.Context, d *schema.ResourceData, } for _, v := range networkInterfaces { - v := v g.Go(func() error { networkInterfaceID := aws.ToString(v.NetworkInterfaceId) diff --git a/internal/service/comprehend/service_endpoints_gen_test.go b/internal/service/comprehend/service_endpoints_gen_test.go index 3bf5c4e34151..6ece418ebda8 100644 --- a/internal/service/comprehend/service_endpoints_gen_test.go +++ b/internal/service/comprehend/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 4226a5b1d2a1f07612f7176b75b08ae593fdd7a6 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:42 -0400 Subject: [PATCH 072/281] computeoptimizer: linter changes --- internal/service/computeoptimizer/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/computeoptimizer/service_endpoints_gen_test.go b/internal/service/computeoptimizer/service_endpoints_gen_test.go index 8d1ae0a4fbf8..df5e6e5e0ce3 100644 --- a/internal/service/computeoptimizer/service_endpoints_gen_test.go +++ b/internal/service/computeoptimizer/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From e32c1029eb359285ef6ed1f36ed32e41a8705f19 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:42 -0400 Subject: [PATCH 073/281] configservice: linter changes --- internal/service/configservice/configuration_recorder.go | 2 +- internal/service/configservice/service_endpoints_gen_test.go | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/internal/service/configservice/configuration_recorder.go b/internal/service/configservice/configuration_recorder.go index a9876d0ecadf..366bdfa1f021 100644 --- a/internal/service/configservice/configuration_recorder.go +++ b/internal/service/configservice/configuration_recorder.go @@ -509,7 +509,7 @@ func flattenRecordingMode(apiObject *types.RecordingMode) []interface{} { "recording_frequency": apiObject.RecordingFrequency, } - if apiObject.RecordingModeOverrides != nil && len(apiObject.RecordingModeOverrides) > 0 { + if len(apiObject.RecordingModeOverrides) > 0 { tfMap["recording_mode_override"] = flattenRecordingModeOverrides(apiObject.RecordingModeOverrides) } diff --git a/internal/service/configservice/service_endpoints_gen_test.go b/internal/service/configservice/service_endpoints_gen_test.go index d778d581ca85..b0bf970be78d 100644 --- a/internal/service/configservice/service_endpoints_gen_test.go +++ b/internal/service/configservice/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From cd7bc6a652316b721c43f6ea250e7f7e98989e7a Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:42 -0400 Subject: [PATCH 074/281] connect: linter changes --- internal/service/connect/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/connect/service_endpoints_gen_test.go b/internal/service/connect/service_endpoints_gen_test.go index db69b24ce3f7..d23b3d5de07a 100644 --- a/internal/service/connect/service_endpoints_gen_test.go +++ b/internal/service/connect/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From e977c0fb3658a849bb62a35101465cb15e6fbaf4 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:42 -0400 Subject: [PATCH 075/281] connectcases: linter changes --- internal/service/connectcases/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/connectcases/service_endpoints_gen_test.go b/internal/service/connectcases/service_endpoints_gen_test.go index 7828b34b8f75..728e8ac4d1c0 100644 --- a/internal/service/connectcases/service_endpoints_gen_test.go +++ b/internal/service/connectcases/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 522d77520cc52b4c809f4c0755790fbfe3e197e9 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:42 -0400 Subject: [PATCH 076/281] controltower: linter changes --- internal/service/controltower/control.go | 1 - internal/service/controltower/service_endpoints_gen_test.go | 2 -- 2 files changed, 3 deletions(-) diff --git a/internal/service/controltower/control.go b/internal/service/controltower/control.go index fda5478d26ce..f4896448d250 100644 --- a/internal/service/controltower/control.go +++ b/internal/service/controltower/control.go @@ -362,7 +362,6 @@ func findEnabledControls(ctx context.Context, conn *controltower.Client, input * } for _, v := range page.EnabledControls { - v := v if v := &v; filter(v) { output = append(output, v) } diff --git a/internal/service/controltower/service_endpoints_gen_test.go b/internal/service/controltower/service_endpoints_gen_test.go index 4177f22267e8..7d053c4741ac 100644 --- a/internal/service/controltower/service_endpoints_gen_test.go +++ b/internal/service/controltower/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 8bc7e21dac3bf2435d2e7403ee4d668193744008 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:42 -0400 Subject: [PATCH 077/281] costoptimizationhub: linter changes --- .../service/costoptimizationhub/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/costoptimizationhub/service_endpoints_gen_test.go b/internal/service/costoptimizationhub/service_endpoints_gen_test.go index 9a5e89bf8ed8..c166c0bd3a06 100644 --- a/internal/service/costoptimizationhub/service_endpoints_gen_test.go +++ b/internal/service/costoptimizationhub/service_endpoints_gen_test.go @@ -237,8 +237,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From ed3280f4a2615dc07ac85947ed92c657410dafa6 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:42 -0400 Subject: [PATCH 078/281] cur: linter changes --- internal/service/cur/report_definition_test.go | 1 - internal/service/cur/service_endpoints_gen_test.go | 2 -- 2 files changed, 3 deletions(-) diff --git a/internal/service/cur/report_definition_test.go b/internal/service/cur/report_definition_test.go index 464ddf9c3934..2515fc1d16e3 100644 --- a/internal/service/cur/report_definition_test.go +++ b/internal/service/cur/report_definition_test.go @@ -865,7 +865,6 @@ func TestCheckDefinitionPropertyCombination(t *testing.T) { } for name, tCase := range testCases { - tCase := tCase t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/service/cur/service_endpoints_gen_test.go b/internal/service/cur/service_endpoints_gen_test.go index 9a06ce0c82ee..206e4db5ab50 100644 --- a/internal/service/cur/service_endpoints_gen_test.go +++ b/internal/service/cur/service_endpoints_gen_test.go @@ -291,8 +291,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 4bec83becc55174a0095ec186f6e8c41b0fad6f5 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:42 -0400 Subject: [PATCH 079/281] customerprofiles: linter changes --- internal/service/customerprofiles/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/customerprofiles/service_endpoints_gen_test.go b/internal/service/customerprofiles/service_endpoints_gen_test.go index 8f2441f60639..fe439218c880 100644 --- a/internal/service/customerprofiles/service_endpoints_gen_test.go +++ b/internal/service/customerprofiles/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 27bbfefd7964bfaf22c5543c9715c338b2dd9cf3 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:42 -0400 Subject: [PATCH 080/281] databrew: linter changes --- internal/service/databrew/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/databrew/service_endpoints_gen_test.go b/internal/service/databrew/service_endpoints_gen_test.go index 40956837ba85..2c741846c61c 100644 --- a/internal/service/databrew/service_endpoints_gen_test.go +++ b/internal/service/databrew/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From d0ba703ea0202c0884141cc8fff42ddc0659964e Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:42 -0400 Subject: [PATCH 081/281] dataexchange: linter changes --- internal/service/dataexchange/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/dataexchange/service_endpoints_gen_test.go b/internal/service/dataexchange/service_endpoints_gen_test.go index e4f07a0660c4..74b15a2ad621 100644 --- a/internal/service/dataexchange/service_endpoints_gen_test.go +++ b/internal/service/dataexchange/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 0458df10e6e6ae9be71fde677693b0c3384815ee Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:42 -0400 Subject: [PATCH 082/281] datapipeline: linter changes --- internal/service/datapipeline/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/datapipeline/service_endpoints_gen_test.go b/internal/service/datapipeline/service_endpoints_gen_test.go index 5c3e4e505602..36b1a0f10b04 100644 --- a/internal/service/datapipeline/service_endpoints_gen_test.go +++ b/internal/service/datapipeline/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From c1ae5d33e932d6baa4851039db35dad9220d8b79 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:42 -0400 Subject: [PATCH 083/281] datasync: linter changes --- internal/service/datasync/service_endpoints_gen_test.go | 2 -- internal/service/datasync/uri_test.go | 2 -- 2 files changed, 4 deletions(-) diff --git a/internal/service/datasync/service_endpoints_gen_test.go b/internal/service/datasync/service_endpoints_gen_test.go index 2c33885b57cd..3d4302b5265d 100644 --- a/internal/service/datasync/service_endpoints_gen_test.go +++ b/internal/service/datasync/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/datasync/uri_test.go b/internal/service/datasync/uri_test.go index 43f9534cea0a..c7538b184342 100644 --- a/internal/service/datasync/uri_test.go +++ b/internal/service/datasync/uri_test.go @@ -167,7 +167,6 @@ func TestSubdirectoryFromLocationURI(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() @@ -233,7 +232,6 @@ func TestDecodeObjectStorageURI(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() From 942ca227bef79f00d6df6499be4120bef627dbc2 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:43 -0400 Subject: [PATCH 084/281] datazone: linter changes --- internal/service/datazone/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/datazone/service_endpoints_gen_test.go b/internal/service/datazone/service_endpoints_gen_test.go index d9757cb80853..23374664523c 100644 --- a/internal/service/datazone/service_endpoints_gen_test.go +++ b/internal/service/datazone/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 75311cf0b3a5c93dcc17387173e4d765fe4d2792 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:43 -0400 Subject: [PATCH 085/281] dax: linter changes --- internal/service/dax/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/dax/service_endpoints_gen_test.go b/internal/service/dax/service_endpoints_gen_test.go index 69508d5850a5..58dda228878d 100644 --- a/internal/service/dax/service_endpoints_gen_test.go +++ b/internal/service/dax/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 557905f62cff278e18b07cb2d55447343b065f26 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:43 -0400 Subject: [PATCH 086/281] deploy: linter changes --- internal/service/deploy/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/deploy/service_endpoints_gen_test.go b/internal/service/deploy/service_endpoints_gen_test.go index 8484f47323b5..7128ff5bfc36 100644 --- a/internal/service/deploy/service_endpoints_gen_test.go +++ b/internal/service/deploy/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From e57313d739186c91b6aab6c95891f834931f5756 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:43 -0400 Subject: [PATCH 087/281] detective: linter changes --- internal/service/detective/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/detective/service_endpoints_gen_test.go b/internal/service/detective/service_endpoints_gen_test.go index 60838ef9a221..09ada86996a6 100644 --- a/internal/service/detective/service_endpoints_gen_test.go +++ b/internal/service/detective/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 45b35dee4d37c40a0c68abeaf7c8209ef273491d Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:43 -0400 Subject: [PATCH 088/281] devicefarm: linter changes --- internal/service/devicefarm/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/devicefarm/service_endpoints_gen_test.go b/internal/service/devicefarm/service_endpoints_gen_test.go index b7e18d3b75fb..7fe94a9d7443 100644 --- a/internal/service/devicefarm/service_endpoints_gen_test.go +++ b/internal/service/devicefarm/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 8a72cba09ad90f544bbf1c44dc5c56f3243f8222 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:43 -0400 Subject: [PATCH 089/281] devopsguru: linter changes --- internal/service/devopsguru/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/devopsguru/service_endpoints_gen_test.go b/internal/service/devopsguru/service_endpoints_gen_test.go index c954744b2655..61214574eb14 100644 --- a/internal/service/devopsguru/service_endpoints_gen_test.go +++ b/internal/service/devopsguru/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 7566e77ff97c8abbfa2d31c4806b025a03d9d5fd Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:43 -0400 Subject: [PATCH 090/281] directconnect: linter changes --- internal/service/directconnect/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/directconnect/service_endpoints_gen_test.go b/internal/service/directconnect/service_endpoints_gen_test.go index 80bf5ee20385..bf0501a5eee0 100644 --- a/internal/service/directconnect/service_endpoints_gen_test.go +++ b/internal/service/directconnect/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From ba92de21933eb9144d7a70f2e6f067bd173b3276 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:43 -0400 Subject: [PATCH 091/281] dlm: linter changes --- internal/service/dlm/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/dlm/service_endpoints_gen_test.go b/internal/service/dlm/service_endpoints_gen_test.go index 63e661780224..d2d0809135af 100644 --- a/internal/service/dlm/service_endpoints_gen_test.go +++ b/internal/service/dlm/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 52f2a331dc3a1c3583ce05fd2f8b71e7d25305f7 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:43 -0400 Subject: [PATCH 092/281] dms: linter changes --- internal/service/dms/certificate.go | 2 +- internal/service/dms/service_endpoints_gen_test.go | 2 -- internal/service/dms/task_settings_json_test.go | 2 -- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/internal/service/dms/certificate.go b/internal/service/dms/certificate.go index 7094b91beabc..52aba8206c98 100644 --- a/internal/service/dms/certificate.go +++ b/internal/service/dms/certificate.go @@ -131,7 +131,7 @@ func resourceCertificateRead(ctx context.Context, d *schema.ResourceData, meta i if v := aws.ToString(certificate.CertificatePem); v != "" { d.Set("certificate_pem", v) } - if certificate.CertificateWallet != nil && len(certificate.CertificateWallet) != 0 { + if len(certificate.CertificateWallet) != 0 { d.Set("certificate_wallet", itypes.Base64EncodeOnce(certificate.CertificateWallet)) } diff --git a/internal/service/dms/service_endpoints_gen_test.go b/internal/service/dms/service_endpoints_gen_test.go index 3491fffc9bbd..bb2135b20704 100644 --- a/internal/service/dms/service_endpoints_gen_test.go +++ b/internal/service/dms/service_endpoints_gen_test.go @@ -348,8 +348,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/dms/task_settings_json_test.go b/internal/service/dms/task_settings_json_test.go index 8d5f46f1b0b9..ebea192cfd0c 100644 --- a/internal/service/dms/task_settings_json_test.go +++ b/internal/service/dms/task_settings_json_test.go @@ -154,12 +154,10 @@ func TestTaskSettingsEqual(t *testing.T) { } for name, typeTest := range tests { - name, typeTest := name, typeTest t.Run(name, func(t *testing.T) { t.Parallel() for name, test := range typeTest { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() From d7db26b5a00e829ff4c26a70e5d06ec8aadc3a1c Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:43 -0400 Subject: [PATCH 093/281] docdb: linter changes --- internal/service/docdb/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/docdb/service_endpoints_gen_test.go b/internal/service/docdb/service_endpoints_gen_test.go index 75c8751a3de6..a8d137092f3d 100644 --- a/internal/service/docdb/service_endpoints_gen_test.go +++ b/internal/service/docdb/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From d940cd837548993564fbd2cf449928d5ff223bb6 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:43 -0400 Subject: [PATCH 094/281] docdbelastic: linter changes --- internal/service/docdbelastic/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/docdbelastic/service_endpoints_gen_test.go b/internal/service/docdbelastic/service_endpoints_gen_test.go index 874c229c4e0c..c53daa1c6c39 100644 --- a/internal/service/docdbelastic/service_endpoints_gen_test.go +++ b/internal/service/docdbelastic/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 08ec4f5ef1e1f96a204cba8421c0fa624c798aaa Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:43 -0400 Subject: [PATCH 095/281] drs: linter changes --- internal/service/drs/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/drs/service_endpoints_gen_test.go b/internal/service/drs/service_endpoints_gen_test.go index 0b1051365ded..e0456e323903 100644 --- a/internal/service/drs/service_endpoints_gen_test.go +++ b/internal/service/drs/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From f63eabce0b3bed8a4002cb752a8bc2c53672a61d Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:43 -0400 Subject: [PATCH 096/281] ds: linter changes --- internal/service/ds/service_endpoints_gen_test.go | 2 -- internal/service/ds/validate_test.go | 3 --- 2 files changed, 5 deletions(-) diff --git a/internal/service/ds/service_endpoints_gen_test.go b/internal/service/ds/service_endpoints_gen_test.go index cd9c8648f132..0660fbbdfca1 100644 --- a/internal/service/ds/service_endpoints_gen_test.go +++ b/internal/service/ds/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/ds/validate_test.go b/internal/service/ds/validate_test.go index bf44b10396fc..771d6d8ff4a2 100644 --- a/internal/service/ds/validate_test.go +++ b/internal/service/ds/validate_test.go @@ -54,7 +54,6 @@ func TestDirectoryIDValidator(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -108,7 +107,6 @@ func TestDomainWithTrailingDotValidatorValidator(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -159,7 +157,6 @@ func TestTrustPasswordValidator(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() From 50e73a7fbf8ba9d524f4f851d4a644f840209df3 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:43 -0400 Subject: [PATCH 097/281] dynamodb: linter changes --- internal/service/dynamodb/arn_test.go | 1 - internal/service/dynamodb/flex_test.go | 2 -- internal/service/dynamodb/service_endpoints_gen_test.go | 2 -- 3 files changed, 5 deletions(-) diff --git a/internal/service/dynamodb/arn_test.go b/internal/service/dynamodb/arn_test.go index f983f553669b..6994aff0a918 100644 --- a/internal/service/dynamodb/arn_test.go +++ b/internal/service/dynamodb/arn_test.go @@ -37,7 +37,6 @@ func TestARNForNewRegion(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() diff --git a/internal/service/dynamodb/flex_test.go b/internal/service/dynamodb/flex_test.go index 9364d599e4b2..de36bed22128 100644 --- a/internal/service/dynamodb/flex_test.go +++ b/internal/service/dynamodb/flex_test.go @@ -123,7 +123,6 @@ func TestExpandTableItemAttributes(t *testing.T) { } for name, tc := range cases { - tc := tc t.Run(name, func(t *testing.T) { t.Parallel() @@ -277,7 +276,6 @@ func TestFlattenTableItemAttributes(t *testing.T) { } for name, tc := range cases { - tc := tc t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/service/dynamodb/service_endpoints_gen_test.go b/internal/service/dynamodb/service_endpoints_gen_test.go index 62835b5ca52d..3741c3b8e41d 100644 --- a/internal/service/dynamodb/service_endpoints_gen_test.go +++ b/internal/service/dynamodb/service_endpoints_gen_test.go @@ -345,8 +345,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From e50e3d5d29fd3e6590a07b2e4423058e406236b8 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:44 -0400 Subject: [PATCH 098/281] ec2: linter changes --- internal/service/ec2/arn_test.go | 1 - internal/service/ec2/ec2_ami.go | 2 +- internal/service/ec2/errors_test.go | 1 - internal/service/ec2/find.go | 1 - internal/service/ec2/service_endpoints_gen_test.go | 2 -- internal/service/ec2/vpc_security_group.go | 4 ++-- internal/service/ec2/vpc_security_group_ingress_rule_test.go | 1 - internal/service/ec2/vpc_security_group_test.go | 4 ++-- internal/service/ec2/vpnsite_connection_test.go | 1 - 9 files changed, 5 insertions(+), 12 deletions(-) diff --git a/internal/service/ec2/arn_test.go b/internal/service/ec2/arn_test.go index df30d7485b15..46d36b84981d 100644 --- a/internal/service/ec2/arn_test.go +++ b/internal/service/ec2/arn_test.go @@ -58,7 +58,6 @@ func TestInstanceProfileARNToName(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() diff --git a/internal/service/ec2/ec2_ami.go b/internal/service/ec2/ec2_ami.go index db94edb7017c..d5f53ff85dd3 100644 --- a/internal/service/ec2/ec2_ami.go +++ b/internal/service/ec2/ec2_ami.go @@ -530,7 +530,7 @@ func resourceAMIDelete(ctx context.Context, d *schema.ResourceData, meta interfa errParts = append(errParts, fmt.Sprintf("%s: %s", snapshotId, err)) } errParts = append(errParts, "These are no longer managed by Terraform and must be deleted manually.") - return sdkdiag.AppendErrorf(diags, strings.Join(errParts, "\n")) + return sdkdiag.AppendErrorf(diags, "%s", strings.Join(errParts, "\n")) } } diff --git a/internal/service/ec2/errors_test.go b/internal/service/ec2/errors_test.go index 0bfa131a6bf4..30ce71d462d5 100644 --- a/internal/service/ec2/errors_test.go +++ b/internal/service/ec2/errors_test.go @@ -121,7 +121,6 @@ func TestUnsuccessfulItemsError(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Name, func(t *testing.T) { t.Parallel() diff --git a/internal/service/ec2/find.go b/internal/service/ec2/find.go index 0bf60edc7433..421d29f4d738 100644 --- a/internal/service/ec2/find.go +++ b/internal/service/ec2/find.go @@ -3016,7 +3016,6 @@ func findVPCEndpointConnectionByServiceIDAndVPCEndpointID(ctx context.Context, c } for _, v := range page.VpcEndpointConnections { - v := v if aws.ToString(v.VpcEndpointId) == vpcEndpointID { output = &v break diff --git a/internal/service/ec2/service_endpoints_gen_test.go b/internal/service/ec2/service_endpoints_gen_test.go index ca6ebe68a3ef..8706c2caf7d8 100644 --- a/internal/service/ec2/service_endpoints_gen_test.go +++ b/internal/service/ec2/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/ec2/vpc_security_group.go b/internal/service/ec2/vpc_security_group.go index 6730abbc03a7..044afe933a25 100644 --- a/internal/service/ec2/vpc_security_group.go +++ b/internal/service/ec2/vpc_security_group.go @@ -858,8 +858,8 @@ func expandIPPerms(group *awstypes.SecurityGroup, configured []interface{}) ([]a if len(groups) > 0 { perm.UserIdGroupPairs = make([]awstypes.UserIdGroupPair, len(groups)) - for i, name := range groups { - ownerId, id := "", name + for i, id := range groups { + ownerId := "" if items := strings.Split(id, "/"); len(items) > 1 { ownerId, id = items[0], items[1] } diff --git a/internal/service/ec2/vpc_security_group_ingress_rule_test.go b/internal/service/ec2/vpc_security_group_ingress_rule_test.go index ba4573bad3d0..364961a40602 100644 --- a/internal/service/ec2/vpc_security_group_ingress_rule_test.go +++ b/internal/service/ec2/vpc_security_group_ingress_rule_test.go @@ -50,7 +50,6 @@ func TestIPProtocol(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/service/ec2/vpc_security_group_test.go b/internal/service/ec2/vpc_security_group_test.go index 613000d8d270..c39f428e5984 100644 --- a/internal/service/ec2/vpc_security_group_test.go +++ b/internal/service/ec2/vpc_security_group_test.go @@ -2752,7 +2752,7 @@ func testRemoveRuleCycle(ctx context.Context, primary, secondary *awstypes.Secur conn := acctest.Provider.Meta().(*conns.AWSClient).EC2Client(ctx) for _, sg := range []*awstypes.SecurityGroup{primary, secondary} { var err error - if sg.IpPermissions != nil && len(sg.IpPermissions) > 0 { + if len(sg.IpPermissions) > 0 { req := &ec2.RevokeSecurityGroupIngressInput{ GroupId: sg.GroupId, IpPermissions: sg.IpPermissions, @@ -2763,7 +2763,7 @@ func testRemoveRuleCycle(ctx context.Context, primary, secondary *awstypes.Secur } } - if sg.IpPermissionsEgress != nil && len(sg.IpPermissionsEgress) > 0 { + if len(sg.IpPermissionsEgress) > 0 { req := &ec2.RevokeSecurityGroupEgressInput{ GroupId: sg.GroupId, IpPermissions: sg.IpPermissionsEgress, diff --git a/internal/service/ec2/vpnsite_connection_test.go b/internal/service/ec2/vpnsite_connection_test.go index 26375d68c6ac..915f48f9f13a 100644 --- a/internal/service/ec2/vpnsite_connection_test.go +++ b/internal/service/ec2/vpnsite_connection_test.go @@ -134,7 +134,6 @@ func TestXmlConfigToTunnelInfo(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Name, func(t *testing.T) { t.Parallel() From ef5bad143b26af36a1d88fd0f04b3ab47d621b01 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:44 -0400 Subject: [PATCH 099/281] ecr: linter changes --- internal/service/ecr/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/ecr/service_endpoints_gen_test.go b/internal/service/ecr/service_endpoints_gen_test.go index ebb1c083a2a0..7214dc038989 100644 --- a/internal/service/ecr/service_endpoints_gen_test.go +++ b/internal/service/ecr/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 4c89eef657b72895305110729c8a15886e5ad5fe Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:44 -0400 Subject: [PATCH 100/281] ecrpublic: linter changes --- internal/service/ecrpublic/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/ecrpublic/service_endpoints_gen_test.go b/internal/service/ecrpublic/service_endpoints_gen_test.go index eebd960a6bab..2c0c04a7777e 100644 --- a/internal/service/ecrpublic/service_endpoints_gen_test.go +++ b/internal/service/ecrpublic/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 50b19878ba899c1a2633b8af1d1e2bb427a48d6d Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:44 -0400 Subject: [PATCH 101/281] ecs: linter changes --- internal/service/ecs/service_endpoints_gen_test.go | 2 -- internal/service/ecs/service_test.go | 2 -- internal/service/ecs/task_definition_test.go | 1 - 3 files changed, 5 deletions(-) diff --git a/internal/service/ecs/service_endpoints_gen_test.go b/internal/service/ecs/service_endpoints_gen_test.go index 8b17232e1b71..d8f5b1c4d499 100644 --- a/internal/service/ecs/service_endpoints_gen_test.go +++ b/internal/service/ecs/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/ecs/service_test.go b/internal/service/ecs/service_test.go index 8d249c6ae996..3dc620a8f386 100644 --- a/internal/service/ecs/service_test.go +++ b/internal/service/ecs/service_test.go @@ -50,7 +50,6 @@ func Test_GetRoleNameFromARN(t *testing.T) { }, } for _, tt := range tests { - tt := tt t.Run(tt.name, func(t *testing.T) { t.Parallel() if got := tfecs.RoleNameFromARN(tt.arn); got != tt.want { @@ -76,7 +75,6 @@ func TestClustereNameFromARN(t *testing.T) { }, } for _, tt := range tests { - tt := tt t.Run(tt.name, func(t *testing.T) { t.Parallel() if got := tfecs.ClusterNameFromARN(tt.arn); got != tt.want { diff --git a/internal/service/ecs/task_definition_test.go b/internal/service/ecs/task_definition_test.go index 61dbf11b1bbc..2bdb14b1935d 100644 --- a/internal/service/ecs/task_definition_test.go +++ b/internal/service/ecs/task_definition_test.go @@ -58,7 +58,6 @@ func Test_StripRevision(t *testing.T) { }, } for _, tc := range testCases { - tc := tc t.Run(tc.name, func(t *testing.T) { t.Parallel() if got := tfecs.TaskDefinitionARNStripRevision(tc.s); got != tc.want { From f96bb2103997b6d6e89dd7d6fa079c06f324e477 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:44 -0400 Subject: [PATCH 102/281] efs: linter changes --- internal/service/efs/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/efs/service_endpoints_gen_test.go b/internal/service/efs/service_endpoints_gen_test.go index 33a135c0f48f..67185cbe0777 100644 --- a/internal/service/efs/service_endpoints_gen_test.go +++ b/internal/service/efs/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 60619b2362e29ffc4f8440a32c4593246f9d44c5 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:44 -0400 Subject: [PATCH 103/281] eks: linter changes --- internal/service/eks/cluster_migrate_test.go | 1 - internal/service/eks/service_endpoints_gen_test.go | 2 -- internal/service/eks/sweep.go | 12 ++++-------- 3 files changed, 4 insertions(+), 11 deletions(-) diff --git a/internal/service/eks/cluster_migrate_test.go b/internal/service/eks/cluster_migrate_test.go index 8e4c1ec4e9eb..db1cbe40e575 100644 --- a/internal/service/eks/cluster_migrate_test.go +++ b/internal/service/eks/cluster_migrate_test.go @@ -57,7 +57,6 @@ func TestClusterStateUpgradeV0(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.testName, func(t *testing.T) { t.Parallel() diff --git a/internal/service/eks/service_endpoints_gen_test.go b/internal/service/eks/service_endpoints_gen_test.go index df336e50006e..ddb83f4241a1 100644 --- a/internal/service/eks/service_endpoints_gen_test.go +++ b/internal/service/eks/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/eks/sweep.go b/internal/service/eks/sweep.go index 5296dcb7a77a..f3730517dc37 100644 --- a/internal/service/eks/sweep.go +++ b/internal/service/eks/sweep.go @@ -76,8 +76,7 @@ func sweepAddons(region string) error { break } - for _, v := range page.Clusters { - clusterName := v + for _, clusterName := range page.Clusters { input := &eks.ListAddonsInput{ ClusterName: aws.String(clusterName), } @@ -187,8 +186,7 @@ func sweepFargateProfiles(region string) error { break } - for _, v := range page.Clusters { - clusterName := v + for _, clusterName := range page.Clusters { input := &eks.ListFargateProfilesInput{ ClusterName: aws.String(clusterName), } @@ -257,8 +255,7 @@ func sweepIdentityProvidersConfig(region string) error { break } - for _, v := range page.Clusters { - clusterName := v + for _, clusterName := range page.Clusters { input := &eks.ListIdentityProviderConfigsInput{ ClusterName: aws.String(clusterName), } @@ -327,8 +324,7 @@ func sweepNodeGroups(region string) error { break } - for _, v := range page.Clusters { - clusterName := v + for _, clusterName := range page.Clusters { input := &eks.ListNodegroupsInput{ ClusterName: aws.String(clusterName), } From 21d702948a138c683dd5263460e38dd7f93d5515 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:44 -0400 Subject: [PATCH 104/281] elasticache: linter changes --- internal/service/elasticache/engine_version_test.go | 9 --------- .../service/elasticache/service_endpoints_gen_test.go | 2 -- internal/service/elasticache/sweep.go | 6 +----- 3 files changed, 1 insertion(+), 16 deletions(-) diff --git a/internal/service/elasticache/engine_version_test.go b/internal/service/elasticache/engine_version_test.go index 0af633bb7947..7a607033a0d1 100644 --- a/internal/service/elasticache/engine_version_test.go +++ b/internal/service/elasticache/engine_version_test.go @@ -58,7 +58,6 @@ func TestValidMemcachedVersionString(t *testing.T) { } for _, testcase := range testcases { - testcase := testcase t.Run(testcase.version, func(t *testing.T) { t.Parallel() @@ -185,7 +184,6 @@ func TestValidRedisVersionString(t *testing.T) { } for _, testcase := range testcases { - testcase := testcase t.Run(testcase.version, func(t *testing.T) { t.Parallel() @@ -284,7 +282,6 @@ func TestValidateClusterEngineVersion(t *testing.T) { } for _, testcase := range testcases { - testcase := testcase t.Run(fmt.Sprintf("%s %s", testcase.engine, testcase.version), func(t *testing.T) { t.Parallel() err := tfelasticache.ValidateClusterEngineVersion(testcase.engine, testcase.version) @@ -389,7 +386,6 @@ func TestCustomizeDiffEngineVersionIsDowngrade(t *testing.T) { } for name, testcase := range testcases { - testcase := testcase t.Run(name, func(t *testing.T) { t.Parallel() @@ -458,7 +454,6 @@ func TestCustomizeDiffEngineVersionIsDowngrade_6xTo6digit(t *testing.T) { } for name, testcase := range testcases { - testcase := testcase t.Run(name, func(t *testing.T) { t.Parallel() @@ -617,7 +612,6 @@ func TestCustomizeDiffEngineVersionForceNewOnDowngrade(t *testing.T) { } for name, testcase := range testcases { - testcase := testcase t.Run(name, func(t *testing.T) { t.Parallel() @@ -687,7 +681,6 @@ func TestNormalizeEngineVersion(t *testing.T) { } for _, testcase := range testcases { - testcase := testcase t.Run(testcase.version, func(t *testing.T) { t.Parallel() @@ -872,8 +865,6 @@ func TestParamGroupNameRequiresMajorVersionUpgrade(t *testing.T) { } for name, testcase := range testcases { - testcase := testcase - t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/service/elasticache/service_endpoints_gen_test.go b/internal/service/elasticache/service_endpoints_gen_test.go index a51cb4b40ac8..f9f6fbf2f3c7 100644 --- a/internal/service/elasticache/service_endpoints_gen_test.go +++ b/internal/service/elasticache/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/elasticache/sweep.go b/internal/service/elasticache/sweep.go index b3072a8a5651..ef6f111aa6c5 100644 --- a/internal/service/elasticache/sweep.go +++ b/internal/service/elasticache/sweep.go @@ -162,9 +162,7 @@ func sweepGlobalReplicationGroups(region string) error { grgErrs = multierror.Append(grgErrs, fmt.Errorf("listing ElastiCache Global Replication Groups: %w", err)) } - for _, v := range page.GlobalReplicationGroups { - globalReplicationGroup := v - + for _, globalReplicationGroup := range page.GlobalReplicationGroups { grgGroup.Go(func() error { id := aws.ToString(globalReplicationGroup.GlobalReplicationGroupId) @@ -458,8 +456,6 @@ func disassociateMembers(ctx context.Context, conn *elasticache.Client, globalRe var membersGroup multierror.Group for _, member := range globalReplicationGroup.Members { - member := member - if aws.ToString(member.Role) == globalReplicationGroupMemberRolePrimary { continue } From 4f3311c60ff4342263ce5e3c0ea795ab506c515e Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:44 -0400 Subject: [PATCH 105/281] elasticbeanstalk: linter changes --- internal/service/elasticbeanstalk/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/elasticbeanstalk/service_endpoints_gen_test.go b/internal/service/elasticbeanstalk/service_endpoints_gen_test.go index 8aa8305fd23c..bce935c13372 100644 --- a/internal/service/elasticbeanstalk/service_endpoints_gen_test.go +++ b/internal/service/elasticbeanstalk/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From e1ef676bde626765bd37153a39bead4e8a14d500 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:44 -0400 Subject: [PATCH 106/281] elasticsearch: linter changes --- internal/service/elasticsearch/service_endpoints_gen_test.go | 2 -- internal/service/elasticsearch/vpc_endpoint_test.go | 1 - 2 files changed, 3 deletions(-) diff --git a/internal/service/elasticsearch/service_endpoints_gen_test.go b/internal/service/elasticsearch/service_endpoints_gen_test.go index 6a8dc878d2d8..128ae41472a5 100644 --- a/internal/service/elasticsearch/service_endpoints_gen_test.go +++ b/internal/service/elasticsearch/service_endpoints_gen_test.go @@ -348,8 +348,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/elasticsearch/vpc_endpoint_test.go b/internal/service/elasticsearch/vpc_endpoint_test.go index 1b81d8aa3ffc..71d0b50da4bd 100644 --- a/internal/service/elasticsearch/vpc_endpoint_test.go +++ b/internal/service/elasticsearch/vpc_endpoint_test.go @@ -82,7 +82,6 @@ func TestVPCEndpointErrorsNotFound(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() From 5a58eeaf3c115ae11bb6f177f2f9d6c6347d6849 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:44 -0400 Subject: [PATCH 107/281] elastictranscoder: linter changes --- .../service/elastictranscoder/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/elastictranscoder/service_endpoints_gen_test.go b/internal/service/elastictranscoder/service_endpoints_gen_test.go index 7ce27982af1a..a2c2b36bc0b5 100644 --- a/internal/service/elastictranscoder/service_endpoints_gen_test.go +++ b/internal/service/elastictranscoder/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From b268746b4adc6952b4eb9a44485f00739500fb64 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:44 -0400 Subject: [PATCH 108/281] elb: linter changes --- internal/service/elb/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/elb/service_endpoints_gen_test.go b/internal/service/elb/service_endpoints_gen_test.go index f050e7d99d02..07f62c2343d8 100644 --- a/internal/service/elb/service_endpoints_gen_test.go +++ b/internal/service/elb/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 75d24eaf40332f933a723cefc9c1022af0604066 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:44 -0400 Subject: [PATCH 109/281] elbv2: linter changes --- internal/service/elbv2/listener.go | 4 +-- .../service/elbv2/listener_data_source.go | 4 +-- internal/service/elbv2/listener_rule_test.go | 2 -- internal/service/elbv2/listener_test.go | 2 -- .../elbv2/service_endpoints_gen_test.go | 2 -- internal/service/elbv2/target_group_test.go | 28 ------------------- 6 files changed, 4 insertions(+), 38 deletions(-) diff --git a/internal/service/elbv2/listener.go b/internal/service/elbv2/listener.go index 012c19e6f27b..6f8f47d702dd 100644 --- a/internal/service/elbv2/listener.go +++ b/internal/service/elbv2/listener.go @@ -523,11 +523,11 @@ func resourceListenerRead(ctx context.Context, d *schema.ResourceData, meta inte return sdkdiag.AppendErrorf(diags, "reading ELBv2 Listener (%s): %s", d.Id(), err) } - if listener.AlpnPolicy != nil && len(listener.AlpnPolicy) == 1 { + if len(listener.AlpnPolicy) == 1 { d.Set("alpn_policy", listener.AlpnPolicy[0]) } d.Set(names.AttrARN, listener.ListenerArn) - if listener.Certificates != nil && len(listener.Certificates) == 1 { + if len(listener.Certificates) == 1 { d.Set(names.AttrCertificateARN, listener.Certificates[0].CertificateArn) } sort.Slice(listener.DefaultActions, func(i, j int) bool { diff --git a/internal/service/elbv2/listener_data_source.go b/internal/service/elbv2/listener_data_source.go index 828348abfd0e..1063b36d8209 100644 --- a/internal/service/elbv2/listener_data_source.go +++ b/internal/service/elbv2/listener_data_source.go @@ -330,11 +330,11 @@ func dataSourceListenerRead(ctx context.Context, d *schema.ResourceData, meta in } d.SetId(aws.ToString(listener.ListenerArn)) - if listener.AlpnPolicy != nil && len(listener.AlpnPolicy) == 1 { + if len(listener.AlpnPolicy) == 1 { d.Set("alpn_policy", listener.AlpnPolicy[0]) } d.Set(names.AttrARN, listener.ListenerArn) - if listener.Certificates != nil && len(listener.Certificates) == 1 { + if len(listener.Certificates) == 1 { d.Set(names.AttrCertificateARN, listener.Certificates[0].CertificateArn) } sort.Slice(listener.DefaultActions, func(i, j int) bool { diff --git a/internal/service/elbv2/listener_rule_test.go b/internal/service/elbv2/listener_rule_test.go index f0bcfdcd361c..acb5cc958ea8 100644 --- a/internal/service/elbv2/listener_rule_test.go +++ b/internal/service/elbv2/listener_rule_test.go @@ -1447,8 +1447,6 @@ func TestAccELBV2ListenerRule_EmptyAction(t *testing.T) { } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(string(name), func(t *testing.T) { ctx := acctest.Context(t) rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix) diff --git a/internal/service/elbv2/listener_test.go b/internal/service/elbv2/listener_test.go index 76af9f2cf7c1..bef9ff72ce59 100644 --- a/internal/service/elbv2/listener_test.go +++ b/internal/service/elbv2/listener_test.go @@ -1550,8 +1550,6 @@ func TestAccELBV2Listener_EmptyDefaultAction(t *testing.T) { } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(string(name), func(t *testing.T) { ctx := acctest.Context(t) rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix) diff --git a/internal/service/elbv2/service_endpoints_gen_test.go b/internal/service/elbv2/service_endpoints_gen_test.go index 3405dc4194a2..f544d94e505b 100644 --- a/internal/service/elbv2/service_endpoints_gen_test.go +++ b/internal/service/elbv2/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/elbv2/target_group_test.go b/internal/service/elbv2/target_group_test.go index 9775e70d6b7d..b40ed55a3b6f 100644 --- a/internal/service/elbv2/target_group_test.go +++ b/internal/service/elbv2/target_group_test.go @@ -2062,8 +2062,6 @@ func TestAccELBV2TargetGroup_ALBAlias_missing(t *testing.T) { } for name, tc := range testcases { //nolint:paralleltest // false positive - tc := tc - t.Run(name, func(t *testing.T) { ctx := acctest.Context(t) rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix) @@ -2803,8 +2801,6 @@ func TestAccELBV2TargetGroup_Instance_HealthCheck_defaults(t *testing.T) { } for _, healthCheckProtocol := range tfelbv2.HealthCheckProtocolEnumValues() { - healthCheckProtocol := healthCheckProtocol - t.Run(healthCheckProtocol, func(t *testing.T) { tc, ok := protocolCase[healthCheckProtocol] if !ok { @@ -2950,8 +2946,6 @@ func TestAccELBV2TargetGroup_Instance_HealthCheck_matcher(t *testing.T) { } for _, healthCheckProtocol := range tfelbv2.HealthCheckProtocolEnumValues() { - healthCheckProtocol := healthCheckProtocol - t.Run(healthCheckProtocol, func(t *testing.T) { tc, ok := protocolCase[healthCheckProtocol] if !ok { @@ -3092,8 +3086,6 @@ func TestAccELBV2TargetGroup_Instance_HealthCheck_path(t *testing.T) { } for _, healthCheckProtocol := range tfelbv2.HealthCheckProtocolEnumValues() { - healthCheckProtocol := healthCheckProtocol - t.Run(healthCheckProtocol, func(t *testing.T) { tc, ok := protocolCase[healthCheckProtocol] if !ok { @@ -3245,8 +3237,6 @@ func TestAccELBV2TargetGroup_Instance_HealthCheck_matcherOutOfRange(t *testing.T } for _, healthCheckProtocol := range tfelbv2.HealthCheckProtocolEnumValues() { - healthCheckProtocol := healthCheckProtocol - t.Run(healthCheckProtocol, func(t *testing.T) { tc, ok := protocolCase[healthCheckProtocol] if !ok { @@ -3308,8 +3298,6 @@ func TestAccELBV2TargetGroup_Instance_HealthCheckGeneve_defaults(t *testing.T) { } for _, healthCheckProtocol := range tfelbv2.HealthCheckProtocolEnumValues() { //nolint:paralleltest // false positive - healthCheckProtocol := healthCheckProtocol - t.Run(healthCheckProtocol, func(t *testing.T) { tc, ok := testcases[healthCheckProtocol] if !ok { @@ -3375,14 +3363,10 @@ func TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_defaults(t *testing.T) { } for _, protocol := range enum.Slice(awstypes.ProtocolEnumHttp, awstypes.ProtocolEnumHttps) { - protocol := protocol - t.Run(protocol, func(t *testing.T) { t.Parallel() for _, healthCheckProtocol := range tfelbv2.HealthCheckProtocolEnumValues() { - healthCheckProtocol := healthCheckProtocol - t.Run(healthCheckProtocol, func(t *testing.T) { tc, ok := testcases[healthCheckProtocol] if !ok { @@ -3452,14 +3436,10 @@ func TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_path(t *testing.T) { } for _, protocol := range enum.Slice(awstypes.ProtocolEnumHttp, awstypes.ProtocolEnumHttps) { - protocol := protocol - t.Run(protocol, func(t *testing.T) { t.Parallel() for _, healthCheckProtocol := range tfelbv2.HealthCheckProtocolEnumValues() { - healthCheckProtocol := healthCheckProtocol - t.Run(healthCheckProtocol, func(t *testing.T) { tc, ok := testcases[healthCheckProtocol] if !ok { @@ -3520,14 +3500,10 @@ func TestAccELBV2TargetGroup_Instance_HealthCheckGRPC_matcherOutOfRange(t *testi } for _, protocol := range enum.Slice(awstypes.ProtocolEnumHttp, awstypes.ProtocolEnumHttps) { - protocol := protocol - t.Run(protocol, func(t *testing.T) { t.Parallel() for _, healthCheckProtocol := range tfelbv2.HealthCheckProtocolEnumValues() { - healthCheckProtocol := healthCheckProtocol - t.Run(healthCheckProtocol, func(t *testing.T) { tc, ok := testcases[healthCheckProtocol] if !ok { @@ -4110,8 +4086,6 @@ func TestAccELBV2TargetGroup_Lambda_HealthCheck_protocol(t *testing.T) { } for _, healthCheckProtocol := range tfelbv2.HealthCheckProtocolEnumValues() { //nolint:paralleltest // false positive - healthCheckProtocol := healthCheckProtocol - t.Run(healthCheckProtocol, func(t *testing.T) { tc, ok := testcases[healthCheckProtocol] if !ok { @@ -4170,8 +4144,6 @@ func TestAccELBV2TargetGroup_Lambda_HealthCheck_protocol_MigrateV0(t *testing.T) } for _, healthCheckProtocol := range tfelbv2.HealthCheckProtocolEnumValues() { //nolint:paralleltest // false positive - healthCheckProtocol := healthCheckProtocol - t.Run(healthCheckProtocol, func(t *testing.T) { tc, ok := testcases[healthCheckProtocol] if !ok { From d0bedda4e2d25f0b34b47395d17414a7d5d1ca28 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:44 -0400 Subject: [PATCH 110/281] emrcontainers: linter changes --- internal/service/emrcontainers/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/emrcontainers/service_endpoints_gen_test.go b/internal/service/emrcontainers/service_endpoints_gen_test.go index 6ea12550bf7a..ef6063baf879 100644 --- a/internal/service/emrcontainers/service_endpoints_gen_test.go +++ b/internal/service/emrcontainers/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 52cb8015c63177156b59c8c6abbc853121ed5af2 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:45 -0400 Subject: [PATCH 111/281] emrserverless: linter changes --- internal/service/emrserverless/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/emrserverless/service_endpoints_gen_test.go b/internal/service/emrserverless/service_endpoints_gen_test.go index a86c2c6c35b0..c8a387c4898f 100644 --- a/internal/service/emrserverless/service_endpoints_gen_test.go +++ b/internal/service/emrserverless/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 295e1bdfb7feb8db376e7fa2f19128119ccbe703 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:45 -0400 Subject: [PATCH 112/281] events: linter changes --- internal/service/events/rule_test.go | 6 ------ internal/service/events/service_endpoints_gen_test.go | 2 -- internal/service/events/target_test.go | 1 - 3 files changed, 9 deletions(-) diff --git a/internal/service/events/rule_test.go b/internal/service/events/rule_test.go index d5b37541da03..9f871684798b 100644 --- a/internal/service/events/rule_test.go +++ b/internal/service/events/rule_test.go @@ -135,7 +135,6 @@ func TestRuleParseResourceID(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() @@ -179,7 +178,6 @@ func TestRuleEventPatternJSONDecoder(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -806,8 +804,6 @@ func TestAccEventsRule_migrateV0(t *testing.T) { } for name, testcase := range testcases { //nolint:paralleltest - testcase := testcase - t.Run(name, func(t *testing.T) { ctx := acctest.Context(t) var v eventbridge.DescribeRuleOutput @@ -878,8 +874,6 @@ func TestAccEventsRule_migrateV0_Equivalent(t *testing.T) { } for name, testcase := range testcases { //nolint:paralleltest - testcase := testcase - t.Run(name, func(t *testing.T) { ctx := acctest.Context(t) rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix) diff --git a/internal/service/events/service_endpoints_gen_test.go b/internal/service/events/service_endpoints_gen_test.go index de3aa35c867e..7c3cbea66b0f 100644 --- a/internal/service/events/service_endpoints_gen_test.go +++ b/internal/service/events/service_endpoints_gen_test.go @@ -348,8 +348,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/events/target_test.go b/internal/service/events/target_test.go index 38b784f64b40..74ed1f482c19 100644 --- a/internal/service/events/target_test.go +++ b/internal/service/events/target_test.go @@ -161,7 +161,6 @@ func TestTargetParseImportID(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() From 8b516e7d1aa7b961dd90369ffb2184f6cd2764da Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:45 -0400 Subject: [PATCH 113/281] evidently: linter changes --- internal/service/evidently/feature.go | 1 - internal/service/evidently/service_endpoints_gen_test.go | 2 -- 2 files changed, 3 deletions(-) diff --git a/internal/service/evidently/feature.go b/internal/service/evidently/feature.go index 54d93b63f8d4..ebcb2a59695f 100644 --- a/internal/service/evidently/feature.go +++ b/internal/service/evidently/feature.go @@ -518,7 +518,6 @@ func VariationChanges(o, n interface{}) (remove []string, addOrUpdate []awstypes // remove is a list of strings remove = make([]string, 0) for k := range om { - k := k if _, ok := nm[k]; !ok { remove = append(remove, k) } diff --git a/internal/service/evidently/service_endpoints_gen_test.go b/internal/service/evidently/service_endpoints_gen_test.go index 6d6e4e5f1c51..2b88aef55be9 100644 --- a/internal/service/evidently/service_endpoints_gen_test.go +++ b/internal/service/evidently/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From ba9d8ec045ed2016726f4cdcc467b3e3c5fd05e0 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:45 -0400 Subject: [PATCH 114/281] finspace: linter changes --- internal/service/finspace/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/finspace/service_endpoints_gen_test.go b/internal/service/finspace/service_endpoints_gen_test.go index 600018888c8f..7a2590b69ceb 100644 --- a/internal/service/finspace/service_endpoints_gen_test.go +++ b/internal/service/finspace/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From c469afa3b76df4d2cf08e96e4528daccb138caaa Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:45 -0400 Subject: [PATCH 115/281] firehose: linter changes --- internal/service/firehose/service_endpoints_gen_test.go | 2 -- internal/service/firehose/sweep.go | 3 +-- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/internal/service/firehose/service_endpoints_gen_test.go b/internal/service/firehose/service_endpoints_gen_test.go index 43e377a9cb03..67a07dd0d05e 100644 --- a/internal/service/firehose/service_endpoints_gen_test.go +++ b/internal/service/firehose/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/firehose/sweep.go b/internal/service/firehose/sweep.go index c61ecd0a2319..58f54a513933 100644 --- a/internal/service/firehose/sweep.go +++ b/internal/service/firehose/sweep.go @@ -37,10 +37,9 @@ func sweepDeliveryStreams(region string) error { return !lastPage } - for _, v := range page.DeliveryStreamNames { + for _, name := range page.DeliveryStreamNames { r := resourceDeliveryStream() d := r.Data(nil) - name := v arn := arn.ARN{ Partition: client.Partition, Service: "firehose", From c43adab99cf978f268bb54b522a0fb2f8b51e02d Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:45 -0400 Subject: [PATCH 116/281] fis: linter changes --- internal/service/fis/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/fis/service_endpoints_gen_test.go b/internal/service/fis/service_endpoints_gen_test.go index 42d82b4d95a5..3fe468cafc2a 100644 --- a/internal/service/fis/service_endpoints_gen_test.go +++ b/internal/service/fis/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 1668dfd61446525e223718da3f32b79556183110 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:45 -0400 Subject: [PATCH 117/281] fms: linter changes --- internal/service/fms/managed_service_data_test.go | 1 - internal/service/fms/service_endpoints_gen_test.go | 2 -- 2 files changed, 3 deletions(-) diff --git a/internal/service/fms/managed_service_data_test.go b/internal/service/fms/managed_service_data_test.go index 035550c29b30..cb5d6cacff37 100644 --- a/internal/service/fms/managed_service_data_test.go +++ b/internal/service/fms/managed_service_data_test.go @@ -60,7 +60,6 @@ func TestRemoveEmptyFieldsFromJSON(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.testName, func(t *testing.T) { t.Parallel() diff --git a/internal/service/fms/service_endpoints_gen_test.go b/internal/service/fms/service_endpoints_gen_test.go index 66ed0ae4db0e..3d77de12ff71 100644 --- a/internal/service/fms/service_endpoints_gen_test.go +++ b/internal/service/fms/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 7255e55efc585527b7621885dd3a3bc306cd166f Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:45 -0400 Subject: [PATCH 118/281] fsx: linter changes --- internal/service/fsx/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/fsx/service_endpoints_gen_test.go b/internal/service/fsx/service_endpoints_gen_test.go index ff2d965b7431..90aeb0f85545 100644 --- a/internal/service/fsx/service_endpoints_gen_test.go +++ b/internal/service/fsx/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From e054593b43de8edd7fff254ac3c647b09c80fc8d Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:45 -0400 Subject: [PATCH 119/281] gamelift: linter changes --- internal/service/gamelift/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/gamelift/service_endpoints_gen_test.go b/internal/service/gamelift/service_endpoints_gen_test.go index ebb016b80cfe..462e8e81a4c3 100644 --- a/internal/service/gamelift/service_endpoints_gen_test.go +++ b/internal/service/gamelift/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 23460c6041cf4892e26498d5379d11109a072db7 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:45 -0400 Subject: [PATCH 120/281] glacier: linter changes --- internal/service/glacier/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/glacier/service_endpoints_gen_test.go b/internal/service/glacier/service_endpoints_gen_test.go index 1f3c37d8129e..2b157f7f9a6b 100644 --- a/internal/service/glacier/service_endpoints_gen_test.go +++ b/internal/service/glacier/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 530a470c58e07bbadc458806c8f22e1fa2a55bba Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:45 -0400 Subject: [PATCH 121/281] globalaccelerator: linter changes --- internal/service/globalaccelerator/arn_test.go | 2 -- .../service/globalaccelerator/service_endpoints_gen_test.go | 2 -- 2 files changed, 4 deletions(-) diff --git a/internal/service/globalaccelerator/arn_test.go b/internal/service/globalaccelerator/arn_test.go index 567bdd92a29c..ee43ba1e884e 100644 --- a/internal/service/globalaccelerator/arn_test.go +++ b/internal/service/globalaccelerator/arn_test.go @@ -48,7 +48,6 @@ func TestEndpointGroupARNToListenerARN(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() @@ -115,7 +114,6 @@ func TestListenerOrEndpointGroupARNToAcceleratorARN(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() diff --git a/internal/service/globalaccelerator/service_endpoints_gen_test.go b/internal/service/globalaccelerator/service_endpoints_gen_test.go index 0f3672ed127d..adcd88fc4bc2 100644 --- a/internal/service/globalaccelerator/service_endpoints_gen_test.go +++ b/internal/service/globalaccelerator/service_endpoints_gen_test.go @@ -237,8 +237,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 92de377a042cf33bd2ff398f527e356f21fe85fd Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:45 -0400 Subject: [PATCH 122/281] glue: linter changes --- internal/service/glue/find.go | 3 +-- internal/service/glue/service_endpoints_gen_test.go | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/internal/service/glue/find.go b/internal/service/glue/find.go index 961a275008d6..1041d698eedf 100644 --- a/internal/service/glue/find.go +++ b/internal/service/glue/find.go @@ -257,9 +257,8 @@ func FindPartitionIndexByName(ctx context.Context, conn *glue.Client, id string) } for _, partInd := range output.PartitionIndexDescriptorList { - index := partInd if aws.ToString(partInd.IndexName) == partIndex { - result = &index + result = &partInd break } } diff --git a/internal/service/glue/service_endpoints_gen_test.go b/internal/service/glue/service_endpoints_gen_test.go index 48902db01c6e..90623c9010c3 100644 --- a/internal/service/glue/service_endpoints_gen_test.go +++ b/internal/service/glue/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From f64f90263b1bcf00a6aee868a004fd55c3f39fa7 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:45 -0400 Subject: [PATCH 123/281] grafana: linter changes --- internal/service/grafana/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/grafana/service_endpoints_gen_test.go b/internal/service/grafana/service_endpoints_gen_test.go index 97e728f6c051..4088bdc78a3a 100644 --- a/internal/service/grafana/service_endpoints_gen_test.go +++ b/internal/service/grafana/service_endpoints_gen_test.go @@ -348,8 +348,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 09190b61a322098d062a44c6be79b053a9770537 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:45 -0400 Subject: [PATCH 124/281] greengrass: linter changes --- internal/service/greengrass/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/greengrass/service_endpoints_gen_test.go b/internal/service/greengrass/service_endpoints_gen_test.go index 7a6a2c1699c2..254302da06c2 100644 --- a/internal/service/greengrass/service_endpoints_gen_test.go +++ b/internal/service/greengrass/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 24c0f7dad24ee9dcca8c02d30ce8700fc57e6378 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:45 -0400 Subject: [PATCH 125/281] groundstation: linter changes --- internal/service/groundstation/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/groundstation/service_endpoints_gen_test.go b/internal/service/groundstation/service_endpoints_gen_test.go index 07bff1476313..79b658543d07 100644 --- a/internal/service/groundstation/service_endpoints_gen_test.go +++ b/internal/service/groundstation/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 5ae48f4aaafbb6aae3aaab5b061c7c11bea57a35 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:46 -0400 Subject: [PATCH 126/281] guardduty: linter changes --- .../guardduty/service_endpoints_gen_test.go | 2 -- internal/service/guardduty/status.go | 5 ++--- internal/service/guardduty/sweep.go | 14 ++++++-------- 3 files changed, 8 insertions(+), 13 deletions(-) diff --git a/internal/service/guardduty/service_endpoints_gen_test.go b/internal/service/guardduty/service_endpoints_gen_test.go index ff6541b36064..13b426a6d4df 100644 --- a/internal/service/guardduty/service_endpoints_gen_test.go +++ b/internal/service/guardduty/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/guardduty/status.go b/internal/service/guardduty/status.go index a9f919cbcdd8..b2ce4ca04170 100644 --- a/internal/service/guardduty/status.go +++ b/internal/service/guardduty/status.go @@ -77,9 +77,8 @@ func getOrganizationAdminAccount(ctx context.Context, conn *guardduty.Client, ad return result, err } - for _, adminAccount := range page.AdminAccounts { - account := adminAccount - if aws.ToString(adminAccount.AdminAccountId) == adminAccountID { + for _, account := range page.AdminAccounts { + if aws.ToString(account.AdminAccountId) == adminAccountID { result = &account } } diff --git a/internal/service/guardduty/sweep.go b/internal/service/guardduty/sweep.go index a67a8e9ec9c9..7adaaed6a032 100644 --- a/internal/service/guardduty/sweep.go +++ b/internal/service/guardduty/sweep.go @@ -55,19 +55,18 @@ func sweepDetectors(region string) error { } for _, detectorID := range page.DetectorIds { - id := detectorID input := &guardduty.DeleteDetectorInput{ - DetectorId: &id, + DetectorId: &detectorID, } - log.Printf("[INFO] Deleting GuardDuty Detector: %s", id) + log.Printf("[INFO] Deleting GuardDuty Detector: %s", detectorID) _, err := conn.DeleteDetector(ctx, input) if tfawserr.ErrCodeContains(err, "AccessDenied") { - log.Printf("[WARN] Skipping GuardDuty Detector (%s): %s", id, err) + log.Printf("[WARN] Skipping GuardDuty Detector (%s): %s", detectorID, err) continue } if err != nil { - sweeperErr := fmt.Errorf("error deleting GuardDuty Detector (%s): %w", id, err) + sweeperErr := fmt.Errorf("error deleting GuardDuty Detector (%s): %w", detectorID, err) log.Printf("[ERROR] %s", sweeperErr) sweeperErrs = multierror.Append(sweeperErrs, sweeperErr) } @@ -102,9 +101,8 @@ func sweepPublishingDestinations(region string) error { } for _, detectorID := range page.DetectorIds { - id := detectorID list_input := &guardduty.ListPublishingDestinationsInput{ - DetectorId: &id, + DetectorId: &detectorID, } pages := guardduty.NewListPublishingDestinationsPaginator(conn, list_input) @@ -124,7 +122,7 @@ func sweepPublishingDestinations(region string) error { for _, destination_element := range page.Destinations { input := &guardduty.DeletePublishingDestinationInput{ DestinationId: destination_element.DestinationId, - DetectorId: &id, + DetectorId: &detectorID, } log.Printf("[INFO] Deleting GuardDuty Publishing Destination: %s", *destination_element.DestinationId) From 5e7005733db4c4e9ffe5ba69f0ca76782a4dfd73 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:46 -0400 Subject: [PATCH 127/281] healthlake: linter changes --- internal/service/healthlake/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/healthlake/service_endpoints_gen_test.go b/internal/service/healthlake/service_endpoints_gen_test.go index 1379fbffcc04..26caaff93991 100644 --- a/internal/service/healthlake/service_endpoints_gen_test.go +++ b/internal/service/healthlake/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 237ef0a1e74f24d19a83be2ea552bae957de4d1f Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:46 -0400 Subject: [PATCH 128/281] iam: linter changes --- internal/service/iam/policy_model_test.go | 3 --- internal/service/iam/service_endpoints_gen_test.go | 2 -- internal/service/iam/session_context_data_source_test.go | 1 - internal/service/iam/user_login_profile_test.go | 5 ++--- 4 files changed, 2 insertions(+), 9 deletions(-) diff --git a/internal/service/iam/policy_model_test.go b/internal/service/iam/policy_model_test.go index 963143279357..53b2391181d0 100644 --- a/internal/service/iam/policy_model_test.go +++ b/internal/service/iam/policy_model_test.go @@ -207,7 +207,6 @@ func TestPolicyHasValidAWSPrincipals(t *testing.T) { // nosemgrep:ci.aws-in-func } for name, testcase := range testcases { - testcase := testcase t.Run(name, func(t *testing.T) { t.Parallel() @@ -257,7 +256,6 @@ func TestIsValidAWSPrincipal(t *testing.T) { // nosemgrep:ci.aws-in-func-name } for name, testcase := range testcases { - testcase := testcase t.Run(name, func(t *testing.T) { t.Parallel() @@ -378,7 +376,6 @@ func TestIAMPolicyStatementConditionSet_MarshalJSON(t *testing.T) { // nosemgrep }, } for name, tc := range testcases { - tc := tc t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/service/iam/service_endpoints_gen_test.go b/internal/service/iam/service_endpoints_gen_test.go index 9ce89ce14f85..e568384d2d0f 100644 --- a/internal/service/iam/service_endpoints_gen_test.go +++ b/internal/service/iam/service_endpoints_gen_test.go @@ -345,8 +345,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/iam/session_context_data_source_test.go b/internal/service/iam/session_context_data_source_test.go index 76e8becd254b..fbfe0d911076 100644 --- a/internal/service/iam/session_context_data_source_test.go +++ b/internal/service/iam/session_context_data_source_test.go @@ -87,7 +87,6 @@ func TestAssumedRoleRoleSessionName(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Name, func(t *testing.T) { t.Parallel() diff --git a/internal/service/iam/user_login_profile_test.go b/internal/service/iam/user_login_profile_test.go index 67ba217c36de..7ad7315fcba4 100644 --- a/internal/service/iam/user_login_profile_test.go +++ b/internal/service/iam/user_login_profile_test.go @@ -34,7 +34,7 @@ func TestGeneratePassword(t *testing.T) { p, err := tfiam.GeneratePassword(6) if err != nil { - t.Fatalf(err.Error()) + t.Fatal(err) } if len(p) != 6 { t.Fatalf("expected a 6 character password, got: %q", p) @@ -42,7 +42,7 @@ func TestGeneratePassword(t *testing.T) { p, err = tfiam.GeneratePassword(128) if err != nil { - t.Fatalf(err.Error()) + t.Fatal(err) } if len(p) != 128 { t.Fatalf("expected a 128 character password, got: %q", p) @@ -66,7 +66,6 @@ func TestPasswordPolicyCheck(t *testing.T) { {pass: "ABCD1#", valid: false}, {pass: "abCD11#$", valid: true}, } { - tc := tc t.Run(tc.pass, func(t *testing.T) { t.Parallel() From 835288d48fbbe107aa248f79420336b052b44090 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:46 -0400 Subject: [PATCH 129/281] identitystore: linter changes --- internal/service/identitystore/flex.go | 4 ---- internal/service/identitystore/service_endpoints_gen_test.go | 2 -- 2 files changed, 6 deletions(-) diff --git a/internal/service/identitystore/flex.go b/internal/service/identitystore/flex.go index 974cf225e6ba..914d524fcfec 100644 --- a/internal/service/identitystore/flex.go +++ b/internal/service/identitystore/flex.go @@ -98,7 +98,6 @@ func flattenAddresses(apiObjects []types.Address) []interface{} { var l []interface{} for _, apiObject := range apiObjects { - apiObject := apiObject l = append(l, flattenAddress(&apiObject)) } @@ -193,7 +192,6 @@ func flattenEmails(apiObjects []types.Email) []interface{} { var l []interface{} for _, apiObject := range apiObjects { - apiObject := apiObject l = append(l, flattenEmail(&apiObject)) } @@ -266,7 +264,6 @@ func flattenExternalIds(apiObjects []types.ExternalId) []interface{} { var l []interface{} for _, apiObject := range apiObjects { - apiObject := apiObject l = append(l, flattenExternalId(&apiObject)) } @@ -389,7 +386,6 @@ func flattenPhoneNumbers(apiObjects []types.PhoneNumber) []interface{} { var l []interface{} for _, apiObject := range apiObjects { - apiObject := apiObject l = append(l, flattenPhoneNumber(&apiObject)) } diff --git a/internal/service/identitystore/service_endpoints_gen_test.go b/internal/service/identitystore/service_endpoints_gen_test.go index 5c4cb36e6173..5bd48890719f 100644 --- a/internal/service/identitystore/service_endpoints_gen_test.go +++ b/internal/service/identitystore/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 1954555493d842ef372bcf6f2578f605223b917b Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:46 -0400 Subject: [PATCH 130/281] imagebuilder: linter changes --- internal/service/imagebuilder/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/imagebuilder/service_endpoints_gen_test.go b/internal/service/imagebuilder/service_endpoints_gen_test.go index 92339031efa8..97a094cd09f0 100644 --- a/internal/service/imagebuilder/service_endpoints_gen_test.go +++ b/internal/service/imagebuilder/service_endpoints_gen_test.go @@ -231,8 +231,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 5717c7ab0962f857c94d7ce290cb64b75d3aaa11 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:46 -0400 Subject: [PATCH 131/281] inspector: linter changes --- internal/service/inspector/assessment_template.go | 2 +- internal/service/inspector/service_endpoints_gen_test.go | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/internal/service/inspector/assessment_template.go b/internal/service/inspector/assessment_template.go index e7dbfa3ec523..d6d4121373f0 100644 --- a/internal/service/inspector/assessment_template.go +++ b/internal/service/inspector/assessment_template.go @@ -221,7 +221,7 @@ func FindAssessmentTemplateByID(ctx context.Context, conn *inspector.Client, arn return nil, err } - if out.AssessmentTemplates == nil || len(out.AssessmentTemplates) == 0 { + if len(out.AssessmentTemplates) == 0 { return nil, &retry.NotFoundError{ LastRequest: in, } diff --git a/internal/service/inspector/service_endpoints_gen_test.go b/internal/service/inspector/service_endpoints_gen_test.go index 90a745ed872a..4b814629901c 100644 --- a/internal/service/inspector/service_endpoints_gen_test.go +++ b/internal/service/inspector/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 2b522d77aacf11dc07f35275206ac131354ec5d8 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:46 -0400 Subject: [PATCH 132/281] inspector2: linter changes --- internal/service/inspector2/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/inspector2/service_endpoints_gen_test.go b/internal/service/inspector2/service_endpoints_gen_test.go index 69c9102c4773..4db181d0e0ca 100644 --- a/internal/service/inspector2/service_endpoints_gen_test.go +++ b/internal/service/inspector2/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From e694b6d6f00f8e85bb5783bb3a3470ca5b91b45a Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:46 -0400 Subject: [PATCH 133/281] internetmonitor: linter changes --- internal/service/internetmonitor/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/internetmonitor/service_endpoints_gen_test.go b/internal/service/internetmonitor/service_endpoints_gen_test.go index 136c0a13823e..c770e4a8f676 100644 --- a/internal/service/internetmonitor/service_endpoints_gen_test.go +++ b/internal/service/internetmonitor/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From df2a4f0d38237bf591c031c1a5359253fc18ee41 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:46 -0400 Subject: [PATCH 134/281] iot: linter changes --- internal/service/iot/service_endpoints_gen_test.go | 2 -- internal/service/iot/topic_rule.go | 1 - internal/service/iot/topic_rule_destination.go | 1 - 3 files changed, 4 deletions(-) diff --git a/internal/service/iot/service_endpoints_gen_test.go b/internal/service/iot/service_endpoints_gen_test.go index 01b36e4153e1..28a9a5ecaf56 100644 --- a/internal/service/iot/service_endpoints_gen_test.go +++ b/internal/service/iot/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/iot/topic_rule.go b/internal/service/iot/topic_rule.go index 45521524398e..2f813adcd788 100644 --- a/internal/service/iot/topic_rule.go +++ b/internal/service/iot/topic_rule.go @@ -1435,7 +1435,6 @@ pageLoop: } for _, v := range page.Rules { - v := v if aws.ToString(v.RuleName) == name { rule = &v break pageLoop diff --git a/internal/service/iot/topic_rule_destination.go b/internal/service/iot/topic_rule_destination.go index d6fb79585f4c..6c94ae8e4537 100644 --- a/internal/service/iot/topic_rule_destination.go +++ b/internal/service/iot/topic_rule_destination.go @@ -240,7 +240,6 @@ pageLoop: } for _, v := range page.DestinationSummaries { - v := v if aws.ToString(v.Arn) == arn { destination = &v break pageLoop From f8120046db20a02096d68ed9ac0418436906247f Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:46 -0400 Subject: [PATCH 135/281] iotanalytics: linter changes --- internal/service/iotanalytics/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/iotanalytics/service_endpoints_gen_test.go b/internal/service/iotanalytics/service_endpoints_gen_test.go index 61915471201f..5e8bc4f57941 100644 --- a/internal/service/iotanalytics/service_endpoints_gen_test.go +++ b/internal/service/iotanalytics/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From b5a5d178f200e25f5eb243b833382f21f3a9f908 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:46 -0400 Subject: [PATCH 136/281] iotevents: linter changes --- internal/service/iotevents/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/iotevents/service_endpoints_gen_test.go b/internal/service/iotevents/service_endpoints_gen_test.go index ecd246190b46..f17981ff4e6b 100644 --- a/internal/service/iotevents/service_endpoints_gen_test.go +++ b/internal/service/iotevents/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 39b3f767af5493ece9ffa68dc9107a890bc1f871 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:46 -0400 Subject: [PATCH 137/281] ivs: linter changes --- internal/service/ivs/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/ivs/service_endpoints_gen_test.go b/internal/service/ivs/service_endpoints_gen_test.go index fb1984125850..6e0487c2da02 100644 --- a/internal/service/ivs/service_endpoints_gen_test.go +++ b/internal/service/ivs/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From d516bd21e6d01069506887e68785827fd97f499c Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:46 -0400 Subject: [PATCH 138/281] ivschat: linter changes --- internal/service/ivschat/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/ivschat/service_endpoints_gen_test.go b/internal/service/ivschat/service_endpoints_gen_test.go index ce933e468d5a..4bec654ba8b4 100644 --- a/internal/service/ivschat/service_endpoints_gen_test.go +++ b/internal/service/ivschat/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 8bdbd4937892f21ffc071b73d3c163564312717a Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:46 -0400 Subject: [PATCH 139/281] kafka: linter changes --- internal/service/kafka/service_endpoints_gen_test.go | 2 -- internal/service/kafka/sort_test.go | 1 - 2 files changed, 3 deletions(-) diff --git a/internal/service/kafka/service_endpoints_gen_test.go b/internal/service/kafka/service_endpoints_gen_test.go index 1d7e16538588..68311368c225 100644 --- a/internal/service/kafka/service_endpoints_gen_test.go +++ b/internal/service/kafka/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/kafka/sort_test.go b/internal/service/kafka/sort_test.go index 77040bd726a4..b0a496d415d7 100644 --- a/internal/service/kafka/sort_test.go +++ b/internal/service/kafka/sort_test.go @@ -35,7 +35,6 @@ func TestSortEndpointsString(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() From f16f43335c7ff25bf7558d75bd01954953e241f7 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:47 -0400 Subject: [PATCH 140/281] kafkaconnect: linter changes --- internal/service/kafkaconnect/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/kafkaconnect/service_endpoints_gen_test.go b/internal/service/kafkaconnect/service_endpoints_gen_test.go index 64f13b5747da..080214bf02d7 100644 --- a/internal/service/kafkaconnect/service_endpoints_gen_test.go +++ b/internal/service/kafkaconnect/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From daba17eb420813cb768d866ed1a70c392d82a2fb Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:47 -0400 Subject: [PATCH 141/281] kendra: linter changes --- internal/service/kendra/id_test.go | 3 --- internal/service/kendra/service_endpoints_gen_test.go | 2 -- 2 files changed, 5 deletions(-) diff --git a/internal/service/kendra/id_test.go b/internal/service/kendra/id_test.go index d2c002bc3ada..54eb957882b8 100644 --- a/internal/service/kendra/id_test.go +++ b/internal/service/kendra/id_test.go @@ -57,7 +57,6 @@ func TestExperienceParseResourceID(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() @@ -130,7 +129,6 @@ func TestQuerySuggestionsBlockListParseID(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() @@ -203,7 +201,6 @@ func TestThesaurusParseResourceID(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() diff --git a/internal/service/kendra/service_endpoints_gen_test.go b/internal/service/kendra/service_endpoints_gen_test.go index ad68216be658..e6bd28e00dc3 100644 --- a/internal/service/kendra/service_endpoints_gen_test.go +++ b/internal/service/kendra/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From e4343c9e14f96a331044bd104444440013a7b617 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:47 -0400 Subject: [PATCH 142/281] keyspaces: linter changes --- internal/service/keyspaces/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/keyspaces/service_endpoints_gen_test.go b/internal/service/keyspaces/service_endpoints_gen_test.go index a06e2d151492..7665f89efcf1 100644 --- a/internal/service/keyspaces/service_endpoints_gen_test.go +++ b/internal/service/keyspaces/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 2af03d462df67c67960332c0eac693b8347abbcd Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:47 -0400 Subject: [PATCH 143/281] kinesis: linter changes --- internal/service/kinesis/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/kinesis/service_endpoints_gen_test.go b/internal/service/kinesis/service_endpoints_gen_test.go index 1bea3dd2a85a..39a4e25332af 100644 --- a/internal/service/kinesis/service_endpoints_gen_test.go +++ b/internal/service/kinesis/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 2f63641a5ce44470a63533ad1f8747cd15c9810a Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:47 -0400 Subject: [PATCH 144/281] kinesisanalytics: linter changes --- internal/service/kinesisanalytics/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/kinesisanalytics/service_endpoints_gen_test.go b/internal/service/kinesisanalytics/service_endpoints_gen_test.go index 75ae9feefcbb..498010c6ecef 100644 --- a/internal/service/kinesisanalytics/service_endpoints_gen_test.go +++ b/internal/service/kinesisanalytics/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 04227bf168a8caec26135cf1e4187c6d9f1d17bc Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:47 -0400 Subject: [PATCH 145/281] kinesisanalyticsv2: linter changes --- .../service/kinesisanalyticsv2/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/kinesisanalyticsv2/service_endpoints_gen_test.go b/internal/service/kinesisanalyticsv2/service_endpoints_gen_test.go index e5ff81992cfd..18ce9e0ea2d8 100644 --- a/internal/service/kinesisanalyticsv2/service_endpoints_gen_test.go +++ b/internal/service/kinesisanalyticsv2/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 7bd9b6fe17c40acf06d7b8321e874df10c64a0ed Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:47 -0400 Subject: [PATCH 146/281] kinesisvideo: linter changes --- internal/service/kinesisvideo/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/kinesisvideo/service_endpoints_gen_test.go b/internal/service/kinesisvideo/service_endpoints_gen_test.go index b15998a1008b..5ef43d76e3c1 100644 --- a/internal/service/kinesisvideo/service_endpoints_gen_test.go +++ b/internal/service/kinesisvideo/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From fc145258313567bd1bc9db4b5209cb157c6b87ec Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:47 -0400 Subject: [PATCH 147/281] kms: linter changes --- internal/service/kms/arn_test.go | 2 -- internal/service/kms/diff_test.go | 1 - internal/service/kms/service_endpoints_gen_test.go | 2 -- internal/service/kms/validate_test.go | 2 -- 4 files changed, 7 deletions(-) diff --git a/internal/service/kms/arn_test.go b/internal/service/kms/arn_test.go index 77740fb962db..383e89101b63 100644 --- a/internal/service/kms/arn_test.go +++ b/internal/service/kms/arn_test.go @@ -43,7 +43,6 @@ func TestAliasARNToKeyARN(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() @@ -135,7 +134,6 @@ func TestKeyARNOrIDEqual(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() diff --git a/internal/service/kms/diff_test.go b/internal/service/kms/diff_test.go index 2a3bf0049906..b807caaa11a8 100644 --- a/internal/service/kms/diff_test.go +++ b/internal/service/kms/diff_test.go @@ -63,7 +63,6 @@ func TestDiffSuppressKeyID(t *testing.T) { } for name, testcase := range testcases { - testcase := testcase t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/service/kms/service_endpoints_gen_test.go b/internal/service/kms/service_endpoints_gen_test.go index f9af45871de2..bded90a87a51 100644 --- a/internal/service/kms/service_endpoints_gen_test.go +++ b/internal/service/kms/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/kms/validate_test.go b/internal/service/kms/validate_test.go index 6a1d5a8bdc49..9cbbec228ab5 100644 --- a/internal/service/kms/validate_test.go +++ b/internal/service/kms/validate_test.go @@ -185,7 +185,6 @@ func TestValidateKeyOrAlias(t *testing.T) { } for _, tc := range cases { - tc := tc t.Run(tc.Value, func(t *testing.T) { t.Parallel() @@ -231,7 +230,6 @@ func TestValidateKeyARN(t *testing.T) { } for name, testcase := range testcases { - testcase := testcase t.Run(name, func(t *testing.T) { t.Parallel() From 19b5e3ee155af83aa8ba826ed784c6a097df9ccd Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:47 -0400 Subject: [PATCH 148/281] lakeformation: linter changes --- internal/service/lakeformation/filter_test.go | 1 - internal/service/lakeformation/lf_tag_test.go | 1 - internal/service/lakeformation/service_endpoints_gen_test.go | 2 -- 3 files changed, 4 deletions(-) diff --git a/internal/service/lakeformation/filter_test.go b/internal/service/lakeformation/filter_test.go index 57db03403ade..5e36ccf93ef2 100644 --- a/internal/service/lakeformation/filter_test.go +++ b/internal/service/lakeformation/filter_test.go @@ -544,7 +544,6 @@ func TestFilterPermissions(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Name, func(t *testing.T) { t.Parallel() diff --git a/internal/service/lakeformation/lf_tag_test.go b/internal/service/lakeformation/lf_tag_test.go index 52a23e526faa..db1084e8a7b5 100644 --- a/internal/service/lakeformation/lf_tag_test.go +++ b/internal/service/lakeformation/lf_tag_test.go @@ -56,7 +56,6 @@ func TestReadLFTagID(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/service/lakeformation/service_endpoints_gen_test.go b/internal/service/lakeformation/service_endpoints_gen_test.go index 5eaebb3a8b26..7768c2084f96 100644 --- a/internal/service/lakeformation/service_endpoints_gen_test.go +++ b/internal/service/lakeformation/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 9d4480857715fd2e6f9a2cf9bacd9f9867e86d87 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:47 -0400 Subject: [PATCH 149/281] lambda: linter changes --- internal/service/lambda/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/lambda/service_endpoints_gen_test.go b/internal/service/lambda/service_endpoints_gen_test.go index e215a4b7cd5a..f3b125a595dd 100644 --- a/internal/service/lambda/service_endpoints_gen_test.go +++ b/internal/service/lambda/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 8a1d1b8c238420bd92c877c84b175cc58fe1a4c7 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:47 -0400 Subject: [PATCH 150/281] launchwizard: linter changes --- internal/service/launchwizard/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/launchwizard/service_endpoints_gen_test.go b/internal/service/launchwizard/service_endpoints_gen_test.go index 9cd14d759589..d779b0bf7651 100644 --- a/internal/service/launchwizard/service_endpoints_gen_test.go +++ b/internal/service/launchwizard/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From daa2b822463eeb3b7323f1b45fd4b75d15c1485a Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:47 -0400 Subject: [PATCH 151/281] lexmodels: linter changes --- internal/service/lexmodels/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/lexmodels/service_endpoints_gen_test.go b/internal/service/lexmodels/service_endpoints_gen_test.go index 3daab1b47891..3d24ced93ed8 100644 --- a/internal/service/lexmodels/service_endpoints_gen_test.go +++ b/internal/service/lexmodels/service_endpoints_gen_test.go @@ -415,8 +415,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From d5022be42ef75975e26002b8a43358ba43740687 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:47 -0400 Subject: [PATCH 152/281] lexv2models: linter changes --- internal/service/lexv2models/intent_test.go | 2 -- internal/service/lexv2models/service_endpoints_gen_test.go | 2 -- 2 files changed, 4 deletions(-) diff --git a/internal/service/lexv2models/intent_test.go b/internal/service/lexv2models/intent_test.go index 0651850188d2..6848d1e9f7d6 100644 --- a/internal/service/lexv2models/intent_test.go +++ b/internal/service/lexv2models/intent_test.go @@ -842,8 +842,6 @@ func TestIntentAutoFlex(t *testing.T) { ) for _, testCase := range testCases { - testCase := testCase - t.Run(fmt.Sprintf("expand %s", testCase.TestName), func(t *testing.T) { t.Parallel() diff --git a/internal/service/lexv2models/service_endpoints_gen_test.go b/internal/service/lexv2models/service_endpoints_gen_test.go index f707e8ab3f09..f5a4b7a88ac3 100644 --- a/internal/service/lexv2models/service_endpoints_gen_test.go +++ b/internal/service/lexv2models/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 7fca095e5b5b3721b6136facf286c5fb2474a2a4 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:47 -0400 Subject: [PATCH 153/281] licensemanager: linter changes --- internal/service/licensemanager/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/licensemanager/service_endpoints_gen_test.go b/internal/service/licensemanager/service_endpoints_gen_test.go index 346867b3c3ac..0ce78eed49ce 100644 --- a/internal/service/licensemanager/service_endpoints_gen_test.go +++ b/internal/service/licensemanager/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From d5af8860cb08ecf8fbba3f0f336b1abbd4f62adb Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:48 -0400 Subject: [PATCH 154/281] lightsail: linter changes --- .../lightsail/container_service_deployment_version_test.go | 1 - internal/service/lightsail/service_endpoints_gen_test.go | 2 -- 2 files changed, 3 deletions(-) diff --git a/internal/service/lightsail/container_service_deployment_version_test.go b/internal/service/lightsail/container_service_deployment_version_test.go index 0062178fe7a7..94574c94a919 100644 --- a/internal/service/lightsail/container_service_deployment_version_test.go +++ b/internal/service/lightsail/container_service_deployment_version_test.go @@ -74,7 +74,6 @@ func TestContainerServiceDeploymentVersionParseResourceID(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() diff --git a/internal/service/lightsail/service_endpoints_gen_test.go b/internal/service/lightsail/service_endpoints_gen_test.go index e0935d7b3604..b2690c818311 100644 --- a/internal/service/lightsail/service_endpoints_gen_test.go +++ b/internal/service/lightsail/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From a4f3b6b1f218299eef28077cadde8152bcfc6157 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:48 -0400 Subject: [PATCH 155/281] location: linter changes --- internal/service/location/tracker_association_test.go | 1 - 1 file changed, 1 deletion(-) diff --git a/internal/service/location/tracker_association_test.go b/internal/service/location/tracker_association_test.go index 05f8391a3307..400c4651096f 100644 --- a/internal/service/location/tracker_association_test.go +++ b/internal/service/location/tracker_association_test.go @@ -55,7 +55,6 @@ func TestTrackerAssociationParseID(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() From 72c37eabf7b4a7290fe0d65423e6a7da4a438551 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:48 -0400 Subject: [PATCH 156/281] logs: linter changes --- internal/service/logs/arn_test.go | 1 - internal/service/logs/query_definition.go | 2 -- internal/service/logs/resource_policy.go | 2 -- internal/service/logs/service_endpoints_gen_test.go | 2 -- 4 files changed, 7 deletions(-) diff --git a/internal/service/logs/arn_test.go b/internal/service/logs/arn_test.go index f164cbbe0073..d274096e452a 100644 --- a/internal/service/logs/arn_test.go +++ b/internal/service/logs/arn_test.go @@ -33,7 +33,6 @@ func TestTrimLogGroupARNWildcardSuffix(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() diff --git a/internal/service/logs/query_definition.go b/internal/service/logs/query_definition.go index 9a6b5e00680f..d3fde0ec435a 100644 --- a/internal/service/logs/query_definition.go +++ b/internal/service/logs/query_definition.go @@ -178,8 +178,6 @@ func findQueryDefinitionByTwoPartKey(ctx context.Context, conn *cloudwatchlogs.C } for _, v := range page.QueryDefinitions { - v := v - if aws.ToString(v.QueryDefinitionId) == queryDefinitionID { output = &v diff --git a/internal/service/logs/resource_policy.go b/internal/service/logs/resource_policy.go index 630423c8f047..6d73c4f7ec62 100644 --- a/internal/service/logs/resource_policy.go +++ b/internal/service/logs/resource_policy.go @@ -149,8 +149,6 @@ func findResourcePolicyByName(ctx context.Context, conn *cloudwatchlogs.Client, } for _, v := range page.ResourcePolicies { - v := v - if aws.ToString(v.PolicyName) == name { output = &v diff --git a/internal/service/logs/service_endpoints_gen_test.go b/internal/service/logs/service_endpoints_gen_test.go index 3e9d2e98aefd..1ebd53a6328f 100644 --- a/internal/service/logs/service_endpoints_gen_test.go +++ b/internal/service/logs/service_endpoints_gen_test.go @@ -348,8 +348,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From c6dd842a88776570a2ea812db4beafbd61c422b8 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:48 -0400 Subject: [PATCH 157/281] lookoutmetrics: linter changes --- internal/service/lookoutmetrics/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/lookoutmetrics/service_endpoints_gen_test.go b/internal/service/lookoutmetrics/service_endpoints_gen_test.go index 668ef9f66d8c..86314117ac4e 100644 --- a/internal/service/lookoutmetrics/service_endpoints_gen_test.go +++ b/internal/service/lookoutmetrics/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From a8a2157991e74145182fdd7d754e2c2796fc0147 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:48 -0400 Subject: [PATCH 158/281] m2: linter changes --- internal/service/m2/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/m2/service_endpoints_gen_test.go b/internal/service/m2/service_endpoints_gen_test.go index 3fe928c2ec95..f15e03ca08bf 100644 --- a/internal/service/m2/service_endpoints_gen_test.go +++ b/internal/service/m2/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From d8c6b5229e456fd2380581cebd354aff08914984 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:48 -0400 Subject: [PATCH 159/281] macie2: linter changes --- internal/service/macie2/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/macie2/service_endpoints_gen_test.go b/internal/service/macie2/service_endpoints_gen_test.go index 19c20acb276a..708402edc394 100644 --- a/internal/service/macie2/service_endpoints_gen_test.go +++ b/internal/service/macie2/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 2e916f6f3b58987552447d197798543ba76a794f Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:48 -0400 Subject: [PATCH 160/281] mediaconnect: linter changes --- internal/service/mediaconnect/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/mediaconnect/service_endpoints_gen_test.go b/internal/service/mediaconnect/service_endpoints_gen_test.go index f78b29f92bfd..b0811aa4889a 100644 --- a/internal/service/mediaconnect/service_endpoints_gen_test.go +++ b/internal/service/mediaconnect/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 5e0abf60b91ceec514d5a8a3daeef5fe88853400 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:48 -0400 Subject: [PATCH 161/281] mediaconvert: linter changes --- internal/service/mediaconvert/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/mediaconvert/service_endpoints_gen_test.go b/internal/service/mediaconvert/service_endpoints_gen_test.go index ea5b7f7e00cf..fecb72936680 100644 --- a/internal/service/mediaconvert/service_endpoints_gen_test.go +++ b/internal/service/mediaconvert/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 7acb5f46542c0dfbc0f490dcc008c11be81d713b Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:48 -0400 Subject: [PATCH 162/281] medialive: linter changes --- internal/service/medialive/multiplex_program_test.go | 1 - internal/service/medialive/service_endpoints_gen_test.go | 2 -- 2 files changed, 3 deletions(-) diff --git a/internal/service/medialive/multiplex_program_test.go b/internal/service/medialive/multiplex_program_test.go index 4a50fc8780cf..8fa8b61fcf9c 100644 --- a/internal/service/medialive/multiplex_program_test.go +++ b/internal/service/medialive/multiplex_program_test.go @@ -48,7 +48,6 @@ func TestParseMultiplexProgramIDUnitTest(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() diff --git a/internal/service/medialive/service_endpoints_gen_test.go b/internal/service/medialive/service_endpoints_gen_test.go index b90ee39c6cd1..598e9498c68d 100644 --- a/internal/service/medialive/service_endpoints_gen_test.go +++ b/internal/service/medialive/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From fb620edd4ae8a8a9b7aa4869d7841bd9aae84ac8 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:48 -0400 Subject: [PATCH 163/281] mediapackage: linter changes --- internal/service/mediapackage/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/mediapackage/service_endpoints_gen_test.go b/internal/service/mediapackage/service_endpoints_gen_test.go index e0034ff47539..2c278264837f 100644 --- a/internal/service/mediapackage/service_endpoints_gen_test.go +++ b/internal/service/mediapackage/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From c740021d765d3099f2ca117798b8a63da42865a2 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:48 -0400 Subject: [PATCH 164/281] mediapackagev2: linter changes --- internal/service/mediapackagev2/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/mediapackagev2/service_endpoints_gen_test.go b/internal/service/mediapackagev2/service_endpoints_gen_test.go index 04e98251e10e..c7900cef74c7 100644 --- a/internal/service/mediapackagev2/service_endpoints_gen_test.go +++ b/internal/service/mediapackagev2/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From ef98bacad94f7286ecd7f45d7a3ae89324571b1c Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:48 -0400 Subject: [PATCH 165/281] mediastore: linter changes --- internal/service/mediastore/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/mediastore/service_endpoints_gen_test.go b/internal/service/mediastore/service_endpoints_gen_test.go index a967b6552f89..e8e8c448c120 100644 --- a/internal/service/mediastore/service_endpoints_gen_test.go +++ b/internal/service/mediastore/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 62faa4a8d27d2cdb5876db41db6743cc98d68fc4 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:48 -0400 Subject: [PATCH 166/281] memorydb: linter changes --- internal/service/memorydb/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/memorydb/service_endpoints_gen_test.go b/internal/service/memorydb/service_endpoints_gen_test.go index f4fad8ba5875..88d3d8b67486 100644 --- a/internal/service/memorydb/service_endpoints_gen_test.go +++ b/internal/service/memorydb/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 36c927b0d413c483fc38e8f4f8b3bb12192c66a4 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:48 -0400 Subject: [PATCH 167/281] mq: linter changes --- internal/service/mq/forge_test.go | 1 - internal/service/mq/service_endpoints_gen_test.go | 2 -- 2 files changed, 3 deletions(-) diff --git a/internal/service/mq/forge_test.go b/internal/service/mq/forge_test.go index 5c3dae882097..05e22d9d56d1 100644 --- a/internal/service/mq/forge_test.go +++ b/internal/service/mq/forge_test.go @@ -64,7 +64,6 @@ func TestCanonicalXML(t *testing.T) { } for _, tc := range cases { - tc := tc t.Run(tc.Name, func(t *testing.T) { t.Parallel() diff --git a/internal/service/mq/service_endpoints_gen_test.go b/internal/service/mq/service_endpoints_gen_test.go index 4321844e88e0..45340607c85f 100644 --- a/internal/service/mq/service_endpoints_gen_test.go +++ b/internal/service/mq/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 4884234925a696a9d4f3687511d15d8e50e2bd99 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:48 -0400 Subject: [PATCH 168/281] mwaa: linter changes --- internal/service/mwaa/sweep.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/internal/service/mwaa/sweep.go b/internal/service/mwaa/sweep.go index 84e7d9487323..af134dd7ade3 100644 --- a/internal/service/mwaa/sweep.go +++ b/internal/service/mwaa/sweep.go @@ -44,8 +44,7 @@ func sweepEnvironment(region string) error { return fmt.Errorf("error retrieving MWAA Environment: %s", err) } - for _, environment := range page.Environments { - name := environment + for _, name := range page.Environments { r := ResourceEnvironment() d := r.Data(nil) d.SetId(name) From fbc5af7fc469bac8707b56fe69e67abf93b88052 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:49 -0400 Subject: [PATCH 169/281] neptune: linter changes --- internal/service/neptune/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/neptune/service_endpoints_gen_test.go b/internal/service/neptune/service_endpoints_gen_test.go index 49b86f46f1f4..4f113d059a26 100644 --- a/internal/service/neptune/service_endpoints_gen_test.go +++ b/internal/service/neptune/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 0f3166826a5b3014ca8ee09e7c73408e762f17ab Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:49 -0400 Subject: [PATCH 170/281] networkfirewall: linter changes --- internal/service/networkfirewall/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/networkfirewall/service_endpoints_gen_test.go b/internal/service/networkfirewall/service_endpoints_gen_test.go index c11305bd94ad..d1a0c6ad4a36 100644 --- a/internal/service/networkfirewall/service_endpoints_gen_test.go +++ b/internal/service/networkfirewall/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 36221ae7e7d7e6cf2efd4c1473fe9e0f5a503a5e Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:49 -0400 Subject: [PATCH 171/281] networkmanager: linter changes --- .../networkmanager/service_endpoints_gen_test.go | 2 -- .../service/networkmanager/vpc_attachment_test.go | 12 ------------ 2 files changed, 14 deletions(-) diff --git a/internal/service/networkmanager/service_endpoints_gen_test.go b/internal/service/networkmanager/service_endpoints_gen_test.go index c90e45cb7bb3..da547b3f2cb8 100644 --- a/internal/service/networkmanager/service_endpoints_gen_test.go +++ b/internal/service/networkmanager/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/networkmanager/vpc_attachment_test.go b/internal/service/networkmanager/vpc_attachment_test.go index e8bd9fcf3679..b9eaa2267a22 100644 --- a/internal/service/networkmanager/vpc_attachment_test.go +++ b/internal/service/networkmanager/vpc_attachment_test.go @@ -47,8 +47,6 @@ func TestAccNetworkManagerVPCAttachment_basic(t *testing.T) { } for name, testcase := range testcases { //nolint:paralleltest // false positive - testcase := testcase - t.Run(name, func(t *testing.T) { ctx := acctest.Context(t) var v awstypes.VpcAttachment @@ -115,8 +113,6 @@ func TestAccNetworkManagerVPCAttachment_Attached_basic(t *testing.T) { } for name, testcase := range testcases { //nolint:paralleltest // false positive - testcase := testcase - t.Run(name, func(t *testing.T) { ctx := acctest.Context(t) var v awstypes.VpcAttachment @@ -182,8 +178,6 @@ func TestAccNetworkManagerVPCAttachment_disappears(t *testing.T) { } for name, testcase := range testcases { //nolint:paralleltest // false positive - testcase := testcase - t.Run(name, func(t *testing.T) { ctx := acctest.Context(t) var v awstypes.VpcAttachment @@ -235,8 +229,6 @@ func TestAccNetworkManagerVPCAttachment_Attached_disappears(t *testing.T) { // n } for name, testcase := range testcases { //nolint:paralleltest // false positive - testcase := testcase - t.Run(name, func(t *testing.T) { ctx := acctest.Context(t) var v awstypes.VpcAttachment @@ -377,8 +369,6 @@ func TestAccNetworkManagerVPCAttachment_update(t *testing.T) { } for name, testcase := range testcases { //nolint:paralleltest // false positive - testcase := testcase - t.Run(name, func(t *testing.T) { ctx := acctest.Context(t) var v1, v2, v3, v4 awstypes.VpcAttachment @@ -463,8 +453,6 @@ func TestAccNetworkManagerVPCAttachment_Attached_update(t *testing.T) { } for name, testcase := range testcases { //nolint:paralleltest // false positive - testcase := testcase - t.Run(name, func(t *testing.T) { ctx := acctest.Context(t) var v1, v2, v3, v4 awstypes.VpcAttachment From 56a667dd952f0af7c69e0940a351bbe0469f862e Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:49 -0400 Subject: [PATCH 172/281] networkmonitor: linter changes --- internal/service/networkmonitor/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/networkmonitor/service_endpoints_gen_test.go b/internal/service/networkmonitor/service_endpoints_gen_test.go index 3af81e1d308a..222f70372a96 100644 --- a/internal/service/networkmonitor/service_endpoints_gen_test.go +++ b/internal/service/networkmonitor/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 05623929985ddece6db3efdacdcc2894733646a4 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:49 -0400 Subject: [PATCH 173/281] oam: linter changes --- internal/service/oam/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/oam/service_endpoints_gen_test.go b/internal/service/oam/service_endpoints_gen_test.go index 8761c852c4f6..4fc08bf1c028 100644 --- a/internal/service/oam/service_endpoints_gen_test.go +++ b/internal/service/oam/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 28c5d3fe5dfe1a9128e0e10c334420fc2670af58 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:49 -0400 Subject: [PATCH 174/281] opensearch: linter changes --- internal/service/opensearch/domain_test.go | 3 --- internal/service/opensearch/service_endpoints_gen_test.go | 2 -- internal/service/opensearch/vpc_endpoint_test.go | 1 - 3 files changed, 6 deletions(-) diff --git a/internal/service/opensearch/domain_test.go b/internal/service/opensearch/domain_test.go index 12d92f84344a..fa6124e49c40 100644 --- a/internal/service/opensearch/domain_test.go +++ b/internal/service/opensearch/domain_test.go @@ -38,7 +38,6 @@ func TestEBSVolumeTypePermitsIopsInput(t *testing.T) { {"standard", awstypes.VolumeTypeStandard, false}, } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -64,7 +63,6 @@ func TestEBSVolumeTypePermitsThroughputInput(t *testing.T) { {"standard", awstypes.VolumeTypeStandard, false}, } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -108,7 +106,6 @@ func TestParseEngineVersion(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() diff --git a/internal/service/opensearch/service_endpoints_gen_test.go b/internal/service/opensearch/service_endpoints_gen_test.go index 0f93cc0db046..eef9ab08dae9 100644 --- a/internal/service/opensearch/service_endpoints_gen_test.go +++ b/internal/service/opensearch/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/opensearch/vpc_endpoint_test.go b/internal/service/opensearch/vpc_endpoint_test.go index b307d81ae49e..e2cc0471c811 100644 --- a/internal/service/opensearch/vpc_endpoint_test.go +++ b/internal/service/opensearch/vpc_endpoint_test.go @@ -86,7 +86,6 @@ func TestVPCEndpointErrorsNotFound(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() From 5a8ce63254eb3ce116801749708257f90392eebe Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:49 -0400 Subject: [PATCH 175/281] opensearchserverless: linter changes --- .../service/opensearchserverless/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/opensearchserverless/service_endpoints_gen_test.go b/internal/service/opensearchserverless/service_endpoints_gen_test.go index 9ebb72f97b52..febf88f63004 100644 --- a/internal/service/opensearchserverless/service_endpoints_gen_test.go +++ b/internal/service/opensearchserverless/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 04dbd0eaf303f353f64a4db63243408aa617e947 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:49 -0400 Subject: [PATCH 176/281] opsworks: linter changes --- internal/service/opsworks/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/opsworks/service_endpoints_gen_test.go b/internal/service/opsworks/service_endpoints_gen_test.go index 1544e193c0a8..bdba67673351 100644 --- a/internal/service/opsworks/service_endpoints_gen_test.go +++ b/internal/service/opsworks/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 144375c5b42f8b27e3f43a8fb3bd4dfb2f9c5ba2 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:49 -0400 Subject: [PATCH 177/281] organizations: linter changes --- internal/service/organizations/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/organizations/service_endpoints_gen_test.go b/internal/service/organizations/service_endpoints_gen_test.go index 3941633f6047..4e9a6e88cb30 100644 --- a/internal/service/organizations/service_endpoints_gen_test.go +++ b/internal/service/organizations/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 1eb891bcf4a52e68a93ec8af82515663f7cfa317 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:49 -0400 Subject: [PATCH 178/281] osis: linter changes --- internal/service/osis/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/osis/service_endpoints_gen_test.go b/internal/service/osis/service_endpoints_gen_test.go index 940518484c64..d4d97d9d4dc4 100644 --- a/internal/service/osis/service_endpoints_gen_test.go +++ b/internal/service/osis/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From e7bf08e57a98b8ea51f028704f3098fcb91f123a Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:49 -0400 Subject: [PATCH 179/281] outposts: linter changes --- internal/service/outposts/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/outposts/service_endpoints_gen_test.go b/internal/service/outposts/service_endpoints_gen_test.go index 20f8a88078c2..cc990b584db6 100644 --- a/internal/service/outposts/service_endpoints_gen_test.go +++ b/internal/service/outposts/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 59981d1ff39aa429199d354680ecd3543b5c5f7b Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:49 -0400 Subject: [PATCH 180/281] pcaconnectorad: linter changes --- internal/service/pcaconnectorad/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/pcaconnectorad/service_endpoints_gen_test.go b/internal/service/pcaconnectorad/service_endpoints_gen_test.go index fd53a886ea91..2b2bad618765 100644 --- a/internal/service/pcaconnectorad/service_endpoints_gen_test.go +++ b/internal/service/pcaconnectorad/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 045b169513cac8d265bd7aa1078c456ac9d130aa Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:49 -0400 Subject: [PATCH 181/281] pinpoint: linter changes --- internal/service/pinpoint/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/pinpoint/service_endpoints_gen_test.go b/internal/service/pinpoint/service_endpoints_gen_test.go index a0134fe633eb..b6bcf3c1adc9 100644 --- a/internal/service/pinpoint/service_endpoints_gen_test.go +++ b/internal/service/pinpoint/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From e64746491ec2dbc8957a8e353742c3170fee4937 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:49 -0400 Subject: [PATCH 182/281] pipes: linter changes --- internal/service/pipes/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/pipes/service_endpoints_gen_test.go b/internal/service/pipes/service_endpoints_gen_test.go index 6996fb58beeb..25068067d320 100644 --- a/internal/service/pipes/service_endpoints_gen_test.go +++ b/internal/service/pipes/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 614a3a1126c852d89024f2728e0890da4c91decf Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:50 -0400 Subject: [PATCH 183/281] polly: linter changes --- internal/service/polly/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/polly/service_endpoints_gen_test.go b/internal/service/polly/service_endpoints_gen_test.go index 1b12cee4ca55..068a895a2877 100644 --- a/internal/service/polly/service_endpoints_gen_test.go +++ b/internal/service/polly/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 8a95c0e3a7f9a9b397cef469144aec28e4eb8db6 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:50 -0400 Subject: [PATCH 184/281] pricing: linter changes --- internal/service/pricing/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/pricing/service_endpoints_gen_test.go b/internal/service/pricing/service_endpoints_gen_test.go index 00c87d520191..572b3ea9ad29 100644 --- a/internal/service/pricing/service_endpoints_gen_test.go +++ b/internal/service/pricing/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 793ac7e9b46886c2291de757f647432fcd0e300e Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:50 -0400 Subject: [PATCH 185/281] qbusiness: linter changes --- internal/service/qbusiness/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/qbusiness/service_endpoints_gen_test.go b/internal/service/qbusiness/service_endpoints_gen_test.go index dd995ba0375d..8cc702aeadda 100644 --- a/internal/service/qbusiness/service_endpoints_gen_test.go +++ b/internal/service/qbusiness/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From ad85f95079612ae68f8974a199bd22556c622b2a Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:50 -0400 Subject: [PATCH 186/281] qldb: linter changes --- internal/service/qldb/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/qldb/service_endpoints_gen_test.go b/internal/service/qldb/service_endpoints_gen_test.go index c3ed46c410c7..104c675b096e 100644 --- a/internal/service/qldb/service_endpoints_gen_test.go +++ b/internal/service/qldb/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 41d2d10a85788005c6f5fab8dc2234ad75e5f719 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:50 -0400 Subject: [PATCH 187/281] quicksight: linter changes --- internal/service/quicksight/flex_test.go | 1 - internal/service/quicksight/service_endpoints_gen_test.go | 2 -- 2 files changed, 3 deletions(-) diff --git a/internal/service/quicksight/flex_test.go b/internal/service/quicksight/flex_test.go index b2a5f55e9bfb..4bd123de079a 100644 --- a/internal/service/quicksight/flex_test.go +++ b/internal/service/quicksight/flex_test.go @@ -214,7 +214,6 @@ func TestDataSourcePermissionsDiff(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() diff --git a/internal/service/quicksight/service_endpoints_gen_test.go b/internal/service/quicksight/service_endpoints_gen_test.go index c0468f9f4bea..4d09e787fcfa 100644 --- a/internal/service/quicksight/service_endpoints_gen_test.go +++ b/internal/service/quicksight/service_endpoints_gen_test.go @@ -231,8 +231,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 0a9d43a23b1e8469e03c101949aba74b5505ec79 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:50 -0400 Subject: [PATCH 188/281] ram: linter changes --- internal/service/ram/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/ram/service_endpoints_gen_test.go b/internal/service/ram/service_endpoints_gen_test.go index 562edb8339cd..388a40471641 100644 --- a/internal/service/ram/service_endpoints_gen_test.go +++ b/internal/service/ram/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 1a677fe0a3cf1c3f4f0fbda3f177c947e709a888 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:50 -0400 Subject: [PATCH 189/281] rbin: linter changes --- internal/service/rbin/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/rbin/service_endpoints_gen_test.go b/internal/service/rbin/service_endpoints_gen_test.go index c8dcffc3425a..9b2cfc1dc629 100644 --- a/internal/service/rbin/service_endpoints_gen_test.go +++ b/internal/service/rbin/service_endpoints_gen_test.go @@ -290,8 +290,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 5610e34883290df9e72d19c208dd0fc556924589 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:50 -0400 Subject: [PATCH 190/281] rds: linter changes --- internal/service/rds/engine_version_test.go | 1 - internal/service/rds/global_cluster_test.go | 1 - internal/service/rds/service_endpoints_gen_test.go | 2 -- 3 files changed, 4 deletions(-) diff --git a/internal/service/rds/engine_version_test.go b/internal/service/rds/engine_version_test.go index 2912f5b9661c..d575be8ae61a 100644 --- a/internal/service/rds/engine_version_test.go +++ b/internal/service/rds/engine_version_test.go @@ -85,7 +85,6 @@ func TestCompareActualEngineVersion(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/service/rds/global_cluster_test.go b/internal/service/rds/global_cluster_test.go index 0a9abfd2ab7d..6f7fb06fe568 100644 --- a/internal/service/rds/global_cluster_test.go +++ b/internal/service/rds/global_cluster_test.go @@ -79,7 +79,6 @@ func TestClusterIDAndRegionFromARN(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() diff --git a/internal/service/rds/service_endpoints_gen_test.go b/internal/service/rds/service_endpoints_gen_test.go index 6543f92d5e48..d69a90058131 100644 --- a/internal/service/rds/service_endpoints_gen_test.go +++ b/internal/service/rds/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From dcd1ffbb3fc73a5d90cc8cdae357d9917405b320 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:50 -0400 Subject: [PATCH 191/281] redshift: linter changes --- internal/service/redshift/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/redshift/service_endpoints_gen_test.go b/internal/service/redshift/service_endpoints_gen_test.go index f3c01626b398..d26c09269c18 100644 --- a/internal/service/redshift/service_endpoints_gen_test.go +++ b/internal/service/redshift/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 5aac7b1177c7f7620b02bb3678932b3574861d9b Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:50 -0400 Subject: [PATCH 192/281] redshiftdata: linter changes --- internal/service/redshiftdata/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/redshiftdata/service_endpoints_gen_test.go b/internal/service/redshiftdata/service_endpoints_gen_test.go index c0ee43c23b4a..abff32bcec6f 100644 --- a/internal/service/redshiftdata/service_endpoints_gen_test.go +++ b/internal/service/redshiftdata/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 6e8718db520ae0e319c9cd56ac43d305a0043c4a Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:50 -0400 Subject: [PATCH 193/281] redshiftserverless: linter changes --- .../service/redshiftserverless/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/redshiftserverless/service_endpoints_gen_test.go b/internal/service/redshiftserverless/service_endpoints_gen_test.go index 4031ac2bb0ee..05bf218fb32f 100644 --- a/internal/service/redshiftserverless/service_endpoints_gen_test.go +++ b/internal/service/redshiftserverless/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 735e2028880ce18844bea21b5b257760cf99d6fa Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:50 -0400 Subject: [PATCH 194/281] rekognition: linter changes --- internal/service/rekognition/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/rekognition/service_endpoints_gen_test.go b/internal/service/rekognition/service_endpoints_gen_test.go index 22fde1ae7a83..f840a7c9cbc2 100644 --- a/internal/service/rekognition/service_endpoints_gen_test.go +++ b/internal/service/rekognition/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From bb61c0b40afeab18984cee500213780e601264b8 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:50 -0400 Subject: [PATCH 195/281] resiliencehub: linter changes --- internal/service/resiliencehub/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/resiliencehub/service_endpoints_gen_test.go b/internal/service/resiliencehub/service_endpoints_gen_test.go index a6dee7944c5e..c7e61aed281d 100644 --- a/internal/service/resiliencehub/service_endpoints_gen_test.go +++ b/internal/service/resiliencehub/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From af31fc0528a51e86b726c302a205395874675f18 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:50 -0400 Subject: [PATCH 196/281] resourceexplorer2: linter changes --- .../service/resourceexplorer2/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/resourceexplorer2/service_endpoints_gen_test.go b/internal/service/resourceexplorer2/service_endpoints_gen_test.go index 12047d59f131..c597113c602b 100644 --- a/internal/service/resourceexplorer2/service_endpoints_gen_test.go +++ b/internal/service/resourceexplorer2/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From d432a659e4cd16aea21a3c3b6974308748dd03aa Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:50 -0400 Subject: [PATCH 197/281] resourcegroups: linter changes --- internal/service/resourcegroups/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/resourcegroups/service_endpoints_gen_test.go b/internal/service/resourcegroups/service_endpoints_gen_test.go index c7511e0323f8..d089416a4475 100644 --- a/internal/service/resourcegroups/service_endpoints_gen_test.go +++ b/internal/service/resourcegroups/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From d0c4cc9dfba3102d16e89776211c7af2657719ee Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:51 -0400 Subject: [PATCH 198/281] resourcegroupstaggingapi: linter changes --- .../resourcegroupstaggingapi/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/resourcegroupstaggingapi/service_endpoints_gen_test.go b/internal/service/resourcegroupstaggingapi/service_endpoints_gen_test.go index 3fd6010e792a..95212e156503 100644 --- a/internal/service/resourcegroupstaggingapi/service_endpoints_gen_test.go +++ b/internal/service/resourcegroupstaggingapi/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 6ccb1b0b218fa0fa0dee13ec352ed06fbba1dbbb Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:51 -0400 Subject: [PATCH 199/281] rolesanywhere: linter changes --- internal/service/rolesanywhere/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/rolesanywhere/service_endpoints_gen_test.go b/internal/service/rolesanywhere/service_endpoints_gen_test.go index e8b6e4292dea..ba6b0957bfaa 100644 --- a/internal/service/rolesanywhere/service_endpoints_gen_test.go +++ b/internal/service/rolesanywhere/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From ea2da4c3cc2308cb44585c555a67121172956e90 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:51 -0400 Subject: [PATCH 200/281] route53: linter changes --- internal/service/route53/record_flex_test.go | 1 - internal/service/route53/service_endpoints_gen_test.go | 2 -- 2 files changed, 3 deletions(-) diff --git a/internal/service/route53/record_flex_test.go b/internal/service/route53/record_flex_test.go index 95a8cce785af..c820ee969609 100644 --- a/internal/service/route53/record_flex_test.go +++ b/internal/service/route53/record_flex_test.go @@ -111,7 +111,6 @@ func TestParseRecordID(t *testing.T) { } for _, tc := range cases { - tc := tc t.Run(tc.Input, func(t *testing.T) { t.Parallel() diff --git a/internal/service/route53/service_endpoints_gen_test.go b/internal/service/route53/service_endpoints_gen_test.go index 5676b3df7f2f..bb74a0f71021 100644 --- a/internal/service/route53/service_endpoints_gen_test.go +++ b/internal/service/route53/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 7a68511c426d35a1fc8c95d49ac94adc726de263 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:51 -0400 Subject: [PATCH 201/281] route53domains: linter changes --- internal/service/route53domains/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/route53domains/service_endpoints_gen_test.go b/internal/service/route53domains/service_endpoints_gen_test.go index e19416d84c56..262e075d1bf2 100644 --- a/internal/service/route53domains/service_endpoints_gen_test.go +++ b/internal/service/route53domains/service_endpoints_gen_test.go @@ -237,8 +237,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From b0c24d1db523cfef064d33845e19be4d70b7f55d Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:51 -0400 Subject: [PATCH 202/281] route53recoverycontrolconfig: linter changes --- .../route53recoverycontrolconfig/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/route53recoverycontrolconfig/service_endpoints_gen_test.go b/internal/service/route53recoverycontrolconfig/service_endpoints_gen_test.go index fdfb9782b76b..7722a9407c0b 100644 --- a/internal/service/route53recoverycontrolconfig/service_endpoints_gen_test.go +++ b/internal/service/route53recoverycontrolconfig/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From b7111d08b4a6954bc2b7a8425dfa3f9532a4cda4 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:51 -0400 Subject: [PATCH 203/281] route53recoveryreadiness: linter changes --- .../route53recoveryreadiness/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/route53recoveryreadiness/service_endpoints_gen_test.go b/internal/service/route53recoveryreadiness/service_endpoints_gen_test.go index 997898501cc1..c4d07b12b97c 100644 --- a/internal/service/route53recoveryreadiness/service_endpoints_gen_test.go +++ b/internal/service/route53recoveryreadiness/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From e872bfe7f6dc02a2d1549feec004d20d4f890e72 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:51 -0400 Subject: [PATCH 204/281] route53resolver: linter changes --- internal/service/route53resolver/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/route53resolver/service_endpoints_gen_test.go b/internal/service/route53resolver/service_endpoints_gen_test.go index 8f540d685772..e2795c18f0e5 100644 --- a/internal/service/route53resolver/service_endpoints_gen_test.go +++ b/internal/service/route53resolver/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From c688513a615340b574674534f73b780d152044fb Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:51 -0400 Subject: [PATCH 205/281] rum: linter changes --- internal/service/rum/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/rum/service_endpoints_gen_test.go b/internal/service/rum/service_endpoints_gen_test.go index 30590c71de84..c4796b1b661d 100644 --- a/internal/service/rum/service_endpoints_gen_test.go +++ b/internal/service/rum/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From baf78169dbb866491ea9244269df13c9573d680c Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:51 -0400 Subject: [PATCH 206/281] s3: linter changes --- internal/service/s3/bucket_acl_test.go | 1 - internal/service/s3/id_test.go | 1 - internal/service/s3/object_test.go | 1 - internal/service/s3/service_endpoints_gen_test.go | 2 -- 4 files changed, 5 deletions(-) diff --git a/internal/service/s3/bucket_acl_test.go b/internal/service/s3/bucket_acl_test.go index 918def2c9f9e..cadf95366571 100644 --- a/internal/service/s3/bucket_acl_test.go +++ b/internal/service/s3/bucket_acl_test.go @@ -227,7 +227,6 @@ func TestBucketACLParseResourceID(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() diff --git a/internal/service/s3/id_test.go b/internal/service/s3/id_test.go index 043760d7e639..0fcd42e41cab 100644 --- a/internal/service/s3/id_test.go +++ b/internal/service/s3/id_test.go @@ -44,7 +44,6 @@ func TestParseResourceID(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() diff --git a/internal/service/s3/object_test.go b/internal/service/s3/object_test.go index d638d3078652..0cb1cb8b7647 100644 --- a/internal/service/s3/object_test.go +++ b/internal/service/s3/object_test.go @@ -96,7 +96,6 @@ func TestSDKv1CompatibleCleanKey(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() diff --git a/internal/service/s3/service_endpoints_gen_test.go b/internal/service/s3/service_endpoints_gen_test.go index f86ff5a64351..a64d2210cde8 100644 --- a/internal/service/s3/service_endpoints_gen_test.go +++ b/internal/service/s3/service_endpoints_gen_test.go @@ -413,8 +413,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 34f511af8586dee3a4c18af1cfbb9ac7ee4dfa87 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:51 -0400 Subject: [PATCH 207/281] s3outposts: linter changes --- internal/service/s3outposts/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/s3outposts/service_endpoints_gen_test.go b/internal/service/s3outposts/service_endpoints_gen_test.go index 252b1be22bec..77db070505ff 100644 --- a/internal/service/s3outposts/service_endpoints_gen_test.go +++ b/internal/service/s3outposts/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From d678574d0b79f29bcf6ff968f7259c0fe6e750cb Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:51 -0400 Subject: [PATCH 208/281] sagemaker: linter changes --- internal/service/sagemaker/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/sagemaker/service_endpoints_gen_test.go b/internal/service/sagemaker/service_endpoints_gen_test.go index 0a336ae0082c..cf3e4873ad36 100644 --- a/internal/service/sagemaker/service_endpoints_gen_test.go +++ b/internal/service/sagemaker/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 769d89e3ecd6fb0da3f3becd61648158b35a7ab2 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:51 -0400 Subject: [PATCH 209/281] scheduler: linter changes --- internal/service/scheduler/schedule_test.go | 2 -- internal/service/scheduler/service_endpoints_gen_test.go | 2 -- 2 files changed, 4 deletions(-) diff --git a/internal/service/scheduler/schedule_test.go b/internal/service/scheduler/schedule_test.go index 63e0dd32686a..6602e11394d6 100644 --- a/internal/service/scheduler/schedule_test.go +++ b/internal/service/scheduler/schedule_test.go @@ -68,7 +68,6 @@ func TestResourceScheduleIDFromARN(t *testing.T) { } for _, tc := range testCases { - tc := tc t.Run(tc.ARN, func(t *testing.T) { t.Parallel() @@ -151,7 +150,6 @@ func TestResourceScheduleParseID(t *testing.T) { } for _, tc := range testCases { - tc := tc t.Run(tc.ID, func(t *testing.T) { t.Parallel() diff --git a/internal/service/scheduler/service_endpoints_gen_test.go b/internal/service/scheduler/service_endpoints_gen_test.go index a4a51a32daff..e5fa55efc7f6 100644 --- a/internal/service/scheduler/service_endpoints_gen_test.go +++ b/internal/service/scheduler/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 0d6834dc89a88136f74e8b357805fa3a04a6ee42 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:51 -0400 Subject: [PATCH 210/281] schemas: linter changes --- internal/service/schemas/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/schemas/service_endpoints_gen_test.go b/internal/service/schemas/service_endpoints_gen_test.go index 81388037caad..d4c3ef094458 100644 --- a/internal/service/schemas/service_endpoints_gen_test.go +++ b/internal/service/schemas/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From bb7a83a2485a95666509b815433c1d6fd5e8fb01 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:51 -0400 Subject: [PATCH 211/281] secretsmanager: linter changes --- internal/service/secretsmanager/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/secretsmanager/service_endpoints_gen_test.go b/internal/service/secretsmanager/service_endpoints_gen_test.go index c16b66c3db2d..205f0423bd3a 100644 --- a/internal/service/secretsmanager/service_endpoints_gen_test.go +++ b/internal/service/secretsmanager/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From c49fdf0164d6929691eeedd92e6e83528519e94e Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:52 -0400 Subject: [PATCH 212/281] securityhub: linter changes --- internal/service/securityhub/service_endpoints_gen_test.go | 2 -- internal/service/securityhub/standards_control_test.go | 1 - 2 files changed, 3 deletions(-) diff --git a/internal/service/securityhub/service_endpoints_gen_test.go b/internal/service/securityhub/service_endpoints_gen_test.go index 944ac88fa5bc..b81c7bd63af0 100644 --- a/internal/service/securityhub/service_endpoints_gen_test.go +++ b/internal/service/securityhub/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/securityhub/standards_control_test.go b/internal/service/securityhub/standards_control_test.go index 177dd4d44b55..5ed2036ddddf 100644 --- a/internal/service/securityhub/standards_control_test.go +++ b/internal/service/securityhub/standards_control_test.go @@ -56,7 +56,6 @@ func TestStandardsControlARNToStandardsSubscriptionARN(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() From 65871a774dc6103ba616aaa4220b7f0ac3801e51 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:52 -0400 Subject: [PATCH 213/281] securitylake: linter changes --- internal/service/securitylake/data_lake.go | 1 - internal/service/securitylake/service_endpoints_gen_test.go | 2 -- 2 files changed, 3 deletions(-) diff --git a/internal/service/securitylake/data_lake.go b/internal/service/securitylake/data_lake.go index 9ff71fe5d717..1850f8d71f68 100644 --- a/internal/service/securitylake/data_lake.go +++ b/internal/service/securitylake/data_lake.go @@ -395,7 +395,6 @@ func findDataLakes(ctx context.Context, conn *securitylake.Client, input *securi } for _, v := range output.DataLakes { - v := v if v := &v; filter(v) { dataLakes = append(dataLakes, v) } diff --git a/internal/service/securitylake/service_endpoints_gen_test.go b/internal/service/securitylake/service_endpoints_gen_test.go index 5ae32c53f8df..880f18899872 100644 --- a/internal/service/securitylake/service_endpoints_gen_test.go +++ b/internal/service/securitylake/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From c572ed9fe04d7529fa2fd3c87b0437163d43fc06 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:52 -0400 Subject: [PATCH 214/281] serverlessrepo: linter changes --- internal/service/serverlessrepo/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/serverlessrepo/service_endpoints_gen_test.go b/internal/service/serverlessrepo/service_endpoints_gen_test.go index 49dddd1f5a5b..b7837043ae7c 100644 --- a/internal/service/serverlessrepo/service_endpoints_gen_test.go +++ b/internal/service/serverlessrepo/service_endpoints_gen_test.go @@ -348,8 +348,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 2b49a0817ee1287e64f9299218c81587153f17f9 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:52 -0400 Subject: [PATCH 215/281] servicecatalog: linter changes --- internal/service/servicecatalog/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/servicecatalog/service_endpoints_gen_test.go b/internal/service/servicecatalog/service_endpoints_gen_test.go index 752946ada599..28217b7c2b18 100644 --- a/internal/service/servicecatalog/service_endpoints_gen_test.go +++ b/internal/service/servicecatalog/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 0ba73c0a093169c11da1cf6fc44688f33f01ce81 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:52 -0400 Subject: [PATCH 216/281] servicecatalogappregistry: linter changes --- .../servicecatalogappregistry/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/servicecatalogappregistry/service_endpoints_gen_test.go b/internal/service/servicecatalogappregistry/service_endpoints_gen_test.go index 66220fd8c544..54e0855d0b11 100644 --- a/internal/service/servicecatalogappregistry/service_endpoints_gen_test.go +++ b/internal/service/servicecatalogappregistry/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From afc246314247ebd5d258ffc106c3f1b51601efe1 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:52 -0400 Subject: [PATCH 217/281] servicediscovery: linter changes --- internal/service/servicediscovery/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/servicediscovery/service_endpoints_gen_test.go b/internal/service/servicediscovery/service_endpoints_gen_test.go index 13c0161c27f1..be14ff4c01e9 100644 --- a/internal/service/servicediscovery/service_endpoints_gen_test.go +++ b/internal/service/servicediscovery/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 60a47f0c87c6c045c634dfb8522b4dcd948cb850 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:52 -0400 Subject: [PATCH 218/281] servicequotas: linter changes --- internal/service/servicequotas/service_data_source.go | 1 - internal/service/servicequotas/service_endpoints_gen_test.go | 2 -- 2 files changed, 3 deletions(-) diff --git a/internal/service/servicequotas/service_data_source.go b/internal/service/servicequotas/service_data_source.go index 92b970b55923..c4bde8c1b419 100644 --- a/internal/service/servicequotas/service_data_source.go +++ b/internal/service/servicequotas/service_data_source.go @@ -51,7 +51,6 @@ func dataSourceServiceRead(ctx context.Context, d *schema.ResourceData, meta int } for _, s := range page.Services { - s := s if aws.ToString(s.ServiceName) == serviceName { service = &s break diff --git a/internal/service/servicequotas/service_endpoints_gen_test.go b/internal/service/servicequotas/service_endpoints_gen_test.go index 172d188825f6..230b908f04a0 100644 --- a/internal/service/servicequotas/service_endpoints_gen_test.go +++ b/internal/service/servicequotas/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 7f840af3b83b09a7ea3b5ecb93e7dac21a73849f Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:52 -0400 Subject: [PATCH 219/281] ses: linter changes --- internal/service/ses/service_endpoints_gen_test.go | 2 -- internal/service/ses/sweep.go | 2 -- 2 files changed, 4 deletions(-) diff --git a/internal/service/ses/service_endpoints_gen_test.go b/internal/service/ses/service_endpoints_gen_test.go index 1183f1ca75dd..07bf3c623d9d 100644 --- a/internal/service/ses/service_endpoints_gen_test.go +++ b/internal/service/ses/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/ses/sweep.go b/internal/service/ses/sweep.go index 28cae5330d4c..5fe143b43919 100644 --- a/internal/service/ses/sweep.go +++ b/internal/service/ses/sweep.go @@ -109,8 +109,6 @@ func sweepIdentities(region, identityType string) error { } for _, identity := range output.Identities { - identity := identity - log.Printf("[INFO] Deleting SES Identity: %s", identity) _, err = conn.DeleteIdentity(ctx, &ses.DeleteIdentityInput{ Identity: aws.String(identity), From 44890473cf31d1b07a16eb8190a19be68a84dc65 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:52 -0400 Subject: [PATCH 220/281] sesv2: linter changes --- internal/service/sesv2/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/sesv2/service_endpoints_gen_test.go b/internal/service/sesv2/service_endpoints_gen_test.go index f95a22b454b0..c485b4147029 100644 --- a/internal/service/sesv2/service_endpoints_gen_test.go +++ b/internal/service/sesv2/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From e4d3f6f29d4b6d42317d614c5f07c5e00d234eba Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:52 -0400 Subject: [PATCH 221/281] sfn: linter changes --- internal/service/sfn/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/sfn/service_endpoints_gen_test.go b/internal/service/sfn/service_endpoints_gen_test.go index 63aae5da534e..7b3cb4c7bc6c 100644 --- a/internal/service/sfn/service_endpoints_gen_test.go +++ b/internal/service/sfn/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From db7fec29b25f151886276ef6fc0f89e902d9e0ab Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:52 -0400 Subject: [PATCH 222/281] shield: linter changes --- internal/service/shield/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/shield/service_endpoints_gen_test.go b/internal/service/shield/service_endpoints_gen_test.go index b3b2acfbecdf..d9d540345471 100644 --- a/internal/service/shield/service_endpoints_gen_test.go +++ b/internal/service/shield/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 99788018ac9260e157c6b2a062b212239ff4a82b Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:52 -0400 Subject: [PATCH 223/281] signer: linter changes --- internal/service/signer/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/signer/service_endpoints_gen_test.go b/internal/service/signer/service_endpoints_gen_test.go index 4b785ccd0fce..60d0bd857843 100644 --- a/internal/service/signer/service_endpoints_gen_test.go +++ b/internal/service/signer/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From c4e760ff795458ca4f3f91c7fd3c1afd83ca7f59 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:52 -0400 Subject: [PATCH 224/281] simpledb: linter changes --- internal/service/simpledb/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/simpledb/service_endpoints_gen_test.go b/internal/service/simpledb/service_endpoints_gen_test.go index d8083cc29926..8b4b63303e3c 100644 --- a/internal/service/simpledb/service_endpoints_gen_test.go +++ b/internal/service/simpledb/service_endpoints_gen_test.go @@ -285,8 +285,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 01c620abf8f1e84072897658fc470599bcb68666 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:52 -0400 Subject: [PATCH 225/281] sns: linter changes --- internal/service/sns/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/sns/service_endpoints_gen_test.go b/internal/service/sns/service_endpoints_gen_test.go index cc432e099d64..12949b7357b3 100644 --- a/internal/service/sns/service_endpoints_gen_test.go +++ b/internal/service/sns/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 4746a64b7c80a275c9782e0abc9361f190cda001 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:53 -0400 Subject: [PATCH 226/281] sqs: linter changes --- internal/service/sqs/queue_test.go | 1 - internal/service/sqs/service_endpoints_gen_test.go | 2 -- 2 files changed, 3 deletions(-) diff --git a/internal/service/sqs/queue_test.go b/internal/service/sqs/queue_test.go index 8c1841db1262..42930a38215c 100644 --- a/internal/service/sqs/queue_test.go +++ b/internal/service/sqs/queue_test.go @@ -72,7 +72,6 @@ func TestQueueNameFromURL(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Name, func(t *testing.T) { t.Parallel() diff --git a/internal/service/sqs/service_endpoints_gen_test.go b/internal/service/sqs/service_endpoints_gen_test.go index f10a5421d620..f67b33824571 100644 --- a/internal/service/sqs/service_endpoints_gen_test.go +++ b/internal/service/sqs/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From e8f30990b09739d30502885a644bf20f3b754453 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:53 -0400 Subject: [PATCH 227/281] ssm: linter changes --- internal/service/ssm/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/ssm/service_endpoints_gen_test.go b/internal/service/ssm/service_endpoints_gen_test.go index c325e7ec88db..f8db521cb85e 100644 --- a/internal/service/ssm/service_endpoints_gen_test.go +++ b/internal/service/ssm/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 89150c8db7cf2417ba4ac5b19ca78522ff5c904d Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:53 -0400 Subject: [PATCH 228/281] ssmcontacts: linter changes --- internal/service/ssmcontacts/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/ssmcontacts/service_endpoints_gen_test.go b/internal/service/ssmcontacts/service_endpoints_gen_test.go index e824fe850d89..d14100c0391e 100644 --- a/internal/service/ssmcontacts/service_endpoints_gen_test.go +++ b/internal/service/ssmcontacts/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 2759d75496a7515a3e22ef8f6747fef0e3a755ba Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:53 -0400 Subject: [PATCH 229/281] ssmincidents: linter changes --- internal/service/ssmincidents/service_endpoints_gen_test.go | 2 -- internal/service/ssmincidents/sweep.go | 4 +--- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/internal/service/ssmincidents/service_endpoints_gen_test.go b/internal/service/ssmincidents/service_endpoints_gen_test.go index 10a11fa8e262..b84ee10c6e26 100644 --- a/internal/service/ssmincidents/service_endpoints_gen_test.go +++ b/internal/service/ssmincidents/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) diff --git a/internal/service/ssmincidents/sweep.go b/internal/service/ssmincidents/sweep.go index 3627b4e2f3f7..2d576700d28f 100644 --- a/internal/service/ssmincidents/sweep.go +++ b/internal/service/ssmincidents/sweep.go @@ -47,9 +47,7 @@ func sweepReplicationSets(region string) error { return fmt.Errorf("error retrieving SSMIncidents Replication Sets: %w", err) } - for _, rs := range page.ReplicationSetArns { - id := rs - + for _, id := range page.ReplicationSetArns { r := ResourceReplicationSet() d := r.Data(nil) d.SetId(id) From 76f2292827af5df8a1078ce632cc759ff513067a Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:53 -0400 Subject: [PATCH 230/281] ssmsap: linter changes --- internal/service/ssmsap/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/ssmsap/service_endpoints_gen_test.go b/internal/service/ssmsap/service_endpoints_gen_test.go index 1d313c57f4e2..a2bbe6cc9476 100644 --- a/internal/service/ssmsap/service_endpoints_gen_test.go +++ b/internal/service/ssmsap/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 2560e5859e56bcd4c68637c5bfc41a16bf017ba1 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:53 -0400 Subject: [PATCH 231/281] sso: linter changes --- internal/service/sso/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/sso/service_endpoints_gen_test.go b/internal/service/sso/service_endpoints_gen_test.go index 79d5f3e7e2cb..db952c1bc0bb 100644 --- a/internal/service/sso/service_endpoints_gen_test.go +++ b/internal/service/sso/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 38bcef65e267c215cd9e8dac54dfffbb3ae83f97 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:53 -0400 Subject: [PATCH 232/281] ssoadmin: linter changes --- internal/service/ssoadmin/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/ssoadmin/service_endpoints_gen_test.go b/internal/service/ssoadmin/service_endpoints_gen_test.go index 772732ce7b75..2529b804269c 100644 --- a/internal/service/ssoadmin/service_endpoints_gen_test.go +++ b/internal/service/ssoadmin/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 4dae3b9e8cb3f59fdcf1de59800a38ac2c47afaf Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:53 -0400 Subject: [PATCH 233/281] storagegateway: linter changes --- internal/service/storagegateway/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/storagegateway/service_endpoints_gen_test.go b/internal/service/storagegateway/service_endpoints_gen_test.go index 536600315232..5cbdb500e67e 100644 --- a/internal/service/storagegateway/service_endpoints_gen_test.go +++ b/internal/service/storagegateway/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 4095799c5a1ef79fa72a821bccc00e7304cde4b9 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:53 -0400 Subject: [PATCH 234/281] sts: linter changes --- internal/service/sts/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/sts/service_endpoints_gen_test.go b/internal/service/sts/service_endpoints_gen_test.go index 02ee4a6b853e..2863e8c5f658 100644 --- a/internal/service/sts/service_endpoints_gen_test.go +++ b/internal/service/sts/service_endpoints_gen_test.go @@ -345,8 +345,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From e7532f99328757cf2a106c26f907a835faeb7ca0 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:53 -0400 Subject: [PATCH 235/281] swf: linter changes --- internal/service/swf/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/swf/service_endpoints_gen_test.go b/internal/service/swf/service_endpoints_gen_test.go index 229f75600335..8bfa684306cb 100644 --- a/internal/service/swf/service_endpoints_gen_test.go +++ b/internal/service/swf/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 388eea7113792500e5b01abcc95ed461f20eacc0 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:53 -0400 Subject: [PATCH 236/281] synthetics: linter changes --- internal/service/synthetics/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/synthetics/service_endpoints_gen_test.go b/internal/service/synthetics/service_endpoints_gen_test.go index 6e4c177055d3..dc7f104f4e42 100644 --- a/internal/service/synthetics/service_endpoints_gen_test.go +++ b/internal/service/synthetics/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 4dd2e4a583a71966aeb3a36dd9fe26b042abf483 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:53 -0400 Subject: [PATCH 237/281] timestreaminfluxdb: linter changes --- .../service/timestreaminfluxdb/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/timestreaminfluxdb/service_endpoints_gen_test.go b/internal/service/timestreaminfluxdb/service_endpoints_gen_test.go index 5bb3383356d2..6fa8464ece1e 100644 --- a/internal/service/timestreaminfluxdb/service_endpoints_gen_test.go +++ b/internal/service/timestreaminfluxdb/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 539e437272c1bc0e7884f3db642c136dad0391e1 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:53 -0400 Subject: [PATCH 238/281] timestreamwrite: linter changes --- internal/service/timestreamwrite/table_data_source_test.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/internal/service/timestreamwrite/table_data_source_test.go b/internal/service/timestreamwrite/table_data_source_test.go index 7e747e52e8e7..2c5244762e74 100644 --- a/internal/service/timestreamwrite/table_data_source_test.go +++ b/internal/service/timestreamwrite/table_data_source_test.go @@ -204,6 +204,7 @@ func TestAccTimestreamWriteTableDataSource_schema(t *testing.T) { }, }) } + func testAccCheckTableDatasourceDestroy(ctx context.Context, databaseName string, tableName string) resource.TestCheckFunc { return func(s *terraform.State) error { conn := acctest.Provider.Meta().(*conns.AWSClient).TimestreamWriteClient(ctx) @@ -216,9 +217,10 @@ func testAccCheckTableDatasourceDestroy(ctx context.Context, databaseName string return err } - return fmt.Errorf(("Timestream Table %s still exists" + databaseName + " " + tableName)) + return fmt.Errorf("Timestream database %s table %s still exists", databaseName, tableName) } } + func testAccCheckTableExistsNames(ctx context.Context, n string) resource.TestCheckFunc { return func(s *terraform.State) error { rs, ok := s.RootModule().Resources[n] From 3ee230738fef073cdd7ecbaadfeb3c7dbad4240a Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:53 -0400 Subject: [PATCH 239/281] transcribe: linter changes --- internal/service/transcribe/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/transcribe/service_endpoints_gen_test.go b/internal/service/transcribe/service_endpoints_gen_test.go index 9c97a6ad1ef6..1a67ffa06764 100644 --- a/internal/service/transcribe/service_endpoints_gen_test.go +++ b/internal/service/transcribe/service_endpoints_gen_test.go @@ -289,8 +289,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From a5afa6cdb56131724eaf140516240c61950450ff Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:54 -0400 Subject: [PATCH 240/281] transfer: linter changes --- internal/service/transfer/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/transfer/service_endpoints_gen_test.go b/internal/service/transfer/service_endpoints_gen_test.go index b58358c921ad..b9e3e7324ac6 100644 --- a/internal/service/transfer/service_endpoints_gen_test.go +++ b/internal/service/transfer/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From c9608fb8e87f892921dbbd29b5e2390d4db8e8a0 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:54 -0400 Subject: [PATCH 241/281] verifiedpermissions: linter changes --- .../service/verifiedpermissions/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/verifiedpermissions/service_endpoints_gen_test.go b/internal/service/verifiedpermissions/service_endpoints_gen_test.go index 140c9173c30d..1e1b82a2d462 100644 --- a/internal/service/verifiedpermissions/service_endpoints_gen_test.go +++ b/internal/service/verifiedpermissions/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From ca4d28562909f33cc6a68f72658f50490bbc602f Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:54 -0400 Subject: [PATCH 242/281] vpclattice: linter changes --- internal/service/vpclattice/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/vpclattice/service_endpoints_gen_test.go b/internal/service/vpclattice/service_endpoints_gen_test.go index fb33b6f70258..1e5a2db3050f 100644 --- a/internal/service/vpclattice/service_endpoints_gen_test.go +++ b/internal/service/vpclattice/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 7ec3ea3aadc52a5cf739a5918f610f6e7b08a59d Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:54 -0400 Subject: [PATCH 243/281] waf: linter changes --- internal/service/waf/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/waf/service_endpoints_gen_test.go b/internal/service/waf/service_endpoints_gen_test.go index 642494e18e3e..dd06d4c6f5c2 100644 --- a/internal/service/waf/service_endpoints_gen_test.go +++ b/internal/service/waf/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 22e062eb74f9bd7a23700a874c9049e096b0af21 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:54 -0400 Subject: [PATCH 244/281] wafregional: linter changes --- internal/service/wafregional/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/wafregional/service_endpoints_gen_test.go b/internal/service/wafregional/service_endpoints_gen_test.go index afc55486bddc..3527bd51233f 100644 --- a/internal/service/wafregional/service_endpoints_gen_test.go +++ b/internal/service/wafregional/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 62850a45663c551c7de799b9d00ddf3161ba19f6 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:54 -0400 Subject: [PATCH 245/281] wafv2: linter changes --- internal/service/wafv2/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/wafv2/service_endpoints_gen_test.go b/internal/service/wafv2/service_endpoints_gen_test.go index e7cea21c794d..cb8e8c3c8006 100644 --- a/internal/service/wafv2/service_endpoints_gen_test.go +++ b/internal/service/wafv2/service_endpoints_gen_test.go @@ -236,8 +236,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 720e2f5bd1244397115bd10d890bb1faf8a0c21b Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:54 -0400 Subject: [PATCH 246/281] wellarchitected: linter changes --- internal/service/wellarchitected/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/wellarchitected/service_endpoints_gen_test.go b/internal/service/wellarchitected/service_endpoints_gen_test.go index d2fecc3dafac..a05d8ec029b0 100644 --- a/internal/service/wellarchitected/service_endpoints_gen_test.go +++ b/internal/service/wellarchitected/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 403e70ba1f296b1b30388154083bdb5bba0558ba Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:54 -0400 Subject: [PATCH 247/281] worklink: linter changes --- internal/service/worklink/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/worklink/service_endpoints_gen_test.go b/internal/service/worklink/service_endpoints_gen_test.go index cca4803e6e75..cef34abc814b 100644 --- a/internal/service/worklink/service_endpoints_gen_test.go +++ b/internal/service/worklink/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From fe21a6687ba2a51dd4cd67358eb3a27a25322a9e Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:54 -0400 Subject: [PATCH 248/281] workspaces: linter changes --- internal/service/workspaces/ip_group.go | 3 +-- internal/service/workspaces/service_endpoints_gen_test.go | 2 -- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/internal/service/workspaces/ip_group.go b/internal/service/workspaces/ip_group.go index 5a8d0ca28f1f..b4c5dd88e02e 100644 --- a/internal/service/workspaces/ip_group.go +++ b/internal/service/workspaces/ip_group.go @@ -157,8 +157,7 @@ func resourceIPGroupDelete(ctx context.Context, d *schema.ResourceData, meta int diags = sdkdiag.AppendErrorf(diags, "describing WorkSpaces Directories: %s", err) } for _, dir := range out.Directories { - for _, ipg := range dir.IpGroupIds { - groupID := ipg + for _, groupID := range dir.IpGroupIds { if groupID == d.Id() { found = true log.Printf("[DEBUG] WorkSpaces IP Group (%s) associated with WorkSpaces Directory (%s), disassociating", groupID, aws.ToString(dir.DirectoryId)) diff --git a/internal/service/workspaces/service_endpoints_gen_test.go b/internal/service/workspaces/service_endpoints_gen_test.go index 06582940149b..9261f889c0a6 100644 --- a/internal/service/workspaces/service_endpoints_gen_test.go +++ b/internal/service/workspaces/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 9afb21076347a68c2a8da23c2d7e5102d21ddba6 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:54 -0400 Subject: [PATCH 249/281] workspacesweb: linter changes --- internal/service/workspacesweb/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/workspacesweb/service_endpoints_gen_test.go b/internal/service/workspacesweb/service_endpoints_gen_test.go index 52862c977dd8..c398aff3c9c0 100644 --- a/internal/service/workspacesweb/service_endpoints_gen_test.go +++ b/internal/service/workspacesweb/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 0a1b984b688283ae2bf6c7b7530614cc6a814d40 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:54 -0400 Subject: [PATCH 250/281] xray: linter changes --- internal/service/xray/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/xray/service_endpoints_gen_test.go b/internal/service/xray/service_endpoints_gen_test.go index ad1b3a8a0a3c..56a4665badeb 100644 --- a/internal/service/xray/service_endpoints_gen_test.go +++ b/internal/service/xray/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From ba5f93035188b40e548e4e1fcb1e1078e1fea295 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:54 -0400 Subject: [PATCH 251/281] slices: linter changes --- internal/slices/predicates_test.go | 2 -- internal/slices/slices_test.go | 8 -------- 2 files changed, 10 deletions(-) diff --git a/internal/slices/predicates_test.go b/internal/slices/predicates_test.go index f105d643ce67..5049286bb5ef 100644 --- a/internal/slices/predicates_test.go +++ b/internal/slices/predicates_test.go @@ -38,7 +38,6 @@ func TestPredicateAnd(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -88,7 +87,6 @@ func TestPredicateOr(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/slices/slices_test.go b/internal/slices/slices_test.go index 8be44a0d2531..35ea97b2621a 100644 --- a/internal/slices/slices_test.go +++ b/internal/slices/slices_test.go @@ -37,7 +37,6 @@ func TestReverse(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -107,7 +106,6 @@ func TestRemoveAll(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -143,7 +141,6 @@ func TestApplyToAll(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -183,7 +180,6 @@ func TestChunk(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -219,7 +215,6 @@ func TestFilter(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -276,7 +271,6 @@ func TestAppendUnique(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -316,7 +310,6 @@ func TestIndexOf(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -400,7 +393,6 @@ func TestRange(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() From 23ae8fb08c05fa92b9cea82232d29dd9a8647e15 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:54 -0400 Subject: [PATCH 252/281] sweep: linter changes --- internal/sweep/sweep.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/sweep/sweep.go b/internal/sweep/sweep.go index f6faabbc0b3e..ac076408bbf3 100644 --- a/internal/sweep/sweep.go +++ b/internal/sweep/sweep.go @@ -110,8 +110,6 @@ func SweepOrchestrator(ctx context.Context, sweepables []Sweepable, optFns ...tf var g multierror.Group for _, sweepable := range sweepables { - sweepable := sweepable - g.Go(func() error { return sweepable.Delete(ctx, ThrottlingRetryTimeout, optFns...) }) From 8e8457d992f3e0d035fcf9388c31eb09bb1e0f1c Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:54 -0400 Subject: [PATCH 253/281] tags: linter changes --- internal/tags/key_value_tags.go | 3 -- internal/tags/key_value_tags_test.go | 41 ---------------------------- internal/tags/tag_resources_test.go | 2 -- 3 files changed, 46 deletions(-) diff --git a/internal/tags/key_value_tags.go b/internal/tags/key_value_tags.go index bf4e92dd50db..a0012952fe44 100644 --- a/internal/tags/key_value_tags.go +++ b/internal/tags/key_value_tags.go @@ -571,7 +571,6 @@ func New(ctx context.Context, i interface{}) KeyValueTags { kvtm := make(KeyValueTags, len(value)) for k, v := range value { - v := v // Prevent referencing issues kvtm[k] = &TagData{Value: &v} } @@ -580,8 +579,6 @@ func New(ctx context.Context, i interface{}) KeyValueTags { kvtm := make(KeyValueTags, len(value)) for k, v := range value { - v := v - if v == nil { kvtm[k] = nil continue diff --git a/internal/tags/key_value_tags_test.go b/internal/tags/key_value_tags_test.go index 980a7ecd5c0b..d664b299792b 100644 --- a/internal/tags/key_value_tags_test.go +++ b/internal/tags/key_value_tags_test.go @@ -47,7 +47,6 @@ func TestKeyValueTagsDefaultConfigGetTags(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -193,7 +192,6 @@ func TestKeyValueTagsDefaultConfigMergeTags(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -304,7 +302,6 @@ func TestKeyValueTagsDefaultConfigTagsEqual(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -368,7 +365,6 @@ func TestKeyValueTagsIgnoreAWS(t *testing.T) { // nosemgrep:ci.aws-in-func-name } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -571,7 +567,6 @@ func TestKeyValueTagsIgnoreConfig(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -635,7 +630,6 @@ func TestKeyValueTagsIgnoreElasticbeanstalk(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -728,7 +722,6 @@ func TestKeyValueTagsIgnorePrefixes(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -796,7 +789,6 @@ func TestKeyValueTagsIgnoreSystem(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -877,7 +869,6 @@ func TestKeyValueTagsIgnore(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -959,8 +950,6 @@ func TestKeyValueTagsKeyAdditionalBoolValue(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase - t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -1052,8 +1041,6 @@ func TestKeyValueTagsKeyAdditionalStringValue(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase - t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -1111,7 +1098,6 @@ func TestKeyValueTagsKeyExists(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -1177,8 +1163,6 @@ func TestKeyValueTagsKeyTagData(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase - t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -1236,7 +1220,6 @@ func TestKeyValueTagsKeyValues(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -1359,7 +1342,6 @@ func TestKeyValueTagsKeys(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -1454,7 +1436,6 @@ func TestKeyValueTagsMap(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -1541,7 +1522,6 @@ func TestKeyValueTagsMerge(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -1621,7 +1601,6 @@ func TestKeyValueTagsOnly(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -1698,7 +1677,6 @@ func TestKeyValueTagsRemoved(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -1776,7 +1754,6 @@ func TestKeyValueTagsUpdated(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -1861,8 +1838,6 @@ func TestKeyValueTagsChunks(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase - t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -1964,7 +1939,6 @@ func TestKeyValueTagsContainsAll(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -2096,7 +2070,6 @@ func TestKeyValueTagsEqual(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -2143,8 +2116,6 @@ func TestKeyValueTagsHash(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase - t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -2281,7 +2252,6 @@ func TestKeyValueTagsRemoveDefaultConfig(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -2341,7 +2311,6 @@ func TestKeyValueTagsURLEncode(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -2403,7 +2372,6 @@ func TestKeyValueTagsURLQueryString(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -2560,8 +2528,6 @@ func TestNew(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase - t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -2719,8 +2685,6 @@ func TestTagDataEqual(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase - t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -2772,8 +2736,6 @@ func TestTagDataString(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase - t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -2816,8 +2778,6 @@ func TestToSnakeCase(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase - t.Run(testCase.Input, func(t *testing.T) { t.Parallel() @@ -2872,7 +2832,6 @@ func TestKeyValueTagsString(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() diff --git a/internal/tags/tag_resources_test.go b/internal/tags/tag_resources_test.go index 40b6190d7b35..6a864382f9cc 100644 --- a/internal/tags/tag_resources_test.go +++ b/internal/tags/tag_resources_test.go @@ -54,7 +54,6 @@ func TestGetResourceID(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Description, func(t *testing.T) { t.Parallel() @@ -101,7 +100,6 @@ func TestSetResourceId(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Description, func(t *testing.T) { t.Parallel() From ca3211bfd511c08a8471cd9075c38279b0f8e789 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:55 -0400 Subject: [PATCH 254/281] tfresource: linter changes --- internal/tfresource/errors_test.go | 3 --- internal/tfresource/not_found_error_test.go | 3 --- internal/tfresource/retry_test.go | 6 ------ 3 files changed, 12 deletions(-) diff --git a/internal/tfresource/errors_test.go b/internal/tfresource/errors_test.go index ccd602328d5c..1e22d70433e0 100644 --- a/internal/tfresource/errors_test.go +++ b/internal/tfresource/errors_test.go @@ -46,7 +46,6 @@ func TestNotFound(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Name, func(t *testing.T) { t.Parallel() @@ -99,7 +98,6 @@ func TestTimedOut(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Name, func(t *testing.T) { t.Parallel() @@ -170,7 +168,6 @@ func TestSetLastError(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.Name, func(t *testing.T) { t.Parallel() diff --git a/internal/tfresource/not_found_error_test.go b/internal/tfresource/not_found_error_test.go index 9a0e00eb46d1..1a760f512feb 100644 --- a/internal/tfresource/not_found_error_test.go +++ b/internal/tfresource/not_found_error_test.go @@ -79,7 +79,6 @@ func TestEmptyResultErrorIs(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -160,7 +159,6 @@ func TestTooManyResultsErrorIs(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -228,7 +226,6 @@ func TestAssertSinglePtrResult(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() diff --git a/internal/tfresource/retry_test.go b/internal/tfresource/retry_test.go index fe10a6c48b1f..2d09d3af1437 100644 --- a/internal/tfresource/retry_test.go +++ b/internal/tfresource/retry_test.go @@ -68,7 +68,6 @@ func TestRetryWhenAWSErrCodeEquals(t *testing.T) { // nosemgrep:ci.aws-in-func-n } for _, testCase := range testCases { //nolint:paralleltest - testCase := testCase t.Run(testCase.Name, func(t *testing.T) { retryCount = 0 @@ -135,7 +134,6 @@ func TestRetryWhenAWSErrMessageContains(t *testing.T) { // nosemgrep:ci.aws-in-f } for _, testCase := range testCases { //nolint:paralleltest - testCase := testCase t.Run(testCase.Name, func(t *testing.T) { retryCount = 0 @@ -226,7 +224,6 @@ func TestRetryWhenNewResourceNotFound(t *testing.T) { //nolint:tparallel } for _, testCase := range testCases { //nolint:paralleltest - testCase := testCase t.Run(testCase.Name, func(t *testing.T) { retryCount = 0 @@ -292,7 +289,6 @@ func TestRetryWhenNotFound(t *testing.T) { //nolint:tparallel } for _, testCase := range testCases { //nolint:paralleltest - testCase := testCase t.Run(testCase.Name, func(t *testing.T) { retryCount = 0 @@ -358,7 +354,6 @@ func TestRetryUntilNotFound(t *testing.T) { //nolint:tparallel } for _, testCase := range testCases { //nolint:paralleltest - testCase := testCase t.Run(testCase.Name, func(t *testing.T) { retryCount = 0 @@ -451,7 +446,6 @@ func TestOptionsApply(t *testing.T) { } for name, testCase := range testCases { - testCase := testCase t.Run(name, func(t *testing.T) { t.Parallel() From 1761b749b3a3a1b6a486a2b64bddc300eb0276a1 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:55 -0400 Subject: [PATCH 255/281] types: linter changes --- internal/types/duration/duration_test.go | 4 +--- internal/types/set_test.go | 3 --- internal/types/timestamp/timestamp_test.go | 3 --- internal/types/zero_test.go | 2 -- 4 files changed, 1 insertion(+), 11 deletions(-) diff --git a/internal/types/duration/duration_test.go b/internal/types/duration/duration_test.go index b3469890bc4f..fa963e568d57 100644 --- a/internal/types/duration/duration_test.go +++ b/internal/types/duration/duration_test.go @@ -75,7 +75,6 @@ func TestParse(t *testing.T) { } for name, tc := range testcases { - tc := tc t.Run(name, func(t *testing.T) { t.Parallel() @@ -103,7 +102,7 @@ func TestSub(t *testing.T) { now := time.Now() tz, err := time.LoadLocation("America/Vancouver") if err != nil { - t.Fatalf(err.Error()) + t.Fatal(err) } testcases := map[string]struct { @@ -149,7 +148,6 @@ func TestSub(t *testing.T) { } for name, tc := range testcases { - tc := tc t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/types/set_test.go b/internal/types/set_test.go index 7da36787a667..e198916b56f0 100644 --- a/internal/types/set_test.go +++ b/internal/types/set_test.go @@ -49,8 +49,6 @@ func TestSetDifference_ints(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase - t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -100,7 +98,6 @@ func TestSetDifference_strings(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/types/timestamp/timestamp_test.go b/internal/types/timestamp/timestamp_test.go index 8f7ac80ac452..1bf78e4c11c8 100644 --- a/internal/types/timestamp/timestamp_test.go +++ b/internal/types/timestamp/timestamp_test.go @@ -29,7 +29,6 @@ func TestValidateOnceADayWindowFormat(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -78,7 +77,6 @@ func TestValidateOnceAWeekWindowFormat(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() @@ -121,7 +119,6 @@ func TestValidateUTCFormat(t *testing.T) { } for name, test := range tests { - name, test := name, test t.Run(name, func(t *testing.T) { t.Parallel() diff --git a/internal/types/zero_test.go b/internal/types/zero_test.go index f90df68dbdf9..6ddba9bde37d 100644 --- a/internal/types/zero_test.go +++ b/internal/types/zero_test.go @@ -40,8 +40,6 @@ func TestIsZero(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase - t.Run(testCase.Name, func(t *testing.T) { t.Parallel() From 5ed6f5520eb6982298c8efd351d0d41a6f72eded Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:55 -0400 Subject: [PATCH 256/281] verify: linter changes --- internal/verify/json_test.go | 1 - internal/verify/validate_test.go | 5 ----- 2 files changed, 6 deletions(-) diff --git a/internal/verify/json_test.go b/internal/verify/json_test.go index 27a39aabb71d..b99881a4f091 100644 --- a/internal/verify/json_test.go +++ b/internal/verify/json_test.go @@ -788,7 +788,6 @@ func TestLegacyPolicyNormalize(t *testing.T) { } for _, tc := range testCases { - tc := tc t.Run(tc.Name, func(t *testing.T) { t.Parallel() diff --git a/internal/verify/validate_test.go b/internal/verify/validate_test.go index 449beb7339f3..8b6c2e89cf92 100644 --- a/internal/verify/validate_test.go +++ b/internal/verify/validate_test.go @@ -413,7 +413,6 @@ func TestValidIAMPolicyJSONString(t *testing.T) { }, } for _, test := range tests { - test := test t.Run(test.Value, func(t *testing.T) { t.Parallel() @@ -807,7 +806,6 @@ func TestMapKeyNoMatch(t *testing.T) { } f := MapKeyNoMatch(regexache.MustCompile(`^.*\d$`), "must not end with a digit") for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -848,7 +846,6 @@ func TestMapSizeAtMost(t *testing.T) { } f := MapSizeAtMost(4) for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -896,7 +893,6 @@ func TestMapSizeBetween(t *testing.T) { } f := MapSizeBetween(2, 4) for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -933,7 +929,6 @@ func TestMapKeysAre(t *testing.T) { } f := MapKeysAre(validation.ToDiagFunc(validation.StringInSlice([]string{"K1", "K2"}, false))) for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() From 6b34e8b16ed3783b0d7634e1e514945dfd0531bb Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:55 -0400 Subject: [PATCH 257/281] names: linter changes --- names/names_test.go | 9 --------- 1 file changed, 9 deletions(-) diff --git a/names/names_test.go b/names/names_test.go index 069f340a4dff..ef55ed8a6bf2 100644 --- a/names/names_test.go +++ b/names/names_test.go @@ -47,7 +47,6 @@ func TestDNSSuffixForPartition(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -94,7 +93,6 @@ func TestIsOptInRegion(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -141,7 +139,6 @@ func TestPartitionForRegion(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -188,7 +185,6 @@ func TestReverseDNS(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.name, func(t *testing.T) { t.Parallel() @@ -229,7 +225,6 @@ func TestProviderPackageForAlias(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() @@ -391,7 +386,6 @@ func TestServicesForDirectories(t *testing.T) { } for _, testCase := range ProviderPackages() { - testCase := testCase t.Run(testCase, func(t *testing.T) { t.Parallel() @@ -449,7 +443,6 @@ func TestProviderNameUpper(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() @@ -512,7 +505,6 @@ func TestFullHumanFriendly(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() @@ -581,7 +573,6 @@ func TestAWSGoV1ClientName(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() From 641432ba0148573c1a31dc9f78d55ec0f0339f9d Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:55 -0400 Subject: [PATCH 258/281] datasource: linter changes --- skaff/datasource/datasourcetest.tmpl | 1 - 1 file changed, 1 deletion(-) diff --git a/skaff/datasource/datasourcetest.tmpl b/skaff/datasource/datasourcetest.tmpl index a9c3f8c82116..f5aea172925f 100644 --- a/skaff/datasource/datasourcetest.tmpl +++ b/skaff/datasource/datasourcetest.tmpl @@ -132,7 +132,6 @@ func Test{{ .DataSource }}ExampleUnitTest(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() got, err := tf{{ .ServicePackage }}.FunctionFromDataSource(testCase.Input) From c7350f91f1bc4a6faa35bfb8ab161bbc1668025c Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 19:23:55 -0400 Subject: [PATCH 259/281] resource: linter changes --- skaff/resource/resourcetest.tmpl | 1 - 1 file changed, 1 deletion(-) diff --git a/skaff/resource/resourcetest.tmpl b/skaff/resource/resourcetest.tmpl index 5129beb33e1c..d2488da1423f 100644 --- a/skaff/resource/resourcetest.tmpl +++ b/skaff/resource/resourcetest.tmpl @@ -131,7 +131,6 @@ func Test{{ .Resource }}ExampleUnitTest(t *testing.T) { } for _, testCase := range testCases { - testCase := testCase t.Run(testCase.TestName, func(t *testing.T) { t.Parallel() got, err := tf{{ .ServicePackage }}.FunctionFromResource(testCase.Input) From 1152354cafebfc09b8531492b489ef7f35860b00 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 20:07:26 -0400 Subject: [PATCH 260/281] emr: Update for linters --- internal/service/emr/cluster.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/service/emr/cluster.go b/internal/service/emr/cluster.go index f65472c3be68..7e352f88bd96 100644 --- a/internal/service/emr/cluster.go +++ b/internal/service/emr/cluster.go @@ -1671,7 +1671,7 @@ func flattenEC2InstanceAttributes(apiObject *awstypes.Ec2InstanceAttributes) []i if apiObject.Ec2SubnetId != nil { tfMap[names.AttrSubnetID] = aws.ToString(apiObject.Ec2SubnetId) } - if apiObject.RequestedEc2SubnetIds != nil && len(apiObject.RequestedEc2SubnetIds) > 0 { + if len(apiObject.RequestedEc2SubnetIds) > 0 { tfMap[names.AttrSubnetIDs] = flex.FlattenStringValueSet(apiObject.RequestedEc2SubnetIds) } if apiObject.IamInstanceProfile != nil { From 8855a2edbcea13be365116c623e0ed22e319de58 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 20:07:55 -0400 Subject: [PATCH 261/281] ci/golangci-lint: Split linting to parallelize --- .ci/.golangci3.yml | 200 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 200 insertions(+) create mode 100644 .ci/.golangci3.yml diff --git a/.ci/.golangci3.yml b/.ci/.golangci3.yml new file mode 100644 index 000000000000..b14fa7fa45a7 --- /dev/null +++ b/.ci/.golangci3.yml @@ -0,0 +1,200 @@ +# IMPORTANT: Only add linters whose names start with letters N-Z here. +# Linters starting with A-M should be placed in .golangci2.yml. +issues: + exclude-rules: + - linters: + - paralleltest + text: "Function TestAcc" + - linters: + - staticcheck + text: "SA1019: \\w+.GetOkExists is deprecated: usage is discouraged due to undefined behaviors and may be removed in a future version of the SDK" + # tfsdk: schema.SchemaValidateFunc + - linters: + - staticcheck + text: "SA1019: schema.SchemaValidateFunc is deprecated: please use SchemaValidateDiagFunc" + # provider: acctest.ConfigAlternateRegionProvider + - linters: + - staticcheck + text: "SA1019: acctest.ConfigAlternateRegionProvider is deprecated: Use ConfigMultipleRegionProvider instead" + # tfsdk: MigrateState + - linters: + - staticcheck + text: "MigrateState is deprecated and any new changes to a resource's schema should be handled by StateUpgraders." + # Legacy CRUD + - linters: + - staticcheck + text: "SA1019: \\w+.\\w+ is deprecated: Use \\w+Context or \\w+WithoutTimeout instead" + # go: strings.Title + - linters: + - staticcheck + text: "SA1019: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0" + # Per-Service + - linters: + - staticcheck + path: internal/service/auditmanager/ + text: "SA1019: apiObject.AwsServices is deprecated" + - linters: + - staticcheck + path: internal/service/batch/ + text: "SA1019: apiObject.ImageId is deprecated: This field is deprecated" + - linters: + - staticcheck + path: internal/service/chime/ + text: "SA1019: conn.\\w+ is deprecated: Replaced by \\w+ in the Amazon Chime SDK Voice Namespace" + - linters: + - staticcheck + path: "internal/service/cloudfront" + text: "SA1019: \\w+.(\\w+) is deprecated: This member has been deprecated" + - linters: + - staticcheck + path: "internal/service/cloudtrail" + text: "SA1019: \\w+.(\\w+) is deprecated: This member has been deprecated" + - linters: + - staticcheck + path: internal/service/detective/ + text: "SA1019: member.VolumeUsageInBytes is deprecated: This property is deprecated. Use VolumeUsageByDatasourcePackage instead" + - linters: + - staticcheck + path: internal/service/ecr/ + text: "SA1019: params.RegistryIds is deprecated: This field is deprecated." + - linters: + - staticcheck + path: "internal/service/firehose" + text: "SA1019: \\w+.(\\w+) is deprecated: (\\w+) has been deprecated" + - linters: + - staticcheck + path: "internal/service/fsx" + text: "SA1019: \\w+.(\\w+) is deprecated: This property is deprecated" + - linters: + - staticcheck + path: internal/service/globalaccelerator/ + text: "SA1019: apiObject.IpFamily is deprecated: IpFamily has been replaced by IpAddressFamily" + - linters: + - staticcheck + path: internal/service/guardduty/ + text: "SA1019: \\w+.\\w+ is deprecated. This (input|operation|parameter|field) is deprecated" + - linters: + - staticcheck + path: internal/service/identitystore/ + text: "SA1019: \\w+.Filters is deprecated: Using filters with List\\w+ API is deprecated" + - linters: + - staticcheck + path: internal/service/kms/ + text: "SA1019: [a-zA-Z0-9.]+.CustomerMasterKeySpec is deprecated: This field has been deprecated. Instead, use the KeySpec field" + - linters: + - staticcheck + path: "internal/service/neptune" + text: "SA1019: \\w+.(\\w+) is deprecated:" + - linters: + - staticcheck + path: "internal/service/s3" + text: "SA1019: \\w+.(\\w+) is deprecated: (\\w+) has been deprecated" + - linters: + - staticcheck + path: "internal/service/s3" + text: "SA1019: \\w+.(\\w+) is deprecated: This member has been deprecated" + - linters: + - staticcheck + path: internal/service/securityhub/ + text: "SA1019: \\w+.(\\w+) is deprecated:" + - linters: + - staticcheck + path: internal/service/servicediscovery/ + text: "SA1019: \\w+.(\\w+) is deprecated:" + - linters: + - staticcheck + path: internal/service/wafv2/ + text: "SA1019: \\w+.(\\w+) is deprecated: Deprecated. Use" + - linters: + - staticcheck + path: internal/service/worklink/ + text: "SA1019: \\w+.(\\w+) is deprecated: Amazon WorkLink is no longer supported. This will be removed in a future version of the SDK." + - linters: + - unparam + text: "always receives" + # tfsdk: d.GetOkExists + - linters: + - tparallel + text: "TestAcc" + max-per-linter: 0 + max-same-issues: 0 + +linters: + disable-all: true + enable: + # !! only add n-z linters here, a-m linters go in .golangci2.yml + - nakedret + - nilerr + - nolintlint + - nosprintfhostport + - paralleltest + - predeclared + - revive + - staticcheck + - stylecheck + - tenv + - tparallel + - typecheck + - unconvert + - unparam + - unused + - usestdlibvars + - whitespace + # - perfsprint + # - thelper + +linters-settings: + nolintlint: + allow-unused: false + allow-leading-space: false + require-explanation: true + require-specific: true + allow-no-explanation: + - mnd + - paralleltest + - tparallel + - unparam + predeclared: + ignore: cap,close,copy,delete,len,new,min,max + revive: + # Recommended configuration. + # See https://github.com/mgechev/revive#recommended-configuration. + ignore-generated-header: true + severity: warning + confidence: 0.8 + error-code: 0 + warning-code: 0 + rules: + - name: atomic + - name: blank-imports + - name: context-as-argument + - name: context-keys-type + - name: dot-imports + - name: empty-block + - name: error-naming + - name: error-return + # - name: error-strings + - name: errorf + # - name: exported + # - name: if-return + # - name: increment-decrement + # - name: indent-error-flow + - name: package-comments + - name: range + - name: receiver-naming + # - name: redefines-builtin-id + - name: superfluous-else + - name: time-naming + # - name: unexported-return + - name: unreachable-code + # - name: unused-parameter + - name: var-declaration + # - name: var-naming + staticcheck: + checks: ["all"] + stylecheck: + checks: ["all", "-ST1005", "-ST1003"] + initialisms: ["ACL", "ACM", "ACMPCA", "ACMPCA", "AMI", "API", "APIGateway", "AppConfig", "AppMesh", "AppSync", "ARN", "ASG", "ASN", "AutoScaling", "BGP", "BYOIP", "CIDR", "CloudFormation", "CloudFront", "CloudWatch", "CMK", "CNAME", "CoIP", "CPU", "CSS", "CSV", "DAX", "DB", "DHCP", "DKIM", "DLM", "DMS", "DNS", "DNSSEC", "DocDB", "DocDB", "DynamoDB", "DynamoDB", "EBS", "EC2", "ECMP", "ECR", "ECS", "EFS", "EIP", "EKS", "ElastiCache", "Elasticsearch", "ELB", "EMR", "FIFO", "FMS", "FQDNS", "FSx", "FSx", "GameLift", "GCM", "GP2", "GP3", "GraphQL", "GRPC", "GuardDuty", "HAProxy", "HSM", "HTTP", "HTTPS", "HVM", "IAM", "IoT", "IP", "IPAM", "IPSet", "iSCSI", "JDBC", "JSON", "KMS", "MFA", "MSK", "MWAA", "MySQL", "NFS", "OAuth", "OIDC", "OpsWorks", "PHP", "PITR", "POSIX", "PreCheck", "QLDB", "RabbitMQ", "RDS", "RFC", "SageMaker", "SASL", "SFN", "SMB", "SMS", "SMTP", "SNS", "SQL", "SQS", "SSH", "SSL", "SSM", "SSO", "STS", "SWF", "TCP", "TLS", "TTL", "URI", "URL", "VGW", "VoIP", "VPC", "VPN", "WAF", "WAFV2", "WorkGroup", "WorkLink", "WorkSpaces", "XRay", "XSS", "YAML"] + +run: + timeout: 75m From 46c3fefb05c08f175c10e02479611d233f594a08 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 20:08:41 -0400 Subject: [PATCH 262/281] ci/make: Split golangci-lint into 3 steps --- GNUmakefile | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/GNUmakefile b/GNUmakefile index cd0a56fd346a..8ed192c0f069 100644 --- a/GNUmakefile +++ b/GNUmakefile @@ -308,20 +308,26 @@ go-misspell: ## [CI] Provider Checks / misspell @echo "make: Provider Checks / misspell..." @misspell -error -source auto -i "littel,ceasar" internal/ -golangci-lint: golangci-lint1 golangci-lint2 ## [CI] All golangci-lint Checks +golangci-lint: golangci-lint1 golangci-lint2 golangci-lint3 ## [CI] All golangci-lint Checks -golangci-lint1: ## [CI] golangci-lint Checks / 1 of 2 - @echo "make: golangci-lint Checks / 1 of 2..." +golangci-lint1: ## [CI] golangci-lint Checks / 1 of 3 + @echo "make: golangci-lint Checks / 1 of 3..." @golangci-lint run \ --config .ci/.golangci.yml \ $(TEST) -golangci-lint2: ## [CI] golangci-lint Checks / 2 of 2 - @echo "make: golangci-lint Checks / 2 of 2..." +golangci-lint2: ## [CI] golangci-lint Checks / 2 of 3 + @echo "make: golangci-lint Checks / 2 of 3..." @golangci-lint run \ --config .ci/.golangci2.yml \ $(TEST) +golangci-lint3: ## [CI] golangci-lint Checks / 3 of 3 + @echo "make: golangci-lint Checks / 3 of 3..." + @golangci-lint run \ + --config .ci/.golangci3.yml \ + $(TEST) + help: ## Display this help @grep -E '^[a-zA-Z0-9_-]+:.*?## .*$$' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-27s\033[0m %s\n", $$1, $$2}' From fbb8e526d005384b069a67e30e383da0208e0125 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 20:09:03 -0400 Subject: [PATCH 263/281] ci/github: Split golangci-lint into 3 steps --- .github/workflows/golangci-lint.yml | 32 +++++++++++++++++++++++++++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index b4225232f3ed..422b1b90c0e1 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -24,7 +24,7 @@ on: jobs: golangci-linta: - name: 1 of 2 + name: 1 of 3 runs-on: custom-linux-large steps: - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 @@ -46,7 +46,7 @@ jobs: version: "${{ steps.golangci-lint-version.outputs.version }}" args: --config .ci/.golangci.yml golangci-lintb: - name: 2 of 2 + name: 2 of 3 needs: [golangci-linta] runs-on: custom-linux-xl steps: @@ -73,3 +73,31 @@ jobs: # of OOM errors. # ref: https://golangci-lint.run/usage/performance/#memory-usage GOGC: "50" + golangci-lintc: + name: 3 of 3 + needs: [golangci-linta] + runs-on: custom-linux-xl + steps: + - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 + - uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2 + with: + go-version-file: go.mod + cache: false + - id: golangci-lint-version + working-directory: .ci/tools + run: >- + echo "version=$( + go list -m all | + grep github.com/golangci/golangci-lint | + awk '{print $2}' + )" >> $GITHUB_OUTPUT + - name: golangci-lint + uses: golangci/golangci-lint-action@aaa42aa0628b4ae2578232a66b541047968fac86 # v3.7.1 + with: + version: "${{ steps.golangci-lint-version.outputs.version }}" + args: --config .ci/.golangci3.yml + env: + # Trigger garbage collection more frequently to reduce the likelihood + # of OOM errors. + # ref: https://golangci-lint.run/usage/performance/#memory-usage + GOGC: "50" From 9b2d05530a5810402d20eda30588e1ea4773b8e0 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 20:09:36 -0400 Subject: [PATCH 264/281] ci/golangci-lint: Reduce linters in each step --- .ci/.golangci2.yml | 200 +++------------------------------------------ 1 file changed, 13 insertions(+), 187 deletions(-) diff --git a/.ci/.golangci2.yml b/.ci/.golangci2.yml index 775d2f184261..dac160853717 100644 --- a/.ci/.golangci2.yml +++ b/.ci/.golangci2.yml @@ -1,125 +1,13 @@ +# IMPORTANT: Only add linters whose names start with letters A-M here. +# Linters starting with N-Z should be placed in .golangci3.yml. issues: - exclude-rules: - - linters: - - paralleltest - text: "Function TestAcc" - - linters: - - tparallel - text: "TestAcc" - - linters: - - unparam - text: "always receives" - # tfsdk: d.GetOkExists - - linters: - - staticcheck - text: "SA1019: \\w+.GetOkExists is deprecated: usage is discouraged due to undefined behaviors and may be removed in a future version of the SDK" - # tfsdk: schema.SchemaValidateFunc - - linters: - - staticcheck - text: "SA1019: schema.SchemaValidateFunc is deprecated: please use SchemaValidateDiagFunc" - # provider: acctest.ConfigAlternateRegionProvider - - linters: - - staticcheck - text: "SA1019: acctest.ConfigAlternateRegionProvider is deprecated: Use ConfigMultipleRegionProvider instead" - # tfsdk: MigrateState - - linters: - - staticcheck - text: "MigrateState is deprecated and any new changes to a resource's schema should be handled by StateUpgraders." - # Legacy CRUD - - linters: - - staticcheck - text: "SA1019: \\w+.\\w+ is deprecated: Use \\w+Context or \\w+WithoutTimeout instead" - # go: strings.Title - - linters: - - staticcheck - text: "SA1019: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0" - # Per-Service - - linters: - - staticcheck - path: internal/service/auditmanager/ - text: "SA1019: apiObject.AwsServices is deprecated" - - linters: - - staticcheck - path: internal/service/batch/ - text: "SA1019: apiObject.ImageId is deprecated: This field is deprecated" - - linters: - - staticcheck - path: internal/service/chime/ - text: "SA1019: conn.\\w+ is deprecated: Replaced by \\w+ in the Amazon Chime SDK Voice Namespace" - - linters: - - staticcheck - path: "internal/service/cloudfront" - text: "SA1019: \\w+.(\\w+) is deprecated: This member has been deprecated" - - linters: - - staticcheck - path: "internal/service/cloudtrail" - text: "SA1019: \\w+.(\\w+) is deprecated: This member has been deprecated" - - linters: - - staticcheck - path: internal/service/detective/ - text: "SA1019: member.VolumeUsageInBytes is deprecated: This property is deprecated. Use VolumeUsageByDatasourcePackage instead" - - linters: - - staticcheck - path: internal/service/ecr/ - text: "SA1019: params.RegistryIds is deprecated: This field is deprecated." - - linters: - - staticcheck - path: "internal/service/firehose" - text: "SA1019: \\w+.(\\w+) is deprecated: (\\w+) has been deprecated" - - linters: - - staticcheck - path: "internal/service/fsx" - text: "SA1019: \\w+.(\\w+) is deprecated: This property is deprecated" - - linters: - - staticcheck - path: internal/service/globalaccelerator/ - text: "SA1019: apiObject.IpFamily is deprecated: IpFamily has been replaced by IpAddressFamily" - - linters: - - staticcheck - path: internal/service/guardduty/ - text: "SA1019: \\w+.\\w+ is deprecated. This (input|operation|parameter|field) is deprecated" - - linters: - - staticcheck - path: internal/service/identitystore/ - text: "SA1019: \\w+.Filters is deprecated: Using filters with List\\w+ API is deprecated" - - linters: - - staticcheck - path: internal/service/kms/ - text: "SA1019: [a-zA-Z0-9.]+.CustomerMasterKeySpec is deprecated: This field has been deprecated. Instead, use the KeySpec field" - - linters: - - staticcheck - path: "internal/service/neptune" - text: "SA1019: \\w+.(\\w+) is deprecated:" - - linters: - - staticcheck - path: "internal/service/s3" - text: "SA1019: \\w+.(\\w+) is deprecated: (\\w+) has been deprecated" - - linters: - - staticcheck - path: "internal/service/s3" - text: "SA1019: \\w+.(\\w+) is deprecated: This member has been deprecated" - - linters: - - staticcheck - path: internal/service/securityhub/ - text: "SA1019: \\w+.(\\w+) is deprecated:" - - linters: - - staticcheck - path: internal/service/servicediscovery/ - text: "SA1019: \\w+.(\\w+) is deprecated:" - - linters: - - staticcheck - path: internal/service/wafv2/ - text: "SA1019: \\w+.(\\w+) is deprecated: Deprecated. Use" - - linters: - - staticcheck - path: internal/service/worklink/ - text: "SA1019: \\w+.(\\w+) is deprecated: Amazon WorkLink is no longer supported. This will be removed in a future version of the SDK." max-per-linter: 0 max-same-issues: 0 linters: disable-all: true - enable: + enable: + # !! only add a-m linters here, n-z linters go in .golangci3.yml - asasalint - asciicheck - containedctx @@ -139,25 +27,6 @@ linters: - makezero - misspell - mnd - - nakedret - - nilerr - - nolintlint - - nosprintfhostport - - paralleltest - - predeclared - - revive - - staticcheck - - stylecheck - - tenv - - tparallel - - typecheck - - unconvert - - unparam - - unused - - usestdlibvars - - whitespace - # - perfsprint - # - thelper linters-settings: copyloopvar: @@ -165,11 +34,19 @@ linters-settings: dogsled: max-blank-identifiers: 3 errcheck: - ignore: github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:ForceNew|Set,io:Close + ignore: github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:Set # "ignore" is deprecated but "exclude-functions" doesn't seem to work or the syntax is non-obvious. # https://github.com/kisielk/errcheck#excluding-functions + # Under exclude-functions are the various attempts at getting it to work, all of which result in d.Set being linted everywhere. #exclude-functions: + # - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*ResourceData).Set + # - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.ResourceData.Set + # - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:ForceNew|Set,io:Close # - (github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.ResourceData).Set + # - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:ForceNew|Set + # - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:ForceNew + # - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:Set + # - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.Set # - io:Close errorlint: errorf: false @@ -217,57 +94,6 @@ linters-settings: - strconv.ParseFloat - strconv.ParseInt - strings.SplitN - nolintlint: - allow-unused: false - allow-leading-space: false - require-explanation: true - require-specific: true - allow-no-explanation: - - mnd - - paralleltest - - tparallel - - unparam - predeclared: - ignore: cap,close,copy,delete,len,new,min,max - revive: - # Recommended configuration. - # See https://github.com/mgechev/revive#recommended-configuration. - ignore-generated-header: true - severity: warning - confidence: 0.8 - error-code: 0 - warning-code: 0 - rules: - - name: atomic - - name: blank-imports - - name: context-as-argument - - name: context-keys-type - - name: dot-imports - - name: empty-block - - name: error-naming - - name: error-return - # - name: error-strings - - name: errorf - # - name: exported - # - name: if-return - # - name: increment-decrement - # - name: indent-error-flow - - name: package-comments - - name: range - - name: receiver-naming - # - name: redefines-builtin-id - - name: superfluous-else - - name: time-naming - # - name: unexported-return - - name: unreachable-code - # - name: unused-parameter - - name: var-declaration - # - name: var-naming - staticcheck: - checks: ["all"] - stylecheck: - checks: ["all", "-ST1005", "-ST1003"] - initialisms: ["ACL", "ACM", "ACMPCA", "ACMPCA", "AMI", "API", "APIGateway", "AppConfig", "AppMesh", "AppSync", "ARN", "ASG", "ASN", "AutoScaling", "BGP", "BYOIP", "CIDR", "CloudFormation", "CloudFront", "CloudWatch", "CMK", "CNAME", "CoIP", "CPU", "CSS", "CSV", "DAX", "DB", "DHCP", "DKIM", "DLM", "DMS", "DNS", "DNSSEC", "DocDB", "DocDB", "DynamoDB", "DynamoDB", "EBS", "EC2", "ECMP", "ECR", "ECS", "EFS", "EIP", "EKS", "ElastiCache", "Elasticsearch", "ELB", "EMR", "FIFO", "FMS", "FQDNS", "FSx", "FSx", "GameLift", "GCM", "GP2", "GP3", "GraphQL", "GRPC", "GuardDuty", "HAProxy", "HSM", "HTTP", "HTTPS", "HVM", "IAM", "IoT", "IP", "IPAM", "IPSet", "iSCSI", "JDBC", "JSON", "KMS", "MFA", "MSK", "MWAA", "MySQL", "NFS", "OAuth", "OIDC", "OpsWorks", "PHP", "PITR", "POSIX", "PreCheck", "QLDB", "RabbitMQ", "RDS", "RFC", "SageMaker", "SASL", "SFN", "SMB", "SMS", "SMTP", "SNS", "SQL", "SQS", "SSH", "SSL", "SSM", "SSO", "STS", "SWF", "TCP", "TLS", "TTL", "URI", "URL", "VGW", "VoIP", "VPC", "VPN", "WAF", "WAFV2", "WorkGroup", "WorkLink", "WorkSpaces", "XRay", "XSS", "YAML"] run: timeout: 75m From 50c06a5c9f263e77f6a4957a0d48246be2297186 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 20:10:46 -0400 Subject: [PATCH 265/281] ci/golangci-lint: Update errcheck ignore --- .ci/.golangci2.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/.golangci2.yml b/.ci/.golangci2.yml index dac160853717..1d21a5c0a989 100644 --- a/.ci/.golangci2.yml +++ b/.ci/.golangci2.yml @@ -34,7 +34,7 @@ linters-settings: dogsled: max-blank-identifiers: 3 errcheck: - ignore: github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:Set + ignore: github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:ForceNew|Set # "ignore" is deprecated but "exclude-functions" doesn't seem to work or the syntax is non-obvious. # https://github.com/kisielk/errcheck#excluding-functions # Under exclude-functions are the various attempts at getting it to work, all of which result in d.Set being linted everywhere. From 2f515faa03cd40a7906bb9e9bccdb5e008dce0e8 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Mon, 26 Aug 2024 20:13:31 -0400 Subject: [PATCH 266/281] lint the linting --- .ci/.golangci2.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/.golangci2.yml b/.ci/.golangci2.yml index 1d21a5c0a989..5f1f982f0845 100644 --- a/.ci/.golangci2.yml +++ b/.ci/.golangci2.yml @@ -6,7 +6,7 @@ issues: linters: disable-all: true - enable: + enable: # !! only add a-m linters here, n-z linters go in .golangci3.yml - asasalint - asciicheck From 09732bff589669057545b947eece47d7f3f4d5e5 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Tue, 27 Aug 2024 12:42:06 -0400 Subject: [PATCH 267/281] emr: make gen --- internal/service/emr/service_endpoints_gen_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/service/emr/service_endpoints_gen_test.go b/internal/service/emr/service_endpoints_gen_test.go index e4719e4ceb49..a8e2b7d2b859 100644 --- a/internal/service/emr/service_endpoints_gen_test.go +++ b/internal/service/emr/service_endpoints_gen_test.go @@ -235,8 +235,6 @@ func TestEndpointConfiguration(t *testing.T) { //nolint:paralleltest // uses t.S } for name, testcase := range testcases { //nolint:paralleltest // uses t.Setenv - testcase := testcase - t.Run(name, func(t *testing.T) { testEndpointCase(t, providerRegion, testcase, callService) }) From 57d4304440839c7fca4dff99ffde0fe4aba3aa62 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Tue, 27 Aug 2024 13:04:31 -0400 Subject: [PATCH 268/281] github/golangci-lint: Failing on Go 1.23 --- .ci/.golangci2.yml | 20 ++++++++++---------- .github/workflows/golangci-lint.yml | 10 +++++----- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/.ci/.golangci2.yml b/.ci/.golangci2.yml index 5f1f982f0845..add3caf210f7 100644 --- a/.ci/.golangci2.yml +++ b/.ci/.golangci2.yml @@ -38,16 +38,16 @@ linters-settings: # "ignore" is deprecated but "exclude-functions" doesn't seem to work or the syntax is non-obvious. # https://github.com/kisielk/errcheck#excluding-functions # Under exclude-functions are the various attempts at getting it to work, all of which result in d.Set being linted everywhere. - #exclude-functions: - # - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*ResourceData).Set - # - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.ResourceData.Set - # - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:ForceNew|Set,io:Close - # - (github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.ResourceData).Set - # - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:ForceNew|Set - # - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:ForceNew - # - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:Set - # - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.Set - # - io:Close + # exclude-functions: + # - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*ResourceData).Set + # - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.ResourceData.Set + # - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:ForceNew|Set,io:Close + # - (github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.ResourceData).Set + # - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:ForceNew|Set + # - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:ForceNew + # - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:Set + # - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.Set + # - io:Close errorlint: errorf: false goconst: diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index 422b1b90c0e1..63d1ddb469f1 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -41,7 +41,7 @@ jobs: awk '{print $2}' )" >> $GITHUB_OUTPUT - name: golangci-lint - uses: golangci/golangci-lint-action@aaa42aa0628b4ae2578232a66b541047968fac86 # v3.7.1 + uses: golangci/golangci-lint-action@aaa42aa0628b4ae2578232a66b541047968fac86 # v6.1.0 with: version: "${{ steps.golangci-lint-version.outputs.version }}" args: --config .ci/.golangci.yml @@ -64,7 +64,7 @@ jobs: awk '{print $2}' )" >> $GITHUB_OUTPUT - name: golangci-lint - uses: golangci/golangci-lint-action@aaa42aa0628b4ae2578232a66b541047968fac86 # v3.7.1 + uses: golangci/golangci-lint-action@aaa42aa0628b4ae2578232a66b541047968fac86 # v6.1.0 with: version: "${{ steps.golangci-lint-version.outputs.version }}" args: --config .ci/.golangci2.yml @@ -72,7 +72,7 @@ jobs: # Trigger garbage collection more frequently to reduce the likelihood # of OOM errors. # ref: https://golangci-lint.run/usage/performance/#memory-usage - GOGC: "50" + GOGC: "30" golangci-lintc: name: 3 of 3 needs: [golangci-linta] @@ -92,7 +92,7 @@ jobs: awk '{print $2}' )" >> $GITHUB_OUTPUT - name: golangci-lint - uses: golangci/golangci-lint-action@aaa42aa0628b4ae2578232a66b541047968fac86 # v3.7.1 + uses: golangci/golangci-lint-action@aaa42aa0628b4ae2578232a66b541047968fac86 # v6.1.0 with: version: "${{ steps.golangci-lint-version.outputs.version }}" args: --config .ci/.golangci3.yml @@ -100,4 +100,4 @@ jobs: # Trigger garbage collection more frequently to reduce the likelihood # of OOM errors. # ref: https://golangci-lint.run/usage/performance/#memory-usage - GOGC: "50" + GOGC: "30" From ac40c3307f1bbc73a02b89d56f1bb7dd20205a37 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Tue, 27 Aug 2024 13:20:43 -0400 Subject: [PATCH 269/281] github/golangci-lint: Failing on Go 1.23 --- .github/workflows/golangci-lint.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index 63d1ddb469f1..9d73b4d1116a 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -71,8 +71,8 @@ jobs: env: # Trigger garbage collection more frequently to reduce the likelihood # of OOM errors. - # ref: https://golangci-lint.run/usage/performance/#memory-usage - GOGC: "30" + # ref: https://golangci-lint.run/product/performance/ + GOGC: "3000" golangci-lintc: name: 3 of 3 needs: [golangci-linta] @@ -99,5 +99,5 @@ jobs: env: # Trigger garbage collection more frequently to reduce the likelihood # of OOM errors. - # ref: https://golangci-lint.run/usage/performance/#memory-usage - GOGC: "30" + # ref: https://golangci-lint.run/product/performance/ + GOGC: "5" From 1022b39468221f531f308c4d8e7485073b376d17 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Tue, 27 Aug 2024 14:07:18 -0400 Subject: [PATCH 270/281] github/golangci-lint: Failing on Go 1.23 --- .ci/.golangci2.yml | 6 ++++-- .github/workflows/golangci-lint.yml | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.ci/.golangci2.yml b/.ci/.golangci2.yml index add3caf210f7..5e3ad25bfa3e 100644 --- a/.ci/.golangci2.yml +++ b/.ci/.golangci2.yml @@ -1,8 +1,10 @@ # IMPORTANT: Only add linters whose names start with letters A-M here. # Linters starting with N-Z should be placed in .golangci3.yml. issues: - max-per-linter: 0 - max-same-issues: 0 + max-per-linter: 10 + max-same-issues: 2 + concurrency: 4 + go: 1.23 linters: disable-all: true diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index 9d73b4d1116a..56e575ad5d51 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -72,7 +72,7 @@ jobs: # Trigger garbage collection more frequently to reduce the likelihood # of OOM errors. # ref: https://golangci-lint.run/product/performance/ - GOGC: "3000" + GOGC: "200" golangci-lintc: name: 3 of 3 needs: [golangci-linta] From 3ad894b5b1bb5cb193b83bac6b6c184c66bac793 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Tue, 27 Aug 2024 14:37:01 -0400 Subject: [PATCH 271/281] github/golangci-lint: Failing on Go 1.23 --- .ci/.golangci2.yml | 2 +- .github/workflows/golangci-lint.yml | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.ci/.golangci2.yml b/.ci/.golangci2.yml index 5e3ad25bfa3e..f4b36d2be669 100644 --- a/.ci/.golangci2.yml +++ b/.ci/.golangci2.yml @@ -4,7 +4,7 @@ issues: max-per-linter: 10 max-same-issues: 2 concurrency: 4 - go: 1.23 + go: '1.22.6' linters: disable-all: true diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index 56e575ad5d51..cf26323c5149 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -30,7 +30,7 @@ jobs: - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 - uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2 with: - go-version-file: go.mod + go-version: '1.22.6' cache: false - id: golangci-lint-version working-directory: .ci/tools @@ -53,7 +53,7 @@ jobs: - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 - uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2 with: - go-version-file: go.mod + go-version: '1.22.6' cache: false - id: golangci-lint-version working-directory: .ci/tools @@ -72,7 +72,7 @@ jobs: # Trigger garbage collection more frequently to reduce the likelihood # of OOM errors. # ref: https://golangci-lint.run/product/performance/ - GOGC: "200" + GOGC: "2000" golangci-lintc: name: 3 of 3 needs: [golangci-linta] @@ -81,7 +81,7 @@ jobs: - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 - uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2 with: - go-version-file: go.mod + go-version: '1.22.6' cache: false - id: golangci-lint-version working-directory: .ci/tools @@ -100,4 +100,4 @@ jobs: # Trigger garbage collection more frequently to reduce the likelihood # of OOM errors. # ref: https://golangci-lint.run/product/performance/ - GOGC: "5" + GOGC: "2000" From 3688bbfdf1eb427fc8cb68aae3a8c24c668149ae Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Tue, 27 Aug 2024 14:54:34 -0400 Subject: [PATCH 272/281] ci/golangci-lint: Update to 1.60.3 --- .ci/.golangci2.yml | 6 +- .ci/.golangci3.yml | 4 +- .ci/tools/go.mod | 103 ++++++------ .ci/tools/go.sum | 237 ++++++++++++++-------------- .github/workflows/golangci-lint.yml | 6 +- 5 files changed, 176 insertions(+), 180 deletions(-) diff --git a/.ci/.golangci2.yml b/.ci/.golangci2.yml index f4b36d2be669..cea62cd3383d 100644 --- a/.ci/.golangci2.yml +++ b/.ci/.golangci2.yml @@ -1,10 +1,8 @@ # IMPORTANT: Only add linters whose names start with letters A-M here. # Linters starting with N-Z should be placed in .golangci3.yml. issues: - max-per-linter: 10 - max-same-issues: 2 - concurrency: 4 - go: '1.22.6' + max-issues-per-linter: 10 + max-same-issues: 3 linters: disable-all: true diff --git a/.ci/.golangci3.yml b/.ci/.golangci3.yml index b14fa7fa45a7..5c352feb964a 100644 --- a/.ci/.golangci3.yml +++ b/.ci/.golangci3.yml @@ -116,8 +116,8 @@ issues: - linters: - tparallel text: "TestAcc" - max-per-linter: 0 - max-same-issues: 0 + max-issues-per-linter: 10 + max-same-issues: 3 linters: disable-all: true diff --git a/.ci/tools/go.mod b/.ci/tools/go.mod index be1c6378bb36..9f5f5928db52 100644 --- a/.ci/tools/go.mod +++ b/.ci/tools/go.mod @@ -5,7 +5,7 @@ go 1.23.0 require ( github.com/YakDriver/tfproviderdocs v0.13.0 github.com/client9/misspell v0.3.4 - github.com/golangci/golangci-lint v1.59.1 + github.com/golangci/golangci-lint v1.60.3 github.com/hashicorp/copywrite v0.19.0 github.com/hashicorp/go-changelog v0.0.0-20240306190400-974418b4aaa3 github.com/katbyte/terrafmt v0.5.4 @@ -19,21 +19,23 @@ require ( require ( 4d63.com/gocheckcompilerdirectives v1.2.1 // indirect 4d63.com/gochecknoglobals v0.2.1 // indirect - cloud.google.com/go v0.112.0 // indirect - cloud.google.com/go/compute/metadata v0.3.0 // indirect - cloud.google.com/go/iam v1.1.6 // indirect - cloud.google.com/go/storage v1.36.0 // indirect + cloud.google.com/go v0.115.0 // indirect + cloud.google.com/go/auth v0.8.1 // indirect + cloud.google.com/go/auth/oauth2adapt v0.2.3 // indirect + cloud.google.com/go/compute/metadata v0.5.0 // indirect + cloud.google.com/go/iam v1.1.12 // indirect + cloud.google.com/go/storage v1.41.0 // indirect dario.cat/mergo v1.0.0 // indirect github.com/4meepo/tagalign v1.3.4 // indirect github.com/Abirdcfly/dupword v0.0.14 // indirect github.com/AlecAivazis/survey/v2 v2.3.6 // indirect github.com/Antonboom/errname v0.1.13 // indirect github.com/Antonboom/nilnil v0.1.9 // indirect - github.com/Antonboom/testifylint v1.3.1 // indirect - github.com/BurntSushi/toml v1.4.0 // indirect - github.com/Crocmagnon/fatcontext v0.2.2 // indirect + github.com/Antonboom/testifylint v1.4.3 // indirect + github.com/BurntSushi/toml v1.4.1-0.20240526193622-a339e1f7089c // indirect + github.com/Crocmagnon/fatcontext v0.4.0 // indirect github.com/Djarvur/go-err113 v0.0.0-20210108212216-aea10b59be24 // indirect - github.com/GaijinEntertainment/go-exhaustruct/v3 v3.2.0 // indirect + github.com/GaijinEntertainment/go-exhaustruct/v3 v3.3.0 // indirect github.com/Masterminds/goutils v1.1.1 // indirect github.com/Masterminds/semver/v3 v3.2.1 // indirect github.com/Masterminds/sprig/v3 v3.2.3 // indirect @@ -59,7 +61,7 @@ require ( github.com/blizzy78/varnamelen v0.8.0 // indirect github.com/bmatcuk/doublestar v1.3.4 // indirect github.com/bmatcuk/doublestar/v4 v4.6.0 // indirect - github.com/bombsimon/wsl/v4 v4.2.1 // indirect + github.com/bombsimon/wsl/v4 v4.4.1 // indirect github.com/bradleyfalzon/ghinstallation/v2 v2.5.0 // indirect github.com/breml/bidichk v0.2.7 // indirect github.com/breml/errchkjson v0.3.6 // indirect @@ -93,7 +95,7 @@ require ( github.com/go-git/gcfg v1.5.1-0.20230307220236-3a3c6141e376 // indirect github.com/go-git/go-billy/v5 v5.5.0 // indirect github.com/go-git/go-git/v5 v5.11.0 // indirect - github.com/go-logr/logr v1.4.1 // indirect + github.com/go-logr/logr v1.4.2 // indirect github.com/go-logr/stdr v1.2.2 // indirect github.com/go-openapi/errors v0.20.2 // indirect github.com/go-openapi/strfmt v0.21.3 // indirect @@ -107,12 +109,12 @@ require ( github.com/go-viper/mapstructure/v2 v2.0.0 // indirect github.com/go-xmlfmt/xmlfmt v1.1.2 // indirect github.com/gobwas/glob v0.2.3 // indirect - github.com/gofrs/flock v0.8.1 // indirect + github.com/gofrs/flock v0.12.1 // indirect github.com/golang-jwt/jwt/v4 v4.5.0 // indirect github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect github.com/golang/protobuf v1.5.4 // indirect github.com/golangci/dupl v0.0.0-20180902072040-3e9179ac440a // indirect - github.com/golangci/gofmt v0.0.0-20231018234816-f50ced29576e // indirect + github.com/golangci/gofmt v0.0.0-20240816233607-d8596aa466a9 // indirect github.com/golangci/misspell v0.6.0 // indirect github.com/golangci/modinfo v0.3.4 // indirect github.com/golangci/plugin-module-register v0.1.1 // indirect @@ -123,10 +125,10 @@ require ( github.com/google/go-github/v53 v53.2.0 // indirect github.com/google/go-intervals v0.0.2 // indirect github.com/google/go-querystring v1.1.0 // indirect - github.com/google/s2a-go v0.1.7 // indirect + github.com/google/s2a-go v0.1.8 // indirect github.com/google/uuid v1.6.0 // indirect github.com/googleapis/enterprise-certificate-proxy v0.3.2 // indirect - github.com/googleapis/gax-go/v2 v2.12.0 // indirect + github.com/googleapis/gax-go/v2 v2.13.0 // indirect github.com/gookit/color v1.5.4 // indirect github.com/gordonklaus/ineffassign v0.1.0 // indirect github.com/gostaticanalysis/analysisutil v0.7.1 // indirect @@ -163,7 +165,7 @@ require ( github.com/jgautheron/goconst v1.7.1 // indirect github.com/jingyugao/rowserrcheck v1.1.1 // indirect github.com/jirfag/go-printf-func-name v0.0.0-20200119135958-7558a9eaa5af // indirect - github.com/jjti/go-spancheck v0.6.1 // indirect + github.com/jjti/go-spancheck v0.6.2 // indirect github.com/jmespath/go-jmespath v0.4.0 // indirect github.com/joho/godotenv v1.3.0 // indirect github.com/jstemmer/go-junit-report v1.0.0 // indirect @@ -197,7 +199,7 @@ require ( github.com/mattn/go-runewidth v0.0.15 // indirect github.com/matttproud/golang_protobuf_extensions v1.0.1 // indirect github.com/mergestat/timediff v0.0.3 // indirect - github.com/mgechev/revive v1.3.7 // indirect + github.com/mgechev/revive v1.3.9 // indirect github.com/mgutz/ansi v0.0.0-20200706080929-d51e80ef957d // indirect github.com/mitchellh/cli v1.1.5 // indirect github.com/mitchellh/copystructure v1.2.0 // indirect @@ -206,7 +208,7 @@ require ( github.com/mitchellh/go-wordwrap v1.0.1 // indirect github.com/mitchellh/mapstructure v1.5.0 // indirect github.com/mitchellh/reflectwalk v1.0.2 // indirect - github.com/moricho/tparallel v0.3.1 // indirect + github.com/moricho/tparallel v0.3.2 // indirect github.com/muesli/termenv v0.12.0 // indirect github.com/nakabonne/nestif v0.3.1 // indirect github.com/nishanths/exhaustive v0.12.0 // indirect @@ -220,7 +222,7 @@ require ( github.com/pjbgf/sha1cd v0.3.0 // indirect github.com/pkg/diff v0.0.0-20210226163009-20ebb0f2a09e // indirect github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect - github.com/polyfloyd/go-errorlint v1.5.2 // indirect + github.com/polyfloyd/go-errorlint v1.6.0 // indirect github.com/posener/complete v1.2.3 // indirect github.com/prometheus/client_golang v1.12.1 // indirect github.com/prometheus/client_model v0.2.0 // indirect @@ -233,7 +235,7 @@ require ( github.com/quasilyte/stdinfo v0.0.0-20220114132959-f7386bf02567 // indirect github.com/rivo/uniseg v0.4.7 // indirect github.com/robfig/cron/v3 v3.0.1 // indirect - github.com/ryancurrah/gomodguard v1.3.2 // indirect + github.com/ryancurrah/gomodguard v1.3.3 // indirect github.com/ryanrolds/sqlclosecheck v0.5.1 // indirect github.com/sagikazarmark/locafero v0.4.0 // indirect github.com/sagikazarmark/slog-shim v0.1.0 // indirect @@ -241,14 +243,14 @@ require ( github.com/sanposhiho/wastedassign/v2 v2.0.7 // indirect github.com/santhosh-tekuri/jsonschema/v5 v5.3.1 // indirect github.com/sashamelentyev/interfacebloat v1.1.0 // indirect - github.com/sashamelentyev/usestdlibvars v1.26.0 // indirect - github.com/securego/gosec/v2 v2.20.1-0.20240525090044-5f0084eb01a9 // indirect + github.com/sashamelentyev/usestdlibvars v1.27.0 // indirect + github.com/securego/gosec/v2 v2.20.1-0.20240822074752-ab3f6c1c83a0 // indirect github.com/sergi/go-diff v1.3.1 // indirect github.com/shazow/go-diff v0.0.0-20160112020656-b6b7b6733b8c // indirect github.com/shopspring/decimal v1.3.1 // indirect github.com/sirupsen/logrus v1.9.3 // indirect github.com/sivchari/containedctx v1.0.3 // indirect - github.com/sivchari/tenv v1.7.1 // indirect + github.com/sivchari/tenv v1.10.0 // indirect github.com/skeema/knownhosts v1.2.1 // indirect github.com/sonatard/noctx v0.0.2 // indirect github.com/sourcegraph/conc v0.3.0 // indirect @@ -257,7 +259,7 @@ require ( github.com/sourcegraph/jsonrpc2 v0.2.0 // indirect github.com/spf13/afero v1.11.0 // indirect github.com/spf13/cast v1.6.0 // indirect - github.com/spf13/cobra v1.8.0 // indirect + github.com/spf13/cobra v1.8.1 // indirect github.com/spf13/pflag v1.0.5 // indirect github.com/spf13/viper v1.18.2 // indirect github.com/ssgreg/nlreturn/v2 v2.2.1 // indirect @@ -265,7 +267,6 @@ require ( github.com/stretchr/objx v0.5.2 // indirect github.com/stretchr/testify v1.9.0 // indirect github.com/subosito/gotenv v1.6.0 // indirect - github.com/t-yuki/gocover-cobertura v0.0.0-20180217150009-aaee18c8195c // indirect github.com/tdakkota/asciicheck v0.2.0 // indirect github.com/terraform-linters/tflint-plugin-sdk v0.20.0 // indirect github.com/terraform-linters/tflint-ruleset-terraform v0.8.0 // indirect @@ -274,12 +275,12 @@ require ( github.com/thlib/go-timezone-local v0.0.0-20210907160436-ef149e42d28e // indirect github.com/timakin/bodyclose v0.0.0-20230421092635-574207250966 // indirect github.com/timonwong/loggercheck v0.9.4 // indirect - github.com/tomarrell/wrapcheck/v2 v2.8.3 // indirect + github.com/tomarrell/wrapcheck/v2 v2.9.0 // indirect github.com/tommy-muehle/go-mnd/v2 v2.5.1 // indirect github.com/ulikunitz/xz v0.5.10 // indirect github.com/ultraware/funlen v0.1.0 // indirect github.com/ultraware/whitespace v0.1.1 // indirect - github.com/uudashr/gocognit v1.1.2 // indirect + github.com/uudashr/gocognit v1.1.3 // indirect github.com/vmihailenco/msgpack/v5 v5.3.5 // indirect github.com/vmihailenco/tagparser/v2 v2.0.0 // indirect github.com/xanzy/ssh-agent v0.3.3 // indirect @@ -294,41 +295,41 @@ require ( github.com/zclconf/go-cty-yaml v1.0.3 // indirect gitlab.com/bosi/decorder v0.4.2 // indirect go-simpler.org/musttag v0.12.2 // indirect - go-simpler.org/sloglint v0.7.1 // indirect + go-simpler.org/sloglint v0.7.2 // indirect go.mongodb.org/mongo-driver v1.10.0 // indirect go.opencensus.io v0.24.0 // indirect - go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.47.0 // indirect - go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.47.0 // indirect - go.opentelemetry.io/otel v1.22.0 // indirect - go.opentelemetry.io/otel/metric v1.22.0 // indirect - go.opentelemetry.io/otel/trace v1.22.0 // indirect + go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.51.0 // indirect + go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.51.0 // indirect + go.opentelemetry.io/otel v1.26.0 // indirect + go.opentelemetry.io/otel/metric v1.26.0 // indirect + go.opentelemetry.io/otel/trace v1.26.0 // indirect go.uber.org/atomic v1.11.0 // indirect go.uber.org/automaxprocs v1.5.3 // indirect go.uber.org/multierr v1.11.0 // indirect go.uber.org/zap v1.24.0 // indirect - golang.org/x/crypto v0.24.0 // indirect - golang.org/x/exp v0.0.0-20240222234643-814bf88cf225 // indirect + golang.org/x/crypto v0.26.0 // indirect + golang.org/x/exp v0.0.0-20240719175910-8a7402abbf56 // indirect golang.org/x/exp/typeparams v0.0.0-20240314144324-c7f7c6466f7f // indirect - golang.org/x/mod v0.18.0 // indirect - golang.org/x/net v0.26.0 // indirect - golang.org/x/oauth2 v0.21.0 // indirect - golang.org/x/sync v0.7.0 // indirect - golang.org/x/sys v0.21.0 // indirect - golang.org/x/term v0.21.0 // indirect - golang.org/x/text v0.16.0 // indirect - golang.org/x/time v0.5.0 // indirect - golang.org/x/tools v0.22.0 // indirect - google.golang.org/api v0.162.0 // indirect - google.golang.org/genproto v0.0.0-20240227224415-6ceb2ff114de // indirect - google.golang.org/genproto/googleapis/api v0.0.0-20240318140521-94a12d6c2237 // indirect - google.golang.org/genproto/googleapis/rpc v0.0.0-20240318140521-94a12d6c2237 // indirect - google.golang.org/grpc v1.64.0 // indirect - google.golang.org/protobuf v1.34.0 // indirect + golang.org/x/mod v0.20.0 // indirect + golang.org/x/net v0.28.0 // indirect + golang.org/x/oauth2 v0.22.0 // indirect + golang.org/x/sync v0.8.0 // indirect + golang.org/x/sys v0.23.0 // indirect + golang.org/x/term v0.23.0 // indirect + golang.org/x/text v0.17.0 // indirect + golang.org/x/time v0.6.0 // indirect + golang.org/x/tools v0.24.0 // indirect + google.golang.org/api v0.192.0 // indirect + google.golang.org/genproto v0.0.0-20240730163845-b1a4ccb954bf // indirect + google.golang.org/genproto/googleapis/api v0.0.0-20240725223205-93522f1f2a9f // indirect + google.golang.org/genproto/googleapis/rpc v0.0.0-20240730163845-b1a4ccb954bf // indirect + google.golang.org/grpc v1.64.1 // indirect + google.golang.org/protobuf v1.34.2 // indirect gopkg.in/ini.v1 v1.67.0 // indirect gopkg.in/warnings.v0 v0.1.2 // indirect gopkg.in/yaml.v2 v2.4.0 // indirect gopkg.in/yaml.v3 v3.0.1 // indirect - honnef.co/go/tools v0.4.7 // indirect + honnef.co/go/tools v0.5.1 // indirect mvdan.cc/unparam v0.0.0-20240528143540-8a5130ca722f // indirect ) diff --git a/.ci/tools/go.sum b/.ci/tools/go.sum index 6c7b07014d89..992965fb58db 100644 --- a/.ci/tools/go.sum +++ b/.ci/tools/go.sum @@ -34,8 +34,8 @@ cloud.google.com/go v0.100.2/go.mod h1:4Xra9TjzAeYHrl5+oeLlzbM2k3mjVhZh4UqTZ//w9 cloud.google.com/go v0.102.0/go.mod h1:oWcCzKlqJ5zgHQt9YsaeTY9KzIvjyy0ArmiBUgpQ+nc= cloud.google.com/go v0.102.1/go.mod h1:XZ77E9qnTEnrgEOvr4xzfdX5TRo7fB4T2F4O6+34hIU= cloud.google.com/go v0.104.0/go.mod h1:OO6xxXdJyvuJPcEPBLN9BJPD+jep5G1+2U5B5gkRYtA= -cloud.google.com/go v0.112.0 h1:tpFCD7hpHFlQ8yPwT3x+QeXqc2T6+n6T+hmABHfDUSM= -cloud.google.com/go v0.112.0/go.mod h1:3jEEVwZ/MHU4djK5t5RHuKOA/GbLddgTdVubX1qnPD4= +cloud.google.com/go v0.115.0 h1:CnFSK6Xo3lDYRoBKEcAtia6VSC837/ZkJuRduSFnr14= +cloud.google.com/go v0.115.0/go.mod h1:8jIM5vVgoAEoiVxQ/O4BFTfHqulPZgs/ufEzMcFMdWU= cloud.google.com/go/aiplatform v1.22.0/go.mod h1:ig5Nct50bZlzV6NvKaTwmplLLddFx0YReh9WfTO5jKw= cloud.google.com/go/aiplatform v1.24.0/go.mod h1:67UUvRBKG6GTayHKV8DBv2RtR1t93YRu5B1P3x99mYY= cloud.google.com/go/analytics v0.11.0/go.mod h1:DjEWCu41bVbYcKyvlws9Er60YE4a//bK6mnhWvQeFNI= @@ -50,6 +50,10 @@ cloud.google.com/go/asset v1.8.0/go.mod h1:mUNGKhiqIdbr8X7KNayoYvyc4HbbFO9URsjby cloud.google.com/go/assuredworkloads v1.5.0/go.mod h1:n8HOZ6pff6re5KYfBXcFvSViQjDwxFkAkmUFffJRbbY= cloud.google.com/go/assuredworkloads v1.6.0/go.mod h1:yo2YOk37Yc89Rsd5QMVECvjaMKymF9OP+QXWlKXUkXw= cloud.google.com/go/assuredworkloads v1.7.0/go.mod h1:z/736/oNmtGAyU47reJgGN+KVoYoxeLBoj4XkKYscNI= +cloud.google.com/go/auth v0.8.1 h1:QZW9FjC5lZzN864p13YxvAtGUlQ+KgRL+8Sg45Z6vxo= +cloud.google.com/go/auth v0.8.1/go.mod h1:qGVp/Y3kDRSDZ5gFD/XPUfYQ9xW1iI7q8RIRoCyBbJc= +cloud.google.com/go/auth/oauth2adapt v0.2.3 h1:MlxF+Pd3OmSudg/b1yZ5lJwoXCEaeedAguodky1PcKI= +cloud.google.com/go/auth/oauth2adapt v0.2.3/go.mod h1:tMQXOfZzFuNuUxOypHlQEXgdfX5cuhwU+ffUuXRJE8I= cloud.google.com/go/automl v1.5.0/go.mod h1:34EjfoFGMZ5sgJ9EoLsRtdPSNZLcfflJR39VbVNS2M0= cloud.google.com/go/automl v1.6.0/go.mod h1:ugf8a6Fx+zP0D59WLhqgTDsQI9w07o64uf/Is3Nh5p8= cloud.google.com/go/bigquery v1.0.1/go.mod h1:i/xbL2UlR5RvWAURpBYZTtm/cXjCha9lbfbpx4poX+o= @@ -73,8 +77,8 @@ cloud.google.com/go/compute v1.6.1/go.mod h1:g85FgpzFvNULZ+S8AYq87axRKuf2Kh7deLq cloud.google.com/go/compute v1.7.0/go.mod h1:435lt8av5oL9P3fv1OEzSbSUe+ybHXGMPQHHZWZxy9U= cloud.google.com/go/compute v1.10.0/go.mod h1:ER5CLbMxl90o2jtNbGSbtfOpQKR0t15FOtRsugnLrlU= cloud.google.com/go/compute/metadata v0.2.0/go.mod h1:zFmK7XCadkQkj6TtorcaGlCW1hT1fIilQDwofLpJ20k= -cloud.google.com/go/compute/metadata v0.3.0 h1:Tz+eQXMEqDIKRsmY3cHTL6FVaynIjX2QxYC4trgAKZc= -cloud.google.com/go/compute/metadata v0.3.0/go.mod h1:zFmK7XCadkQkj6TtorcaGlCW1hT1fIilQDwofLpJ20k= +cloud.google.com/go/compute/metadata v0.5.0 h1:Zr0eK8JbFv6+Wi4ilXAR8FJ3wyNdpxHKJNPos6LTZOY= +cloud.google.com/go/compute/metadata v0.5.0/go.mod h1:aHnloV2TPI38yx4s9+wAZhHykWvVCfu7hQbF+9CWoiY= cloud.google.com/go/containeranalysis v0.5.1/go.mod h1:1D92jd8gRR/c0fGMlymRgxWD3Qw9C1ff6/T7mLgVL8I= cloud.google.com/go/containeranalysis v0.6.0/go.mod h1:HEJoiEIu+lEXM+k7+qLCci0h33lX3ZqoYFdmPcoO7s4= cloud.google.com/go/datacatalog v1.3.0/go.mod h1:g9svFY6tuR+j+hrTw3J2dNcmI0dzmSiyOzm8kpLq0a0= @@ -112,8 +116,8 @@ cloud.google.com/go/gkehub v0.10.0/go.mod h1:UIPwxI0DsrpsVoWpLB0stwKCP+WFVG9+y97 cloud.google.com/go/grafeas v0.2.0/go.mod h1:KhxgtF2hb0P191HlY5besjYm6MqTSTj3LSI+M+ByZHc= cloud.google.com/go/iam v0.3.0/go.mod h1:XzJPvDayI+9zsASAFO68Hk07u3z+f+JrT2xXNdp4bnY= cloud.google.com/go/iam v0.5.0/go.mod h1:wPU9Vt0P4UmCux7mqtRu6jcpPAb74cP1fh50J3QpkUc= -cloud.google.com/go/iam v1.1.6 h1:bEa06k05IO4f4uJonbB5iAgKTPpABy1ayxaIZV/GHVc= -cloud.google.com/go/iam v1.1.6/go.mod h1:O0zxdPeGBoFdWW3HWmBxJsk0pfvNM/p/qa82rWOGTwI= +cloud.google.com/go/iam v1.1.12 h1:JixGLimRrNGcxvJEQ8+clfLxPlbeZA6MuRJ+qJNQ5Xw= +cloud.google.com/go/iam v1.1.12/go.mod h1:9LDX8J7dN5YRyzVHxwQzrQs9opFFqn0Mxs9nAeB+Hhg= cloud.google.com/go/language v1.4.0/go.mod h1:F9dRpNFQmJbkaop6g0JhSBXCNlO90e1KWx5iDdxbWic= cloud.google.com/go/language v1.6.0/go.mod h1:6dJ8t3B+lUYfStgls25GusK04NLh3eDLQnWM3mdEbhI= cloud.google.com/go/lifesciences v0.5.0/go.mod h1:3oIKy8ycWGPUyZDR/8RNnTOYevhaMLqh5vLUXs9zvT8= @@ -174,8 +178,8 @@ cloud.google.com/go/storage v1.10.0/go.mod h1:FLPqc6j+Ki4BU591ie1oL6qBQGu2Bl/tZ9 cloud.google.com/go/storage v1.22.1/go.mod h1:S8N1cAStu7BOeFfE8KAQzmyyLkK8p/vmRq6kuBTW58Y= cloud.google.com/go/storage v1.23.0/go.mod h1:vOEEDNFnciUMhBeT6hsJIn3ieU5cFRmzeLgDvXzfIXc= cloud.google.com/go/storage v1.27.0/go.mod h1:x9DOL8TK/ygDUMieqwfhdpQryTeEkhGKMi80i/iqR2s= -cloud.google.com/go/storage v1.36.0 h1:P0mOkAcaJxhCTvAkMhxMfrTKiNcub4YmmPBtlhAyTr8= -cloud.google.com/go/storage v1.36.0/go.mod h1:M6M/3V/D3KpzMTJyPOR/HU6n2Si5QdaXYEsng2xgOs8= +cloud.google.com/go/storage v1.41.0 h1:RusiwatSu6lHeEXe3kglxakAmAbfV+rhtPqA6i8RBx0= +cloud.google.com/go/storage v1.41.0/go.mod h1:J1WCa/Z2FcgdEDuPUY8DxT5I+d9mFKsCepp5vR6Sq80= cloud.google.com/go/talent v1.1.0/go.mod h1:Vl4pt9jiHKvOgF9KoZo6Kob9oV4lwd/ZD5Cto54zDRw= cloud.google.com/go/talent v1.2.0/go.mod h1:MoNF9bhFQbiJ6eFD3uSsg0uBALw4n4gaCaEjBw9zo8g= cloud.google.com/go/videointelligence v1.6.0/go.mod h1:w0DIDlVRKtwPCn/C4iwZIJdvC69yInhW0cfi+p546uU= @@ -200,18 +204,18 @@ github.com/Antonboom/errname v0.1.13 h1:JHICqsewj/fNckzrfVSe+T33svwQxmjC+1ntDsHO github.com/Antonboom/errname v0.1.13/go.mod h1:uWyefRYRN54lBg6HseYCFhs6Qjcy41Y3Jl/dVhA87Ns= github.com/Antonboom/nilnil v0.1.9 h1:eKFMejSxPSA9eLSensFmjW2XTgTwJMjZ8hUHtV4s/SQ= github.com/Antonboom/nilnil v0.1.9/go.mod h1:iGe2rYwCq5/Me1khrysB4nwI7swQvjclR8/YRPl5ihQ= -github.com/Antonboom/testifylint v1.3.1 h1:Uam4q1Q+2b6H7gvk9RQFw6jyVDdpzIirFOOrbs14eG4= -github.com/Antonboom/testifylint v1.3.1/go.mod h1:NV0hTlteCkViPW9mSR4wEMfwp+Hs1T3dY60bkvSfhpM= +github.com/Antonboom/testifylint v1.4.3 h1:ohMt6AHuHgttaQ1xb6SSnxCeK4/rnK7KKzbvs7DmEck= +github.com/Antonboom/testifylint v1.4.3/go.mod h1:+8Q9+AOLsz5ZiQiiYujJKs9mNz398+M6UgslP4qgJLA= github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU= -github.com/BurntSushi/toml v1.4.0 h1:kuoIxZQy2WRRk1pttg9asf+WVv6tWQuBNVmK8+nqPr0= -github.com/BurntSushi/toml v1.4.0/go.mod h1:ukJfTF/6rtPPRCnwkur4qwRxa8vTRFBF0uk2lLoLwho= +github.com/BurntSushi/toml v1.4.1-0.20240526193622-a339e1f7089c h1:pxW6RcqyfI9/kWtOwnv/G+AzdKuy2ZrqINhenH4HyNs= +github.com/BurntSushi/toml v1.4.1-0.20240526193622-a339e1f7089c/go.mod h1:ukJfTF/6rtPPRCnwkur4qwRxa8vTRFBF0uk2lLoLwho= github.com/BurntSushi/xgb v0.0.0-20160522181843-27f122750802/go.mod h1:IVnqGOEym/WlBOVXweHU+Q+/VP0lqqI8lqeDx9IjBqo= -github.com/Crocmagnon/fatcontext v0.2.2 h1:OrFlsDdOj9hW/oBEJBNSuH7QWf+E9WPVHw+x52bXVbk= -github.com/Crocmagnon/fatcontext v0.2.2/go.mod h1:WSn/c/+MMNiD8Pri0ahRj0o9jVpeowzavOQplBJw6u0= +github.com/Crocmagnon/fatcontext v0.4.0 h1:4ykozu23YHA0JB6+thiuEv7iT6xq995qS1vcuWZq0tg= +github.com/Crocmagnon/fatcontext v0.4.0/go.mod h1:ZtWrXkgyfsYPzS6K3O88va6t2GEglG93vnII/F94WC0= github.com/Djarvur/go-err113 v0.0.0-20210108212216-aea10b59be24 h1:sHglBQTwgx+rWPdisA5ynNEsoARbiCBOyGcJM4/OzsM= github.com/Djarvur/go-err113 v0.0.0-20210108212216-aea10b59be24/go.mod h1:4UJr5HIiMZrwgkSPdsjy2uOQExX/WEILpIrO9UPGuXs= -github.com/GaijinEntertainment/go-exhaustruct/v3 v3.2.0 h1:sATXp1x6/axKxz2Gjxv8MALP0bXaNRfQinEwyfMcx8c= -github.com/GaijinEntertainment/go-exhaustruct/v3 v3.2.0/go.mod h1:Nl76DrGNJTA1KJ0LePKBw/vznBX1EHbAZX8mwjR82nI= +github.com/GaijinEntertainment/go-exhaustruct/v3 v3.3.0 h1:/fTUt5vmbkAcMBt4YQiuC23cV0kEsN1MVMNqeOW43cU= +github.com/GaijinEntertainment/go-exhaustruct/v3 v3.3.0/go.mod h1:ONJg5sxcbsdQQ4pOW8TGdTidT2TMAUy/2Xhr8mrYaao= github.com/MakeNowJust/heredoc v1.0.0 h1:cXCdzVdstXyiTqTvfqk9SDHpKNjxuom+DOlyEeQ4pzQ= github.com/MakeNowJust/heredoc v1.0.0/go.mod h1:mG5amYoWBHf8vpLOuehzbGGw0EHxpZZ6lCpQ4fNJ8LE= github.com/Masterminds/goutils v1.1.1 h1:5nUrii3FMTL5diU80unEVvNevw1nH4+ZV4DSLVJLSYI= @@ -309,8 +313,8 @@ github.com/bmatcuk/doublestar v1.3.4 h1:gPypJ5xD31uhX6Tf54sDPUOBXTqKH4c9aPY66CyQ github.com/bmatcuk/doublestar v1.3.4/go.mod h1:wiQtGV+rzVYxB7WIlirSN++5HPtPlXEo9MEoZQC/PmE= github.com/bmatcuk/doublestar/v4 v4.6.0 h1:HTuxyug8GyFbRkrffIpzNCSK4luc0TY3wzXvzIZhEXc= github.com/bmatcuk/doublestar/v4 v4.6.0/go.mod h1:xBQ8jztBU6kakFMg+8WGxn0c6z1fTSPVIjEY1Wr7jzc= -github.com/bombsimon/wsl/v4 v4.2.1 h1:Cxg6u+XDWff75SIFFmNsqnIOgob+Q9hG6y/ioKbRFiM= -github.com/bombsimon/wsl/v4 v4.2.1/go.mod h1:Xu/kDxGZTofQcDGCtQe9KCzhHphIe0fDuyWTxER9Feo= +github.com/bombsimon/wsl/v4 v4.4.1 h1:jfUaCkN+aUpobrMO24zwyAMwMAV5eSziCkOKEauOLdw= +github.com/bombsimon/wsl/v4 v4.4.1/go.mod h1:Xu/kDxGZTofQcDGCtQe9KCzhHphIe0fDuyWTxER9Feo= github.com/bradleyfalzon/ghinstallation/v2 v2.5.0 h1:yaYcGQ7yEIGbsJfW/9z7v1sLiZg/5rSNNXwmMct5XaE= github.com/bradleyfalzon/ghinstallation/v2 v2.5.0/go.mod h1:amcvPQMrRkWNdueWOjPytGL25xQGzox7425qMgzo+Vo= github.com/breathingdust/go-changelog v0.0.0-20210127001721-f985d5709c15 h1:OUv8PSGE8S6CPWWKc+2T7tyLwcKKERcvWn19O4KiUu4= @@ -368,11 +372,9 @@ github.com/cncf/xds/go v0.0.0-20210805033703-aa0b78936158/go.mod h1:eXthEFrGJvWH github.com/cncf/xds/go v0.0.0-20210922020428-25de7278fc84/go.mod h1:eXthEFrGJvWHgFFCl3hGmgk+/aYT6PnTQLykKQRLhEs= github.com/cncf/xds/go v0.0.0-20211001041855-01bcc9b48dfe/go.mod h1:eXthEFrGJvWHgFFCl3hGmgk+/aYT6PnTQLykKQRLhEs= github.com/cncf/xds/go v0.0.0-20211011173535-cb28da3451f1/go.mod h1:eXthEFrGJvWHgFFCl3hGmgk+/aYT6PnTQLykKQRLhEs= -github.com/cncf/xds/go v0.0.0-20240318125728-8a4994d93e50 h1:DBmgJDC9dTfkVyGgipamEh2BpGYxScCH1TOF1LL1cXc= -github.com/cncf/xds/go v0.0.0-20240318125728-8a4994d93e50/go.mod h1:5e1+Vvlzido69INQaVO6d87Qn543Xr6nooe9Kz7oBFM= github.com/coreos/go-semver v0.3.0/go.mod h1:nnelYz7RCh+5ahJtPPxZlU+153eP4D4r3EedlOD2RNk= github.com/coreos/go-systemd/v22 v22.3.2/go.mod h1:Y58oyj3AT4RCenI/lSvhwexgC+NSVTIJ3seZv2GcEnc= -github.com/cpuguy83/go-md2man/v2 v2.0.3/go.mod h1:tgQtvFlXSQOSOSIRvRPT7W67SCa46tRHOmNcaadrF8o= +github.com/cpuguy83/go-md2man/v2 v2.0.4/go.mod h1:tgQtvFlXSQOSOSIRvRPT7W67SCa46tRHOmNcaadrF8o= github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E= github.com/creack/pty v1.1.17 h1:QeVUsEDNrLBW4tMgZHvxy18sKtr6VI492kBhUfhDJNI= github.com/creack/pty v1.1.17/go.mod h1:MOBLtS5ELjhRRrroQr9kyvTxUAFNvYEK993ew/Vr4O4= @@ -404,8 +406,6 @@ github.com/envoyproxy/go-control-plane v0.9.9-0.20210512163311-63b5d3c536b0/go.m github.com/envoyproxy/go-control-plane v0.9.10-0.20210907150352-cf90f659a021/go.mod h1:AFq3mo9L8Lqqiid3OhADV3RfLJnjiw63cSpi+fDTRC0= github.com/envoyproxy/go-control-plane v0.10.2-0.20220325020618-49ff273808a1/go.mod h1:KJwIaB5Mv44NWtYuAOFCVOjcI94vtpEz2JU/D2v6IjE= github.com/envoyproxy/protoc-gen-validate v0.1.0/go.mod h1:iSmxcyjqTsJpI2R4NaDN7+kN2VEUnK/pcBlmesArF7c= -github.com/envoyproxy/protoc-gen-validate v1.0.4 h1:gVPz/FMfvh57HdSJQyvBtF00j8JU4zdyUgIUNhlgg0A= -github.com/envoyproxy/protoc-gen-validate v1.0.4/go.mod h1:qys6tmnRsYrQqIhm2bvKZH4Blx/1gTIZ2UKVY1M+Yew= github.com/ettle/strcase v0.2.0 h1:fGNiVF21fHXpX1niBgk0aROov1LagYsOwV/xqKDKR/Q= github.com/ettle/strcase v0.2.0/go.mod h1:DajmHElDSaX76ITe3/VHVyMin4LWSJN5Z909Wp+ED1A= github.com/fatih/color v1.7.0/go.mod h1:Zm6kSWBoL9eyXnKyktHP6abPY2pDugNf5KwzbycvMj4= @@ -459,8 +459,8 @@ github.com/go-logfmt/logfmt v0.3.0/go.mod h1:Qt1PoO58o5twSAckw1HlFXLmHsOX5/0LbT9 github.com/go-logfmt/logfmt v0.4.0/go.mod h1:3RMwSq7FuexP4Kalkev3ejPJsZTpXXBr9+V4qmtdjCk= github.com/go-logfmt/logfmt v0.5.0/go.mod h1:wCYkCAKZfumFQihp8CzCvQ3paCTfi41vtzG1KdI/P7A= github.com/go-logr/logr v1.2.2/go.mod h1:jdQByPbusPIv2/zmleS9BjJVeZ6kBagPoEUsqbVz/1A= -github.com/go-logr/logr v1.4.1 h1:pKouT5E8xu9zeFC39JXRDukb6JFQPXM5p5I91188VAQ= -github.com/go-logr/logr v1.4.1/go.mod h1:9T104GzyrTigFIr8wt5mBrctHMim0Nb2HLGrmQ40KvY= +github.com/go-logr/logr v1.4.2 h1:6pFjapn8bFcIbiKo3XT4j/BhANplGihG6tvd+8rYgrY= +github.com/go-logr/logr v1.4.2/go.mod h1:9T104GzyrTigFIr8wt5mBrctHMim0Nb2HLGrmQ40KvY= github.com/go-logr/stdr v1.2.2 h1:hSWxHoqTgW2S2qGc0LTAI563KZ5YKYRhT3MFKZMbjag= github.com/go-logr/stdr v1.2.2/go.mod h1:mMo/vtBO5dYbehREoey6XUKy/eSumjCCveDpRre4VKE= github.com/go-openapi/errors v0.20.2 h1:dxy7PGTqEh94zj2E3h1cUmQQWiM1+aeCROfAr02EmK8= @@ -501,8 +501,8 @@ github.com/go-xmlfmt/xmlfmt v1.1.2/go.mod h1:aUCEOzzezBEjDBbFBoSiya/gduyIiWYRP6C github.com/gobwas/glob v0.2.3 h1:A4xDbljILXROh+kObIiy5kIaPYD8e96x1tgBhUI5J+Y= github.com/gobwas/glob v0.2.3/go.mod h1:d3Ez4x06l9bZtSvzIay5+Yzi0fmZzPgnTbPcKjJAkT8= github.com/godbus/dbus/v5 v5.0.4/go.mod h1:xhWf0FNVPg57R7Z0UbKHbJfkEywrmjJnf7w5xrFpKfA= -github.com/gofrs/flock v0.8.1 h1:+gYjHKf32LDeiEEFhQaotPbLuUXjY5ZqxKgXy7n59aw= -github.com/gofrs/flock v0.8.1/go.mod h1:F1TvTiK9OcQqauNUHlbJvyl9Qa1QvF/gOUDKA14jxHU= +github.com/gofrs/flock v0.12.1 h1:MTLVXXHf8ekldpJk3AKicLij9MdwOWkZ+a/jHHZby9E= +github.com/gofrs/flock v0.12.1/go.mod h1:9zxTsyu5xtJ9DK+1tFZyibEV7y3uwDxPPfbxeeHCoD0= github.com/gogo/protobuf v1.1.1/go.mod h1:r8qH/GZQm5c6nD/R0oafs1akxWv10x8SbQlK7atdtwQ= github.com/gogo/protobuf v1.3.2/go.mod h1:P1XiOD3dCwIKUDQYPy72D8LYyHL2YPYrpS2s69NZV8Q= github.com/golang-jwt/jwt/v4 v4.5.0 h1:7cYmW1XlMY7h7ii7UhUyChSgS5wUJEnm9uZVTGqOWzg= @@ -545,10 +545,10 @@ github.com/golang/snappy v0.0.1/go.mod h1:/XxbfmMg8lxefKM7IXC3fBNl/7bRcc72aCRzEW github.com/golang/snappy v0.0.3/go.mod h1:/XxbfmMg8lxefKM7IXC3fBNl/7bRcc72aCRzEWrmP2Q= github.com/golangci/dupl v0.0.0-20180902072040-3e9179ac440a h1:w8hkcTqaFpzKqonE9uMCefW1WDie15eSP/4MssdenaM= github.com/golangci/dupl v0.0.0-20180902072040-3e9179ac440a/go.mod h1:ryS0uhF+x9jgbj/N71xsEqODy9BN81/GonCZiOzirOk= -github.com/golangci/gofmt v0.0.0-20231018234816-f50ced29576e h1:ULcKCDV1LOZPFxGZaA6TlQbiM3J2GCPnkx/bGF6sX/g= -github.com/golangci/gofmt v0.0.0-20231018234816-f50ced29576e/go.mod h1:Pm5KhLPA8gSnQwrQ6ukebRcapGb/BG9iUkdaiCcGHJM= -github.com/golangci/golangci-lint v1.59.1 h1:CRRLu1JbhK5avLABFJ/OHVSQ0Ie5c4ulsOId1h3TTks= -github.com/golangci/golangci-lint v1.59.1/go.mod h1:jX5Oif4C7P0j9++YB2MMJmoNrb01NJ8ITqKWNLewThg= +github.com/golangci/gofmt v0.0.0-20240816233607-d8596aa466a9 h1:/1322Qns6BtQxUZDTAT4SdcoxknUki7IAoK4SAXr8ME= +github.com/golangci/gofmt v0.0.0-20240816233607-d8596aa466a9/go.mod h1:Oesb/0uFAyWoaw1U1qS5zyjCg5NP9C9iwjnI4tIsXEE= +github.com/golangci/golangci-lint v1.60.3 h1:l38A5de24ZeDlcFF+EB7m3W5joPD99/hS5SIHJPyZa0= +github.com/golangci/golangci-lint v1.60.3/go.mod h1:J4vOpcjzRI+lDL2DKNGBZVB3EQSBfCBCMpaydWLtJNo= github.com/golangci/misspell v0.6.0 h1:JCle2HUTNWirNlDIAUO44hUsKhOFqGPoC4LZxlaSXDs= github.com/golangci/misspell v0.6.0/go.mod h1:keMNyY6R9isGaSAu+4Q8NMBwMPkh15Gtc8UCVoDtAWo= github.com/golangci/modinfo v0.3.4 h1:oU5huX3fbxqQXdfspamej74DFX0kyGLkw1ppvXoJ8GA= @@ -595,8 +595,8 @@ github.com/google/martian v2.1.0+incompatible/go.mod h1:9I4somxYTbIHy5NJKHRl3wXi github.com/google/martian/v3 v3.0.0/go.mod h1:y5Zk1BBys9G+gd6Jrk0W3cC1+ELVxBWuIGO+w/tUAp0= github.com/google/martian/v3 v3.1.0/go.mod h1:y5Zk1BBys9G+gd6Jrk0W3cC1+ELVxBWuIGO+w/tUAp0= github.com/google/martian/v3 v3.2.1/go.mod h1:oBOf6HBosgwRXnUGWUB05QECsc6uvmMiJ3+6W4l/CUk= -github.com/google/martian/v3 v3.3.2 h1:IqNFLAmvJOgVlpdEBiQbDc2EwKW77amAycfTuWKdfvw= -github.com/google/martian/v3 v3.3.2/go.mod h1:oBOf6HBosgwRXnUGWUB05QECsc6uvmMiJ3+6W4l/CUk= +github.com/google/martian/v3 v3.3.3 h1:DIhPTQrbPkgs2yJYdXU/eNACCG5DVQjySNRNlflZ9Fc= +github.com/google/martian/v3 v3.3.3/go.mod h1:iEPrYcgCF7jA9OtScMFQyAlZZ4YXTKEtJ1E6RWzmBA0= github.com/google/pprof v0.0.0-20181206194817-3ea8567a2e57/go.mod h1:zfwlbNMJ+OItoe0UupaVj+oy1omPYYDuagoSzA8v9mc= github.com/google/pprof v0.0.0-20190515194954-54271f7e092f/go.mod h1:zfwlbNMJ+OItoe0UupaVj+oy1omPYYDuagoSzA8v9mc= github.com/google/pprof v0.0.0-20191218002539-d4f498aebedc/go.mod h1:ZgVRPoUq/hfqzAqh7sHMqb3I9Rq5C59dIz2SbBwJ4eM= @@ -611,11 +611,11 @@ github.com/google/pprof v0.0.0-20210226084205-cbba55b83ad5/go.mod h1:kpwsk12EmLe github.com/google/pprof v0.0.0-20210601050228-01bbb1931b22/go.mod h1:kpwsk12EmLew5upagYY7GY0pfYCcupk39gWOCRROcvE= github.com/google/pprof v0.0.0-20210609004039-a478d1d731e9/go.mod h1:kpwsk12EmLew5upagYY7GY0pfYCcupk39gWOCRROcvE= github.com/google/pprof v0.0.0-20210720184732-4bb14d4b1be1/go.mod h1:kpwsk12EmLew5upagYY7GY0pfYCcupk39gWOCRROcvE= -github.com/google/pprof v0.0.0-20240424215950-a892ee059fd6 h1:k7nVchz72niMH6YLQNvHSdIE7iqsQxK1P41mySCvssg= -github.com/google/pprof v0.0.0-20240424215950-a892ee059fd6/go.mod h1:kf6iHlnVGwgKolg33glAes7Yg/8iWP8ukqeldJSO7jw= +github.com/google/pprof v0.0.0-20240727154555-813a5fbdbec8 h1:FKHo8hFI3A+7w0aUQuYXQ+6EN5stWmeY/AZqtM8xk9k= +github.com/google/pprof v0.0.0-20240727154555-813a5fbdbec8/go.mod h1:K1liHPHnj73Fdn/EKuT8nrFqBihUSKXoLYU0BuatOYo= github.com/google/renameio v0.1.0/go.mod h1:KWCgfxg9yswjAJkECMjeO8J8rahYeXnNhOm40UhjYkI= -github.com/google/s2a-go v0.1.7 h1:60BLSyTrOV4/haCDW4zb1guZItoSq8foHCXrAnjBo/o= -github.com/google/s2a-go v0.1.7/go.mod h1:50CgR4k1jNlWBu4UfS4AcfhVe1r6pdZPygJ3R8F0Qdw= +github.com/google/s2a-go v0.1.8 h1:zZDs9gcbt9ZPLV0ndSyQk6Kacx2g/X+SKYovpnz3SMM= +github.com/google/s2a-go v0.1.8/go.mod h1:6iNWHTpQ+nfNRN5E00MSdfDwVesa8hhS32PhPO8deJA= github.com/google/uuid v1.1.1/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo= github.com/google/uuid v1.1.2/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo= github.com/google/uuid v1.3.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo= @@ -635,8 +635,8 @@ github.com/googleapis/gax-go/v2 v2.3.0/go.mod h1:b8LNqSzNabLiUpXKkY7HAR5jr6bIT99 github.com/googleapis/gax-go/v2 v2.4.0/go.mod h1:XOTVJ59hdnfJLIP/dh8n5CGryZR2LxK9wbMD5+iXC6c= github.com/googleapis/gax-go/v2 v2.5.1/go.mod h1:h6B0KMMFNtI2ddbGJn3T3ZbwkeT6yqEF02fYlzkUCyo= github.com/googleapis/gax-go/v2 v2.6.0/go.mod h1:1mjbznJAPHFpesgE5ucqfYEscaz5kMdcIDwU/6+DDoY= -github.com/googleapis/gax-go/v2 v2.12.0 h1:A+gCJKdRfqXkr+BIRGtZLibNXf0m1f9E4HG56etFpas= -github.com/googleapis/gax-go/v2 v2.12.0/go.mod h1:y+aIqrI5eb1YGMVJfuV3185Ts/D7qKpsEkdD5+I6QGU= +github.com/googleapis/gax-go/v2 v2.13.0 h1:yitjD5f7jQHhyDsnhKEBU52NdvvdSeGzlAnDPT0hH1s= +github.com/googleapis/gax-go/v2 v2.13.0/go.mod h1:Z/fvTZXF8/uw7Xu5GuslPw+bplx6SS338j1Is2S+B7A= github.com/googleapis/go-type-adapters v1.0.0/go.mod h1:zHW75FOG2aur7gAO2B+MLby+cLsWGBF62rFAi7WjWO4= github.com/gookit/color v1.5.4 h1:FZmqs7XOyGgCAxmWyPslpiok1k05wmY3SJTytgvYFs0= github.com/gookit/color v1.5.4/go.mod h1:pZJOeOS8DM43rXbp4AZo1n9zCU2qjpcRko0b6/QJi9w= @@ -769,8 +769,8 @@ github.com/jingyugao/rowserrcheck v1.1.1 h1:zibz55j/MJtLsjP1OF4bSdgXxwL1b+Vn7Tjz github.com/jingyugao/rowserrcheck v1.1.1/go.mod h1:4yvlZSDb3IyDTUZJUmpZfm2Hwok+Dtp+nu2qOq+er9c= github.com/jirfag/go-printf-func-name v0.0.0-20200119135958-7558a9eaa5af h1:KA9BjwUk7KlCh6S9EAGWBt1oExIUv9WyNCiRz5amv48= github.com/jirfag/go-printf-func-name v0.0.0-20200119135958-7558a9eaa5af/go.mod h1:HEWGJkRDzjJY2sqdDwxccsGicWEf9BQOZsq2tV+xzM0= -github.com/jjti/go-spancheck v0.6.1 h1:ZK/wE5Kyi1VX3PJpUO2oEgeoI4FWOUm7Shb2Gbv5obI= -github.com/jjti/go-spancheck v0.6.1/go.mod h1:vF1QkOO159prdo6mHRxak2CpzDpHAfKiPUDP/NeRnX8= +github.com/jjti/go-spancheck v0.6.2 h1:iYtoxqPMzHUPp7St+5yA8+cONdyXD3ug6KK15n7Pklk= +github.com/jjti/go-spancheck v0.6.2/go.mod h1:+X7lvIrR5ZdUTkxFYqzJ0abr8Sb5LOo80uOhWNqIrYA= github.com/jmespath/go-jmespath v0.4.0 h1:BEgLn5cpjn8UN1mAw4NjwDrS35OdebyEtFe+9YPoQUg= github.com/jmespath/go-jmespath v0.4.0/go.mod h1:T8mJZnbsbmF+m6zOOFylbeCJqk5+pHWvzYPziyZiYoo= github.com/jmespath/go-jmespath/internal/testify v1.5.1 h1:shLQSRRSCCPj3f2gpwzGwWFoC7ycTf1rcQZHOlsJ6N8= @@ -886,8 +886,8 @@ github.com/matttproud/golang_protobuf_extensions v1.0.1 h1:4hp9jkHxhMHkqkrB3Ix0j github.com/matttproud/golang_protobuf_extensions v1.0.1/go.mod h1:D8He9yQNgCq6Z5Ld7szi9bcBfOoFv/3dc6xSMkL2PC0= github.com/mergestat/timediff v0.0.3 h1:ucCNh4/ZrTPjFZ081PccNbhx9spymCJkFxSzgVuPU+Y= github.com/mergestat/timediff v0.0.3/go.mod h1:yvMUaRu2oetc+9IbPLYBJviz6sA7xz8OXMDfhBl7YSI= -github.com/mgechev/revive v1.3.7 h1:502QY0vQGe9KtYJ9FpxMz9rL+Fc/P13CI5POL4uHCcE= -github.com/mgechev/revive v1.3.7/go.mod h1:RJ16jUbF0OWC3co/+XTxmFNgEpUPwnnA0BRllX2aDNA= +github.com/mgechev/revive v1.3.9 h1:18Y3R4a2USSBF+QZKFQwVkBROUda7uoBlkEuBD+YD1A= +github.com/mgechev/revive v1.3.9/go.mod h1:+uxEIr5UH0TjXWHTno3xh4u7eg6jDpXKzQccA9UGhHU= github.com/mgutz/ansi v0.0.0-20170206155736-9520e82c474b/go.mod h1:01TrycV0kFyexm33Z7vhZRXopbI8J3TDReVlkTgMUxE= github.com/mgutz/ansi v0.0.0-20200706080929-d51e80ef957d h1:5PJl274Y63IEHC+7izoQE9x6ikvDFZS2mDVS3drnohI= github.com/mgutz/ansi v0.0.0-20200706080929-d51e80ef957d/go.mod h1:01TrycV0kFyexm33Z7vhZRXopbI8J3TDReVlkTgMUxE= @@ -923,8 +923,8 @@ github.com/modern-go/reflect2 v0.0.0-20180701023420-4b7aa43c6742/go.mod h1:bx2lN github.com/modern-go/reflect2 v1.0.1/go.mod h1:bx2lNnkwVCuqBIxFjflWJWanXIb3RllmbCylyMrvgv0= github.com/modern-go/reflect2 v1.0.2/go.mod h1:yWuevngMOJpCy52FWWMvUC8ws7m/LJsjYzDa0/r8luk= github.com/montanaflynn/stats v0.0.0-20171201202039-1bf9dbcd8cbe/go.mod h1:wL8QJuTMNUDYhXwkmfOly8iTdp5TEcJFWZD2D7SIkUc= -github.com/moricho/tparallel v0.3.1 h1:fQKD4U1wRMAYNngDonW5XupoB/ZGJHdpzrWqgyg9krA= -github.com/moricho/tparallel v0.3.1/go.mod h1:leENX2cUv7Sv2qDgdi0D0fCftN8fRC67Bcn8pqzeYNI= +github.com/moricho/tparallel v0.3.2 h1:odr8aZVFA3NZrNybggMkYO3rgPRcqjeQUlBBFVxKHTI= +github.com/moricho/tparallel v0.3.2/go.mod h1:OQ+K3b4Ln3l2TZveGCywybl68glfLEwFGqvnjok8b+U= github.com/muesli/reflow v0.3.0 h1:IFsN6K9NfGtjeggFP+68I4chLZV2yIKsXJFNZ+eWh6s= github.com/muesli/reflow v0.3.0/go.mod h1:pbwTDkVPibjO2kyvBQRBxTWEEGDGq0FlB1BIKtnHY/8= github.com/muesli/termenv v0.12.0 h1:KuQRUE3PgxRFWhq4gHvZtPSLCGDqM5q/cYr1pZ39ytc= @@ -947,10 +947,10 @@ github.com/oklog/ulid v1.3.1 h1:EGfNDEx6MqHz8B3uNV6QAib1UR2Lm97sHi3ocA6ESJ4= github.com/oklog/ulid v1.3.1/go.mod h1:CirwcVhetQ6Lv90oh/F+FBtV6XMibvdAFo93nm5qn4U= github.com/olekukonko/tablewriter v0.0.5 h1:P2Ga83D34wi1o9J6Wh1mRuqd4mF/x/lgBS7N7AbDhec= github.com/olekukonko/tablewriter v0.0.5/go.mod h1:hPp6KlRPjbx+hW8ykQs1w3UBbZlj6HuIJcUGPhkA7kY= -github.com/onsi/ginkgo/v2 v2.17.3 h1:oJcvKpIb7/8uLpDDtnQuf18xVnwKp8DTD7DQ6gTd/MU= -github.com/onsi/ginkgo/v2 v2.17.3/go.mod h1:nP2DPOQoNsQmsVyv5rDA8JkXQoCs6goXIvr/PRJ1eCc= -github.com/onsi/gomega v1.33.1 h1:dsYjIxxSR755MDmKVsaFQTE22ChNBcuuTWgkUDSubOk= -github.com/onsi/gomega v1.33.1/go.mod h1:U4R44UsT+9eLIaYRB2a5qajjtQYn0hauxvRm16AVYg0= +github.com/onsi/ginkgo/v2 v2.20.0 h1:PE84V2mHqoT1sglvHc8ZdQtPcwmvvt29WLEEO3xmdZw= +github.com/onsi/ginkgo/v2 v2.20.0/go.mod h1:lG9ey2Z29hR41WMVthyJBGUBcBhGOtoPF2VFMvBXFCI= +github.com/onsi/gomega v1.34.1 h1:EUMJIKUjM8sKjYbtxQI9A4z2o+rruxnzNvpknOXie6k= +github.com/onsi/gomega v1.34.1/go.mod h1:kU1QgUvBDLXBJq618Xvm2LUX6rSAfRaFRTcdOeDLwwY= github.com/otiai10/copy v1.2.0/go.mod h1:rrF5dJ5F0t/EWSYODDu4j9/vEeYHMkc8jt0zJChqQWw= github.com/otiai10/copy v1.14.0 h1:dCI/t1iTdYGtkvCuBG2BgR6KZa83PTclw4U5n2wAllU= github.com/otiai10/copy v1.14.0/go.mod h1:ECfuL02W+/FkTWZWgQqXPWZgW9oeKCSQ5qVfSc4qc4w= @@ -982,8 +982,8 @@ github.com/pkg/profile v1.6.0/go.mod h1:qBsxPvzyUincmltOk6iyRVxHYg4adc0OFOv72ZdL github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 h1:Jamvg5psRIccs7FGNTlIRMkT8wgtp5eCXdBlqhYGL6U= github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= -github.com/polyfloyd/go-errorlint v1.5.2 h1:SJhVik3Umsjh7mte1vE0fVZ5T1gznasQG3PV7U5xFdA= -github.com/polyfloyd/go-errorlint v1.5.2/go.mod h1:sH1QC1pxxi0fFecsVIzBmxtrgd9IF/SkJpA6wqyKAJs= +github.com/polyfloyd/go-errorlint v1.6.0 h1:tftWV9DE7txiFzPpztTAwyoRLKNj9gpVm2cg8/OwcYY= +github.com/polyfloyd/go-errorlint v1.6.0/go.mod h1:HR7u8wuP1kb1NeN1zqTd1ZMlqUKPPHF+Id4vIPvDqVw= github.com/posener/complete v1.1.1/go.mod h1:em0nMJCgc9GFtwrmVmEMR/ZL6WyhyjMBndrE9hABlRI= github.com/posener/complete v1.2.3 h1:NP0eAhjcjImqslEwo/1hq7gpajME0fTLTezBKDqfXqo= github.com/posener/complete v1.2.3/go.mod h1:WZIdtGGp+qx0sLrYKtIRAruyNpv6hFCicSgv7Sy7s/s= @@ -1035,8 +1035,8 @@ github.com/rogpeppe/go-internal v1.3.0/go.mod h1:M8bDsm7K2OlrFYOpmOWEs/qY81heoFR github.com/rogpeppe/go-internal v1.12.0 h1:exVL4IDcn6na9z1rAb56Vxr+CgyK3nn3O+epU5NdKM8= github.com/rogpeppe/go-internal v1.12.0/go.mod h1:E+RYuTGaKKdloAfM02xzb0FW3Paa99yedzYV+kq4uf4= github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM= -github.com/ryancurrah/gomodguard v1.3.2 h1:CuG27ulzEB1Gu5Dk5gP8PFxSOZ3ptSdP5iI/3IXxM18= -github.com/ryancurrah/gomodguard v1.3.2/go.mod h1:LqdemiFomEjcxOqirbQCb3JFvSxH2JUYMerTFd3sF2o= +github.com/ryancurrah/gomodguard v1.3.3 h1:eiSQdJVNr9KTNxY2Niij8UReSwR8Xrte3exBrAZfqpg= +github.com/ryancurrah/gomodguard v1.3.3/go.mod h1:rsKQjj4l3LXe8N344Ow7agAy5p9yjsWOtRzUMYmA0QY= github.com/ryanrolds/sqlclosecheck v0.5.1 h1:dibWW826u0P8jNLsLN+En7+RqWWTYrjCB9fJfSfdyCU= github.com/ryanrolds/sqlclosecheck v0.5.1/go.mod h1:2g3dUjoS6AL4huFdv6wn55WpLIDjY7ZgUR4J8HOO/XQ= github.com/ryanuber/columnize v0.0.0-20160712163229-9b3edd62028f/go.mod h1:sm1tb6uqfes/u+d4ooFouqFdy9/2g9QGwK3SQygK0Ts= @@ -1054,11 +1054,11 @@ github.com/santhosh-tekuri/jsonschema/v5 v5.3.1 h1:lZUw3E0/J3roVtGQ+SCrUrg3ON6Ng github.com/santhosh-tekuri/jsonschema/v5 v5.3.1/go.mod h1:uToXkOrWAZ6/Oc07xWQrPOhJotwFIyu2bBVN41fcDUY= github.com/sashamelentyev/interfacebloat v1.1.0 h1:xdRdJp0irL086OyW1H/RTZTr1h/tMEOsumirXcOJqAw= github.com/sashamelentyev/interfacebloat v1.1.0/go.mod h1:+Y9yU5YdTkrNvoX0xHc84dxiN1iBi9+G8zZIhPVoNjQ= -github.com/sashamelentyev/usestdlibvars v1.26.0 h1:LONR2hNVKxRmzIrZR0PhSF3mhCAzvnr+DcUiHgREfXE= -github.com/sashamelentyev/usestdlibvars v1.26.0/go.mod h1:9nl0jgOfHKWNFS43Ojw0i7aRoS4j6EBye3YBhmAIRF8= +github.com/sashamelentyev/usestdlibvars v1.27.0 h1:t/3jZpSXtRPRf2xr0m63i32ZrusyurIGT9E5wAvXQnI= +github.com/sashamelentyev/usestdlibvars v1.27.0/go.mod h1:9nl0jgOfHKWNFS43Ojw0i7aRoS4j6EBye3YBhmAIRF8= github.com/sean-/seed v0.0.0-20170313163322-e2103e2c3529/go.mod h1:DxrIzT+xaE7yg65j358z/aeFdxmN0P9QXhEzd20vsDc= -github.com/securego/gosec/v2 v2.20.1-0.20240525090044-5f0084eb01a9 h1:rnO6Zp1YMQwv8AyxzuwsVohljJgp4L0ZqiCgtACsPsc= -github.com/securego/gosec/v2 v2.20.1-0.20240525090044-5f0084eb01a9/go.mod h1:dg7lPlu/xK/Ut9SedURCoZbVCR4yC7fM65DtH9/CDHs= +github.com/securego/gosec/v2 v2.20.1-0.20240822074752-ab3f6c1c83a0 h1:VqD4JMoqwuuCz8GZlBDsIDyE6K4YUsWJpbNtuOWHoFk= +github.com/securego/gosec/v2 v2.20.1-0.20240822074752-ab3f6c1c83a0/go.mod h1:iyeMMRw8QEmueUSZ2VqmkQMiDyDcobfPnG00CV/NWdE= github.com/sergi/go-diff v1.1.0/go.mod h1:STckp+ISIX8hZLjrqAeVduY0gWCT9IjLuqbuNXdaHfM= github.com/sergi/go-diff v1.3.1 h1:xkr+Oxo4BOQKmkn/B9eMK0g5Kg/983T9DqqPHwYqD+8= github.com/sergi/go-diff v1.3.1/go.mod h1:aMJSSKb2lpPvRNec0+w3fl7LP9IOFzdc9Pa4NFbPK1I= @@ -1077,8 +1077,8 @@ github.com/sirupsen/logrus v1.9.3 h1:dueUQJ1C2q9oE3F7wvmSGAaVtTmUizReu6fjN8uqzbQ github.com/sirupsen/logrus v1.9.3/go.mod h1:naHLuLoDiP4jHNo9R0sCBMtWGeIprob74mVsIT4qYEQ= github.com/sivchari/containedctx v1.0.3 h1:x+etemjbsh2fB5ewm5FeLNi5bUjK0V8n0RB+Wwfd0XE= github.com/sivchari/containedctx v1.0.3/go.mod h1:c1RDvCbnJLtH4lLcYD/GqwiBSSf4F5Qk0xld2rBqzJ4= -github.com/sivchari/tenv v1.7.1 h1:PSpuD4bu6fSmtWMxSGWcvqUUgIn7k3yOJhOIzVWn8Ak= -github.com/sivchari/tenv v1.7.1/go.mod h1:64yStXKSOxDfX47NlhVwND4dHwfZDdbp2Lyl018Icvg= +github.com/sivchari/tenv v1.10.0 h1:g/hzMA+dBCKqGXgW8AV/1xIWhAvDrx0zFKNR48NFMg0= +github.com/sivchari/tenv v1.10.0/go.mod h1:tdY24masnVoZFxYrHv/nD6Tc8FbkEtAQEEziXpyMgqY= github.com/skeema/knownhosts v1.2.1 h1:SHWdIUa82uGZz+F+47k8SY4QhhI291cXCpopT1lK2AQ= github.com/skeema/knownhosts v1.2.1/go.mod h1:xYbVRSPxqBZFrdmDyMmsOs+uX1UZC3nTN3ThzgDxUwo= github.com/sonatard/noctx v0.0.2 h1:L7Dz4De2zDQhW8S0t+KUjY0MAQJd6SgVwhzNIc4ok00= @@ -1097,8 +1097,8 @@ github.com/spf13/afero v1.11.0/go.mod h1:GH9Y3pIexgf1MTIWtNGyogA5MwRIDXGUr+hbWNo github.com/spf13/cast v1.3.1/go.mod h1:Qx5cxh0v+4UWYiBimWS+eyWzqEqokIECu5etghLkUJE= github.com/spf13/cast v1.6.0 h1:GEiTHELF+vaR5dhz3VqZfFSzZjYbgeKDpBxQVS4GYJ0= github.com/spf13/cast v1.6.0/go.mod h1:ancEpBxwJDODSW/UG4rDrAqiKolqNNh2DX3mk86cAdo= -github.com/spf13/cobra v1.8.0 h1:7aJaZx1B85qltLMc546zn58BxxfZdR/W22ej9CFoEf0= -github.com/spf13/cobra v1.8.0/go.mod h1:WXLWApfZ71AjXPya3WOlMsY9yMs7YeiHhFVlvLyhcho= +github.com/spf13/cobra v1.8.1 h1:e5/vxKd/rZsfSJMUX1agtjeTDf+qv1/JdBF8gg5k9ZM= +github.com/spf13/cobra v1.8.1/go.mod h1:wHxEcudfqmLYa8iTfL+OuZPbBZkmvliBWKIezN3kD9Y= github.com/spf13/pflag v1.0.5 h1:iy+VFUOCP1a+8yFto/drg2CJ5u0yRoB7fZw3DKv/JXA= github.com/spf13/pflag v1.0.5/go.mod h1:McXfInJRrz4CZXVZOBLb0bTZqETkiAhM9Iw0y3An2Bg= github.com/spf13/viper v1.18.2 h1:LUXCnvUvSM6FXAsj6nnfc8Q2tp1dIgUfY9Kc8GsSOiQ= @@ -1129,8 +1129,6 @@ github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsT github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY= github.com/subosito/gotenv v1.6.0 h1:9NlTDc1FTs4qu0DDq7AEtTPNw6SVm7uBMsUCUjABIf8= github.com/subosito/gotenv v1.6.0/go.mod h1:Dk4QP5c2W3ibzajGcXpNraDfq2IrhjMIvMSWPKKo0FU= -github.com/t-yuki/gocover-cobertura v0.0.0-20180217150009-aaee18c8195c h1:+aPplBwWcHBo6q9xrfWdMrT9o4kltkmmvpemgIjep/8= -github.com/t-yuki/gocover-cobertura v0.0.0-20180217150009-aaee18c8195c/go.mod h1:SbErYREK7xXdsRiigaQiQkI9McGRzYMvlKYaP3Nimdk= github.com/tdakkota/asciicheck v0.2.0 h1:o8jvnUANo0qXtnslk2d3nMKTFNlOnJjRrNcj0j9qkHM= github.com/tdakkota/asciicheck v0.2.0/go.mod h1:Qb7Y9EgjCLJGup51gDHFzbI08/gbGhL/UVhYIPWG2rg= github.com/tenntenn/modver v1.0.1 h1:2klLppGhDgzJrScMpkj9Ujy3rXPUspSjAcev9tSEBgA= @@ -1155,8 +1153,8 @@ github.com/timakin/bodyclose v0.0.0-20230421092635-574207250966 h1:quvGphlmUVU+n github.com/timakin/bodyclose v0.0.0-20230421092635-574207250966/go.mod h1:27bSVNWSBOHm+qRp1T9qzaIpsWEP6TbUnei/43HK+PQ= github.com/timonwong/loggercheck v0.9.4 h1:HKKhqrjcVj8sxL7K77beXh0adEm6DLjV/QOGeMXEVi4= github.com/timonwong/loggercheck v0.9.4/go.mod h1:caz4zlPcgvpEkXgVnAJGowHAMW2NwHaNlpS8xDbVhTg= -github.com/tomarrell/wrapcheck/v2 v2.8.3 h1:5ov+Cbhlgi7s/a42BprYoxsr73CbdMUTzE3bRDFASUs= -github.com/tomarrell/wrapcheck/v2 v2.8.3/go.mod h1:g9vNIyhb5/9TQgumxQyOEqDHsmGYcGsVMOx/xGkqdMo= +github.com/tomarrell/wrapcheck/v2 v2.9.0 h1:801U2YCAjLhdN8zhZ/7tdjB3EnAoRlJHt/s+9hijLQ4= +github.com/tomarrell/wrapcheck/v2 v2.9.0/go.mod h1:g9vNIyhb5/9TQgumxQyOEqDHsmGYcGsVMOx/xGkqdMo= github.com/tommy-muehle/go-mnd/v2 v2.5.1 h1:NowYhSdyE/1zwK9QCLeRb6USWdoif80Ie+v+yU8u1Zw= github.com/tommy-muehle/go-mnd/v2 v2.5.1/go.mod h1:WsUAkMJMYww6l/ufffCD3m+P7LEvr8TnZn9lwVDlgzw= github.com/uber-go/gopatch v0.4.0 h1:1/8EUo6Zk3+gtTHvOUsZs5ysCUlHj3NDjuF59zLXz2k= @@ -1167,8 +1165,8 @@ github.com/ultraware/funlen v0.1.0 h1:BuqclbkY6pO+cvxoq7OsktIXZpgBSkYTQtmwhAK81v github.com/ultraware/funlen v0.1.0/go.mod h1:XJqmOQja6DpxarLj6Jj1U7JuoS8PvL4nEqDaQhy22p4= github.com/ultraware/whitespace v0.1.1 h1:bTPOGejYFulW3PkcrqkeQwOd6NKOOXvmGD9bo/Gk8VQ= github.com/ultraware/whitespace v0.1.1/go.mod h1:XcP1RLD81eV4BW8UhQlpaR+SDc2givTvyI8a586WjW8= -github.com/uudashr/gocognit v1.1.2 h1:l6BAEKJqQH2UpKAPKdMfZf5kE4W/2xk8pfU1OVLvniI= -github.com/uudashr/gocognit v1.1.2/go.mod h1:aAVdLURqcanke8h3vg35BC++eseDm66Z7KmchI5et4k= +github.com/uudashr/gocognit v1.1.3 h1:l+a111VcDbKfynh+airAy/DJQKaXh2m9vkoysMPSZyM= +github.com/uudashr/gocognit v1.1.3/go.mod h1:aKH8/e8xbTRBwjbCkwZ8qt4l2EpKXl31KMHgSS+lZ2U= github.com/vmihailenco/msgpack/v4 v4.3.12/go.mod h1:gborTTJjAo/GWTqqRjrLCn9pgNN+NXzzngzBKDPIqw4= github.com/vmihailenco/msgpack/v5 v5.3.5 h1:5gO0H1iULLWGhs2H5tbAHIZTV8/cYafcFOr9znI5mJU= github.com/vmihailenco/msgpack/v5 v5.3.5/go.mod h1:7xyJ9e+0+9SaZT0Wt1RGleJXzli6Q/V5KbhBonMG9jc= @@ -1222,8 +1220,8 @@ go-simpler.org/assert v0.9.0 h1:PfpmcSvL7yAnWyChSjOz6Sp6m9j5lyK8Ok9pEL31YkQ= go-simpler.org/assert v0.9.0/go.mod h1:74Eqh5eI6vCK6Y5l3PI8ZYFXG4Sa+tkr70OIPJAUr28= go-simpler.org/musttag v0.12.2 h1:J7lRc2ysXOq7eM8rwaTYnNrHd5JwjppzB6mScysB2Cs= go-simpler.org/musttag v0.12.2/go.mod h1:uN1DVIasMTQKk6XSik7yrJoEysGtR2GRqvWnI9S7TYM= -go-simpler.org/sloglint v0.7.1 h1:qlGLiqHbN5islOxjeLXoPtUdZXb669RW+BDQ+xOSNoU= -go-simpler.org/sloglint v0.7.1/go.mod h1:OlaVDRh/FKKd4X4sIMbsz8st97vomydceL146Fthh/c= +go-simpler.org/sloglint v0.7.2 h1:Wc9Em/Zeuu7JYpl+oKoYOsQSy2X560aVueCW/m6IijY= +go-simpler.org/sloglint v0.7.2/go.mod h1:US+9C80ppl7VsThQclkM7BkCHQAzuz8kHLsW3ppuluo= go.etcd.io/etcd/api/v3 v3.5.4/go.mod h1:5GB2vv4A4AOn3yk7MftYGHkUfGtDHnEraIjym4dYz5A= go.etcd.io/etcd/client/pkg/v3 v3.5.4/go.mod h1:IJHfcCEKxYu1Os13ZdwCwIUTUVGYTSAM3YSwc9/Ac1g= go.etcd.io/etcd/client/v3 v3.5.4/go.mod h1:ZaRkVgBZC+L+dLCjTcF1hRXpgZXQPOvnA/Ak/gq3kiY= @@ -1238,18 +1236,18 @@ go.opencensus.io v0.22.5/go.mod h1:5pWMHQbX5EPX2/62yrJeAkowc+lfs/XD7Uxpq3pI6kk= go.opencensus.io v0.23.0/go.mod h1:XItmlyltB5F7CS4xOC1DcqMoFqwtC6OG2xF7mCv7P7E= go.opencensus.io v0.24.0 h1:y73uSU6J157QMP2kn2r30vwW1A2W2WFwSCGnAVxeaD0= go.opencensus.io v0.24.0/go.mod h1:vNK8G9p7aAivkbmorf4v+7Hgx+Zs0yY+0fOtgBfjQKo= -go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.47.0 h1:UNQQKPfTDe1J81ViolILjTKPr9WetKW6uei2hFgJmFs= -go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.47.0/go.mod h1:r9vWsPS/3AQItv3OSlEJ/E4mbrhUbbw18meOjArPtKQ= -go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.47.0 h1:sv9kVfal0MK0wBMCOGr+HeJm9v803BkJxGrk2au7j08= -go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.47.0/go.mod h1:SK2UL73Zy1quvRPonmOmRDiWk1KBV3LyIeeIxcEApWw= -go.opentelemetry.io/otel v1.22.0 h1:xS7Ku+7yTFvDfDraDIJVpw7XPyuHlB9MCiqqX5mcJ6Y= -go.opentelemetry.io/otel v1.22.0/go.mod h1:eoV4iAi3Ea8LkAEI9+GFT44O6T/D0GWAVFyZVCC6pMI= -go.opentelemetry.io/otel/metric v1.22.0 h1:lypMQnGyJYeuYPhOM/bgjbFM6WE44W1/T45er4d8Hhg= -go.opentelemetry.io/otel/metric v1.22.0/go.mod h1:evJGjVpZv0mQ5QBRJoBF64yMuOf4xCWdXjK8pzFvliY= -go.opentelemetry.io/otel/sdk v1.21.0 h1:FTt8qirL1EysG6sTQRZ5TokkU8d0ugCj8htOgThZXQ8= -go.opentelemetry.io/otel/sdk v1.21.0/go.mod h1:Nna6Yv7PWTdgJHVRD9hIYywQBRx7pbox6nwBnZIxl/E= -go.opentelemetry.io/otel/trace v1.22.0 h1:Hg6pPujv0XG9QaVbGOBVHunyuLcCC3jN7WEhPx83XD0= -go.opentelemetry.io/otel/trace v1.22.0/go.mod h1:RbbHXVqKES9QhzZq/fE5UnOSILqRt40a21sPw2He1xo= +go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.51.0 h1:A3SayB3rNyt+1S6qpI9mHPkeHTZbD7XILEqWnYZb2l0= +go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.51.0/go.mod h1:27iA5uvhuRNmalO+iEUdVn5ZMj2qy10Mm+XRIpRmyuU= +go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.51.0 h1:Xs2Ncz0gNihqu9iosIZ5SkBbWo5T8JhhLJFMQL1qmLI= +go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.51.0/go.mod h1:vy+2G/6NvVMpwGX/NyLqcC41fxepnuKHk16E6IZUcJc= +go.opentelemetry.io/otel v1.26.0 h1:LQwgL5s/1W7YiiRwxf03QGnWLb2HW4pLiAhaA5cZXBs= +go.opentelemetry.io/otel v1.26.0/go.mod h1:UmLkJHUAidDval2EICqBMbnAd0/m2vmpf/dAM+fvFs4= +go.opentelemetry.io/otel/metric v1.26.0 h1:7S39CLuY5Jgg9CrnA9HHiEjGMF/X2VHvoXGgSllRz30= +go.opentelemetry.io/otel/metric v1.26.0/go.mod h1:SY+rHOI4cEawI9a7N1A4nIg/nTQXe1ccCNWYOJUrpX4= +go.opentelemetry.io/otel/sdk v1.24.0 h1:YMPPDNymmQN3ZgczicBY3B6sf9n62Dlj9pWD3ucgoDw= +go.opentelemetry.io/otel/sdk v1.24.0/go.mod h1:KVrIYw6tEubO9E96HQpcmpTKDVn9gdv35HoYiQWGDFg= +go.opentelemetry.io/otel/trace v1.26.0 h1:1ieeAUb4y0TE26jUFrCIXKpTuVK7uJGN9/Z/2LP5sQA= +go.opentelemetry.io/otel/trace v1.26.0/go.mod h1:4iDxvGDQuUkHve82hJJ8UqrwswHYsZuWCBllGV2U2y0= go.opentelemetry.io/proto/otlp v0.7.0/go.mod h1:PqfVotwruBrMGOCsRd/89rSnXhoiJIqeYNgFYFoEGnI= go.uber.org/atomic v1.7.0/go.mod h1:fEN4uk6kAWBTFdckzkM89CLk9XfWZrxpCo0nPH17wJc= go.uber.org/atomic v1.11.0 h1:ZvwS0R+56ePWxUNi+Atn9dWONBPp/AUETXlHW0DxSjE= @@ -1281,8 +1279,8 @@ golang.org/x/crypto v0.1.0/go.mod h1:RecgLatLF4+eUMCP1PoPZQb+cVrJcOPbHkTkbkB9sbw golang.org/x/crypto v0.3.0/go.mod h1:hebNnKkNXi2UzZN1eVRvBB7co0a+JxK6XbPiWVs/3J4= golang.org/x/crypto v0.3.1-0.20221117191849-2c476679df9a/go.mod h1:hebNnKkNXi2UzZN1eVRvBB7co0a+JxK6XbPiWVs/3J4= golang.org/x/crypto v0.7.0/go.mod h1:pYwdfH91IfpZVANVyUOhSIPZaFoJGxTFbZhFTx+dXZU= -golang.org/x/crypto v0.24.0 h1:mnl8DM0o513X8fdIkmyFE/5hTYxbwYOjDS/+rK6qpRI= -golang.org/x/crypto v0.24.0/go.mod h1:Z1PMYSOR5nyMcyAVAIQSKCDwalqy85Aqn1x3Ws4L5DM= +golang.org/x/crypto v0.26.0 h1:RrRspgV4mU+YwB4FYnuBoKsUapNIL5cohGAmSH3azsw= +golang.org/x/crypto v0.26.0/go.mod h1:GY7jblb9wI+FOo5y8/S2oY4zWP07AkOJ4+jxCqdqn54= golang.org/x/exp v0.0.0-20190121172915-509febef88a4/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA= golang.org/x/exp v0.0.0-20190306152737-a1d7652674e8/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA= golang.org/x/exp v0.0.0-20190510132918-efd6b22b2522/go.mod h1:ZjyILWgesfNpC6sMxTJOJm9Kp84zZh5NQWvqDGG3Qr8= @@ -1293,8 +1291,8 @@ golang.org/x/exp v0.0.0-20191227195350-da58074b4299/go.mod h1:2RIsYlXP63K8oxa1u0 golang.org/x/exp v0.0.0-20200119233911-0405dc783f0a/go.mod h1:2RIsYlXP63K8oxa1u096TMicItID8zy7Y6sNkU49FU4= golang.org/x/exp v0.0.0-20200207192155-f17229e696bd/go.mod h1:J/WKrq2StrnmMY6+EHIKF9dgMWnmCNThgcyBT1FY9mM= golang.org/x/exp v0.0.0-20200224162631-6cc2880d07d6/go.mod h1:3jZMyOhIsHpP37uCMkUooju7aAi5cS1Q23tOzKc+0MU= -golang.org/x/exp v0.0.0-20240222234643-814bf88cf225 h1:LfspQV/FYTatPTr/3HzIcmiUFH7PGP+OQ6mgDYo3yuQ= -golang.org/x/exp v0.0.0-20240222234643-814bf88cf225/go.mod h1:CxmFvTBINI24O/j8iY7H1xHzx2i4OsyguNBmN/uPtqc= +golang.org/x/exp v0.0.0-20240719175910-8a7402abbf56 h1:2dVuKD2vS7b0QIHQbpyTISPd0LeHDbnYEryqj5Q1ug8= +golang.org/x/exp v0.0.0-20240719175910-8a7402abbf56/go.mod h1:M4RDyNAINzryxdtnbRXRL/OHtkFuWGRjvuhBJpk2IlY= golang.org/x/exp/typeparams v0.0.0-20220428152302-39d4317da171/go.mod h1:AbB0pIl9nAr9wVwH+Z2ZpaocVmF5I4GyWCDIsVjR0bk= golang.org/x/exp/typeparams v0.0.0-20230203172020-98cc5a0785f9/go.mod h1:AbB0pIl9nAr9wVwH+Z2ZpaocVmF5I4GyWCDIsVjR0bk= golang.org/x/exp/typeparams v0.0.0-20240314144324-c7f7c6466f7f h1:phY1HzDcf18Aq9A8KkmRtY9WvOFIxN8wgfvy6Zm1DV8= @@ -1330,8 +1328,8 @@ golang.org/x/mod v0.6.0-dev.0.20220419223038-86c51ed26bb4/go.mod h1:jJ57K6gSWd91 golang.org/x/mod v0.6.0/go.mod h1:4mET923SAdbXp2ki8ey+zGs1SLqsuM2Y0uvdZR/fUNI= golang.org/x/mod v0.7.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs= golang.org/x/mod v0.8.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs= -golang.org/x/mod v0.18.0 h1:5+9lSbEzPSdWkH32vYPBwEpX8KwDbM52Ud9xBUvNlb0= -golang.org/x/mod v0.18.0/go.mod h1:hTbmBsO62+eylJbnUtE2MGJUyE7QWk4xUqPFrRgJ+7c= +golang.org/x/mod v0.20.0 h1:utOm6MM3R3dnawAiJgn0y+xvuYRsm1RKM/4giyfDgV0= +golang.org/x/mod v0.20.0/go.mod h1:hTbmBsO62+eylJbnUtE2MGJUyE7QWk4xUqPFrRgJ+7c= golang.org/x/net v0.0.0-20180724234803-3673e40ba225/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4= golang.org/x/net v0.0.0-20180826012351-8a410e7b638d/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4= golang.org/x/net v0.0.0-20181114220301-adae6a3d119a/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4= @@ -1392,8 +1390,8 @@ golang.org/x/net v0.5.0/go.mod h1:DivGGAXEgPSlEBzxGzZI+ZLohi+xUj054jfeKui00ws= golang.org/x/net v0.6.0/go.mod h1:2Tu9+aMcznHK/AK1HMvgo6xiTLG5rD5rZLDS+rp2Bjs= golang.org/x/net v0.8.0/go.mod h1:QVkue5JL9kW//ek3r6jTKnTFis1tRmNAW2P1shuFdJc= golang.org/x/net v0.10.0/go.mod h1:0qNGK6F8kojg2nk9dLZ2mShWaEBan6FAoqfSigmmuDg= -golang.org/x/net v0.26.0 h1:soB7SVo0PWrY4vPW/+ay0jKDNScG2X9wFeYlXIvJsOQ= -golang.org/x/net v0.26.0/go.mod h1:5YKkiSynbBIh3p6iOc/vibscux0x38BZDkn8sCUPxHE= +golang.org/x/net v0.28.0 h1:a9JDOJc5GMUJ0+UDqmLT86WiEy7iWyIhz8gz8E4e5hE= +golang.org/x/net v0.28.0/go.mod h1:yqtgsTWOOnlGLG9GFRrK3++bGOUEkNBoHZc8MEDWPNg= golang.org/x/oauth2 v0.0.0-20180821212333-d2e6202438be/go.mod h1:N/0e6XlmueqKjAGxoOufVs8QHGRruUQn6yWY3a++T0U= golang.org/x/oauth2 v0.0.0-20190226205417-e64efc72b421/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw= golang.org/x/oauth2 v0.0.0-20190604053449-0f29369cfe45/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw= @@ -1420,8 +1418,8 @@ golang.org/x/oauth2 v0.0.0-20220909003341-f21342109be1/go.mod h1:h4gKUeWbJ4rQPri golang.org/x/oauth2 v0.0.0-20221014153046-6fdb5e3db783/go.mod h1:h4gKUeWbJ4rQPri7E0u6Gs4e9Ri2zaLxzw5DI5XGrYg= golang.org/x/oauth2 v0.1.0/go.mod h1:G9FE4dLTsbXUu90h/Pf85g4w1D+SSAgR+q46nJZ8M4A= golang.org/x/oauth2 v0.8.0/go.mod h1:yr7u4HXZRm1R1kBWqr/xKNqewf0plRYoB7sla+BCIXE= -golang.org/x/oauth2 v0.21.0 h1:tsimM75w1tF/uws5rbeHzIWxEqElMehnc+iW793zsZs= -golang.org/x/oauth2 v0.21.0/go.mod h1:XYTD2NtWslqkgxebSiOHnXEap4TF09sJSc7H1sXbhtI= +golang.org/x/oauth2 v0.22.0 h1:BzDx2FehcG7jJwgWLELCdmLuxk2i+x9UDpSiss2u0ZA= +golang.org/x/oauth2 v0.22.0/go.mod h1:XYTD2NtWslqkgxebSiOHnXEap4TF09sJSc7H1sXbhtI= golang.org/x/sync v0.0.0-20180314180146-1d60e4601c6f/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= golang.org/x/sync v0.0.0-20181108010431-42b317875d0f/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= golang.org/x/sync v0.0.0-20181221193216-37e7f081c4d4/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= @@ -1437,8 +1435,8 @@ golang.org/x/sync v0.0.0-20220601150217-0de741cfad7f/go.mod h1:RxMgew5VJxzue5/jJ golang.org/x/sync v0.0.0-20220722155255-886fb9371eb4/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= golang.org/x/sync v0.0.0-20220929204114-8fcdb60fdcc0/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= golang.org/x/sync v0.1.0/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= -golang.org/x/sync v0.7.0 h1:YsImfSBoP9QPYL0xyKJPq0gcaJdG3rInoqxTWbfQu9M= -golang.org/x/sync v0.7.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk= +golang.org/x/sync v0.8.0 h1:3NFvSEYkUoMifnESzZl15y791HH1qU2xm6eCJU5ZPXQ= +golang.org/x/sync v0.8.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk= golang.org/x/sys v0.0.0-20180823144017-11551d06cbcc/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= golang.org/x/sys v0.0.0-20180830151530-49385e6e1522/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= golang.org/x/sys v0.0.0-20180905080454-ebe1bf3edb33/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= @@ -1528,7 +1526,6 @@ golang.org/x/sys v0.0.0-20220520151302-bc2c85ada10a/go.mod h1:oPkhp1MJrh7nUepCBc golang.org/x/sys v0.0.0-20220610221304-9f5ed59c137d/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.0.0-20220615213510-4f61da869c0c/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.0.0-20220624220833-87e55d714810/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= -golang.org/x/sys v0.0.0-20220702020025-31831981b65f/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.0.0-20220715151400-c0bba94af5f8/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.0.0-20220722155257-8c9f86f7a55f/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.0.0-20220728004956-3c1f35247d10/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= @@ -1540,8 +1537,8 @@ golang.org/x/sys v0.4.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.5.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.8.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= -golang.org/x/sys v0.21.0 h1:rF+pYz3DAGSQAxAu1CbC7catZg4ebC4UIeIhKxBZvws= -golang.org/x/sys v0.21.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA= +golang.org/x/sys v0.23.0 h1:YfKFowiIMvtgl1UERQoTPPToxltDeZfbj4H7dVUCwmM= +golang.org/x/sys v0.23.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA= golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo= golang.org/x/term v0.0.0-20210503060354-a79de5458b56/go.mod h1:tfny5GFUkzUvx4ps4ajbZsCe5lw1metzhBm9T3x7oIY= golang.org/x/term v0.0.0-20210927222741-03fcf44c2211/go.mod h1:jbD1KX2456YbFQfuXm/mYQcufACuNUgVhRMnK/tPxf8= @@ -1551,8 +1548,8 @@ golang.org/x/term v0.4.0/go.mod h1:9P2UbLfCdcvo3p/nzKvsmas4TnlujnuoV9hGgYzW1lQ= golang.org/x/term v0.5.0/go.mod h1:jMB1sMXY+tzblOD4FWmEbocvup2/aLOaQEp7JmGp78k= golang.org/x/term v0.6.0/go.mod h1:m6U89DPEgQRMq3DNkDClhWw02AUbt2daBVO4cn4Hv9U= golang.org/x/term v0.8.0/go.mod h1:xPskH00ivmX89bAKVGSKKtLOWNx2+17Eiy94tnKShWo= -golang.org/x/term v0.21.0 h1:WVXCp+/EBEHOj53Rvu+7KiT/iElMrO8ACK16SMZ3jaA= -golang.org/x/term v0.21.0/go.mod h1:ooXLefLobQVslOqselCNF4SxFAaoS6KujMbsGzSDmX0= +golang.org/x/term v0.23.0 h1:F6D4vR+EHoL9/sWAWgAR1H2DcHr4PareCbAaCo1RpuU= +golang.org/x/term v0.23.0/go.mod h1:DgV24QBUrK6jhZXl+20l6UWznPlwAHm1Q1mGHtydmSk= golang.org/x/text v0.0.0-20170915032832-14c0d48ead0c/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= golang.org/x/text v0.3.1-0.20180807135948-17ff2d5776d2/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= @@ -1568,13 +1565,13 @@ golang.org/x/text v0.6.0/go.mod h1:mrYo+phRRbMaCq/xk9113O4dZlRixOauAjOtrjsXDZ8= golang.org/x/text v0.7.0/go.mod h1:mrYo+phRRbMaCq/xk9113O4dZlRixOauAjOtrjsXDZ8= golang.org/x/text v0.8.0/go.mod h1:e1OnstbJyHTd6l/uOt8jFFHp6TRDWZR/bV3emEE/zU8= golang.org/x/text v0.9.0/go.mod h1:e1OnstbJyHTd6l/uOt8jFFHp6TRDWZR/bV3emEE/zU8= -golang.org/x/text v0.16.0 h1:a94ExnEXNtEwYLGJSIUxnWoxoRz/ZcCsV63ROupILh4= -golang.org/x/text v0.16.0/go.mod h1:GhwF1Be+LQoKShO3cGOHzqOgRrGaYc9AvblQOmPVHnI= +golang.org/x/text v0.17.0 h1:XtiM5bkSOt+ewxlOE/aE/AKEHibwj/6gvWMl9Rsh0Qc= +golang.org/x/text v0.17.0/go.mod h1:BuEKDfySbSR4drPmRPG/7iBdf8hvFMuRexcpahXilzY= golang.org/x/time v0.0.0-20181108054448-85acf8d2951c/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ= golang.org/x/time v0.0.0-20190308202827-9d24e82272b4/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ= golang.org/x/time v0.0.0-20191024005414-555d28b269f0/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ= -golang.org/x/time v0.5.0 h1:o7cqy6amK/52YcAKIPlM3a+Fpj35zvRj2TP+e1xFSfk= -golang.org/x/time v0.5.0/go.mod h1:3BpzKBy/shNhVucY/MWOyx10tF3SFh9QdLuxbVysPQM= +golang.org/x/time v0.6.0 h1:eTDhh4ZXt5Qf0augr54TN6suAUudPcawVZeIAPU7D4U= +golang.org/x/time v0.6.0/go.mod h1:3BpzKBy/shNhVucY/MWOyx10tF3SFh9QdLuxbVysPQM= golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= golang.org/x/tools v0.0.0-20190114222345-bf090417da8b/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= golang.org/x/tools v0.0.0-20190226205152-f727befe758c/go.mod h1:9Yl7xja0Znq3iFh3HoIrodX9oNMXvdceNzlUR8zjMvY= @@ -1641,14 +1638,13 @@ golang.org/x/tools v0.1.4/go.mod h1:o0xws9oXOQQZyjljx8fwUC0k7L1pTE6eaCbjGeHmOkk= golang.org/x/tools v0.1.5/go.mod h1:o0xws9oXOQQZyjljx8fwUC0k7L1pTE6eaCbjGeHmOkk= golang.org/x/tools v0.1.9/go.mod h1:nABZi5QlRsZVlzPpHl034qft6wpY4eDcsTt5AaioBiU= golang.org/x/tools v0.1.10/go.mod h1:Uh6Zz+xoGYZom868N8YTex3t7RhtHDBrE8Gzo9bV56E= -golang.org/x/tools v0.1.11/go.mod h1:SgwaegtQh8clINPpECJMqnxLv9I09HLqnW3RMqW0CA4= golang.org/x/tools v0.1.12/go.mod h1:hNGJHUnrk76NpqgfD5Aqm5Crs+Hm0VOH/i9J2+nxYbc= golang.org/x/tools v0.2.0/go.mod h1:y4OqIKeOV/fWJetJ8bXPU1sEVniLMIyDAZWeHdV+NTA= golang.org/x/tools v0.3.0/go.mod h1:/rWhSS2+zyEVwoJf8YAX6L2f0ntZ7Kn/mGgAWcipA5k= golang.org/x/tools v0.5.0/go.mod h1:N+Kgy78s5I24c24dU8OfWNEotWjutIs8SnJvn5IDq+k= golang.org/x/tools v0.6.0/go.mod h1:Xwgl3UAJ/d3gWutnCtw505GrjyAbvKui8lOU390QaIU= -golang.org/x/tools v0.22.0 h1:gqSGLZqv+AI9lIQzniJ0nZDRG5GBPsSi+DRNHWNz6yA= -golang.org/x/tools v0.22.0/go.mod h1:aCwcsjqvq7Yqt6TNyX7QMU2enbQ/Gt0bo6krSeEri+c= +golang.org/x/tools v0.24.0 h1:J1shsA93PJUEVaUSaay7UXAyE8aimq3GW0pjlolpa24= +golang.org/x/tools v0.24.0/go.mod h1:YhNqVBIfWHdzvTLs0d8LCuMhkKUgSUKldakyV7W/WDQ= golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0= golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0= golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0= @@ -1656,8 +1652,9 @@ golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1/go.mod h1:I/5z698sn9Ka8T golang.org/x/xerrors v0.0.0-20220411194840-2f41105eb62f/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0= golang.org/x/xerrors v0.0.0-20220517211312-f3a8303e98df/go.mod h1:K8+ghG5WaK9qNqU5K3HdILfMLy1f3aNYFI/wnl100a8= golang.org/x/xerrors v0.0.0-20220609144429-65e65417b02f/go.mod h1:K8+ghG5WaK9qNqU5K3HdILfMLy1f3aNYFI/wnl100a8= -golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2 h1:H2TDz8ibqkAF6YGhCdN3jS9O0/s90v0rJh3X/OLHEUk= golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2/go.mod h1:K8+ghG5WaK9qNqU5K3HdILfMLy1f3aNYFI/wnl100a8= +golang.org/x/xerrors v0.0.0-20231012003039-104605ab7028 h1:+cNy6SZtPcJQH3LJVLOSmiC7MMxXNOb3PU/VUEz+EhU= +golang.org/x/xerrors v0.0.0-20231012003039-104605ab7028/go.mod h1:NDW/Ps6MPRej6fsCIbMTohpP40sJ/P/vI1MoTEGwX90= google.golang.org/api v0.4.0/go.mod h1:8k5glujaEP+g9n7WNsDg8QP6cUVNI86fCNMcbazEtwE= google.golang.org/api v0.7.0/go.mod h1:WtwebWUNSVBH/HAw79HIFXZNqEvBhG+Ra+ax0hx3E3M= google.golang.org/api v0.8.0/go.mod h1:o4eAsZoiT+ibD93RtjEohWalFOjRDx6CVaqeizhEnKg= @@ -1706,8 +1703,8 @@ google.golang.org/api v0.96.0/go.mod h1:w7wJQLTM+wvQpNf5JyEcBoxK0RH7EDrh/L4qfsuJ google.golang.org/api v0.97.0/go.mod h1:w7wJQLTM+wvQpNf5JyEcBoxK0RH7EDrh/L4qfsuJ13s= google.golang.org/api v0.98.0/go.mod h1:w7wJQLTM+wvQpNf5JyEcBoxK0RH7EDrh/L4qfsuJ13s= google.golang.org/api v0.100.0/go.mod h1:ZE3Z2+ZOr87Rx7dqFsdRQkRBk36kDtp/h+QpHbB7a70= -google.golang.org/api v0.162.0 h1:Vhs54HkaEpkMBdgGdOT2P6F0csGG/vxDS0hWHJzmmps= -google.golang.org/api v0.162.0/go.mod h1:6SulDkfoBIg4NFmCuZ39XeeAgSHCPecfSUuDyYlAHs0= +google.golang.org/api v0.192.0 h1:PljqpNAfZaaSpS+TnANfnNAXKdzHM/B9bKhwRlo7JP0= +google.golang.org/api v0.192.0/go.mod h1:9VcphjvAxPKLmSxVSzPlSRXy/5ARMEw5bf58WoVXafQ= google.golang.org/appengine v1.1.0/go.mod h1:EbEs0AVv82hx2wNQdGPgUI5lhzA/G0D9YwlJXL52JkM= google.golang.org/appengine v1.4.0/go.mod h1:xpcJRLb0r/rnEns0DIKYYv+WjYCduHsrkT7/EB5XEv4= google.golang.org/appengine v1.5.0/go.mod h1:xpcJRLb0r/rnEns0DIKYYv+WjYCduHsrkT7/EB5XEv4= @@ -1817,12 +1814,12 @@ google.golang.org/genproto v0.0.0-20221010155953-15ba04fc1c0e/go.mod h1:3526vdqw google.golang.org/genproto v0.0.0-20221014173430-6e2ab493f96b/go.mod h1:1vXfmgAz9N9Jx0QA82PqRVauvCz1SGSz739p0f183jM= google.golang.org/genproto v0.0.0-20221014213838-99cd37c6964a/go.mod h1:1vXfmgAz9N9Jx0QA82PqRVauvCz1SGSz739p0f183jM= google.golang.org/genproto v0.0.0-20221025140454-527a21cfbd71/go.mod h1:9qHF0xnpdSfF6knlcsnpzUu5y+rpwgbvsyGAZPBMg4s= -google.golang.org/genproto v0.0.0-20240227224415-6ceb2ff114de h1:F6qOa9AZTYJXOUEr4jDysRDLrm4PHePlge4v4TGAlxY= -google.golang.org/genproto v0.0.0-20240227224415-6ceb2ff114de/go.mod h1:VUhTRKeHn9wwcdrk73nvdC9gF178Tzhmt/qyaFcPLSo= -google.golang.org/genproto/googleapis/api v0.0.0-20240318140521-94a12d6c2237 h1:RFiFrvy37/mpSpdySBDrUdipW/dHwsRwh3J3+A9VgT4= -google.golang.org/genproto/googleapis/api v0.0.0-20240318140521-94a12d6c2237/go.mod h1:Z5Iiy3jtmioajWHDGFk7CeugTyHtPvMHA4UTmUkyalE= -google.golang.org/genproto/googleapis/rpc v0.0.0-20240318140521-94a12d6c2237 h1:NnYq6UN9ReLM9/Y01KWNOWyI5xQ9kbIms5GGJVwS/Yc= -google.golang.org/genproto/googleapis/rpc v0.0.0-20240318140521-94a12d6c2237/go.mod h1:WtryC6hu0hhx87FDGxWCDptyssuo68sk10vYjF+T9fY= +google.golang.org/genproto v0.0.0-20240730163845-b1a4ccb954bf h1:OqdXDEakZCVtDiZTjcxfwbHPCT11ycCEsTKesBVKvyY= +google.golang.org/genproto v0.0.0-20240730163845-b1a4ccb954bf/go.mod h1:mCr1K1c8kX+1iSBREvU3Juo11CB+QOEWxbRS01wWl5M= +google.golang.org/genproto/googleapis/api v0.0.0-20240725223205-93522f1f2a9f h1:b1Ln/PG8orm0SsBbHZWke8dDp2lrCD4jSmfglFpTZbk= +google.golang.org/genproto/googleapis/api v0.0.0-20240725223205-93522f1f2a9f/go.mod h1:AHT0dDg3SoMOgZGnZk29b5xTbPHMoEC8qthmBLJCpys= +google.golang.org/genproto/googleapis/rpc v0.0.0-20240730163845-b1a4ccb954bf h1:liao9UHurZLtiEwBgT9LMOnKYsHze6eA6w1KQCMVN2Q= +google.golang.org/genproto/googleapis/rpc v0.0.0-20240730163845-b1a4ccb954bf/go.mod h1:Ue6ibwXGpU+dqIcODieyLOcgj7z8+IcskoNIgZxtrFY= google.golang.org/grpc v1.14.0/go.mod h1:yo6s7OP7yaDglbqo1J04qKzAhqBH6lvTonzMVmEdcZw= google.golang.org/grpc v1.19.0/go.mod h1:mqu4LbDTu4XGKhr4mRzUsmM4RtVoemTSY81AxZiDr8c= google.golang.org/grpc v1.20.1/go.mod h1:10oTOabMzJvdu6/UiuZezV6QK5dSlG84ov/aaiqXj38= @@ -1860,8 +1857,8 @@ google.golang.org/grpc v1.48.0/go.mod h1:vN9eftEi1UMyUsIF80+uQXhHjbXYbm0uXoFCACu google.golang.org/grpc v1.49.0/go.mod h1:ZgQEeidpAuNRZ8iRrlBKXZQP1ghovWIVhdJRyCDK+GI= google.golang.org/grpc v1.50.0/go.mod h1:ZgQEeidpAuNRZ8iRrlBKXZQP1ghovWIVhdJRyCDK+GI= google.golang.org/grpc v1.50.1/go.mod h1:ZgQEeidpAuNRZ8iRrlBKXZQP1ghovWIVhdJRyCDK+GI= -google.golang.org/grpc v1.64.0 h1:KH3VH9y/MgNQg1dE7b3XfVK0GsPSIzJwdF617gUSbvY= -google.golang.org/grpc v1.64.0/go.mod h1:oxjF8E3FBnjp+/gVFYdWacaLDx9na1aqy9oovLpxQYg= +google.golang.org/grpc v1.64.1 h1:LKtvyfbX3UGVPFcGqJ9ItpVWW6oN/2XqTxfAnwRRXiA= +google.golang.org/grpc v1.64.1/go.mod h1:hiQF4LFZelK2WKaP6W0L92zGHtiQdZxk8CrSdvyjeP0= google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.1.0/go.mod h1:6Kw0yEErY5E/yWrBtf03jp27GLLJujG4z/JK95pnjjw= google.golang.org/protobuf v0.0.0-20200109180630-ec00e32a8dfd/go.mod h1:DFci5gLYBciE7Vtevhsrf46CRTquxDuWsQurQQe4oz8= google.golang.org/protobuf v0.0.0-20200221191635-4d8936d0db64/go.mod h1:kwYJMbMJ01Woi6D6+Kah6886xMZcty6N08ah7+eCXa0= @@ -1878,8 +1875,8 @@ google.golang.org/protobuf v1.26.0/go.mod h1:9q0QmTI4eRPtz6boOQmLYwt+qCgq0jsYwAQ google.golang.org/protobuf v1.27.1/go.mod h1:9q0QmTI4eRPtz6boOQmLYwt+qCgq0jsYwAQnmE0givc= google.golang.org/protobuf v1.28.0/go.mod h1:HV8QOd/L58Z+nl8r43ehVNZIU/HEI6OcFqwMG9pJV4I= google.golang.org/protobuf v1.28.1/go.mod h1:HV8QOd/L58Z+nl8r43ehVNZIU/HEI6OcFqwMG9pJV4I= -google.golang.org/protobuf v1.34.0 h1:Qo/qEd2RZPCf2nKuorzksSknv0d3ERwp1vFG38gSmH4= -google.golang.org/protobuf v1.34.0/go.mod h1:c6P6GXX6sHbq/GpV6MGZEdwhWPcYBgnhAHhKbcUYpos= +google.golang.org/protobuf v1.34.2 h1:6xV6lTsCfpGD21XK49h7MhtcApnLqkfYgPcdHftf6hg= +google.golang.org/protobuf v1.34.2/go.mod h1:qYOHts0dSfpeUzUFpOMr/WGzszTmLH+DiWniOlNbLDw= gopkg.in/alecthomas/kingpin.v2 v2.2.6/go.mod h1:FMv+mEhP44yOT+4EoQTLFTRgOQ1FBLkstjWtayDeSgw= gopkg.in/asn1-ber.v1 v1.0.0-20181015200546-f715ec2f112d/go.mod h1:cuepJuh7vyXfUyUwEgHQXw849cJrilpS5NeIjOWESAw= gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= @@ -1918,8 +1915,8 @@ honnef.co/go/tools v0.0.0-20190523083050-ea95bdfd59fc/go.mod h1:rf3lG4BRIbNafJWh honnef.co/go/tools v0.0.1-2019.2.3/go.mod h1:a3bituU0lyd329TUQxRnasdCoJDkEUEAqEt0JzvZhAg= honnef.co/go/tools v0.0.1-2020.1.3/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9vFzvIQ3k= honnef.co/go/tools v0.0.1-2020.1.4/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9vFzvIQ3k= -honnef.co/go/tools v0.4.7 h1:9MDAWxMoSnB6QoSqiVr7P5mtkT9pOc1kSxchzPCnqJs= -honnef.co/go/tools v0.4.7/go.mod h1:+rnGS1THNh8zMwnd2oVOTL9QF6vmfyG6ZXBULae2uc0= +honnef.co/go/tools v0.5.1 h1:4bH5o3b5ZULQ4UrBmP+63W9r7qIkqJClEA9ko5YKx+I= +honnef.co/go/tools v0.5.1/go.mod h1:e9irvo83WDG9/irijV44wr3tbhcFeRnfpVlRqVwpzMs= mvdan.cc/gofumpt v0.7.0 h1:bg91ttqXmi9y2xawvkuMXyvAA/1ZGJqYAEGjXuP0JXU= mvdan.cc/gofumpt v0.7.0/go.mod h1:txVFJy/Sc/mvaycET54pV8SW8gWxTlUuGHVEcncmNUo= mvdan.cc/unparam v0.0.0-20240528143540-8a5130ca722f h1:lMpcwN6GxNbWtbpI1+xzFLSW8XzX0u72NttUGVFjO3U= diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index cf26323c5149..1fb6f108c488 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -30,7 +30,7 @@ jobs: - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 - uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2 with: - go-version: '1.22.6' + go-version-file: go.mod cache: false - id: golangci-lint-version working-directory: .ci/tools @@ -53,7 +53,7 @@ jobs: - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 - uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2 with: - go-version: '1.22.6' + go-version-file: go.mod cache: false - id: golangci-lint-version working-directory: .ci/tools @@ -81,7 +81,7 @@ jobs: - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 - uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2 with: - go-version: '1.22.6' + go-version-file: go.mod cache: false - id: golangci-lint-version working-directory: .ci/tools From dbb7ab6bbdff5bfd49203d8dc7d00ea2c4ffa881 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Tue, 27 Aug 2024 15:05:59 -0400 Subject: [PATCH 273/281] ci/golangci-lint: Attempt to get it un-Killed --- .github/workflows/golangci-lint.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index 1fb6f108c488..bd2f28aee362 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -72,7 +72,7 @@ jobs: # Trigger garbage collection more frequently to reduce the likelihood # of OOM errors. # ref: https://golangci-lint.run/product/performance/ - GOGC: "2000" + GOGC: "90" golangci-lintc: name: 3 of 3 needs: [golangci-linta] @@ -100,4 +100,4 @@ jobs: # Trigger garbage collection more frequently to reduce the likelihood # of OOM errors. # ref: https://golangci-lint.run/product/performance/ - GOGC: "2000" + GOGC: "80" From 7f9405c80fb7ec35f96385a14638ff4d36e93321 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Tue, 27 Aug 2024 15:21:50 -0400 Subject: [PATCH 274/281] ci/golangci-lint: Attempt to get it un-Killed --- .github/workflows/golangci-lint.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index bd2f28aee362..699aea37e498 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -72,7 +72,7 @@ jobs: # Trigger garbage collection more frequently to reduce the likelihood # of OOM errors. # ref: https://golangci-lint.run/product/performance/ - GOGC: "90" + GOGC: "120" golangci-lintc: name: 3 of 3 needs: [golangci-linta] @@ -100,4 +100,4 @@ jobs: # Trigger garbage collection more frequently to reduce the likelihood # of OOM errors. # ref: https://golangci-lint.run/product/performance/ - GOGC: "80" + GOGC: "100" From 3160bc556f99dd8ffa91c278bdb13d1b38791557 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Tue, 27 Aug 2024 15:35:59 -0400 Subject: [PATCH 275/281] ci/golangci-lint: Attempt to get it un-Killed --- .github/workflows/golangci-lint.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index 699aea37e498..3c562d5d356d 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -72,7 +72,7 @@ jobs: # Trigger garbage collection more frequently to reduce the likelihood # of OOM errors. # ref: https://golangci-lint.run/product/performance/ - GOGC: "120" + GOGC: "150" golangci-lintc: name: 3 of 3 needs: [golangci-linta] @@ -100,4 +100,4 @@ jobs: # Trigger garbage collection more frequently to reduce the likelihood # of OOM errors. # ref: https://golangci-lint.run/product/performance/ - GOGC: "100" + GOGC: "150" From 56fef0102ed5a744109483c7f64661f98d733753 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Tue, 27 Aug 2024 15:42:31 -0400 Subject: [PATCH 276/281] ci/golangci-lint: Attempt to get it un-Killed --- .github/workflows/golangci-lint.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index 3c562d5d356d..bd9003d87f12 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -72,7 +72,7 @@ jobs: # Trigger garbage collection more frequently to reduce the likelihood # of OOM errors. # ref: https://golangci-lint.run/product/performance/ - GOGC: "150" + GOGC: "747" golangci-lintc: name: 3 of 3 needs: [golangci-linta] @@ -100,4 +100,4 @@ jobs: # Trigger garbage collection more frequently to reduce the likelihood # of OOM errors. # ref: https://golangci-lint.run/product/performance/ - GOGC: "150" + GOGC: "1374" From 4261cfbc0ec9f260e6122e4897e41b62f31c7750 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Tue, 27 Aug 2024 15:57:16 -0400 Subject: [PATCH 277/281] Add changelog --- .changelog/38999.txt | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 .changelog/38999.txt diff --git a/.changelog/38999.txt b/.changelog/38999.txt new file mode 100644 index 000000000000..5a01d5f46322 --- /dev/null +++ b/.changelog/38999.txt @@ -0,0 +1,3 @@ +```release-note:note +provider: Updates to Go 1.23. We do not expect this change to impact most users. For macOS, Go 1.23 requires macOS 11 Big Sur or later; support for previous versions has been discontinued. +``` \ No newline at end of file From 30749590a3541842a2ce461fc63c9e6705ca2d4b Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Tue, 27 Aug 2024 15:57:27 -0400 Subject: [PATCH 278/281] ci/golangci-lint: Attempt to get it un-Killed --- .github/workflows/golangci-lint.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index bd9003d87f12..56e2ea20823f 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -72,7 +72,7 @@ jobs: # Trigger garbage collection more frequently to reduce the likelihood # of OOM errors. # ref: https://golangci-lint.run/product/performance/ - GOGC: "747" + GOGC: "349" golangci-lintc: name: 3 of 3 needs: [golangci-linta] @@ -100,4 +100,4 @@ jobs: # Trigger garbage collection more frequently to reduce the likelihood # of OOM errors. # ref: https://golangci-lint.run/product/performance/ - GOGC: "1374" + GOGC: "499" From ffdbb5101161a1c90938d9c88a98e67d927b7c7a Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Tue, 27 Aug 2024 16:06:26 -0400 Subject: [PATCH 279/281] ci/golangci-lint: Attempt to get it un-Killed --- .github/workflows/golangci-lint.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index 56e2ea20823f..eb64282e8c57 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -72,7 +72,7 @@ jobs: # Trigger garbage collection more frequently to reduce the likelihood # of OOM errors. # ref: https://golangci-lint.run/product/performance/ - GOGC: "349" + GOGC: "216" golangci-lintc: name: 3 of 3 needs: [golangci-linta] @@ -100,4 +100,4 @@ jobs: # Trigger garbage collection more frequently to reduce the likelihood # of OOM errors. # ref: https://golangci-lint.run/product/performance/ - GOGC: "499" + GOGC: "282" From 87bca3df5ca64c6c8abda9a30fdf3eac4f56e6b0 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Tue, 27 Aug 2024 16:17:19 -0400 Subject: [PATCH 280/281] ci/golangci-lint: Attempt to get it un-Killed --- .github/workflows/golangci-lint.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index eb64282e8c57..24038c9c8086 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -72,7 +72,7 @@ jobs: # Trigger garbage collection more frequently to reduce the likelihood # of OOM errors. # ref: https://golangci-lint.run/product/performance/ - GOGC: "216" + GOGC: "172" golangci-lintc: name: 3 of 3 needs: [golangci-linta] @@ -100,4 +100,4 @@ jobs: # Trigger garbage collection more frequently to reduce the likelihood # of OOM errors. # ref: https://golangci-lint.run/product/performance/ - GOGC: "282" + GOGC: "194" From dc34ec3b2bf4085cfaf4c949bc14aa8114c3d999 Mon Sep 17 00:00:00 2001 From: Dirk Avery Date: Tue, 27 Aug 2024 16:31:18 -0400 Subject: [PATCH 281/281] ci/golangci-lint: Attempt to get it un-Killed --- .github/workflows/golangci-lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index 24038c9c8086..cddc9b9459d3 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -72,7 +72,7 @@ jobs: # Trigger garbage collection more frequently to reduce the likelihood # of OOM errors. # ref: https://golangci-lint.run/product/performance/ - GOGC: "172" + GOGC: "150" golangci-lintc: name: 3 of 3 needs: [golangci-linta]