-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eligibility not restored after node-drain -disable
#4356
Comments
I was unable to reproduce in Nomad 0.8.1
However, our master branch did have exactly this bug and PR #4352 fixed it. @glimberg can you re-confirm your nomad version and steps to reproduce? |
@preetapan This occurred when calling node drain from an older version of the client that knows nothing about eligibility (0.7.x). The servers were running 0.8.1, however. |
@glimberg now I see that you put that in the original description, missed that before. Thanks for clarifying |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Related to #4347
Server/client nodes were running Nomad v0.8.1 (Linux)
Node drain enable/disable calls were executed via Nomad v0.7.x (Windows).
According to the docs, node eligibility should be disabled when
node-drain -enable
is set on a node, and eligibility should be enabled whennode-drain -disable
is set on a node.In this case, eligibility was not enabled when
node-drain -disable
was called on a node, leaving it out of the pool of available client nodes.The text was updated successfully, but these errors were encountered: