Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eligibility not restored after node-drain -disable #4356

Closed
glimberg opened this issue May 30, 2018 · 4 comments · Fixed by #4357
Closed

Eligibility not restored after node-drain -disable #4356

glimberg opened this issue May 30, 2018 · 4 comments · Fixed by #4357

Comments

@glimberg
Copy link

Related to #4347

Server/client nodes were running Nomad v0.8.1 (Linux)

Node drain enable/disable calls were executed via Nomad v0.7.x (Windows).

According to the docs, node eligibility should be disabled when node-drain -enable is set on a node, and eligibility should be enabled when node-drain -disable is set on a node.

In this case, eligibility was not enabled when node-drain -disable was called on a node, leaving it out of the pool of available client nodes.

@preetapan
Copy link
Contributor

I was unable to reproduce in Nomad 0.8.1

$ nomad node drain -enable 7d5
Are you sure you want to enable drain mode for node "7d5fc08a-af80-be93-50c1-e077a8c36cb7"? [y/N] y
2018-05-30T20:38:31Z: Ctrl-C to stop monitoring: will not cancel the node drain
2018-05-30T20:38:31Z: Node "7d5fc08a-af80-be93-50c1-e077a8c36cb7" drain strategy set
2018-05-30T20:38:31Z: All allocations on node "7d5fc08a-af80-be93-50c1-e077a8c36cb7" have stopped.
2018-05-30T20:38:31Z: Node "7d5fc08a-af80-be93-50c1-e077a8c36cb7" drain complete
$ nomad node status   
ID        DC   Name   Class   Drain  Eligibility  Status
7d5fc08a  dc1  linux  <none>  false  ineligible   ready
$ nomad node drain -disable 7d5
Are you sure you want to disable drain mode for node "7d5fc08a-af80-be93-50c1-e077a8c36cb7"? [y/N] y
Node "7d5fc08a-af80-be93-50c1-e077a8c36cb7" drain strategy unset
$ nomad node status   
ID        DC   Name   Class   Drain  Eligibility  Status
7d5fc08a  dc1  linux  <none>  false  eligible     ready

However, our master branch did have exactly this bug and PR #4352 fixed it. @glimberg can you re-confirm your nomad version and steps to reproduce?

@glimberg
Copy link
Author

@preetapan This occurred when calling node drain from an older version of the client that knows nothing about eligibility (0.7.x). The servers were running 0.8.1, however.

@preetapan
Copy link
Contributor

@glimberg now I see that you put that in the original description, missed that before. Thanks for clarifying

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants