Skip to content

Commit e93fbe6

Browse files
committed
Reverts #6703
This PR reverts changes introduced in #6703 that made changes to affinities and spreads cause destructive updates. #6988 outlines good reason to rethink this until we have scheduler functionality in place that treats and update to spread/affinity similar to how count changes are handled (rebalancing the difference instead of rescheduling all allocs).
1 parent 4757f87 commit e93fbe6

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

scheduler/util.go

+3-9
Original file line numberDiff line numberDiff line change
@@ -367,15 +367,9 @@ func tasksUpdated(jobA, jobB *structs.Job, taskGroup string) bool {
367367
return true
368368
}
369369

370-
// Check Affinities
371-
if affinitiesUpdated(jobA, jobB, taskGroup) {
372-
return true
373-
}
374-
375-
// Check Spreads
376-
if spreadsUpdated(jobA, jobB, taskGroup) {
377-
return true
378-
}
370+
// TODO: check affinities and spreads
371+
// for tasks updated, but do not necessarily
372+
// reschedule or re-create them.
379373

380374
// Check each task
381375
for _, at := range a.Tasks {

0 commit comments

Comments
 (0)