diff --git a/lib/handlebars/logger.js b/lib/handlebars/logger.js index 1d583ddb9..1ab0051f5 100644 --- a/lib/handlebars/logger.js +++ b/lib/handlebars/logger.js @@ -1,3 +1,5 @@ +import {indexOf} from './utils'; + let logger = { methodMap: ['debug', 'info', 'warn', 'error'], level: 'info', @@ -5,7 +7,7 @@ let logger = { // Maps a given level value to the `methodMap` indexes above. lookupLevel: function(level) { if (typeof level === 'string') { - let levelMap = logger.methodMap.indexOf(level.toLowerCase()); + let levelMap = indexOf(logger.methodMap, level.toLowerCase()); if (levelMap >= 0) { level = levelMap; } else { diff --git a/spec/env/common.js b/spec/env/common.js index 2a24db20f..e37805261 100644 --- a/spec/env/common.js +++ b/spec/env/common.js @@ -61,12 +61,12 @@ global.shouldThrow = function(callback, type, msg) { try { callback(); failed = true; - } catch (err) { - if (type && !(err instanceof type)) { - throw new AssertError('Type failure: ' + err); + } catch (caught) { + if (type && !(caught instanceof type)) { + throw new AssertError('Type failure: ' + caught); } - if (msg && !(msg.test ? msg.test(err.message) : msg === err.message)) { - throw new AssertError('Throw mismatch: Expected ' + err.message + ' to match ' + msg + '\n\n' + err.stack, shouldThrow); + if (msg && !(msg.test ? msg.test(caught.message) : msg === caught.message)) { + throw new AssertError('Throw mismatch: Expected ' + caught.message + ' to match ' + msg + '\n\n' + caught.stack, shouldThrow); } } if (failed) { diff --git a/spec/index.html b/spec/index.html index 348ae89d6..5db2146ad 100644 --- a/spec/index.html +++ b/spec/index.html @@ -1,3 +1,4 @@ + Mocha diff --git a/spec/regressions.js b/spec/regressions.js index 931fc4b65..bd0a111e8 100644 --- a/spec/regressions.js +++ b/spec/regressions.js @@ -215,7 +215,8 @@ describe('Regressions', function() { return 'found'; } } - return 'not'; + // And to make IE happy, check for the known string as length is not enumerated. + return (this == 'bat' ? 'found' : 'not'); } };