Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bloom filters based on structured metadata search chunks even if key does not exists #14614

Closed
tiithansen opened this issue Oct 24, 2024 · 4 comments

Comments

@tiithansen
Copy link

Describe the bug

Based on this even if metadata key is not present chunk is still considered to be used.

Expected behavior
If key nor value exist in metadata chunk should not be considered.

@chaudum
Copy link
Contributor

chaudum commented Oct 29, 2024

Hi @tiithansen

This is expected behaviour. The reason is that the requested label of the label filter expression could be a regular label as well. We simply don't know it at this point, since the bloom gateway is only dealing with fingerprints (hashed labels of streams).

Yes, ideally we could dismiss all chunks. This is something we have on our radar and want to improve, because it can increase the filter rate by a lot.

@tiithansen
Copy link
Author

tiithansen commented Nov 1, 2024

Hmm, ok lets say I run query like:
{cluster="prod"} | trace_id="xxxx" then it matches all chunks which have trace_id in it?

By regular label you mean stream filter label?

@chaudum
Copy link
Contributor

chaudum commented Nov 4, 2024

By regular label you mean stream filter label?

Right.

We solved the problem with #14661

@tiithansen
Copy link
Author

Thanks, I will give it test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants