browser: Mark a bunch of places where races happen #4521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a lot of places in the k6ext.Promise will create a separate goroutine and then access the arguments in it. This isn't safe and will race with anything running on the event loop. It is very likely that this happens very rarely especially as in a bunch of the cases this is only for `opts` - which seems to be less used in most cases. Additionally in a bunch of cases mapping back to the sobek.Values is done in that same goroutine instead of on the event loop. I am marking all of those in one commit and not fixing them all as that will take a lot longer and likely a bunch of them will not be the same as the rest.
mstoykov
requested review from
oleiade and
codebien
and removed request for
a team
olegbespalov
approved these changes
Feb 10, 2025
joanlopez
approved these changes
Feb 10, 2025
|
Just to document/link issues and PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In a lot of places in the k6ext.Promise will create a separate goroutine and then access the arguments in it. This isn't safe and will race with anything running on the event loop.
It is very likely that this happens very rarely especially as in a bunch of the cases this is only for
opts- which seems to be less used in most cases.Additionally in a bunch of cases mapping back to the sobek.Values is done in that same goroutine instead of on the event loop.
Why?
I am marking all of those in one commit and not fixing them all as that will take a lot longer and likely a bunch of them will not be the same as the rest.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)