Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

even if space cannot be seen updating version doesn't allow downloading new space if it was previously there #331

Open
juancarlosfarah opened this issue Sep 18, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@juancarlosfarah
Copy link
Member

In the new version, old spaces are not visible, even if they are still in the database.

When a teacher tries to download a space, if it is in the database (even if it's not visible), it throws the duplicate error.

What should happen is that either (1) when update happens / app is opened, a safety check runs so that "orphan" spaces are made visible, (2) when update happens / app is opened, a safety check runs so that "orphan" spaces get deleted, (2) when download is attempted, if space is there, it gets deleted and the new space is downloaded. Or maybe something else?

To consider: are files also necessary to deal with?

To reproduce:

  1. Using an old Graasp Desktop, say 15.0.
  2. Save a space.
  3. Update to new Graasp Desktop 15.5+.
  4. Try to save space.

Expected Output:

Space appears on the saved spaces tab.

Actual Output:

Duplicate error.

@juancarlosfarah juancarlosfarah added the bug Something isn't working label Sep 18, 2020
@pyphilia
Copy link
Contributor

@juancarlosfarah I couldn' reproduce the error. In fact it should work, especially in the case you are mentioning, since spaces are always saved in spaces (it didn't change between versions) and all spaces are displayed for every user.

We can talk about it when you have time, but a solution which could suit every next release would be to check whether the database structure matches with the next release. If it is not the case (a breaking change might happen) we create a backup of the database (json as well as zipping all the spaces) so that the user can import it again if necessary and erase the database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants