Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving a Space does not change pathname #263

Open
pyphilia opened this issue May 5, 2020 · 0 comments
Open

Saving a Space does not change pathname #263

pyphilia opened this issue May 5, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@pyphilia
Copy link
Contributor

pyphilia commented May 5, 2020

The update when saving a space happens in the redux store, but pathname is not updated at this moment. We might have path space/7slvq0 even after saving it.

This is a problem when we want to go back from another path, we lose the saved information and SpaceHeader will display the unsaved buttons.

This bug happens when export a space with selection.

To reproduce:

  • visit space 7slvq0
  • save space
  • export space (with whatever options)

The space header displays the save button.

@pyphilia pyphilia added the bug Something isn't working label May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant