Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

Update to v2.4.0 of @graasp/ui is blocked #614

Closed
spaenleh opened this issue Apr 18, 2023 · 0 comments · Fixed by #627
Closed

Update to v2.4.0 of @graasp/ui is blocked #614

spaenleh opened this issue Apr 18, 2023 · 0 comments · Fixed by #627
Assignees
@pyphilia @codeofmochi @MalinSvenberg
Labels
bug 🪲 Something isn't working question Further information is requested v0.12.0

Comments

@spaenleh
Copy link
Member

Changes to the props of the DocumentItem component in @graasp/[email protected] changes the typing of the item prop.
Before:

  • item prop was a Pick<DocumentItem, 'extra'>
  • DocumentForm in builder was only passing an object with the extra key

Currently:

  • item is now typed as DocumentItemRecord
  • DocumentForm does not have the full item yet.

@graasp/ui need the item name in order to render the component in collapsed state.

Solutions:

  • change typing of props in UI:
    • when showCollapse is false the itemName is not mandatory
  • change DocumentForm to send full item (even with fake props) ...
@spaenleh spaenleh added bug 🪲 Something isn't working question Further information is requested labels Apr 18, 2023
@codeofmochi codeofmochi mentioned this issue May 4, 2023
Closed
@spaenleh spaenleh linked a pull request May 8, 2023 that will close this issue
fix: bump ui to 2.4.3 #627
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pyphilia pyphilia

@codeofmochi codeofmochi

@MalinSvenberg MalinSvenberg

Labels
bug 🪲 Something isn't working question Further information is requested v0.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: bump ui to 2.4.3 graasp/graasp-builder
4 participants
@pyphilia @codeofmochi @spaenleh @MalinSvenberg