Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added user_id to arguments of functions to remove read items of user in client #810

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

resulshm
Copy link
Contributor

@resulshm resulshm commented Mar 5, 2024

fix: remove read items of user in GetItemNeighbors and GetItemNeighborsWithCategory methods of GorseClient

@Xoshbin
Copy link

Xoshbin commented Mar 12, 2024

@zhenghaoz Is there any chance to merge this? it's very annoying when the user sees the read items again and again.
Thank you

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.06%. Comparing base (78c016b) to head (b10ee9d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
- Coverage   70.16%   70.06%   -0.11%     
==========================================
  Files          66       66              
  Lines       12546    12553       +7     
==========================================
- Hits         8803     8795       -8     
- Misses       2929     2942      +13     
- Partials      814      816       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhenghaoz
Copy link
Collaborator

Thank you

@zhenghaoz zhenghaoz merged commit e9a80e5 into gorse-io:master Mar 12, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants