Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_job, cancel_job should accept Job classes in addition to job_id #616

Closed
tswast opened this issue Apr 15, 2021 · 1 comment · Fixed by #617
Closed

get_job, cancel_job should accept Job classes in addition to job_id #616

tswast opened this issue Apr 15, 2021 · 1 comment · Fixed by #617
Assignees
@tswast
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tswast
Copy link
Contributor

tswast commented Apr 15, 2021

If a Job class is passed in, use that location instead of the location from the argument parameters.
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Apr 15, 2021
@tswast tswast self-assigned this Apr 15, 2021
@tswast tswast added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Apr 15, 2021
@tswast
Copy link
Contributor Author

tswast commented Apr 15, 2021

Will be useful for #610 so that we don't have to make location a positional parameter.

@tswast tswast mentioned this issue Apr 15, 2021
Merged
4 tasks
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 15, 2021
@tswast
feat: accept job object as argument to get_job and cancel_job (#617)
f75dcdf 
This allows one to more easily cancel or get updated metadata for an
existing job from the client class. Ensures that project ID and location
are correctly populated.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #616 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tswast tswast

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: accept job object as argument to get_job and cancel_job tswast/python-bigquery
1 participant
@tswast