From 3948e918520d005a4cb7274f48f20cf5fbede13f Mon Sep 17 00:00:00 2001 From: Rich Hodgkins Date: Sat, 28 Mar 2020 12:18:11 +0000 Subject: [PATCH] fix(bucket): only disable resumable uploads for bucket.upload when inspecting the file size (fixes #1133) --- src/bucket.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/bucket.ts b/src/bucket.ts index 103e888cf8..822d0ae0c8 100644 --- a/src/bucket.ts +++ b/src/bucket.ts @@ -3454,7 +3454,10 @@ class Bucket extends ServiceObject { return; } - options.resumable = fd.size > RESUMABLE_THRESHOLD; + if (fd.size <= RESUMABLE_THRESHOLD) { + // Only disable resumable uploads so createWriteStream still attempts them and falls back to simple upload. + options.resumable = false; + } upload(); });