From ee57d7a517379ff71f133ecd0bad4a888efb05e1 Mon Sep 17 00:00:00 2001 From: Shanika Kuruppu Date: Thu, 22 Oct 2020 21:26:45 +1100 Subject: [PATCH] test: confirm returnCommitStats is accepted --- test/table.ts | 95 +++++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 80 insertions(+), 15 deletions(-) diff --git a/test/table.ts b/test/table.ts index bc4e294eb..049f47002 100644 --- a/test/table.ts +++ b/test/table.ts @@ -253,12 +253,21 @@ describe('Table', () => { }); it('should accept gaxOptions', done => { - const gaxOptions = {}; + const deleteRowsOptions = {gaxOptions: {}}; transaction.commit = options => { - assert.strictEqual(options, gaxOptions); + assert.strictEqual(options, deleteRowsOptions); done(); }; - table.deleteRows(KEYS, gaxOptions, assert.ifError); + table.deleteRows(KEYS, deleteRowsOptions, assert.ifError); + }); + + it('should accept commit options', done => { + const deleteRowsOptions = {returnCommitStats: true}; + transaction.commit = options => { + assert.strictEqual(options, deleteRowsOptions); + done(); + }; + table.deleteRows(KEYS, deleteRowsOptions, assert.ifError); }); it('should delete the rows via transaction', done => { @@ -333,17 +342,31 @@ describe('Table', () => { }); it('should accept gaxOptions', done => { - const gaxOptions = {}; + const insertRowsOptions = {gaxOptions: {}}; (sandbox.stub(transaction, 'insert') as sinon.SinonStub).withArgs( table.name, ROW ); transaction.commit = options => { - assert.strictEqual(options, gaxOptions); + assert.strictEqual(options, insertRowsOptions); done(); }; - table.insert(ROW, gaxOptions, assert.ifError); + table.insert(ROW, insertRowsOptions, assert.ifError); + }); + + it('should accept commit options', done => { + const insertRowsOptions = {returnCommitStats: true}; + (sandbox.stub(transaction, 'insert') as sinon.SinonStub).withArgs( + table.name, + ROW + ); + transaction.commit = options => { + assert.strictEqual(options, insertRowsOptions); + done(); + }; + + table.insert(ROW, insertRowsOptions, assert.ifError); }); }); @@ -441,17 +464,31 @@ describe('Table', () => { }); it('should accept gaxOptions', done => { - const gaxOptions = {}; + const replaceRowsOptions = {gaxOptions: {}}; + (sandbox.stub(transaction, 'replace') as sinon.SinonStub).withArgs( + table.name, + ROW + ); + transaction.commit = options => { + assert.strictEqual(options, replaceRowsOptions); + done(); + }; + + table.replace(ROW, replaceRowsOptions, assert.ifError); + }); + + it('should accept commit options', done => { + const replaceRowsOptions = {returnCommitStats: true}; (sandbox.stub(transaction, 'replace') as sinon.SinonStub).withArgs( table.name, ROW ); transaction.commit = options => { - assert.strictEqual(options, gaxOptions); + assert.strictEqual(options, replaceRowsOptions); done(); }; - table.replace(ROW, gaxOptions, assert.ifError); + table.replace(ROW, replaceRowsOptions, assert.ifError); }); }); @@ -485,17 +522,31 @@ describe('Table', () => { }); it('should accept gaxOptions', done => { - const gaxOptions = {}; + const updateRowsOptions = {gaxOptions: {}}; (sandbox.stub(transaction, 'update') as sinon.SinonStub).withArgs( table.name, ROW ); transaction.commit = options => { - assert.strictEqual(options, gaxOptions); + assert.strictEqual(options, updateRowsOptions); done(); }; - table.update(ROW, gaxOptions, assert.ifError); + table.update(ROW, updateRowsOptions, assert.ifError); + }); + + it('should accept commit options', done => { + const updateRowsOptions = {returnCommitStats: true}; + (sandbox.stub(transaction, 'update') as sinon.SinonStub).withArgs( + table.name, + ROW + ); + transaction.commit = options => { + assert.strictEqual(options, updateRowsOptions); + done(); + }; + + table.update(ROW, updateRowsOptions, assert.ifError); }); }); @@ -529,17 +580,31 @@ describe('Table', () => { }); it('should accept gaxOptions', done => { - const gaxOptions = {}; + const upsertRowsOptions = {gaxOptions: {}}; + (sandbox.stub(transaction, 'upsert') as sinon.SinonStub).withArgs( + table.name, + ROW + ); + transaction.commit = options => { + assert.strictEqual(options, upsertRowsOptions); + done(); + }; + + table.upsert(ROW, upsertRowsOptions, assert.ifError); + }); + + it('should accept commit options', done => { + const upsertRowsOptions = {returnCommitStats: true}; (sandbox.stub(transaction, 'upsert') as sinon.SinonStub).withArgs( table.name, ROW ); transaction.commit = options => { - assert.strictEqual(options, gaxOptions); + assert.strictEqual(options, upsertRowsOptions); done(); }; - table.upsert(ROW, gaxOptions, assert.ifError); + table.upsert(ROW, upsertRowsOptions, assert.ifError); }); }); });