Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.11.1 released a backwards incompatible breaking change in a patch version #445

Closed
1 task done
danking opened this issue Feb 14, 2020 · 3 comments
Closed
1 task done
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@danking
Copy link

danking commented Feb 14, 2020

The bug is reported in #443. I'm opening this ticket to specifically request a discussion about how to avoid breaking changes in a patch version. The PR that introduced the change is #365. The release of that change as 1.11.1 was PR #437 . It looks like there needs to be a test that a valid token can be decoded?

@busunkim96
Copy link
Contributor

@danking Yes, it looks like we need a system test against the live endpoint.

I made two bad assumptions here, that the v1 and v3 endpoints returned the same payload, and that the codebase already had a test for it. I'll use this issue to track the addition of the test.

Thanks for filing an issue!

@danking
Copy link
Author

danking commented Feb 14, 2020

Thanks @busunkim96 !

@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Feb 15, 2020
@busunkim96 busunkim96 added type: process A process-related concern. May include testing, release, or the like. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Feb 19, 2020
@arithmetic1728
Copy link
Contributor

seems the problem is already solved, closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

4 participants