Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-768 Support Markdown Emoji #864

Conversation

andrewpollack
Copy link
Contributor

@andrewpollack andrewpollack commented Aug 21, 2021

Please let me know any ways that this PR can be improved! It's my first time contributing to a Rust project, so hopefully this all makes sense!

This Pull Request fixes/closes #768 .

It changes the following:

  • Adds ''gh-emoji" crate to dependencies
  • Added emoji functionality to 'commitlist.rs' commit msg

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@extrawurst
Copy link
Collaborator

Hi @andrewpollack thanks for tackling this!

Please check out my comment in the issue:

Note: In case anyone wants to tackle this - make sure to not run the parser on every draw but just on the cache of commits we keep in memory

Please use LogEntry::from to parse for emojis and write a unittest and a changelog entry.

@andrewpollack
Copy link
Contributor Author

@extrawurst Ahh that makes perfect sense! I'll close this PR for now, and reopen once these changes are made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Markdown emoji
2 participants