Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows MSI #371

Closed
wants to merge 7 commits into from
Closed

Add windows MSI #371

wants to merge 7 commits into from

Conversation

pm100
Copy link
Contributor

@pm100 pm100 commented Oct 26, 2020

Final PR with ci.yml reverted

@extrawurst
Copy link
Collaborator

I think we can drop this. the major part was merged in #360 and I am fixing up the CI now but still run cargo wix to verify it works: #372

@extrawurst
Copy link
Collaborator

#372 is merged but just like in your CI test the pipeline says:

WARN: Skipped building the release binary

can you add the appropriate script that checks the msi file is generated, print its size and fail if it is not generated. (just to be sure it works and out of curiosity how big such a MSI is)

@pm100 pm100 closed this Oct 26, 2020
@pm100 pm100 deleted the msi branch October 26, 2020 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants