Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot open external/internal editor #1461

Closed
PatWie opened this issue Dec 5, 2022 · 1 comment
Closed

Cannot open external/internal editor #1461

PatWie opened this issue Dec 5, 2022 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@PatWie
Copy link

PatWie commented Dec 5, 2022

Describe the bug
Cannot launch any editor to edit a previous commit message (even the last one).

To Reproduce

cd /tmp
mkdir test && cd  test
git init && touch "a"
git add a &&  git commit -m "override me"

Open gitui and click e when the commit message is highlighted.

Expected behavior
Opening the same editor as when editing a file from the Files tab or clicking ctrl+e when creating the commit message in the first place.

Screenshots
image

Context (please complete the following information):

  • OS/Distro + Version: 18.04.1-Ubuntu
  • GitUI Version: gitui 0.22.1 from cargo install
  • Rust version: rustc 1.62.0 (a8314ef7d 2022-06-27)

Additional context
The menu item on the bottom of the screenshot mit be missleading. Does this function even exists? If not, then the edit menu item should be removed. The logs indicate a keypress has been detected

10:14:13 [TRACE] (1) gitui::app: [~/.cargo/registry/src/github.jparrowsec.cn-1ecc6299db9ec823/gitui-0.22.1/src/app.rs:382] event: Input(Key(KeyEvent { code: Char('e'), modifiers: NONE, kind: Press, state: NONE }
))
@PatWie PatWie added the bug Something isn't working label Dec 5, 2022
@extrawurst
Copy link
Collaborator

ha good point, this UX sucks. the edit is actually about the file selected in the tree below. let me fix that. editing a previous commit messages is a feature not supported yet

@extrawurst extrawurst added this to the v0.23 milestone Dec 5, 2022
IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this issue Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants