From 000b3244c33cfde9257ccedc73fbd9190201941a Mon Sep 17 00:00:00 2001 From: Allan Ritchie Date: Fri, 21 Feb 2025 10:48:08 -0500 Subject: [PATCH] Remove unnecessary hacks --- src/Sentry.Bindings.Cocoa/ApiDefinitions.cs | 2 +- src/Sentry/Platforms/Cocoa/SentrySdk.cs | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/Sentry.Bindings.Cocoa/ApiDefinitions.cs b/src/Sentry.Bindings.Cocoa/ApiDefinitions.cs index 57e18f8790..77ad1d5797 100644 --- a/src/Sentry.Bindings.Cocoa/ApiDefinitions.cs +++ b/src/Sentry.Bindings.Cocoa/ApiDefinitions.cs @@ -27,7 +27,7 @@ namespace Sentry.CocoaSdk; // typedef SentryEvent * _Nullable (^SentryBeforeSendEventCallback)(SentryEvent * _Nonnull); [Internal] -delegate SentryEvent? SentryBeforeSendEventCallback (SentryEvent @event); +delegate SentryEvent SentryBeforeSendEventCallback (SentryEvent @event); // typedef id _Nullable (^SentryBeforeSendSpanCallback)(id _Nonnull); [Internal] diff --git a/src/Sentry/Platforms/Cocoa/SentrySdk.cs b/src/Sentry/Platforms/Cocoa/SentrySdk.cs index e53fb3d016..15d5441bf8 100644 --- a/src/Sentry/Platforms/Cocoa/SentrySdk.cs +++ b/src/Sentry/Platforms/Cocoa/SentrySdk.cs @@ -135,11 +135,9 @@ private static void InitSentryCocoaSdk(SentryOptions options) return evt; var result = options.BeforeSendInternal(sentryEvent, null!); -#pragma warning disable 8603 // returning null is fine - the native binding even has this set, but the tooling doesn't want to obey, so the pragma was necessary if (result == null) - return null; -#pragma warning restore 8603 + return null!; evt.ServerName = result.ServerName; evt.Dist = result.Distribution;