-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firstbuild #3
Merged
Merged
Firstbuild #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for serving site locally
This should probably supersede #1 |
I know I'm not requested on review, but I've:
|
Mmm... I wonder if it's a character error (it was all edited on my Win book). In all truth, I didn't use it through the |
|
working on it. @darribas is probably right about it being an eol character difference by platform. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the tooling required for building the book and serving it, both out of the (improved/expanded) Docker container. A bit more detail:
infrastructure/bookbuild/
)Dockerfile
(infrastructure/docker/
)Makefile
streamlining the build of the container (container
), book (booksite
), and the serving of the book locally (bookserve
)jupyter-book
frommaster
(as per jupyter-book#120) and also front loads the installation of requirements for swifter builds later on.docs