Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firstbuild #3

Merged
merged 16 commits into from
Mar 8, 2019
Merged

Firstbuild #3

merged 16 commits into from
Mar 8, 2019

Conversation

darribas
Copy link
Member

@darribas darribas commented Mar 7, 2019

This PR brings the tooling required for building the book and serving it, both out of the (improved/expanded) Docker container. A bit more detail:

  • Book building process (infrastructure/bookbuild/)
  • New location for Dockerfile (infrastructure/docker/)
  • Improved Makefile streamlining the build of the container (container), book (booksite), and the serving of the book locally (bookserve)
  • New Docker container that installs jupyter-book from master (as per jupyter-book#120) and also front loads the installation of requirements for swifter builds later on.
  • Initial build on docs

@darribas darribas requested a review from sjsrey March 7, 2019 08:51
@ljwolf
Copy link
Member

ljwolf commented Mar 7, 2019

This should probably supersede #1

@ljwolf
Copy link
Member

ljwolf commented Mar 7, 2019

I know I'm not requested on review, but I've:

  1. successfully make container'd
  2. now get a tracebak on make booksite:
lw17329  ⋯  Dropbox  projects  geographic-data-science   firstbuild | …  make booksite
docker run --rm -v /home/lw17329/Dropbox/projects/geographic-data-science:/home/jovyan/host gdsbook start.sh sh -c "\
	sed -i -e 's/\r/' host/infrastructure/booksite/build.sh && \
	./host/infrastructure/booksite/build.sh"
Executing the command: sh -c 	sed -i -e 's/\r/' host/infrastructure/booksite/build.sh && 	./host/infrastructure/booksite/build.sh
sed: -e expression #1, char 5: unterminated `s' command
Makefile:4: recipe for target 'booksite' failed
make: *** [booksite] Error 1

@darribas
Copy link
Member Author

darribas commented Mar 7, 2019

Mmm... I wonder if it's a character error (it was all edited on my Win book). In all truth, I didn't use it through the Makefile as PowerShell doesn't allow it. I copied the command and ran it. Does that work?

@sjsrey
Copy link
Contributor

sjsrey commented Mar 7, 2019

gds/geographic-data-science - [firstbuild] » make booksite
docker run --rm -v /home/serge/Dropbox/g/gds/geographic-data-science:/home/jovyan/host gdsbook start.sh sh -c "\
        sed -i -e 's/\r/' host/infrastructure/booksite/build.sh && \
        ./host/infrastructure/booksite/build.sh"
Executing the command: sh -c    sed -i -e 's/\r/' host/infrastructure/booksite/build.sh &&    ./host/infrastructure/booksite/build.sh
sed: -e expression #1, char 5: unterminated `s' command
make: *** [Makefile:4: booksite] Error 1
gds/geographic-data-science - [firstbuild] »

@ljwolf
Copy link
Member

ljwolf commented Mar 7, 2019

working on it. @darribas is probably right about it being an eol character difference by platform.

@sjsrey sjsrey merged commit fd0aa41 into gdsbook:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants