Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MappingDetails is empty when opened from MappingBrowser #746

Open
nichtich opened this issue Apr 4, 2025 · 1 comment
Open

MappingDetails is empty when opened from MappingBrowser #746

nichtich opened this issue Apr 4, 2025 · 1 comment
Assignees
@rodolv-commons
Labels
bug Something is broken
Milestone
1.12.2

Comments

@nichtich
Copy link
Member

nichtich commented Apr 4, 2025

Example: https://coli-conc.gbv.de/cocoda/app/?fromScheme=http%3A%2F%2Fbartoc.org%2Fen%2Fnode%2F1707&toScheme=http%3A%2F%2Fbartoc.org%2Fen%2Fnode%2F18785&mappingUri=https%3A%2F%2Fcoli-conc.gbv.de%2Fapi%2Fmappings%2Fba70dc49-6a54-4d00-9c73-69a15d97548e

Image

Image

Maybe think this is caused because the mapping data is loaded asynchronously and not available yet when the MappingDetails modal is opened. In 1.12.1 we made empty fields in MappingDetails to be hidden but they can later become non-empty.
@nichtich nichtich added the bug Something is broken label Apr 4, 2025
@nichtich nichtich added this to the 1.12.2 milestone Apr 4, 2025
@rodolv-commons rodolv-commons self-assigned this Apr 9, 2025
@rodolv-commons rodolv-commons mentioned this issue Apr 9, 2025
Merged
rodolv-commons added a commit that referenced this issue Apr 9, 2025
@rodolv-commons
Issue (#746) bug on mapping detail (#749)
0498c62 
* Delete logics about searchlinks

* Insert logics about searchlinks

* Refactor click event on opening the modal
@rodolv-commons
Copy link
Member

@nichtich solved, we have from dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodolv-commons rodolv-commons

Labels
bug Something is broken
Projects
None yet
Milestone
1.12.2
Development

No branches or pull requests
2 participants
@nichtich @rodolv-commons