Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pose multiplication instead of subtraction #231

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Jun 6, 2022

🎉 New feature

Part of gz-math#60.

Summary

As noted in gz-math#60, there are concerns about the pose subtraction operator. Given that it is equivalent to multiplying by an inverse (albeit with reversed order), the subtraction operator will be deprecated. This PR replaces usage of the soon-to-be-deprecated operator with the equivalent multiplication by inverse.

Test it

Build against gazebosim/gz-math#438 and confirm that tests still pass and that there are no deprecation warnings.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Part of gz-math#60.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from iche033 as a code owner June 6, 2022 22:44
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 6, 2022
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #231 (83ddeeb) into main (3359a0f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   68.73%   68.73%           
=======================================
  Files          34       34           
  Lines        3419     3419           
=======================================
  Hits         2350     2350           
  Misses       1069     1069           
Impacted Files Coverage Δ
src/LogicalCameraSensor.cc 90.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3359a0f...83ddeeb. Read the comment docs.

@iche033 iche033 merged commit 9302a7d into main Jun 7, 2022
@iche033 iche033 deleted the scpeters/pose_deprecate_subtraction branch June 7, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants