gatsby-plugin-google-analytics: sendPageView should be called via requestAnimationFrame, when available

[d4h0]

React-Helm uses requestAnimationFrame to avoid FOUC.

This lead to a bug in gatsby-plugin-google-analytics where a page view was sent with the title of the previous page.

A workaround was implemented to fix the problem:

    if (`requestAnimationFrame` in window) {
      requestAnimationFrame(() => {
        requestAnimationFrame(sendPageView)
      })
    } else {
      // simulate 2 rAF calls
      setTimeout(sendPageView, 32)
    }

For some reason, requestAnimationFrame was removed later (see here):

  // Minimum delay for reactHelmet's requestAnimationFrame
  const delay = Math.max(32, pluginOptions.pageTransitionDelay || 0)
  setTimeout(sendPageView, delay)

Basically, this code assumes that every display has a refresh rate of 60, which is not the case (the iPad Pro has a refresh rate of 120, for example).

Because React-Helm uses requestAnimationFrame when available (and this plugin does not), this means, that on devices with a higher refresh rate than 60, the wrong title still could be sent.

See MDN on requestAnimationFrame:

The number of callbacks is usually 60 times per second, but will generally match the display refresh rate in most web browsers as per W3C recommendation.

An easy fix would be, to restore the original implementation (see above)

[LekoArts]

We'd be happy to receive a PR to fix this. Thanks for the issue!

[d4h0]

@LekoArts: Sorry, I'm not using Google Analytics myself, and I'm behind with my own projects, so I won't create a PR myself (researching and reporting this bug used up all my available time for this).

[github-actions]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

[d4h0]

If we missed this issue or if you want to keep it open, please reply here.

Looks like nobody is interested in fixing this, but this issue is still about a bug that should get fixed at some point, so it should be kept open, IMO.

[github-actions]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

[github-actions]

Hey again!

It’s been 60 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.
Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to comment on this issue or create a new one if you need anything else.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community! 💪💜

[seanflahertyT4]

Hi, is this still an issue? I am experiencing incorrect (unset) title names on google analytics. If so, I can do the PR.