Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite reload when JS is disabled + directly visiting /offline-plugin-app-shell-fallback/ #17748

Closed
vtenfys opened this issue Sep 19, 2019 · 2 comments
Assignees
Labels
stale? Issue that may be closed soon due to the original author not responding any more.

Comments

@vtenfys
Copy link
Contributor

vtenfys commented Sep 19, 2019

Description

When directly visiting /offline-plugin-app-shell-fallback/ with JavaScript disabled there is an infinite reload (due to changes in #17590).

Steps to reproduce

  1. Go to a site with offline plugin
  2. Wait for SW to install
  3. Disable JS for that site
  4. Go to /offline-plugin-app-shell-fallback/

Expected result

Just a blank page

Actual result

A blank page which also happens to reload itself infinitely

Environment

gatsby-plugin-offline v3.something (awaiting publish)

@vtenfys vtenfys self-assigned this Sep 19, 2019
@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Oct 10, 2019
@gatsbot
Copy link

gatsbot bot commented Oct 10, 2019

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@gatsbot
Copy link

gatsbot bot commented Oct 21, 2019

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community!

@gatsbot gatsbot bot closed this as completed Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale? Issue that may be closed soon due to the original author not responding any more.
Projects
None yet
Development

No branches or pull requests

1 participant