Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow "<no value>" in rendered initHelp #146

Closed
majori opened this issue Oct 25, 2024 · 3 comments · Fixed by #150
Closed

Disallow "<no value>" in rendered initHelp #146

majori opened this issue Oct 25, 2024 · 3 comments · Fixed by #150
Assignees
@rchojn
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@majori
Copy link
Member

majori commented Oct 25, 2024 •
edited
Loading

Throw an error if the rendered initHelp contains "<no value>", meaning that the template uses variables which are not defined. This is already done for the template files: https://github.com/futurice/jalapeno/blob/main/pkg/engine/engine.go#L43-L46
@majori majori added the bug Something isn't working label Oct 25, 2024
@majori majori changed the title Disallow "<no-value>" in templated initHelp Disallow "<no-value>" in rendered initHelp Oct 25, 2024
@majori majori added the good first issue Good for newcomers label Oct 25, 2024
@rchojn
Copy link
Contributor

rchojn commented Oct 28, 2024

@majori can I take this one?

@majori
Copy link
Member Author

majori commented Oct 30, 2024 •
edited
Loading

Sure, PRs are welcome!

@majori majori changed the title Disallow "<no-value>" in rendered initHelp Disallow "<no value>" in rendered initHelp Oct 30, 2024
@rchojn
Copy link
Contributor

rchojn commented Oct 30, 2024

Can you assign it to me, please?

@majori majori linked a pull request Nov 6, 2024 that will close this issue
fix: validate undefined variables in initHelp template #150
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rchojn rchojn

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: validate undefined variables in initHelp template rchojn/jalapeno
2 participants
@majori @rchojn