Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a display package #31

Open
WanWizard opened this issue Mar 8, 2013 · 9 comments
Open

Create a display package #31

WanWizard opened this issue Mar 8, 2013 · 9 comments

Comments

@WanWizard
Copy link
Contributor

Containing View, Presenter, Asset, Theme and Parser, packaged into a single library. It can then be included for those creating "standard" websites, while those creating API backends don't need to have it installed.

@WanWizard
Copy link
Contributor Author

For consistency, perhaps all HTML stuff should move to this package too? (@stevewest?)

@emlynwest
Copy link
Contributor

I am not sure the html stuff should be in the display package, after all all it does is generate html tags, I don't feel it should be tied to the display package.

@WanWizard
Copy link
Contributor Author

It would keep all stufff generating HTML in a single package, instead of all over the place. Not sure "display" is best name for this package though, but I felt "output" is too generic.

@WanWizard
Copy link
Contributor Author

Repository fuelphp/display created.

@emlynwest
Copy link
Contributor

Generating a html tag seems such a small thing and it something that might need to be done regardless of output package. It feels more like a generic, common, action and therefore should stay in common.

@WanWizard
Copy link
Contributor Author

If you're referring to the HTML class, for me that's more of an XML helper, it doesn't contain any specific HTML. I don't have a problem with that staying in Common.

@emlynwest
Copy link
Contributor

I am referring to the HTML class that's currently in Common.

@WanWizard
Copy link
Contributor Author

Yeah, no problem with that. I was more thinking about the methods in the v1 HTML class.

@emlynwest
Copy link
Contributor

Ah, then I agree that those should be with the display package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants