Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Forge relies on outdated alloy-rs solc list.json for solc binary information #7441

Closed
2 tasks done
sambacha opened this issue Mar 19, 2024 · 3 comments
Closed
2 tasks done
Labels
T-bug Type: bug

Comments

@sambacha
Copy link
Contributor

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (0026488 2024-03-19T00:20:40.934617000Z)

What command(s) is the bug in?

forge build

Operating System

macOS (Apple Silicon)

Describe the bug

Forge is fetching the following solc binary information from alloy-rs, however these list files do not contain the latest solc binary, 0.8.25

https://raw.githubusercontent.com/alloy-rs/solc-builds/e4b80d33bc4d015b2fc3583e217fbf248b2014e1/macosx/aarch64/list.json
https://github.com/alloy-rs/solc-builds/raw/e4b80d33bc4d015b2fc3583e217fbf248b2014e1/macosx/aarch64/list.json

This sort of overlaps with #7440

@sambacha sambacha added the T-bug Type: bug label Mar 19, 2024
@mattsse
Copy link
Member

mattsse commented Mar 19, 2024

could you please be more specific,
is the issue redundant call or is 0.8.25 not working?

however these list files do not contain the latest solc binary, 0.8.25

yes this is correct because 0.8.25 is now a universal binary.
I think we can get rid of the extra call by checking if universal binaries are available, starting with 0.8.24 I believe

@sambacha
Copy link
Contributor Author

Resolved by https://github.com/alloy-rs/svm-rs/blob/de5bd77c5af7b5188dfe0d00675cef72dbdbd145/crates/svm-rs/src/releases.rs#L137-L170 added in alloy-rs/svm-rs#118

Thanks, you da real MVP mr snacks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
None yet
Development

No branches or pull requests

3 participants