Skip to content

[Bug] Rescan Repositories removes folders and names #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
decadence opened this issue Sep 18, 2019 · 11 comments
Closed

[Bug] Rescan Repositories removes folders and names #448

decadence opened this issue Sep 18, 2019 · 11 comments
Milestone

Comments

@decadence
Copy link

Let's say I organise my repos to folders.
When I choose "Rescan Repositories" it deletes all folders, resets all repository names, removes all repos which I added manually from other folders.

I think it should delete not existing repos, add new ones and don't touch existing.
Also multiple folders for scan would be nice.

Version 1.39.0.0.

@decadence decadence changed the title Rescan Repositories removes folders and names [Bug] Rescan Repositories removes folders and names Sep 22, 2019
@jobec
Copy link

jobec commented Jan 20, 2020

Fix this one, and I throw out SourceTree...

Fork should scan and follow the filesystem on startup, not the other way around.

@DanPristupov DanPristupov added this to the 1.42 milestone Jan 20, 2020
@DanPristupov
Copy link
Contributor

This was implemented in Fork 1.42 in November 2019.

Screenshot 2020-01-20 at 10 49 11

@jobec
Copy link

jobec commented Jan 20, 2020

It's still a manual action.

I copy over a settings file upon install and set RepositoryManager´->SourceDirectories` to the right path.
But upon first startup, users don't see any repositories, unless they click the "hidden" rescan link.
IMHO, this is something that should run automatically on startup.

Looking and comparing with sourcetree:

  • OR you have users manually add repositories, one by one.
  • OR you follow what's on the file system.

now it gives the impression Fork follows what's on disk, but in reality, it doesn't.

@DanPristupov
Copy link
Contributor

IMHO, this is something that should run automatically on startup.

This is a long operation and may take ~10 seconds (or even longer for users with HDDs). It can't be run on startup.

now it gives the impression Fork follows what's on disk, but in reality, it doesn't.

Fork imports the repos which are located on disk. However you can also add repositories manually.

@jobec
Copy link

jobec commented Jan 20, 2020

Ok, I might have misunderstood Fork's functioning. The path it asks at the beginning, is for an initial loading of repositories. Not to keep an eye on a certain folder. So that init screen made me think in the wrong direction.

How about one of these?

  • detecting that new folders were added/deleted and prompting users to do the rescan?
  • Explicitly add a button to rescan, preventing users from having to go into preferences.
  • Not asking users for an initial folder, giving them the impression it'll sync with that folder all the time?

Also, I would add button a somewhere to quickly open en repo. Dragging it onto fork is not that good of a UX. Also, that Open button at the top right doesn't do anything, unless you have a repo in the list already.

Quick comparison with sourcetree:
image

@jobec
Copy link

jobec commented Jan 20, 2020

Oh... just read Fork wont be free anymore in the near future... (#571)
Never mind the above...

I can't defend buying it for a large group of developers if there's SourceTree or VS Code's extensions like GitLens & GitGraph

@DanPristupov
Copy link
Contributor

@jobec 👍
Sorry, I must pay my bills.

@jobec
Copy link

jobec commented Jan 20, 2020

Sure, I understand.

You've got a nice piece of software here. But like I said, I cannot defend the cost if there are alternatives :-(

Maybe it's an idea to make it free for open source developers/maintainers? Like IntelliJ does with it's PyCharm licenses. It'll give me the chance to still use it and contribute "ideas".
And like IntelliJ, it might give you a 'boot on the ground" with certain developers that introduce it in their company that way.

@decadence
Copy link
Author

decadence commented Jan 20, 2020

@DanPristupov if it was implemented you can close this issue so it won't appear in your task list.
I can't check it right now but I believe you made it work like we expected 👍

@decadence
Copy link
Author

I checked this feature today and it works great. All of my folders are persisted after rescan.
Moreover I noticed if default clone folder contains folder with repositories Fork automatically creates this folder after rescan. Great job!

Only one thing I want to remind:

Also multiple folders for scan would be nice.

But it can be separated issue if it's more suitable.

@DanPristupov
Copy link
Contributor

Also multiple folders for scan would be nice.
But it can be separated issue if it's more suitable.

#474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants