From cd0548a0c2bb6b6eed180151db55d7cac4e46d52 Mon Sep 17 00:00:00 2001 From: huichiaotsou Date: Wed, 4 May 2022 11:28:05 +0800 Subject: [PATCH] remove redundant type string --- database/schema/08-gov.sql | 6 ++++++ modules/gov/utils_proposal.go | 2 +- types/gov.go | 1 - 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/database/schema/08-gov.sql b/database/schema/08-gov.sql index df2ce5c2b9..11cfdf8a46 100644 --- a/database/schema/08-gov.sql +++ b/database/schema/08-gov.sql @@ -25,6 +25,12 @@ CREATE TABLE proposal ); CREATE INDEX proposal_proposer_address_index ON proposal (proposer_address); +CREATE TABLE proposal_invalid_retry +( + proposal_id INTEGER NOT NULL REFERENCES proposal (id), + retry_count INTEGER NOT NULL +); + CREATE TABLE proposal_deposit ( proposal_id INTEGER NOT NULL REFERENCES proposal (id), diff --git a/modules/gov/utils_proposal.go b/modules/gov/utils_proposal.go index 5310db77c6..36f6034062 100644 --- a/modules/gov/utils_proposal.go +++ b/modules/gov/utils_proposal.go @@ -87,7 +87,7 @@ func (m *Module) updateDeletedProposalStatus(id uint64) error { // handleParamChangeProposal updates params to the corresponding modules if a ParamChangeProposal has passed func (m *Module) handleParamChangeProposal(height int64, proposal govtypes.Proposal) error { - if proposal.Status.String() != types.ProposalStatusPassed { + if proposal.Status.String() != govtypes.StatusPassed.String() { // If the status of ParamChangeProposal is not passed, do nothing return nil } diff --git a/types/gov.go b/types/gov.go index af186687f3..411bb477bb 100644 --- a/types/gov.go +++ b/types/gov.go @@ -10,7 +10,6 @@ import ( const ( ProposalStatusInvalid = "PROPOSAL_STATUS_INVALID" - ProposalStatusPassed = "PROPOSAL_STATUS_PASSED" ) // DepositParams contains the data of the deposit parameters of the x/gov module