Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Configurable Logger #293

Closed
13 tasks done
fahrradflucht opened this issue Jan 24, 2019 · 0 comments
Closed
13 tasks done

Core: Configurable Logger #293

fahrradflucht opened this issue Jan 24, 2019 · 0 comments

Comments

@fahrradflucht
Copy link
Member

fahrradflucht commented Jan 24, 2019

Currently we access console directly. Let users provide a logger instead.

The FeatureAppManager and FeatureServiceRegistry need to accept an optional logger through their constructor options. This option must also be added to the createFeatureHub options.

To let Feature Services and Apps log through common infrastructure, we will provide a new Feature Service named LoggerService. This new Feature Service automatically prefixes consumer logs with consumer UIDs. The underlaying logger is provided via a Feature Service factory.

Both loggers need to implement the same interface defined in Core. We also provide a ConsoleLogger implementing this interface for easy adaption.

Tasks

@unstubbable unstubbable added this to the Backlog milestone Jan 24, 2019
@clebert clebert changed the title Configurable Logger Core: Configurable Logger Mar 1, 2019
@clebert clebert modified the milestones: Backlog, Mathis Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants