Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Feature: Nationalities #385

Closed
gkunwar opened this issue Jul 23, 2015 · 7 comments
Closed

New Feature: Nationalities #385

gkunwar opened this issue Jul 23, 2015 · 7 comments
Labels
💡 Issue: Feature Request

Comments

@gkunwar
Copy link
Contributor

gkunwar commented Jul 23, 2015

No description provided.

@salexzee
Copy link

Is this a feature request or something you plan on submitting a pull request for?

@gkunwar
Copy link
Contributor Author

gkunwar commented Jul 24, 2015

@salexzee I'm planning to add this feature.

@salexzee
Copy link

Ah ok.

@gkunwar
Copy link
Contributor Author

gkunwar commented Aug 7, 2015

Completed this feature and submitted for PR.

@tejasbubane
Copy link
Contributor

@gkunwar I think you should use nepali script for nepali locale, not English.

And please split the locale changes and the new nationality feature into two separate PRs as @stympy suggested in the PR comment.

@gkunwar
Copy link
Contributor Author

gkunwar commented Apr 21, 2018

@stympy here is the PR link related to this issue:
#1190

@vbrazo
Copy link
Member

vbrazo commented May 13, 2018

@gkunwar I'm closing this PR since you already solved this issue in another issue. Thanks for the effort 💯

@vbrazo vbrazo closed this as completed May 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💡 Issue: Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tejasbubane @vbrazo @gkunwar @salexzee