diff --git a/CHANGELOG.md b/CHANGELOG.md index 8763c7fb6a..e34f169f68 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ - [PR #1310](https://github.com/stympy/faker/pull/1310) Add alias for middle_name and remove locale [@vbrazo](https://github.com/vbrazo) ### Chores +- [PR #1347](https://github.com/stympy/faker/pull/1347) Remove launchy dependency [@vbrazo](https://github.com/vbrazo) - [PR #1311](https://github.com/stympy/faker/pull/1311) Target Ruby 2.3 [@tagliala](https://github.com/tagliala) - [PR #372](https://github.com/stympy/faker/pull/372) Add test_password_could_achieve_max_length [@oleksii-ti](https://github.com/oleksii-ti) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d35db0e189..086ce0a488 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -14,7 +14,7 @@ Ways to run Rubocop: 5. Make the test pass. Always use `sample`, `shuffle`, and `rand` from the Base class (just like the rest of the code) rather than `Array#sample`, `Array#shuffle` and `Kernel#rand` to preserve the deterministic feature. -6. We care about code coverage and use `SimpleCov` to analyze the code and generate test coverage reports. It's possible to check the test coverage by running `bundle exec rake coverage_report`. Please make sure to not decrease our `current % covered`. +6. We care about code coverage and use `SimpleCov` to analyze the code and generate test coverage reports. It's possible to check the test coverage by running `open coverage/index.html`. Please make sure to not decrease our `current % covered` and add appropriate test cases when necessary. 7. When adding a new class, add a new yaml file to `lib/locales/en` rather than adding translations to `lib/locales/en.yml`. For example, if you add Faker::MyThing, put your translations in `lib/locales/en/my_thing.yml`. See [the locale README](./lib/locales/en/README.md) for more info. diff --git a/Gemfile.lock b/Gemfile.lock index fc21c55010..d987ab40e4 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -7,8 +7,6 @@ PATH GEM remote: https://rubygems.org/ specs: - addressable (2.5.2) - public_suffix (>= 2.0.2, < 4.0) ast (2.4.0) concurrent-ruby (1.0.5) docile (1.3.0) @@ -16,15 +14,12 @@ GEM concurrent-ruby (~> 1.0) jaro_winkler (1.5.1) json (2.1.0) - launchy (2.4.3) - addressable (~> 2.3) minitest (5.10.3) parallel (1.12.1) parser (2.5.1.2) ast (~> 2.4.0) power_assert (1.1.1) powerpack (0.1.2) - public_suffix (3.0.2) rainbow (3.0.0) rake (12.3.0) rubocop (0.58.1) @@ -51,7 +46,6 @@ PLATFORMS DEPENDENCIES faker! - launchy minitest rake rubocop @@ -60,4 +54,4 @@ DEPENDENCIES timecop BUNDLED WITH - 1.16.2 + 1.16.4 diff --git a/Rakefile b/Rakefile index a010b81ec8..6b1f42c9dd 100644 --- a/Rakefile +++ b/Rakefile @@ -17,12 +17,6 @@ task :console do IRB.start end -task :coverage_report do - require 'launchy' - - Launchy.open('coverage/index.html') -end - require 'rubocop/rake_task' RuboCop::RakeTask.new diff --git a/faker.gemspec b/faker.gemspec index 29240b7b18..f98027161f 100644 --- a/faker.gemspec +++ b/faker.gemspec @@ -15,7 +15,6 @@ Gem::Specification.new do |s| s.license = 'MIT' s.add_runtime_dependency('i18n', '>= 0.7') - s.add_development_dependency('launchy') s.add_development_dependency('minitest') s.add_development_dependency('rake') s.add_development_dependency('rubocop')