Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate:locales does not update deeply nested index files #485

Closed
ST-DDT opened this issue Feb 13, 2022 · 0 comments · Fixed by #494
Closed

generate:locales does not update deeply nested index files #485

ST-DDT opened this issue Feb 13, 2022 · 0 comments · Fixed by #494
Assignees
@ST-DDT
Labels
c: feature Request for new feature
Milestone
v6 - Non-Breaking...

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Feb 13, 2022

Currently the script only updates

  • src/locale/<locale>.ts
  • src/locales/<locale>/index.ts
  • src/locales/<locale>/<module>/index.ts
  • src/locales/index.ts
  • docs/api/localization.md

But it does not update

  • src/locales/<locale>/<module>/<submodules...>/index.ts

We should probably add a test, that ensures we don't break it again.

To avoid stacking changes on top of each other, we should merge #478 first.

Detected in #484
@ST-DDT ST-DDT added c: feature Request for new feature s: on hold Blocked by something or frozen to avoid conflicts labels Feb 13, 2022
@ST-DDT ST-DDT self-assigned this Feb 13, 2022
@Shinigami92 Shinigami92 moved this to Todo in Faker Roadmap Feb 14, 2022
@ST-DDT ST-DDT removed the s: on hold Blocked by something or frozen to avoid conflicts label Feb 14, 2022
@ST-DDT ST-DDT mentioned this issue Feb 15, 2022
Merged
@ST-DDT ST-DDT moved this from Todo to Awaiting Review in Faker Roadmap Feb 16, 2022
Repository owner moved this from Awaiting Review to Done in Faker Roadmap Feb 16, 2022
@ST-DDT ST-DDT removed this from Faker Roadmap Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ST-DDT ST-DDT

Labels
c: feature Request for new feature
Projects
None yet
Milestone
v6 - Non-Breaking Changes
Development

Successfully merging a pull request may close this issue.

feat(types): generate all locales index files with non-any types faker-js/faker
1 participant
@ST-DDT